Public Access
Draw the tags that have been storable and invisible since the domain landed
`Tag` has been a full item kind for three commits — a table, a migration, a codec, a merge, a cipher — and `HostSecret.TagIds` has merged per tag so two people tagging one host both keep theirs. Nothing drew a chip. The tags a client could store were ones nothing here could see. Chips on host rows, both heads, from names resolved through the tag list rather than ids: a tag that does not resolve is left out rather than drawn, because it means the tag was deleted elsewhere or belongs to a vault this session cannot read, and a host with one chip fewer is the honest answer where a host wearing a GUID is not. The id stays on the host, so the chip comes back if the tag does. The picker is chips that toggle, matching the chips on the row behind it. A list of names to tick would make the user match an entry to a chip they can see two inches away. The box under it creates a tag and puts it on straight away, because that is when a tag is usually wanted — while tagging a host and finding it does not exist yet. Unlike every other field in that editor it writes to the keychain immediately, since a host can only name an id that exists; cancelling therefore leaves the tag behind, which is honest rather than hidden. A name that already exists is used rather than repeated: two tags called "staging" are storable and must stay storable, because two people creating one offline is how it happens, but typing it into a box beside a chip of the same name is a slip. Renaming and deleting needed a home, or the picker fills with names nobody uses and never empties. That home is a TAGS category on the keychain screen, where every other item kind is managed — and renaming is the whole reason a tag is an item rather than a string repeated inside twenty payloads: it is one write, and no host is touched. The delete confirmation counts the hosts wearing it, which is the difference between a tidy-up and losing a filter somebody relies on. The desktop host editor now scrolls, and that is not a tidy-up. A picker's height is a chip per tag in the keychain, wrapped, so somebody with fifteen tags has an editor half again as tall as somebody with three; no fixed height holds that, and trimming other fields to buy room only moves the failure to whoever has sixteen. The layout suite caught it the moment its seeder grew tags — which is why the seeder now creates ten rather than three, enough to drive the pane onto its cap so the capped shape is what gets measured rather than one no real keychain produces. The cost is named where it is paid: the harness skips anything inside a ScrollViewer, so from here it certifies that pane fits the column rather than that every field in it does. Two smaller things fell out. Five buttons overflowed the keychain header by a few pixels, so GENERATE lost the word KEY — its tooltip carries what the word did. And TotalItemCount had been counting keys and credentials while ALL showed four kinds; it counts all five now, because a number under a chip that disagrees with the rows it opens is worse than no number. An adversarial review of this change found two defects it had introduced, both green against the full suite. NewTag filed into the "new items go to" picker while the tag list only ever holds the active vault's — so with a team vault selected a tag would be created, queued for push, reported as added, and then invisible, with no row, no count, no picker entry and nothing able to rename or delete it, because there is no active-vault switcher to go and find it with. The comment on the host editor's own create path states that exact rule; this was the one place that broke it, and NewObjectStore, whose list is likewise active-vault-only, already ignored the picker. And the tag editor was the only one of five that did not disarm a pending deletion when it opened, so arming a key's deletion and then pressing + TAG left a live DELETE for an item the user was no longer looking at, directly above the boxes they were typing into. Both are fixed, both have a test, and the first was checked against the broken version before being kept. The same review caught a doc comment that had been inserted between SnippetRowViewModel's summary and its declaration, silently taking it over. Verified by the whole suite on a clean build: 1413 tests over nineteen projects, none failing. Both heads build. The rectangles the layout suite cannot reach are phase 9 of docs/manual-checks.md. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
@@ -756,7 +756,7 @@ public sealed class ScreenLayoutTests : IAsyncLifetime
|
||||
.Where(button => button.Classes.Contains("cat"))
|
||||
.ToList();
|
||||
|
||||
buttons.Count.ShouldBe(4, "one per category that exists");
|
||||
buttons.Count.ShouldBe(5, "one per category that exists");
|
||||
|
||||
foreach (var button in buttons)
|
||||
{
|
||||
@@ -1432,12 +1432,39 @@ public sealed class ScreenLayoutTests : IAsyncLifetime
|
||||
/// </remarks>
|
||||
private async Task SeedAsync()
|
||||
{
|
||||
// Before the hosts, so the tag picker in the host editor has chips in it and the rows below have
|
||||
// chips on them. A vault with no tags collapses both, and a collapsed control is the shape this
|
||||
// suite is least interested in certifying.
|
||||
//
|
||||
// Ten of them, and the number is doing work: the picker is a chip per tag, wrapped, so this is what
|
||||
// drives the sidebar's editor onto the MaxHeight of the ScrollViewer it gained in the same change —
|
||||
// and that capped pane is the thing which has to fit the column. Three tags left it short of the cap,
|
||||
// measuring a shape no user with a real keychain ever sees.
|
||||
foreach (var label in new[]
|
||||
{
|
||||
"pci", "eu-west-1", "postgres-16", "on-call", "customer-a", "bastion",
|
||||
"kubernetes-worker", "legacy", "staging", "database-primary",
|
||||
})
|
||||
{
|
||||
vault.NewTagCommand.Execute(null);
|
||||
vault.TagEditorLabel = label;
|
||||
await vault.SaveTagCommand.ExecuteAsync(null);
|
||||
}
|
||||
|
||||
for (var i = 0; i < 6; i++)
|
||||
{
|
||||
vault.NewHostCommand.Execute(null);
|
||||
vault.EditorLabel = $"host-{i}";
|
||||
vault.EditorHostname = $"host-{i}.internal";
|
||||
vault.EditorUsername = "deploy";
|
||||
|
||||
// Every tag on the first host, so the widest realistic row — a chip row that wraps — is what
|
||||
// gets measured rather than a bare label.
|
||||
foreach (var choice in vault.EditorTagChoices.Where(_ => i == 0).ToList())
|
||||
{
|
||||
vault.ToggleEditorTagCommand.Execute(choice);
|
||||
}
|
||||
|
||||
await vault.SaveHostCommand.ExecuteAsync(null);
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user