Restructure into src/tests and add build foundation (M0)

Moves the scaffold to src/DodoSSH.Api and establishes the repo conventions the rest of the milestones build on. Structure: - src/{Contracts,Crypto,Domain,Infrastructure,Api}, tests/{Contracts,Crypto,Domain}.Tests - DodoSSH.slnx rewritten with src/ and tests/ solution folders Build: - Directory.Build.props centralises TFM, nullable, deterministic builds and TreatWarningsAsErrors; Directory.Packages.props pins every version centrally - packages.lock.json committed so CI restores in locked mode - NuGet.config clears machine-level sources, which both fixes NU1507 under central package management and makes restore reproducible off this machine - Microsoft.OpenApi pinned to 2.11.0: ASP.NET Core 10.0.10 resolves 2.0.0, which is covered by GHSA-v5pm-xwqc-g5wc (high, patched in 2.7.5) Analyzers: - AnalysisLevel is Recommended, not All. With warnings-as-errors, All turns opinionated naming rules into build breaks and trains people to blanket-suppress. - BannedSymbols.txt bans DateTime.UtcNow (TimeProvider), Guid.NewGuid (CreateVersion7), sync-over-async, MD5/SHA1, PBKDF2 and SecureString - CA1711/CA1724 disabled: both are .NET Framework CAS-era naming rules - PublicApiAnalyzers on Contracts only, since that assembly is the client's real contract API: - weather-forecast template removed - UseHttpsRedirection removed; TLS terminates at the reverse proxy and redirecting behind one causes loops - /healthz/{live,ready,startup}. Liveness deliberately checks no dependencies so a transient database outage cannot restart the container and kill live SSH sessions. Notes: - No coverage collector yet. Microsoft.Testing.Extensions.CodeCoverage pulls an MTP 1.x MSBuild extension that throws TypeLoadException against the MTP 2.3.x xunit.v3 brings. Coverage gates are an M3 concern; revisit with an MTP 2.x-aligned version then. Verified: dotnet build (0 warnings), 17 tests pass, format check clean, API serves health and OpenAPI endpoints.
2026-07-28 12:25:34 +02:00
parent 1138291d79
commit 3a81f3c90b
43 changed files with 1714 additions and 62 deletions
@@ -0,0 +1,28 @@
+<Project Sdk="Microsoft.NET.Sdk">
+
+  <!--
+    DTOs shared between the API and the desktop client. This assembly, not the generated
+    OpenAPI document, is the real client contract, so PublicApiAnalyzers is enabled here
+    and only here: an accidental change to a public member becomes a build error rather
+    than a runtime deserialisation failure on somebody's laptop.
+
+    Track additions in PublicAPI.Unshipped.txt; move them to PublicAPI.Shipped.txt when a
+    version is released.
+  -->
+
+  <PropertyGroup>
+    <GenerateDocumentationFile>true</GenerateDocumentationFile>
+    <IsTrimmable>true</IsTrimmable>
+    <IsAotCompatible>true</IsAotCompatible>
+  </PropertyGroup>
+
+  <ItemGroup>
+    <PackageReference Include="Microsoft.CodeAnalysis.PublicApiAnalyzers" PrivateAssets="all" />
+  </ItemGroup>
+
+  <ItemGroup>
+    <AdditionalFiles Include="PublicAPI.Shipped.txt" />
+    <AdditionalFiles Include="PublicAPI.Unshipped.txt" />
+  </ItemGroup>
+
+</Project>
@@ -0,0 +1,48 @@
+namespace DodoSSH.Contracts;
+
+/// <summary>
+/// Stable machine-readable error codes returned in the <c>code</c> extension of an
+/// RFC 9457 ProblemDetails response.
+/// </summary>
+/// <remarks>
+/// These live in Contracts so the client switches on constants rather than parsing prose.
+/// The values are part of the public contract: add freely, never rename or repurpose.
+/// </remarks>
+public static class ProblemCodes
+{
+    /// <summary>The base URI that every problem <c>type</c> is formed under.</summary>
+    public const string TypeBaseUri = "https://dodossh.dev/problems/";
+
+    /// <summary>A push operation's <c>expectedVersion</c> did not match the stored row.</summary>
+    public const string VaultConflict = "vault-conflict";
+
+    /// <summary>The caller is authenticated but lacks the required permission.</summary>
+    public const string Forbidden = "forbidden";
+
+    /// <summary>The sync cursor was malformed, or failed its integrity tag.</summary>
+    public const string InvalidCursor = "invalid-cursor";
+
+    /// <summary>An <c>Idempotency-Key</c> was reused with a different request body.</summary>
+    public const string IdempotencyKeyReuse = "idempotency-key-reuse";
+
+    /// <summary>The caller has not yet enrolled a public key, so no vault is reachable.</summary>
+    public const string EnrollmentRequired = "enrollment-required";
+
+    /// <summary>Enrollment was attempted for a user who already holds a current key.</summary>
+    public const string AlreadyEnrolled = "already-enrolled";
+
+    /// <summary>The relay refused the requested target. Never states why, to avoid a probe oracle.</summary>
+    public const string RelayTargetRejected = "relay-target-rejected";
+
+    /// <summary>The relay ticket is expired, already used, or not valid for this node.</summary>
+    public const string RelayTicketInvalid = "relay-ticket-invalid";
+
+    /// <summary>A per-user or per-node relay session limit was reached.</summary>
+    public const string RelayLimitReached = "relay-limit-reached";
+
+    /// <summary>The client is older than the server's <c>minClientVersion</c>.</summary>
+    public const string ClientTooOld = "client-too-old";
+
+    /// <summary>A push batch exceeded the operation count or payload size cap.</summary>
+    public const string PushBatchTooLarge = "push-batch-too-large";
+}
@@ -0,0 +1 @@
+#nullable enable
@@ -0,0 +1,14 @@
+#nullable enable
+DodoSSH.Contracts.ProblemCodes
+const DodoSSH.Contracts.ProblemCodes.AlreadyEnrolled = "already-enrolled" -> string!
+const DodoSSH.Contracts.ProblemCodes.ClientTooOld = "client-too-old" -> string!
+const DodoSSH.Contracts.ProblemCodes.EnrollmentRequired = "enrollment-required" -> string!
+const DodoSSH.Contracts.ProblemCodes.Forbidden = "forbidden" -> string!
+const DodoSSH.Contracts.ProblemCodes.IdempotencyKeyReuse = "idempotency-key-reuse" -> string!
+const DodoSSH.Contracts.ProblemCodes.InvalidCursor = "invalid-cursor" -> string!
+const DodoSSH.Contracts.ProblemCodes.PushBatchTooLarge = "push-batch-too-large" -> string!
+const DodoSSH.Contracts.ProblemCodes.RelayLimitReached = "relay-limit-reached" -> string!
+const DodoSSH.Contracts.ProblemCodes.RelayTargetRejected = "relay-target-rejected" -> string!
+const DodoSSH.Contracts.ProblemCodes.RelayTicketInvalid = "relay-ticket-invalid" -> string!
+const DodoSSH.Contracts.ProblemCodes.TypeBaseUri = "https://dodossh.dev/problems/" -> string!
+const DodoSSH.Contracts.ProblemCodes.VaultConflict = "vault-conflict" -> string!
@@ -0,0 +1,31 @@
+{
+  "version": 2,
+  "dependencies": {
+    "net10.0": {
+      "Meziantou.Analyzer": {
+        "type": "Direct",
+        "requested": "[3.0.134, )",
+        "resolved": "3.0.134",
+        "contentHash": "tTYCcYKyOko3TMNxmxmA9nakbcHVUgglENmCMIhzIjl9y9FBZO/0tWSxTGC74Sp198FmWih5S5KkjQRBg5ePkQ=="
+      },
+      "Microsoft.CodeAnalysis.BannedApiAnalyzers": {
+        "type": "Direct",
+        "requested": "[5.6.0, )",
+        "resolved": "5.6.0",
+        "contentHash": "Kcobt3pnOdO0A+6CKiMHZdTEluJpsfxiV20axtZdmfBQnDmiWTKPJADlgAfdTuKNAnVarrkJa0UEGwuOo91muw=="
+      },
+      "Microsoft.CodeAnalysis.PublicApiAnalyzers": {
+        "type": "Direct",
+        "requested": "[5.6.0, )",
+        "resolved": "5.6.0",
+        "contentHash": "W4kJGezNIKLzo0Ak5FAQDFvkMf2U7DtGL4THmHyRSApfKsKt5V+eX/bU0ZLKAt/uf9Bb2o1bi0YDKj/GRB/vYQ=="
+      },
+      "Microsoft.NET.ILLink.Tasks": {
+        "type": "Direct",
+        "requested": "[10.0.10, )",
+        "resolved": "10.0.10",
+        "contentHash": "f5VCIE7AJpd5YvzNTeMGVzQIgyE9tX+AreTYwQF+REbu+DZo/2Ae+jNSwhPEYrVz6RRkd7y8ubXjk6Nn6Ka+Cg=="
+      }
+    }
+  }
+}