Public Access
Wire the Avalonia shell to the vault
The host list now comes from the vault instead of from a form. A fresh machine takes a server URL, signs in through the browser, enrolls, and from then on opens with the passphrase alone. DodoSSH.Client.Session is the composition layer: where a profile lives, how it unlocks, and how a machine gets one. ClientPaths picks a non-roaming per-OS directory — %LOCALAPPDATA% and never %APPDATA%, because a SQLite cache that roams between two machines is a corrupt one, and each machine's outbox is its own. SessionOpener needs no transport at all and could not reach one if it wanted to; that is the offline unlock, asserted rather than asserted about. A wrong passphrase, a stale KDF and a grant revoked by a rekey are three different answers, because the remedies are three different things and telling someone to retype a passphrase that was never the problem is worse than saying nothing. The shell's states are the onboarding story. The recovery code gets its own state that cannot be clicked past: it exists for one moment, losing it with the passphrase loses the vault, and there is no server-side reset by design. It is dropped from memory on confirmation rather than merely hidden. Sign-in is a delegate over IVaultServer, so the whole state machine runs in a test against an in-memory server — no browser, no identity provider, no toolkit. The view models are plain observable objects, which is what makes that possible. What it does not cover is whether the XAML binds to the right names; that needs a rendered tree and Avalonia.Headless, and is its own piece of work. Three things found by doing it rather than by reading it: - Pooled SQLite connections keep the database file open after the last context is disposed. On Windows that means locked, so the application could never replace its own cache — and a test could not clean up after itself, which is how it surfaced. Dispose now clears the pool. - EF's SQLite provider puts the database in WAL mode, so the cache is three files. A comment in ClientCacheFactory claimed the opposite; reading PRAGMA journal_mode off a real launch settled it. WAL is the right mode here — a sync pass writes while the interface reads — so the comment was wrong on the merits as well as on the fact. - Enrolling a device key with nowhere to keep the private half would put a wrap on the server nobody can open and make the device list claim this machine can unlock without a passphrase. Device binding is now optional and the shell declines it until the OS keystore is wired. Verified on Windows: the client created %LOCALAPPDATA%\DodoSSH\cache.db and migrated it on first launch, and msedgewebview2 held an established connection to the data plane while the unlock overlay covered it — which is the point of covering the WebView rather than collapsing it, since a NativeWebView that is never laid out is never realised. 630 tests, up from 593. The recovery-code gate and the offline unlock were each verified by breaking them and watching the right test fail. Still to do for M1's actual definition of done: the manual run against the real API and a real Keycloak. Credentials are not a synced entity type yet, so a connection still asks for a password, and the interface says so rather than implying otherwise.
This commit is contained in:
@@ -22,6 +22,7 @@ namespace DodoSSH.Client.Storage;
|
||||
public sealed class ClientCacheFactory : IDbContextFactory<ClientCacheContext>, IDisposable
|
||||
{
|
||||
private readonly DbContextOptions<ClientCacheContext> options;
|
||||
private readonly string connectionString;
|
||||
|
||||
/// <remarks>
|
||||
/// An in-memory SQLite database exists only while at least one connection to it is open, so the
|
||||
@@ -33,6 +34,7 @@ public sealed class ClientCacheFactory : IDbContextFactory<ClientCacheContext>,
|
||||
|
||||
private ClientCacheFactory(string connectionString, SqliteConnection? keepAlive)
|
||||
{
|
||||
this.connectionString = connectionString;
|
||||
this.keepAlive = keepAlive;
|
||||
|
||||
options = new DbContextOptionsBuilder<ClientCacheContext>()
|
||||
@@ -41,7 +43,22 @@ public sealed class ClientCacheFactory : IDbContextFactory<ClientCacheContext>,
|
||||
.Options;
|
||||
}
|
||||
|
||||
/// <summary>Opens, or creates, a cache file.</summary>
|
||||
/// <summary>
|
||||
/// Opens, or creates, a cache file.
|
||||
/// </summary>
|
||||
/// <remarks>
|
||||
/// <para>
|
||||
/// The parent directory must exist; SQLite will not create one. <c>ClientPaths.EnsureCreated</c> is
|
||||
/// what does that, and it runs before this in the application's startup.
|
||||
/// </para>
|
||||
/// <para>
|
||||
/// <b>The database ends up in WAL mode</b>, set by EF Core's SQLite provider rather than here, and
|
||||
/// that is the right mode for this design: a background sync pass writes while the interface reads,
|
||||
/// and under the default rollback journal a writer locks the whole database and those reads would fail
|
||||
/// busy. Worth knowing rather than discovering — it means the cache is three files, not one, so a
|
||||
/// backup or uninstall routine that copies or deletes only <c>cache.db</c> is wrong.
|
||||
/// </para>
|
||||
/// </remarks>
|
||||
/// <param name="databasePath">Full path to the SQLite file.</param>
|
||||
public static ClientCacheFactory ForFile(string databasePath)
|
||||
{
|
||||
@@ -50,8 +67,9 @@ public sealed class ClientCacheFactory : IDbContextFactory<ClientCacheContext>,
|
||||
var builder = new SqliteConnectionStringBuilder
|
||||
{
|
||||
DataSource = databasePath,
|
||||
// The cache is written by one process. WAL would buy concurrent readers we do not have
|
||||
// and would leave two extra files beside the database for a user to wonder about.
|
||||
// Pooled, because a store operation takes a context per call and reopening the file every
|
||||
// time would be pure overhead in a process that runs for hours. The cost is that the pool
|
||||
// outlives the contexts, which Dispose has to deal with — see below.
|
||||
Pooling = true,
|
||||
};
|
||||
|
||||
@@ -115,6 +133,13 @@ public sealed class ClientCacheFactory : IDbContextFactory<ClientCacheContext>,
|
||||
|
||||
disposed = true;
|
||||
keepAlive?.Dispose();
|
||||
|
||||
// Pooled connections outlive the contexts that borrowed them, so without this the database file
|
||||
// stays open after the last context is disposed — on Windows that means locked. The application
|
||||
// then cannot delete or replace its own cache, and a test cannot clean up after itself, which is
|
||||
// how this was found. Clearing the pool is the documented way to release it.
|
||||
using var pooled = new SqliteConnection(connectionString);
|
||||
SqliteConnection.ClearPool(pooled);
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user