Wire the Avalonia shell to the vault

The host list now comes from the vault instead of from a form. A fresh
machine takes a server URL, signs in through the browser, enrolls, and
from then on opens with the passphrase alone.

DodoSSH.Client.Session is the composition layer: where a profile lives,
how it unlocks, and how a machine gets one. ClientPaths picks a
non-roaming per-OS directory — %LOCALAPPDATA% and never %APPDATA%,
because a SQLite cache that roams between two machines is a corrupt one,
and each machine's outbox is its own. SessionOpener needs no transport at
all and could not reach one if it wanted to; that is the offline unlock,
asserted rather than asserted about. A wrong passphrase, a stale KDF and a
grant revoked by a rekey are three different answers, because the remedies
are three different things and telling someone to retype a passphrase that
was never the problem is worse than saying nothing.

The shell's states are the onboarding story. The recovery code gets its
own state that cannot be clicked past: it exists for one moment, losing it
with the passphrase loses the vault, and there is no server-side reset by
design. It is dropped from memory on confirmation rather than merely
hidden.

Sign-in is a delegate over IVaultServer, so the whole state machine runs
in a test against an in-memory server — no browser, no identity provider,
no toolkit. The view models are plain observable objects, which is what
makes that possible. What it does not cover is whether the XAML binds to
the right names; that needs a rendered tree and Avalonia.Headless, and is
its own piece of work.

Three things found by doing it rather than by reading it:

- Pooled SQLite connections keep the database file open after the last
  context is disposed. On Windows that means locked, so the application
  could never replace its own cache — and a test could not clean up after
  itself, which is how it surfaced. Dispose now clears the pool.
- EF's SQLite provider puts the database in WAL mode, so the cache is
  three files. A comment in ClientCacheFactory claimed the opposite;
  reading PRAGMA journal_mode off a real launch settled it. WAL is the
  right mode here — a sync pass writes while the interface reads — so the
  comment was wrong on the merits as well as on the fact.
- Enrolling a device key with nowhere to keep the private half would put a
  wrap on the server nobody can open and make the device list claim this
  machine can unlock without a passphrase. Device binding is now optional
  and the shell declines it until the OS keystore is wired.

Verified on Windows: the client created %LOCALAPPDATA%\DodoSSH\cache.db
and migrated it on first launch, and msedgewebview2 held an established
connection to the data plane while the unlock overlay covered it — which
is the point of covering the WebView rather than collapsing it, since a
NativeWebView that is never laid out is never realised.

630 tests, up from 593. The recovery-code gate and the offline unlock were
each verified by breaking them and watching the right test fail.

Still to do for M1's actual definition of done: the manual run against the
real API and a real Keycloak. Credentials are not a synced entity type
yet, so a connection still asks for a password, and the interface says so
rather than implying otherwise.
This commit is contained in:
2026-07-29 11:02:19 +02:00
parent 8d2416a602
commit 49f617b450
33 changed files with 5405 additions and 210 deletions
@@ -0,0 +1,81 @@
namespace DodoSSH.Client.Session.Tests;
/// <summary>
/// Where the profile goes.
/// </summary>
/// <remarks>
/// A short suite for something that looks trivial and is not. The cache is a SQLite file written by one
/// process, and the design assumes each machine has its own — the outbox holds changes only this machine
/// has made. Two machines sharing one file through a cloud sync client corrupts it, so a roaming or
/// synced directory is a correctness problem rather than a matter of taste.
/// </remarks>
public sealed class ClientPathsTests
{
[Fact]
public void TheCacheLivesInsideTheProfileDirectory()
{
var paths = new ClientPaths(Path.Combine("C:", "somewhere", "DodoSSH"));
Path.GetDirectoryName(paths.CacheFile).ShouldBe(paths.DataDirectory);
Path.GetFileName(paths.CacheFile).ShouldBe("cache.db");
}
[Fact]
public void TheDefaultDirectoryIsAbsoluteAndNamed()
{
var paths = ClientPaths.Default;
Path.IsPathFullyQualified(paths.DataDirectory).ShouldBeTrue(paths.DataDirectory);
paths.DataDirectory.Contains("odoSSH", StringComparison.Ordinal)
.ShouldBeTrue($"'{paths.DataDirectory}' should be identifiable as ours");
}
[Fact]
public void ResolvingTheDefault_CreatesNothing()
{
// Read during startup diagnostics and by tests. A side effect here would mean merely asking where
// the cache would go creates a directory.
var paths = new ClientPaths(
Path.Combine(Path.GetTempPath(), $"dodossh-paths-{Guid.CreateVersion7():N}"));
Directory.Exists(paths.DataDirectory).ShouldBeFalse();
paths.EnsureCreated();
try
{
Directory.Exists(paths.DataDirectory).ShouldBeTrue();
// Idempotent, because startup runs it every launch.
paths.EnsureCreated();
}
finally
{
Directory.Delete(paths.DataDirectory, recursive: true);
}
}
[Fact]
public void OnWindowsItIsTheLocalProfileAndNotTheRoamingOne()
{
// %APPDATA% roams in a domain environment, which would sync one machine's SQLite cache to another
// and corrupt it. %LOCALAPPDATA% does not.
if (!OperatingSystem.IsWindows())
{
Assert.Skip("Windows-only path convention.");
}
var local = Environment.GetFolderPath(Environment.SpecialFolder.LocalApplicationData);
var roaming = Environment.GetFolderPath(Environment.SpecialFolder.ApplicationData);
ClientPaths.Default.DataDirectory.ShouldStartWith(local);
// Guard against the two happening to be equal on some configuration, which would make the
// assertion above meaningless.
if (!string.Equals(local, roaming, StringComparison.OrdinalIgnoreCase))
{
ClientPaths.Default.DataDirectory.ShouldNotStartWith(roaming);
}
}
}