Let a team be joined only by somebody who is already here

An invitation decided access from an assertion about an address. Everything else
in this model decides it from something a person did — an admin naming an
account, a key holder wrapping a vault key to a key they verified — and this was
the one place a token's email claim was the thing that let somebody in.

It was guarded as tightly as that can be guarded: the claim was refused outright
on an unverified or absent `email_verified`, with no setting to relax it. But the
guard and the risk were the same shape. The whole defence was one boolean sent by
a system the deployment does not control.

So `POST /teams/{id}/members` is the only way in, and an address with no account
is refused with `no-such-account` — which is now the end of the road rather than
the signal to invite. Both clients say the remedy: that person signs in here
once, which is what creates the account, and then they can be added. The desktop
leaves the address in the box, because a message telling you to come back later
is one you act on later.

Gone with it: the `team_invitation` table, the claim hook in the sign-in path,
and `Oidc:EmailVerifiedClaim`, which that hook was the only reader of. Nothing in
the server now reads the email claim to decide anything.

Pending invitations are dropped rather than converted. Converting one would mean
creating a membership because an address matched, which is the property being
removed — and an invitation to an address that did have an account here had
already been claimed by the hourly sweep, so what is left is offers to people who
never arrived.

Two tests carry the property rather than the feature: the endpoint inventory
asserts the three routes are absent, and the API suite adds an address that has
no account, watches the refusal, then signs that address in and checks it joined
nothing. Without the second half, a server that merely renamed the deferred path
would pass.

tests/DodoSSH.Client.App.Tests/FakeVaultServer.Teams.cs

@@ -36,7 +36,6 @@ internal sealed partial class FakeVaultServer : ITeamApi, IDirectoryApi, IVaultG
         grants = [];
     private readonly List<KeyLogRecord> keyLog = [];
     private readonly List<DirectoryEntry> directory = [];
-    private readonly Dictionary<Guid, List<TeamInvitationSummary>> invitations = [];
 
     /// <summary>
     /// Every account on this fake server, enrolled or not.
@@ -345,7 +344,6 @@ internal sealed partial class FakeVaultServer : ITeamApi, IDirectoryApi, IVaultG
 
         teams.RemoveAt(index);
         members.Remove(teamId);
-        invitations.Remove(teamId);
 
         return Task.FromResult(true);
     }
@@ -464,69 +462,6 @@ internal sealed partial class FakeVaultServer : ITeamApi, IDirectoryApi, IVaultG
         return Task.FromResult(member);
     }
 
-    /// <inheritdoc />
-    public Task<IReadOnlyList<TeamInvitationSummary>> ListTeamInvitationsAsync(
-        Guid teamId,
-        CancellationToken cancellationToken) =>
-        Task.FromResult<IReadOnlyList<TeamInvitationSummary>>(
-            invitations.TryGetValue(teamId, out var list) ? [.. list] : []);
-
-    /// <inheritdoc />
-    public Task<TeamInvitationSummary> CreateTeamInvitationAsync(
-        Guid teamId,
-        CreateTeamInvitationRequest request,
-        CancellationToken cancellationToken)
-    {
-        var list = invitations.GetValueOrDefault(teamId, []);
-
-        if (list.Exists(invitation =>
-            invitation.State == TeamInvitationState.Pending
-            && string.Equals(invitation.Email, request.Email, StringComparison.OrdinalIgnoreCase)))
-        {
-            throw new DodoSshApiException(
-                System.Net.HttpStatusCode.BadRequest,
-                ProblemCodes.InvalidTeamInvitation,
-                "There is already an invitation to that address for this team.");
-        }
-
-        var invited = new TeamInvitationSummary(
-            request.InvitationId,
-            request.Email,
-            request.Role,
-            TeamInvitationState.Pending,
-            UserId,
-            DateTimeOffset.UnixEpoch,
-            DateTimeOffset.UnixEpoch.AddDays(14),
-            AcceptedAt: null);
-
-        invitations[teamId] = [.. list, invited];
-
-        return Task.FromResult(invited);
-    }
-
-    /// <inheritdoc />
-    public Task<bool> RevokeTeamInvitationAsync(
-        Guid teamId,
-        Guid invitationId,
-        CancellationToken cancellationToken)
-    {
-        var list = invitations.GetValueOrDefault(teamId, []);
-        var index = list.FindIndex(invitation =>
-            invitation.InvitationId == invitationId
-            && invitation.State == TeamInvitationState.Pending);
-
-        if (index < 0)
-        {
-            return Task.FromResult(false);
-        }
-
-        // Kept and marked rather than removed, as the server keeps it: the screen has to be able to
-        // say an invitation was withdrawn rather than letting it vanish and read as never sent.
-        list[index] = list[index] with { State = TeamInvitationState.Revoked };
-
-        return Task.FromResult(true);
-    }
-
     /// <inheritdoc />
     public Task<TeamMemberSummary> ChangeTeamMemberRoleAsync(
         Guid teamId,
@@ -697,7 +632,6 @@ internal sealed partial class FakeVaultServer : ITeamApi, IDirectoryApi, IVaultG
         {
             teams.RemoveAll(team => team.TeamId == teamId);
             members.Remove(teamId);
-            invitations.Remove(teamId);
         }
 
         return Task.FromResult(true);