From 7ee2aacdc91de2b7807273dca9b6452c4a87c4a3 Mon Sep 17 00:00:00 2001 From: Laurens Bezemer | DodoTech Date: Wed, 26 Aug 2026 17:26:52 +0200 Subject: [PATCH] Put check 1.12 back in step with the splash it describes MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The progress bar went in "Take the frozen bar off the splash, and leave the line that is true" and the manual check still told a person to watch it move, and then to watch it stop. A check that names something not on the screen is worse than no check: whoever runs it has to decide whether they are looking at a regression or at a stale document, and the honest answer is not available from the page. Says what the failure state looks like now — the line changes and nothing else on the card is there to contradict it — and records where the bar went, so the next reader is not left wondering whether it was lost by accident. Co-Authored-By: Claude Opus 5 --- docs/manual-checks.md | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/docs/manual-checks.md b/docs/manual-checks.md index c0e77e9..e5dde21 100644 --- a/docs/manual-checks.md +++ b/docs/manual-checks.md @@ -256,8 +256,8 @@ registered in the capture phase, that no native menu is drawn once it is prevent Close DodoSSH and start it again. Watch the first second. -**Pass:** a small panel — about 420 pixels wide, no titlebar — appears saying **DodoSSH** and *Starting…* -with a bar moving under it, and is then replaced by the main window. Measured on a debug build against a cold +**Pass:** a small panel — about 420 pixels wide, no titlebar — appears saying **DodoSSH** and *Starting…*, +and is then replaced by the main window. Measured on a debug build against a cold profile: the panel at 668 ms, the window at 3.1 s. A release install is quicker and the shape is the same. What must never come back is the old behaviour, which was nothing at all on screen for the whole of it. @@ -270,8 +270,12 @@ over whatever you gave up and went back to. *directory* where `cache.db` should be — `%LOCALAPPDATA%\DodoSSH.Nightly\cache.db` for the nightly — and start the application. -**Pass:** the panel stays, the bar stops moving, and it reads *DodoSSH could not start:* followed by the -reason and *Press Escape to close.* Escape closes it. Remove the directory afterwards. +**Pass:** the panel stays and the line becomes *DodoSSH could not start:* followed by the reason and +*Press Escape to close.* Escape closes it. Remove the directory afterwards. + +There is deliberately nothing else on the card to contradict that line — the progress bar this check used to +describe was taken off in "Take the frozen bar off the splash, and leave the line that is true", because an +indeterminate bar over a composition that had stopped was the one thing a splash must never do. **Failure means:** a panel left saying *Starting…* is the main window having failed to show with nothing catching it, which is the one outcome worse than the crash it replaced — `DodoSshApp.ComposeBehind` exists to