Public Access
Give the desktop a nightly channel, the way the phone has one
ADR 0014 gave the phone a nightly and ADR 0013 rule 3 gave the desktop none, so the two heads had different answers to the same question — how does somebody try what is on main? — for no reason except the order the work happened in. This is the desktop's answer: CI publishes a build from main on every push, and it installs beside the release one rather than over it. The phone gets its separation from the platform. Android refuses an update signed by a different key, so its two channels cannot replace one another whatever anybody does. Nothing refuses anything here: Velopack applies what its feed serves and verifies no signature. So all of it is construction, and there are four separations because each closes a different door. A pack id each, so the two install in different directories and neither feed's package can be applied to the other's install. A Velopack channel each — win and win-nightly — so neither build ever reads the other's release index; the name reaches the wire as releases.win-nightly.json, which is why the constant in VelopackUpdateChannel and the argument in ci.yml have to agree or the channel answers nothing forever with no error. A prerelease flag, so the release channel cannot see the nightly even by accident. And a profile directory each, which is the one that is easy to skip and would hurt most: the cache schema is migrated on every launch, before unlock, so a shared profile means a nightly quietly upgrading a database the release build then opens. Both are installed at once by design, so that is an ordinary Tuesday rather than a corner case. The prerelease flag turns out to be load-bearing across heads as well. The phone's release channel reads releases/latest, which skips prereleases — so a desktop nightly published as a stable release would become the newest release in this repository and every phone on the release channel would start failing its check against a release carrying no Android manifest. Which build this is arrives as assembly metadata, the same mechanism and the same reasoning as the Android head: the updater needs the string rather than a branch, and a value baked into the assembly is one a crash report can be asked for. Three things read it — the feed, the prerelease flag, and the profile — and one more shows it: the titlebar says DodoSSH Nightly. Everything else that distinguishes the two is somewhere nobody is looking while typing a passphrase into one of them. The version needed a floor and it is applied to the whole build rather than to the packaging. MinVer answers 0.0.0-alpha.0.N until the first v* tag and vpk refuses anything below 0.0.1, so the job lifts the patch digit and keeps the height — through MinVerVersionOverride, so the assemblies carry the same number the installer does. Packing a version the assembly disagreed with would put one string on the preferences screen and another in the feed, which is the screen somebody reads when asked which nightly they are on. Two things found by running it rather than reading it. -t:MinVer needs a restore first, because the target arrives with the package and MSB4057 on a clean checkout reads like a typo in the workflow rather than a missing restore; the release script had the same gap and now restores before it reads. And vpk rejects an empty --packVersion loudly, which is how a broken version handoff announces itself rather than shipping a package called 1.0.0. Rule 3 is untouched. The release channel still has no job, no token and no runner, and the two channels cannot see each other. What a nightly costs is written where somebody reads it before installing one: whoever can write a release here can put a build on every nightly machine, which is fine for a build being tried and is not fine for a build holding somebody's infrastructure credentials. Verified by running the job's own steps against a clone in a Linux container: DodoSSH.Desktop.Nightly-win-nightly-Setup.exe, and an index naming pack id DodoSSH.Desktop.Nightly at 0.0.1-alpha.0.144. The upload itself is the one step not exercised — it needs a real forge and a write token, and check 16.10 is what walks the half no runner can.
This commit is contained in:
@@ -71,6 +71,11 @@ $RepoUrl = 'https://git.dodotech.cloud/DodoTech-Public/DodoSSH'
|
||||
# A contract with VelopackUpdateChannel.ReleaseChannel. It is Velopack's Windows default, so leaving it
|
||||
# unsaid on both sides would work too — but unsaid here and stated there is how a feed goes quiet with no
|
||||
# error at all: the client checks, finds nothing, and reports itself up to date forever.
|
||||
#
|
||||
# The nightly channel is the same three values with different contents — DodoSSH.Desktop.Nightly, DodoSSH
|
||||
# Nightly, win-nightly — and they live in the `desktop nightly` job in .github/workflows/ci.yml rather than
|
||||
# here, because that build is CI's and this script is a person's. Nothing shares them, deliberately: this
|
||||
# file must keep working if that job is deleted. See ADR 0013 decision 9 for what the separation buys.
|
||||
$Channel = 'win'
|
||||
|
||||
$RepoRoot = Split-Path -Parent $PSScriptRoot
|
||||
@@ -100,11 +105,20 @@ Push-Location $RepoRoot
|
||||
try {
|
||||
# ---- What is being released -----------------------------------------------------------------------
|
||||
|
||||
# -t:MinVer, and it is load-bearing. -getProperty on its own evaluates the project and runs no
|
||||
# targets, while MinVer sets Version from inside one — so this read answered the SDK's default
|
||||
# 1.0.0 regardless of the tag, and the check below would then have refused to build anything not
|
||||
# tagged v1.0.0. CI's tag check had the same line and the same fault; both are fixed, and both
|
||||
# say so, because this is the version that ends up in the package a client compares against.
|
||||
# Restored before the version is read, and both halves of that sentence are load-bearing.
|
||||
#
|
||||
# -t:MinVer, because -getProperty on its own evaluates the project and runs no targets, while MinVer
|
||||
# sets Version from inside one — so this read answered the SDK's default 1.0.0 regardless of the tag,
|
||||
# and the check below would then have refused to build anything not tagged v1.0.0. CI's tag check had
|
||||
# the same line and the same fault.
|
||||
#
|
||||
# And a restore first, because naming a target that arrives with a package fails MSB4057 on a clean
|
||||
# clone, where obj/ has no MinVer targets to import yet. It costs seconds on a machine that has built
|
||||
# before, which is every machine except the one this would otherwise fail on.
|
||||
Write-Step 'Restoring the desktop head, so the version can be read'
|
||||
& dotnet restore $Project --locked-mode
|
||||
if ($LASTEXITCODE -ne 0) { Stop-With 'Restore failed.' }
|
||||
|
||||
$version = (& dotnet msbuild $Project -getProperty:Version -t:MinVer -nologo) -replace '\s', ''
|
||||
if ([string]::IsNullOrWhiteSpace($version)) {
|
||||
Stop-With 'Could not read the version from MSBuild.'
|
||||
|
||||
Reference in New Issue
Block a user