Public Access
Let the terminal's text be made bigger, and remember how big
Taking pinch-zoom off the phone left nothing in its place, and there was nothing on the desktop either. This is the replacement, and it is deliberately not the thing that was removed: zoom scales what has already been drawn, so the remote goes on wrapping to a width that is no longer on screen. Changing the font size refits the grid and reports the new column count, so the far end is told it has fewer columns. That round trip is the feature. The size is one number, owned by the shell. It has to be, for two reasons that pull the same way: it must survive a relaunch, and it must be reachable from a phone that has no Ctrl key to press. So the page asks and the host decides — a signed step over a new client opcode, answered with a size over a new server opcode. The phone's buttons and the desktop's chords arrive at the same place, and a size set by either is the size both remember. Stored in settings.json beside the cache rather than in it, and that is not laziness about a migration. The cache is encrypted and unreadable until a vault is unlocked, and the first terminal of a locked launch needs the size already. Nothing secret may go in that file; ClientSettings says so out loud, because the next person to add a preference is the one who needs to read it. Where it is reachable from differs per head, and only here. The phone gets A− and A+ on the connection line — not in the accessory row, which scrolls, and a control that fixes unreadable text must never be the thing that is off-screen. The desktop gets the three chords every terminal emulator has, answered by the page while a terminal has focus and by the window when it does not, plus a row in preferences that shows the current value and names the chords rather than replacing them. Someone whose terminal is too small to read is not in a position to go looking. Clamped 8 to 32. Below eight a monospace grid stops being legible and becomes a texture, and every column of it is still a column the remote is being told exists; above thirty-two a phone in portrait has too few columns to hold a prompt. The buttons disable at the ends rather than accepting presses that do nothing, which on a terminal reads as the application having stopped responding. The preferences screen's header comment claimed none of the design's terminal settings could be saved, and listed the three things that were missing to make one work. All three now exist, so it says which one is real and why the other five still are not. Verified with the protocol suite — including that the step byte round-trips signed, since read unsigned a step down arrives as 255 and clamps to the largest font, making "smaller" do the most dramatic available version of "larger" — a data-plane test that the chord is heard with no session registered, and five shell tests: the default matches the renderer's, both clamps hold, reset works, and a size chosen in one shell is there in a second one over the same profile directory. Layout suite and both heads build. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -37,6 +37,18 @@ public sealed class TerminalSessionEndedEventArgs(uint sessionId) : EventArgs
|
||||
public uint SessionId { get; } = sessionId;
|
||||
}
|
||||
|
||||
/// <summary>The renderer asking for a different font size.</summary>
|
||||
/// <param name="step">
|
||||
/// How far to move, in points of font size, or zero to go back to the default. It is a step rather than a
|
||||
/// size because the page does not hold the current one — the host does, and clamping a step is what stops
|
||||
/// two chords in flight from disagreeing about where they started.
|
||||
/// </param>
|
||||
public sealed class TerminalFontSizeStepEventArgs(int step) : EventArgs
|
||||
{
|
||||
/// <summary>The requested move, or zero for "back to the default".</summary>
|
||||
public int Step { get; } = step;
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Owns the loopback data plane and every live terminal session.
|
||||
/// </summary>
|
||||
@@ -96,6 +108,11 @@ public sealed class TerminalWorkspace : IAsyncDisposable
|
||||
this.options = options ?? new TerminalWorkspaceOptions();
|
||||
|
||||
dataPlane = new TerminalDataPlane(assets);
|
||||
|
||||
// Forwarded rather than re-raised with the workspace as the sender, so a handler can tell where it
|
||||
// came from. Nothing here decides anything about the size: the shell owns it, because the shell is
|
||||
// what remembers it between launches.
|
||||
dataPlane.FontSizeStepRequested += (_, e) => FontSizeStepRequested?.Invoke(this, e);
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
@@ -186,9 +203,42 @@ public sealed class TerminalWorkspace : IAsyncDisposable
|
||||
/// </remarks>
|
||||
public event EventHandler<TerminalSessionEndedEventArgs>? SessionEnded;
|
||||
|
||||
/// <summary>Raised when the renderer's own keyboard asks for a different font size.</summary>
|
||||
/// <remarks>
|
||||
/// The chords can only be heard by the page — once a terminal has focus the host's window sees no key
|
||||
/// events at all — so this is how Ctrl+plus reaches the thing that owns the setting. Raised on the
|
||||
/// socket's receive loop; marshal before touching a view model.
|
||||
/// </remarks>
|
||||
public event EventHandler<TerminalFontSizeStepEventArgs>? FontSizeStepRequested;
|
||||
|
||||
/// <summary>Starts the loopback listener.</summary>
|
||||
public void Start() => server = dataPlane.RunAsync(lifetime.Token);
|
||||
|
||||
/// <summary>
|
||||
/// Tells every pane what size to draw at.
|
||||
/// </summary>
|
||||
/// <remarks>
|
||||
/// <para>
|
||||
/// Sent to the page rather than applied per session, and unconditionally rather than only when a
|
||||
/// session is live: the page keeps the size for panes opened later, so this is also how the first
|
||||
/// terminal of a launch comes up at the size the user last chose.
|
||||
/// </para>
|
||||
/// <para>
|
||||
/// Every live pane refits as a result and reports its new geometry, so the remotes are told they have
|
||||
/// fewer columns. That round trip is the feature rather than a side effect — see
|
||||
/// <see cref="TerminalServerOpcode.FontSize"/>.
|
||||
/// </para>
|
||||
/// </remarks>
|
||||
/// <param name="pixels">The size in CSS pixels. Clamped by the caller; sent as one byte.</param>
|
||||
/// <param name="cancellationToken">Cancellation.</param>
|
||||
public ValueTask SetFontSizeAsync(int pixels, CancellationToken cancellationToken) =>
|
||||
dataPlane.SendAsync(
|
||||
TerminalFrame.Create(
|
||||
(byte)TerminalServerOpcode.FontSize,
|
||||
sessionId: 0,
|
||||
TerminalFrame.CreateFontSizePayload(pixels)),
|
||||
cancellationToken);
|
||||
|
||||
/// <summary>
|
||||
/// Waits until the renderer page has attached its socket.
|
||||
/// </summary>
|
||||
|
||||
Reference in New Issue
Block a user