Share the shelf as well as what is on it, and ask a group which vault

A group is where hosts are filed and what lends them a port, a username and a key, and until now it could only ever be made in the vault this machine files new items into. So sharing a vault shared the machines and not the arrangement: a colleague opened four hosts filed under a group they could read the name of and nothing else, and the group a teammate made had no card, no heading and no way to be corrected from the screen looking straight at the hosts inside it. Recorded as half shipped in docs/design-import-gaps.md, and this is the other half. The list stopped being the active vault's. It was narrow for two stated reasons — a row shown across vaults has to carry which vault it lives in, because rename and delete both need it, and two vaults may hold a "production" each, which a layout with one heading per group cannot tell apart — and both are now paid for rather than avoided. Every row carries its vault, the badge beside the name says which, and the two cards sit side by side saying what they are. The three shapes of the group read are now deliberately different sizes. The list is what a person looks at, so a hidden vault's groups leave it: a card that cannot be opened onto anything is worse than no card. The per-vault lists are what a picker offers, because a picker is always asking about one vault. The map is what a host's GroupId resolves through, and it stays widest of all — including over hidden vaults, since a group lends a port and hiding a vault must never change what one of its hosts dials. RebuildGroups is the one place hiding is applied, which is what keeps those answers apart. The editor asks which vault on the terms the host editor's picker set: while adding only, hidden where there is one writable vault, and never offered afterwards, because the two are encrypted under different keys and moving an item is a delete and a retype. Its parent picker is that vault's alone, for the reason the host editor's group picker is one level down — a parent in another vault is a level half the key holders cannot resolve, and their hosts would inherit from nothing. + NEW GROUP inside an open group departs from NewHost and takes that group's vault rather than the standing preference: a group made inside another is in its parent's vault by construction, and answering "inside PLATFORM" with a group elsewhere and no parent would drop the one thing the button said. Two smaller things follow from the cards spanning vaults. Dragging a host onto a group card in another vault is refused with both names, because the write it would make is exactly the id-nobody-can-resolve the host editor's picker was fixed to prevent, and treating it as "no group" would unfile a host somebody was plainly filing. And a group being renamed says its vault in the drawer's header, since the picker is not drawn for an existing one and renaming a colleague's shelf without being told whose it is is the edit most worth naming. The save target is a nullable field behind a property that falls back to the standing preference. The group name box is bound whether or not anything raised an editor over it — that is what the desktop's group bar was, and typing a name into it and pressing ADD is still a way to make a group, which would otherwise have written to no vault at all. 1575 tests pass, five more than before: a group filed into a shared vault is listed and renamed there, the editor's picker does not move the keychain screen's, the parent picker offers only its own vault, a cross-vault drop is refused, and hiding a vault takes the cards without changing what its hosts dial.
2026-08-04 16:27:16 +02:00
parent 176df67861
commit c39df3f51e
8 changed files with 762 additions and 108 deletions
@@ -125,7 +125,21 @@
        <DataTemplate DataType="vm:SidebarGroupHeader">
          <Grid ColumnDefinitions="Auto,*,Auto,Auto" Margin="8,12,8,5">
            <TextBlock Grid.Column="0" Classes="detail" Text="{Binding Chevron}" VerticalAlignment="Center" />
-            <TextBlock Grid.Column="1" Classes="section" Text="{Binding Label}" Margin="7,0,0,0" />
+
+            <!--
+              The name, and the vault it is in where this session holds more than one. The badge is what
+              makes one heading per group survive a shared vault: two vaults may each hold a "production",
+              and this list has no nesting to tell the two apart with. Drawn as the same outline tag a host
+              row wears, so "which vault" looks the same wherever it is answered.
+            -->
+            <StackPanel Grid.Column="1" Orientation="Horizontal" Spacing="6" Margin="7,0,0,0">
+              <TextBlock Classes="section" Text="{Binding Label}" TextTrimming="CharacterEllipsis" />
+              <Border Classes="tag outline" VerticalAlignment="Center"
+                      IsVisible="{Binding HasVaultBadge}">
+                <TextBlock Text="{Binding VaultBadge}" />
+              </Border>
+            </StackPanel>
+
            <TextBlock Grid.Column="2" Classes="detail" Text="{Binding Count}" FontSize="9"
                       VerticalAlignment="Center" />

@@ -367,6 +381,27 @@

          <TextBox Classes="field" Text="{Binding GroupEditorLabel}" PlaceholderText="group name" />

+          <!--
+            ◆ WHICH VAULT THIS GROUP WILL LIVE IN, on the same terms as the host editor's picker above and
+            for the same reason: it is what makes the group shared, and it cannot be changed afterwards.
+            Above INSIDE because it decides what INSIDE can offer — a parent belongs to one vault, and one
+            from another is a level half the readers cannot resolve.
+          -->
+          <StackPanel Spacing="6" IsVisible="{Binding ShowsGroupEditorVaultChoice}">
+            <TextBlock Classes="label" Text="VAULT" Margin="0,4,0,0" />
+            <ComboBox ItemsSource="{Binding GroupEditorVaultChoices}"
+                      SelectedItem="{Binding GroupEditorSelectedVault}"
+                      HorizontalAlignment="Stretch" MinHeight="44">
+              <ComboBox.ItemTemplate>
+                <DataTemplate x:DataType="vm:VaultChoiceViewModel">
+                  <TextBlock Classes="mono" FontSize="12" Text="{Binding Display}" />
+                </DataTemplate>
+              </ComboBox.ItemTemplate>
+            </ComboBox>
+            <TextBlock Classes="body"
+                       Text="A group in a shared vault is visible to everybody holding that vault's key, and only hosts in the same vault can be filed under it." />
+          </StackPanel>
+
          <TextBlock Classes="label" Text="INSIDE" Margin="0,4,0,0" />
          <ComboBox ItemsSource="{Binding GroupEditorParentChoices}"
                    SelectedItem="{Binding GroupEditorSelectedParent}"