Specify the key statement encoding and key log chain (crypto.md 7.1, 7.2)

Public Access

Section 7 always required "a canonical, length-prefixed encoding" for
signatures without ever specifying one. That gap had to be closed before
enrollment could exist: the client hashes the key statement and uses the
result as an OIDC nonce, so the provider signs over those exact bytes. Two
implementations disagreeing by one byte produce two nonces and an
enrollment nobody can verify -- and it only shows up against a real
provider, never in a local test.

JSON cannot be the hashed form. Property order, number formatting, Unicode
escaping and whitespace all vary between serialisers. So the statement is
transmitted as JSON and hashed as a fixed binary encoding, and the two are
independent by construction.

Three details are load-bearing rather than stylistic:

- The presence byte before each string is what makes the encoding
  injective. Without it an absent email and an empty one encode
  identically, and two different statements share a binding.
- Timestamps truncate to milliseconds. PostgreSQL stores microseconds, so
  a statement that has been through the database must still hash to what
  the client hashed. The same applies to the key log, where an entry that
  cannot reproduce its own hash after being read back makes the chain
  unverifiable.
- The key log entry hash deliberately excludes the database sequence. It
  is unknown until the insert runs, and order already follows the hash
  links -- so a renumbered or gapped sequence column cannot silently
  reorder history.

KeyStatementFields is separate from Contracts.KeyStatement on purpose: one
may gain JSON fields freely, the other cannot change without invalidating
every stored binding, and Crypto must not depend on the contract assembly.
KeyStatementDriftTests makes a field added to one and not the other a
build failure, because a wire field outside the binding is unauthenticated
data the server can change undetected.

54 new tests and two new golden vector sections. The vectors pin the
absent-versus-empty email case and confirm that an offset-bearing
sub-millisecond timestamp encodes identically to its truncated UTC form.
Only additions to vectors.json; nothing existing moved.

This commit is contained in:

jaap-jan

2026-07-28 16:06:11 +02:00

parent e6673f0bf2

commit d2a2ed8a29

13 changed files with 1363 additions and 1 deletions

									
										tests/DodoSSH.Contracts.Tests/DodoSSH.Contracts.Tests.csproj
									
		+7
		
												View File
												
				@@ -9,6 +9,13 @@

				  <ItemGroup>

				    <ProjectReference Include="../../src/DodoSSH.Contracts/DodoSSH.Contracts.csproj" />

				    <!--

				      Only so KeyStatementDriftTests can compare the wire DTO against the type the canonical

				      encoding is defined over. Contracts itself must not reference Crypto: the two are

				      deliberately independent, which is the thing that test guards.

				    -->

				    <ProjectReference Include="../../src/DodoSSH.Crypto/DodoSSH.Crypto.csproj" />

				  </ItemGroup>

				</Project>