Public Access
Sync credentials as a vault item type, and bind one to a host
Closes the largest remaining M1 gap in the data layer: a username and password can live in the vault, sync between machines, and be named by a host as how it authenticates. What is not here is the interface for creating one — see the end of this message. The third item type, and the first one that cost almost nothing to add. Server: a VaultCredential row, an EF configuration, a migration, and a CredentialKind. Client: a secret, a codec, a merge, a cipher, a kind, a repository facade and a session property. No new reconciliation logic, no change to the sync engine, no client cache migration. That was the whole point of the item-kind seam, and this is the evidence it holds. The narrowest type of the three on plaintext, and not for symmetry. A host has a deliberate concession — the relay needs an address it can resolve. A key has a fingerprint, public by nature, which this client still declines to send. A password has no part that is safe to expose: not its length, not a hash, not a hint. So CredentialKind refuses every plaintext field there is, hydrates none, and the table has no column to put one in. HostSecret.CredentialId is the password counterpart of SshKeyId, and the two are mutually exclusive. SSH itself would happily try a key and fall back to a password, but a host naming both leaves "how does this authenticate?" without a single answer — the interface, the connect path and the user would each be free to guess differently. TryValidate refuses it. One consequence was not anticipated: "a full host" stops being a coherent idea, which is what broke AFullHost_RoundTrips and is now written into that test. The schema version became a ladder rather than a maximum: credential-bound is 3, key-bound is 2, neither is still 1. Adding credentials therefore does not drag every key-bound host in every vault onto a version that clients understanding keys perfectly well would refuse to edit. A test pins exactly that, because it is the property the whole content-dependent-version rule exists to provide, and the obvious implementation would quietly lose it. Two tests had become false and said so: - Push_AnUnsupportedEntityType_IsInvalidNotAFailedBatch used Credential as its example of a type this server does not implement. It now asks the server's own registry what is still missing, so it cannot go stale again, and skips with a reason if that set ever empties. - ThePullFilterNamesEveryTypeThisBuildSynchronises pinned the exact list, which is what it is for. Also fixes ten nullable warnings — eight in SyncEndpointTests, two in a test file added earlier today. Neither set was introduced here; both were invisible until an unrelated change forced their project to recompile, which means the zero-warning claims made earlier in this work only ever covered what happened to be rebuilt. 777 tests green. Zero warnings, dotnet format clean. Not done, and deliberately: the credential interface. The vault column is 340 pixels wide and already holds two lists and two editors, kept from clipping its own buttons at the window's minimum height only by the one-editor-at-a-time rule added earlier today. A third list and a third editor would recreate that defect rather than avoid it, so the column needs a shape decision first. Credentials sync; they cannot yet be created in the interface.
This commit is contained in:
@@ -38,6 +38,7 @@ internal sealed class SyncDevice : IDisposable
|
||||
Conflicts = new ConflictStore(factory, protector, TimeProvider.System);
|
||||
Hosts = new HostRepository(Items, Outbox, keyring);
|
||||
SshKeys = new SshKeyRepository(Items, Outbox, keyring);
|
||||
Credentials = new CredentialRepository(Items, Outbox, keyring);
|
||||
|
||||
Engine = new SyncEngine(
|
||||
server, Items, Outbox, SyncState, Conflicts, keyring, TimeProvider.System, options);
|
||||
@@ -59,6 +60,8 @@ internal sealed class SyncDevice : IDisposable
|
||||
|
||||
internal SshKeyRepository SshKeys { get; }
|
||||
|
||||
internal CredentialRepository Credentials { get; }
|
||||
|
||||
internal SyncEngine Engine { get; }
|
||||
|
||||
internal static async Task<SyncDevice> CreateAsync(
|
||||
@@ -142,6 +145,26 @@ internal sealed class SyncDevice : IDisposable
|
||||
internal Task DeleteKeyAsync(Guid entityId) =>
|
||||
SshKeys.DeleteAsync(SyncHarness.VaultId, entityId, TestContext.Current.CancellationToken);
|
||||
|
||||
// ---- And again on credentials ----
|
||||
|
||||
internal Task<ItemListing<CredentialSecret>> ListCredentialsAsync() =>
|
||||
Credentials.ListAsync(SyncHarness.VaultId, TestContext.Current.CancellationToken);
|
||||
|
||||
internal async Task<VaultItem<CredentialSecret>> FindCredentialAsync(Guid entityId)
|
||||
{
|
||||
var listing = await ListCredentialsAsync();
|
||||
|
||||
return listing.Items.SingleOrDefault(credential => credential.EntityId == entityId)
|
||||
?? throw new InvalidOperationException($"{Name} cannot see credential {entityId}.");
|
||||
}
|
||||
|
||||
internal Task<Guid> CreateCredentialAsync(CredentialSecret credential) =>
|
||||
Credentials.CreateAsync(SyncHarness.VaultId, credential, TestContext.Current.CancellationToken);
|
||||
|
||||
internal Task UpdateCredentialAsync(Guid entityId, CredentialSecret credential) =>
|
||||
Credentials.UpdateAsync(
|
||||
SyncHarness.VaultId, entityId, credential, TestContext.Current.CancellationToken);
|
||||
|
||||
internal Task<IReadOnlyList<StoredConflict>> ConflictsAsync() =>
|
||||
Conflicts.ListAsync(SyncHarness.VaultId, false, TestContext.Current.CancellationToken);
|
||||
|
||||
@@ -284,6 +307,14 @@ internal sealed class SyncHarness : IDisposable
|
||||
/// what it was used for. <c>SshKeySecret.TryValidate</c> only requires the armour, and the tests that
|
||||
/// need a key SSH.NET can actually load live in <c>DodoSSH.Client.Ssh.Tests</c> where one is generated.
|
||||
/// </remarks>
|
||||
/// <summary>A credential for the suites, varying only what a test is about.</summary>
|
||||
internal static CredentialSecret Credential(
|
||||
string label,
|
||||
string password = "hunter2",
|
||||
string? username = null,
|
||||
string? notes = null) =>
|
||||
new() { Label = label, Password = password, Username = username, Notes = notes };
|
||||
|
||||
internal static SshKeySecret Key(
|
||||
string label,
|
||||
string material = "deploy-key-material",
|
||||
|
||||
Reference in New Issue
Block a user