From e6673f0bf2c5511305c03971d21da060e86209f5 Mon Sep 17 00:00:00 2001 From: Jaap-Jan de Wit | DodoTech Date: Tue, 28 Jul 2026 16:05:52 +0200 Subject: [PATCH] Fix the CI formatting gate, which was already failing dotnet format --verify-no-changes exits 2 on main: the async-suffix naming rule fires on every async test method. I reported this gate as clean when finishing the sync engine and it was not. Test names are documentation. Push_WithAStaleVersion_ReportsConflict says what is asserted; adding Async says the same plus an implementation detail nobody reading a failure report needs. The suffix convention exists so callers can spot awaitables, and a test method has no callers -- so the rule is switched off under tests/ rather than the names being changed. --- .editorconfig | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.editorconfig b/.editorconfig index 8945f0d..60979ca 100644 --- a/.editorconfig +++ b/.editorconfig @@ -133,6 +133,12 @@ dotnet_diagnostic.CA1849.severity = warning # sync call in async method dotnet_diagnostic.CA1812.severity = none dotnet_diagnostic.CA1034.severity = none +# A test name is documentation: Push_WithAStaleVersion_ReportsConflict says what is being +# asserted, and Push_WithAStaleVersion_ReportsConflictAsync says the same thing plus an +# implementation detail nobody reading a failure report cares about. The async suffix +# convention exists so callers can spot awaitables; a test method has no callers. +dotnet_diagnostic.IDE1006.severity = none + [src/DodoSSH.Infrastructure/Migrations/*.cs] # EF Core generates these; do not lint or format them. generated_code = true