Merge branch 'claude/desktop-auto-updater-0264a3'

2026-08-04 17:56:50 +02:00
parent f37d7ee12e 0b6059d4a8
commit e923b12b7f
1 changed files with 16 additions and 1 deletions
@@ -346,7 +346,22 @@ internal sealed partial class UpdateViewModel : ObservableObject, IAsyncDisposab
        State = UpdateState.Downloading;
        DownloadPercent = 0;
-        var progress = new Progress<int>(percent => DownloadPercent = percent);
+        // Monotonic, and it has to be. Progress<T> delivers its callbacks by posting them to the captured
        // synchronisation context rather than invoking them inline, so a report can arrive after the
        // download has already returned — and an unguarded assignment then puts a stale smaller number
        // back on the bar and leaves it there, because nothing reports again. Seen for real: a run of this
        // finished at 50 with the state already Ready.
        //
        // Guarding here rather than reaching for an inline IProgress, because the posting is wanted: in the
        // application these callbacks come off whichever thread the updater downloads on, and an observable
        // property changed off the UI thread is a binding exception rather than a stale number.
        var progress = new Progress<int>(percent =>
        {
            if (percent > DownloadPercent)
            {
                DownloadPercent = percent;
            }
        });
        await updates.DownloadAsync(found, progress, cancellationToken).ConfigureAwait(true);