Public Access
Let a shared vault arrive, a bucket be found, and a vault be deleted
Three things a user reported, one of which was a real bug and one of which was
not the bug it looked like.
**A vault shared with somebody never reached their machine.** The grant was
correct at both ends: the sharing client verified the recipient's key against the
key log and wrapped every generation to it, the server stored it, and /me would
have returned it. Nothing asked. VaultSession.RefreshVaultsAsync — the method
whose own summary says it is "called after a share and on a periodic pass" — had
no caller anywhere in the application, so the vault list was whatever the last
browser sign-in cached. A restart did not help: an offline unlock reads that same
cache. The vault appeared only if the recipient happened to sign in through the
browser again, which is why this looked like sharing being broken rather than
like a list that was never re-read.
So every synchronisation pass now re-reads it, before it syncs. SyncOnceAsync
takes the whole server rather than its sync half for that reason, and the order
matters: a vault admitted by the refresh is one that same pass then pulls, where
the other order would show a newly shared vault as an empty one until the minute
after. The shell is told only when the set actually changed — it rebuilds the tab
strip's vault menu from the session's list, and doing that on every quiet pass
would rebuild a menu once a minute for nothing.
The test needed the fake server to be able to do something no test here had
needed before: hand this account a vault it did not make. ShareVaultWithMe wraps
a real key to the encryption key this account enrolled, so the keyring opens it
exactly as it opens a real colleague's — a helper that filled the field with
bytes would let a vault appear in the list and never prove it could be read.
**Adding an S3 bucket on the desktop works, and could not be found.** The report
was that it is not possible; driving the real XAML headlessly says otherwise —
Keychain, + BUCKET, and the editor saves. What is true is that S3 is where
somebody goes looking, and from there SELECT BUCKET opened a combo box with
nothing in it and no sentence anywhere saying that a bucket is a keychain item.
From where the user was standing that is indistinguishable from an application
with no way to add one.
The empty state now says what a bucket is and offers a button that lands on the
keychain with the editor already open — navigating to the screen and leaving
+ BUCKET to be found among five buttons would be most of the same problem. The
phone gets the sentence and no button: its keychain screen reads and deletes and
edits nothing, so there is no editor to send anybody to, and naming the machine
that has one beats an empty control that reads as a screen still loading.
The keychain screen's layout test grew the two categories it never covered.
Tags and buckets arrived after it was written, and the header strip it measures
is one that has overflowed twice before.
**A vault can now be deleted.** DELETE /api/v1/vaults/{id}, gated on Admin —
the line the rename already drew, for a stronger version of its reason, since
this takes the vault from everybody in it at once. The row is soft-deleted and
every grant to it withdrawn in one write; VaultAccessService filters on the stamp
at both ends, so from that moment the vault is absent from every member's /me and
every call naming it answers 404. Their clients notice on the pass described
above.
The team behind it is archived when it owned nothing else, which is the mirror of
renaming it: a vault made from the vaults screen gets a team named after it that
nobody was ever shown, and leaving that behind would leave a membership list no
screen has a row for. That is a second call rather than one transaction —
archiving is TeamService's, it refuses while a team owns vaults, and it can only
tell that this one no longer does once the deletion is committed. A crash between
the two leaves an empty team: invisible, archivable afterwards, harmless, and a
better failure than a vault that could not be deleted because tidying up after it
did not work.
Two refusals worth stating. The personal vault cannot be deleted at either end:
it is created by enrollment, everything filed nowhere else lives in it, and no
call would make another. And the items are kept — ciphertext behind a vault
nothing will resolve, so deleting them buys no confidentiality while destroying
what an operator undoing a mistake would need.
The client drops the key from the keyring and the row from the cache rather than
waiting for a refresh, so the list is right immediately; the items stay, as they
stay for a vault whose grant was withdrawn, because a copy is on every other
member's machine too and removing these rows would be the client pretending to a
reach it does not have. The confirmation says that out loud before it is
answered. It is the one sentence this screen must not leave implied: deletion is
no more retroactive than revocation is. See ADR 0001.
Desktop only, deliberately. The Android vaults screen offers no rename and no
hand-over either, so adding delete alone there would be the one destructive vault
operation on a screen with no other.
Three places asserted that a vault can never be deleted — TeamService's refusal
message, the TeamNotEmpty problem code, and ADR 0009 — and each now names the
route instead.
This commit is contained in:
@@ -377,7 +377,10 @@ internal sealed partial class MainWindowViewModel : ObservableObject, IAsyncDisp
|
||||
// to register for a reason no message could explain.
|
||||
this.deviceName = string.IsNullOrWhiteSpace(deviceName) ? Environment.MachineName : deviceName;
|
||||
|
||||
transfers = new TransfersViewModel(sftpSessions, clock);
|
||||
// The fourth argument is the route out of the S3 screen's empty state. A bucket is made on the
|
||||
// keychain screen, which is a different tab and two clicks away from somebody who has gone to S3
|
||||
// to add one — so the screen that needs a bucket is given a way to reach the screen that makes one.
|
||||
transfers = new TransfersViewModel(sftpSessions, clock, addBucket: ShowNewBucket);
|
||||
|
||||
// Built once, like the workspace it writes for, and given a vault only while one is open. It has to
|
||||
// outlive every lock for the same reason the workspace does: a shell opened before a lock is still
|
||||
@@ -1300,6 +1303,27 @@ internal sealed partial class MainWindowViewModel : ObservableObject, IAsyncDisp
|
||||
vaults.NewVaultCommand.Execute(null);
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Goes to the keychain with the bucket editor open.
|
||||
/// </summary>
|
||||
/// <remarks>
|
||||
/// <para>
|
||||
/// The same shape as <see cref="ShowNewVault"/> and for the same reason: the thing being made lives on
|
||||
/// one screen, and the moment somebody wants it happens on another. Here the two are a whole tab apart —
|
||||
/// S3 is where a bucket is used and the keychain is where its keys are kept — which is what made the S3
|
||||
/// screen's empty picker read as an application that could not add one at all.
|
||||
/// </para>
|
||||
/// <para>
|
||||
/// Silent when the vault is locked, which is a state the button behind this is not reachable in: the
|
||||
/// screen it sits on is inside the unlocked half of the window.
|
||||
/// </para>
|
||||
/// </remarks>
|
||||
private void ShowNewBucket()
|
||||
{
|
||||
ShowScreen(ShellScreen.Keychain);
|
||||
Vault?.NewObjectStoreCommand.Execute(null);
|
||||
}
|
||||
|
||||
// ---- The phone's connect menu ----
|
||||
|
||||
/// <summary>
|
||||
@@ -2599,6 +2623,8 @@ internal sealed partial class MainWindowViewModel : ObservableObject, IAsyncDisp
|
||||
// "connecting…" for ever and leave the session it eventually opened with nothing in the window
|
||||
// naming it, and so no way to close it. The subscription dies with the vault once the attempt
|
||||
// resolves: the vault holds the handler, not the other way round.
|
||||
oldValue.VaultsChanged -= OnVaultsAdmitted;
|
||||
|
||||
if (attempts.Count == 0)
|
||||
{
|
||||
oldValue.ConnectionStarting -= OnVaultConnectionStarting;
|
||||
@@ -2614,6 +2640,12 @@ internal sealed partial class MainWindowViewModel : ObservableObject, IAsyncDisp
|
||||
newValue.SessionOpened += OnVaultSessionOpened;
|
||||
newValue.PropertyChanged += OnVaultPropertyChanged;
|
||||
|
||||
// A vault somebody shared arrives on a synchronisation pass rather than through anything the
|
||||
// user pressed here — so the menu that lists them is rebuilt from the event rather than at the
|
||||
// end of a command, which is the one place a newly admitted vault has no command to be at the
|
||||
// end of.
|
||||
newValue.VaultsChanged += OnVaultsAdmitted;
|
||||
|
||||
// The host list is rebuilt from scratch on every synchronisation pass, and a rebuilt row starts
|
||||
// disconnected — so without this the status dots go out once a minute underneath terminals that
|
||||
// are still open. The rows belong to the vault and the connection state belongs to the shell,
|
||||
@@ -2696,6 +2728,16 @@ internal sealed partial class MainWindowViewModel : ObservableObject, IAsyncDisp
|
||||
AdoptTab(tab);
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Redraws the vault menu after a synchronisation pass found a vault this account had not seen.
|
||||
/// </summary>
|
||||
/// <remarks>
|
||||
/// The vault itself is already on every screen by the time this runs — the pass that admitted it
|
||||
/// reloaded the lists — so this is only the one thing the vault view model has no way to reach: the
|
||||
/// switches in the tab strip, which are built here from the session's vault list.
|
||||
/// </remarks>
|
||||
private void OnVaultsAdmitted(object? sender, EventArgs e) => RebuildVaultToggles();
|
||||
|
||||
/// <remarks>
|
||||
/// The vault opens SSH sessions and this shell owns the strip they appear in, so this is the seam between
|
||||
/// them and nothing more.
|
||||
|
||||
@@ -313,13 +313,24 @@ internal sealed partial class TransfersViewModel : ObservableObject, IAsyncDispo
|
||||
/// removes the thread from the question rather than making the test guess it right.
|
||||
/// </para>
|
||||
/// </param>
|
||||
/// <param name="addBucket">
|
||||
/// Takes the user to where a bucket is made, or null in a head that has nowhere to take them.
|
||||
/// <para>
|
||||
/// A delegate rather than this screen making one itself, and it is the same seam the vaults screen uses
|
||||
/// for the shell: a bucket is a keychain item, the editor that writes one belongs to the keychain screen,
|
||||
/// and duplicating it here would be a second form writing the same secret. What this screen owns is the
|
||||
/// knowledge that somebody standing on it with no buckets needs to be sent somewhere.
|
||||
/// </para>
|
||||
/// </param>
|
||||
internal TransfersViewModel(
|
||||
ISftpSessionFactory sftp,
|
||||
TimeProvider clock,
|
||||
Action<Action>? post = null)
|
||||
Action<Action>? post = null,
|
||||
Action? addBucket = null)
|
||||
{
|
||||
this.sftp = sftp;
|
||||
this.post = post ?? (action => Dispatcher.UIThread.Post(action));
|
||||
this.addBucket = addBucket;
|
||||
|
||||
// The supplier answers with whatever session is current at the moment a transfer starts, which is
|
||||
// what lets a queue survive a disconnect and reconnect without every queued row failing.
|
||||
@@ -332,6 +343,32 @@ internal sealed partial class TransfersViewModel : ObservableObject, IAsyncDispo
|
||||
RemoteEntries.CollectionChanged += (_, _) => OnPropertyChanged(nameof(HasRemoteEntries));
|
||||
LocalEntries.CollectionChanged += (_, _) => OnPropertyChanged(nameof(HasLocalEntries));
|
||||
Transfers.CollectionChanged += (_, _) => OnPropertyChanged(nameof(HasTransfers));
|
||||
|
||||
// The fourth, and it follows a list this screen does not own: the buckets are refilled from the
|
||||
// vault on every synchronisation pass, so the invitation these flags decide between has to change
|
||||
// with them rather than at the moment somebody pressed something. That is the path that matters —
|
||||
// adding the first bucket happens on another screen, and this one has to notice when it comes back.
|
||||
Buckets.CollectionChanged += (_, _) => RaiseBucketState();
|
||||
}
|
||||
|
||||
/// <summary>Where a bucket is made, or null in a head with nowhere to send anybody.</summary>
|
||||
private readonly Action? addBucket;
|
||||
|
||||
/// <summary>Goes to the keychain with the bucket editor open.</summary>
|
||||
/// <remarks>
|
||||
/// The dead end this replaces was a real one: SELECT BUCKET opened a picker with nothing in it, and
|
||||
/// nothing anywhere on the screen said that a bucket is made on the keychain screen. Somebody who had
|
||||
/// come to S3 to add one had arrived at the place it is used and been shown no route to the place it is
|
||||
/// created.
|
||||
/// </remarks>
|
||||
[RelayCommand]
|
||||
private void AddBucket()
|
||||
{
|
||||
// Closed first, so returning here from the keychain does not find a picker still open over a list
|
||||
// that has since gained the bucket it was empty of.
|
||||
IsChoosingRemote = false;
|
||||
|
||||
addBucket?.Invoke();
|
||||
}
|
||||
|
||||
/// <summary>The hosts that can be connected to, which is the vault's list.</summary>
|
||||
@@ -352,6 +389,28 @@ internal sealed partial class TransfersViewModel : ObservableObject, IAsyncDispo
|
||||
[ObservableProperty]
|
||||
private ObjectStoreRowViewModel? selectedBucket;
|
||||
|
||||
/// <summary>
|
||||
/// Whether there is a bucket to open at all.
|
||||
/// </summary>
|
||||
/// <remarks>
|
||||
/// The question this screen used to answer by showing an empty combo box. A bucket is made on the
|
||||
/// keychain screen and nowhere else, and S3 is where somebody goes looking for it — so a picker with
|
||||
/// nothing in it and no sentence beside it was, from where the user was standing, an application with no
|
||||
/// way to add a bucket. See <see cref="AddBucket"/>.
|
||||
/// </remarks>
|
||||
internal bool HasBuckets => Buckets.Count > 0;
|
||||
|
||||
/// <summary>Whether this screen is on S3 with a bucket to offer.</summary>
|
||||
/// <remarks>
|
||||
/// The two flags are resolved here rather than combined in markup, because a binding cannot say "and" —
|
||||
/// and because the pair is one question with two answers, which is easier to keep straight in one place
|
||||
/// than in four <c>IsVisible</c> expressions that have to stay each other's opposites.
|
||||
/// </remarks>
|
||||
internal bool ShowsBucketChoice => ShowsBucketPicker && HasBuckets;
|
||||
|
||||
/// <summary>Whether this screen is on S3 with nothing to open yet.</summary>
|
||||
internal bool ShowsNoBuckets => ShowsBucketPicker && !HasBuckets;
|
||||
|
||||
/// <summary>
|
||||
/// Which sort of remote the right-hand pane is about to open.
|
||||
/// </summary>
|
||||
@@ -1641,16 +1700,30 @@ internal sealed partial class TransfersViewModel : ObservableObject, IAsyncDispo
|
||||
partial void OnRemoteChanged(RemoteKind value)
|
||||
{
|
||||
OnPropertyChanged(nameof(ShowsHostPicker));
|
||||
OnPropertyChanged(nameof(ShowsBucketPicker));
|
||||
OnPropertyChanged(nameof(ConnectLabel));
|
||||
OnPropertyChanged(nameof(SelectedHostAsksForAPassword));
|
||||
|
||||
RaiseBucketState();
|
||||
|
||||
// Arriving at the other destination shows its invitation rather than a picker somebody left open on
|
||||
// this one — and the picker it would have left open is the wrong one, since the two kinds have
|
||||
// different lists behind them.
|
||||
IsChoosingRemote = false;
|
||||
}
|
||||
|
||||
/// <summary>Raises the three flags that answer "is there a bucket to open".</summary>
|
||||
/// <remarks>
|
||||
/// Together, because they are one fact read three ways and a caller that raised two of them would leave
|
||||
/// an invitation and an empty state on screen at once.
|
||||
/// </remarks>
|
||||
private void RaiseBucketState()
|
||||
{
|
||||
OnPropertyChanged(nameof(ShowsBucketPicker));
|
||||
OnPropertyChanged(nameof(HasBuckets));
|
||||
OnPropertyChanged(nameof(ShowsBucketChoice));
|
||||
OnPropertyChanged(nameof(ShowsNoBuckets));
|
||||
}
|
||||
|
||||
partial void OnIsConnectedChanged(bool value)
|
||||
{
|
||||
OnPropertyChanged(nameof(CanDownload));
|
||||
|
||||
@@ -3845,7 +3845,7 @@ internal sealed partial class VaultViewModel(
|
||||
return;
|
||||
}
|
||||
|
||||
var report = await SyncOnceAsync(server.Sync, cancellationToken).ConfigureAwait(true);
|
||||
var report = await SyncOnceAsync(server, cancellationToken).ConfigureAwait(true);
|
||||
|
||||
// Null means a background pass held the gate. Saying so beats reporting a sync that this
|
||||
// press did not perform.
|
||||
@@ -3935,7 +3935,7 @@ internal sealed partial class VaultViewModel(
|
||||
return;
|
||||
}
|
||||
|
||||
var report = await SyncOnceAsync(server.Sync, cancellationToken).ConfigureAwait(true);
|
||||
var report = await SyncOnceAsync(server, cancellationToken).ConfigureAwait(true);
|
||||
|
||||
if (report is null)
|
||||
{
|
||||
@@ -3971,12 +3971,19 @@ internal sealed partial class VaultViewModel(
|
||||
}
|
||||
|
||||
/// <remarks>
|
||||
/// <para>
|
||||
/// The gate is shared with the manual command, so a press and a tick can never overlap. Taken with a
|
||||
/// zero timeout rather than awaited: a pass that arrives while another is running has nothing to add by
|
||||
/// waiting for it, and queueing them would turn a slow server into a backlog of identical work.
|
||||
/// </para>
|
||||
/// <para>
|
||||
/// Takes the whole server rather than its sync half, because the first thing a pass does is ask
|
||||
/// <em>which vaults there are</em> — see <see cref="AdmitNewVaultsAsync"/>. A pass that only synced the
|
||||
/// vaults it already knew could never discover one somebody had just shared.
|
||||
/// </para>
|
||||
/// </remarks>
|
||||
private async Task<IReadOnlyList<VaultSyncReport>?> SyncOnceAsync(
|
||||
ISyncApi api,
|
||||
IVaultServer server,
|
||||
CancellationToken cancellationToken)
|
||||
{
|
||||
if (!await syncGate.WaitAsync(0, cancellationToken).ConfigureAwait(true))
|
||||
@@ -3986,10 +3993,14 @@ internal sealed partial class VaultViewModel(
|
||||
|
||||
try
|
||||
{
|
||||
// Before the sync, so a vault admitted here is one of the vaults that pass then pulls. The
|
||||
// other order would show a newly shared vault as an empty one until the minute after.
|
||||
await AdmitNewVaultsAsync(server.Account, cancellationToken).ConfigureAwait(true);
|
||||
|
||||
// Every vault this session can read, not only the one new items are filed into. A team's
|
||||
// vault that never synced would show its hosts exactly once — at the unlock that first
|
||||
// pulled it — and then quietly stop, which reads as the feature not working.
|
||||
var report = await session.SyncAllAsync(api, cancellationToken).ConfigureAwait(true);
|
||||
var report = await session.SyncAllAsync(server.Sync, cancellationToken).ConfigureAwait(true);
|
||||
|
||||
// Not unconditionally false, which it was while a pass was one vault and a failure was an
|
||||
// exception. A failure is now a report — one unreachable team vault must not stop the others
|
||||
@@ -4012,6 +4023,53 @@ internal sealed partial class VaultViewModel(
|
||||
}
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Re-reads which vaults this account can reach, and opens any that have become readable.
|
||||
/// </summary>
|
||||
/// <remarks>
|
||||
/// <para>
|
||||
/// <b>This is the whole of how a shared vault arrives.</b> Sharing is two acts on two machines: the
|
||||
/// person sharing wraps the vault key to the recipient, and the recipient's own client has to notice.
|
||||
/// The recipient is handed nothing — there is no push channel — so without this the vault list stayed
|
||||
/// exactly as it was cached at sign-in, and a vault shared with somebody appeared on their machine only
|
||||
/// if they happened to sign in through the browser again. Everything else was already right, which is
|
||||
/// why it looked like sharing was broken rather than like a list that was never re-read.
|
||||
/// </para>
|
||||
/// <para>
|
||||
/// A failure is left to the caller, which treats it as the pass failing: the call is to the same server
|
||||
/// the sync is about to use, so a refresh that cannot answer is not a state in which the sync would
|
||||
/// have.
|
||||
/// </para>
|
||||
/// <para>
|
||||
/// The shell is told only when the set actually changed. It rebuilds the tab strip's vault menu from
|
||||
/// this list, and doing that on every quiet pass would rebuild a menu once a minute for nothing.
|
||||
/// </para>
|
||||
/// </remarks>
|
||||
private async Task AdmitNewVaultsAsync(IAccountApi api, CancellationToken cancellationToken)
|
||||
{
|
||||
var before = session.Vaults.Count;
|
||||
|
||||
var admitted = await session.RefreshVaultsAsync(api, cancellationToken).ConfigureAwait(true);
|
||||
|
||||
if (admitted == 0 && session.Vaults.Count == before)
|
||||
{
|
||||
return;
|
||||
}
|
||||
|
||||
VaultsChanged?.Invoke(this, EventArgs.Empty);
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Raised when a synchronisation pass found that the vaults this account can reach have changed.
|
||||
/// </summary>
|
||||
/// <remarks>
|
||||
/// An event rather than a callback because the listener is the shell and the shell owns this object,
|
||||
/// which is the same shape the connection events above use. What it is for is the tab strip's vault
|
||||
/// menu: it is built from the session's vault list, so a vault admitted mid-session would otherwise be
|
||||
/// on every screen and missing from the one control that can hide it.
|
||||
/// </remarks>
|
||||
internal event EventHandler? VaultsChanged;
|
||||
|
||||
/// <remarks>
|
||||
/// <c>ConfigureAwait(true)</c> throughout, and that is load-bearing rather than habit: the loop is
|
||||
/// started from the UI thread, so every continuation returns to it and the observable collections
|
||||
|
||||
@@ -233,16 +233,38 @@ internal sealed record VaultInvitationRowViewModel(TeamInvitationSummary Invitat
|
||||
/// than read from the selection at confirm time — otherwise selecting a different row between arming
|
||||
/// and confirming would apply the answer to something else.
|
||||
/// </remarks>
|
||||
/// <param name="Kind">Which operation the answer applies to.</param>
|
||||
/// <param name="TeamId">The membership list the action is aimed at.</param>
|
||||
/// <param name="MemberId">The member it is aimed at.</param>
|
||||
/// <param name="MemberId">The member it is aimed at, or empty where it is not aimed at one.</param>
|
||||
/// <param name="VaultId">The vault it is aimed at.</param>
|
||||
/// <param name="Question">What is being asked.</param>
|
||||
/// <param name="Consequence">What will actually happen, stated honestly.</param>
|
||||
internal sealed record VaultActionRequest(
|
||||
VaultActionKind Kind,
|
||||
Guid TeamId,
|
||||
Guid MemberId,
|
||||
Guid VaultId,
|
||||
string Question,
|
||||
string Consequence);
|
||||
|
||||
/// <summary>Which destructive operation a confirmation is standing in front of.</summary>
|
||||
/// <remarks>
|
||||
/// Carried on the request rather than inferred from which fields are set. There were two of these the
|
||||
/// moment deletion existed, and a confirm handler that guessed from a member id being empty would be one
|
||||
/// refactor away from carrying out the wrong one of the two.
|
||||
/// </remarks>
|
||||
internal enum VaultActionKind
|
||||
{
|
||||
/// <summary>Not a legal value.</summary>
|
||||
Unspecified = 0,
|
||||
|
||||
/// <summary>Hand the vault's membership list to somebody else.</summary>
|
||||
HandOver = 1,
|
||||
|
||||
/// <summary>Delete the vault.</summary>
|
||||
Delete = 2,
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// The vaults screen: which vaults there are, who is in each, and who holds a key to it.
|
||||
/// </summary>
|
||||
@@ -414,6 +436,16 @@ internal sealed partial class VaultsViewModel(
|
||||
/// <summary>Whether the selected vault is the personal one.</summary>
|
||||
internal bool SelectedIsPersonal => SelectedVault?.IsPersonal == true;
|
||||
|
||||
/// <summary>
|
||||
/// Whether the selected vault is one this account may delete.
|
||||
/// </summary>
|
||||
/// <remarks>
|
||||
/// Narrower than <see cref="CanAdministerSelected"/> by exactly the personal vault, which cannot be
|
||||
/// deleted by anybody: it is where everything filed nowhere else lives and nothing can make another.
|
||||
/// The server refuses one too, so a button offered here would be a button that leads to a refusal.
|
||||
/// </remarks>
|
||||
internal bool CanDeleteSelected => SelectedVault is { IsPersonal: false, CanAdminister: true };
|
||||
|
||||
/// <summary>Whether there is anything to show beside the vault list.</summary>
|
||||
internal bool HasSelection => SelectedVault is not null;
|
||||
|
||||
@@ -1230,13 +1262,70 @@ internal sealed partial class VaultsViewModel(
|
||||
}
|
||||
|
||||
PendingAction = new VaultActionRequest(
|
||||
VaultActionKind.HandOver,
|
||||
teamId,
|
||||
member.UserId,
|
||||
vault.VaultId,
|
||||
$"Hand '{vault.Name}' to {member.Name}?",
|
||||
"They become its owner and you become an admin. You will not be able to take it back "
|
||||
+ "yourself — only the new owner can hand it on. Your key to it is untouched.");
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Arms the deletion confirmation for the selected vault.
|
||||
/// </summary>
|
||||
/// <remarks>
|
||||
/// <para>
|
||||
/// The consequence is spelled out at length rather than summarised, and every sentence in it is one
|
||||
/// somebody could otherwise be surprised by afterwards. The last is the one this product must never
|
||||
/// leave implied: deleting a vault does not reach the machines it has already synced to. That is the
|
||||
/// same limit revocation has, for the same reason, and it is written down in ADR 0001.
|
||||
/// </para>
|
||||
/// <para>
|
||||
/// The personal vault is refused here as well as by the server. A button that reached a refusal would
|
||||
/// be teaching somebody to try things and read errors, and the reason is a fact this screen knows.
|
||||
/// </para>
|
||||
/// </remarks>
|
||||
[RelayCommand]
|
||||
private void DeleteVault()
|
||||
{
|
||||
if (SelectedVault is not { } vault)
|
||||
{
|
||||
return;
|
||||
}
|
||||
|
||||
if (vault.IsPersonal)
|
||||
{
|
||||
Status = "Your personal vault cannot be deleted. It is where everything filed nowhere else "
|
||||
+ "lives, and there is no way to make another.";
|
||||
return;
|
||||
}
|
||||
|
||||
if (vault.TeamId is not { } teamId)
|
||||
{
|
||||
return;
|
||||
}
|
||||
|
||||
var others = Members.Count(member => !member.IsSelf);
|
||||
|
||||
var shared = others > 0
|
||||
? string.Create(
|
||||
CultureInfo.CurrentCulture,
|
||||
$" {others} other member(s) lose it at the same moment, without being asked.")
|
||||
: string.Empty;
|
||||
|
||||
PendingAction = new VaultActionRequest(
|
||||
VaultActionKind.Delete,
|
||||
teamId,
|
||||
Guid.Empty,
|
||||
vault.VaultId,
|
||||
$"Delete '{vault.Name}'?",
|
||||
$"Everything in it goes: its hosts, keys, passwords, snippets and buckets stop being readable "
|
||||
+ $"by anybody, including you, and nothing here can undo it.{shared} What it cannot do is "
|
||||
+ "reach a machine that has already synced this vault — a copy pulled yesterday is still "
|
||||
+ "there. Rotate the credentials that mattered.");
|
||||
}
|
||||
|
||||
/// <summary>Cancels an armed action.</summary>
|
||||
[RelayCommand]
|
||||
private void CancelAction() => PendingAction = null;
|
||||
@@ -1258,22 +1347,71 @@ internal sealed partial class VaultsViewModel(
|
||||
|
||||
PendingAction = null;
|
||||
|
||||
await RunAsync(async () =>
|
||||
await RunAsync(() => request.Kind switch
|
||||
{
|
||||
await server.Teams
|
||||
.TransferTeamOwnershipAsync(
|
||||
request.TeamId,
|
||||
new TransferTeamOwnershipRequest(request.MemberId),
|
||||
cancellationToken)
|
||||
.ConfigureAwait(true);
|
||||
|
||||
await ReloadAsync(cancellationToken).ConfigureAwait(true);
|
||||
|
||||
Status = "Handed over. You are an admin of this vault now, and only its new owner can hand "
|
||||
+ "it on again.";
|
||||
VaultActionKind.Delete => DeleteAsync(server, request, cancellationToken),
|
||||
_ => HandOverAsync(server, request, cancellationToken),
|
||||
}).ConfigureAwait(true);
|
||||
}
|
||||
|
||||
private async Task HandOverAsync(
|
||||
IVaultServer server,
|
||||
VaultActionRequest request,
|
||||
CancellationToken cancellationToken)
|
||||
{
|
||||
await server.Teams
|
||||
.TransferTeamOwnershipAsync(
|
||||
request.TeamId,
|
||||
new TransferTeamOwnershipRequest(request.MemberId),
|
||||
cancellationToken)
|
||||
.ConfigureAwait(true);
|
||||
|
||||
await ReloadAsync(cancellationToken).ConfigureAwait(true);
|
||||
|
||||
Status = "Handed over. You are an admin of this vault now, and only its new owner can hand "
|
||||
+ "it on again.";
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Deletes the vault the confirmation was armed for.
|
||||
/// </summary>
|
||||
/// <remarks>
|
||||
/// <para>
|
||||
/// The name is read before the call, because afterwards there is no row to read it from and the
|
||||
/// sentence this ends with is about a vault that no longer exists.
|
||||
/// </para>
|
||||
/// <para>
|
||||
/// The rest of the shell is told, as a rename tells it: the tab strip's vault menu, the file-this-into
|
||||
/// picker and every host list are built from the session's vault list, and all of them are a vault out
|
||||
/// of date the moment one goes.
|
||||
/// </para>
|
||||
/// </remarks>
|
||||
private async Task DeleteAsync(
|
||||
IVaultServer server,
|
||||
VaultActionRequest request,
|
||||
CancellationToken cancellationToken)
|
||||
{
|
||||
if (session() is not { } open)
|
||||
{
|
||||
Status = "Unlock your keychain first: deleting a vault gives up this machine's key to it.";
|
||||
return;
|
||||
}
|
||||
|
||||
var name = Vaults.FirstOrDefault(row => row.VaultId == request.VaultId)?.Name ?? "That vault";
|
||||
|
||||
var deleted = await open
|
||||
.DeleteVaultAsync(server.Grants, request.VaultId, cancellationToken)
|
||||
.ConfigureAwait(true);
|
||||
|
||||
await ReloadAsync(cancellationToken).ConfigureAwait(true);
|
||||
await NotifyVaultsChangedAsync(cancellationToken).ConfigureAwait(true);
|
||||
|
||||
Status = deleted
|
||||
? $"Deleted '{name}'. Everybody's key to it is withdrawn. What anybody had already synced is "
|
||||
+ "still on their machine — rotate the credentials that mattered."
|
||||
: $"'{name}' was already gone. Somebody else deleted it, or your access to it ended.";
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Removes somebody, revoking their grants and rotating the vaults they could read.
|
||||
/// </summary>
|
||||
@@ -1629,6 +1767,7 @@ internal sealed partial class VaultsViewModel(
|
||||
OnPropertyChanged(nameof(OwnsSelected));
|
||||
OnPropertyChanged(nameof(SelectedIsShared));
|
||||
OnPropertyChanged(nameof(SelectedIsPersonal));
|
||||
OnPropertyChanged(nameof(CanDeleteSelected));
|
||||
OnPropertyChanged(nameof(HasInvitations));
|
||||
OnPropertyChanged(nameof(SharedMembershipWarning));
|
||||
OnPropertyChanged(nameof(HasSharedMembershipWarning));
|
||||
|
||||
Reference in New Issue
Block a user