diff --git a/docs/design-import-gaps.md b/docs/design-import-gaps.md index cf20d6c..01e420e 100644 --- a/docs/design-import-gaps.md +++ b/docs/design-import-gaps.md @@ -741,3 +741,27 @@ to a 34-pixel rail carrying the chevron that brings it back — a rail rather th that vanishes without trace is one people report as lost. The choice is written through to `ClientSettings.SessionSidebarOpen` rather than held for the session: it is a decision about how much of the window a terminal gets, and one that had to be made again on every launch would not really be on offer. + +## v5c-5 — one door to settings, not three + +**The user-chip popover keeps its Settings row and has lost Vaults and Preferences.** v5c gave it three, and +the table above records why: until that pass "Settings" and "Preferences" had been two doors onto the same +bare screen, so splitting them was a real fix, and Vaults arrived beside them when `VaultsScreen` became a +settings page too. + +Living with it made the shape of the mistake clear. All three opened the same full-window mode and differed +only in which of its seven pages they landed on — and `SettingsNav`, which lists every one of those pages +including Vaults and Preferences, is on screen the entire time you are in there. So two of the three rows +were deep links into a place the third one opens, saving one click and costing a menu that read as though it +offered three destinations. A menu at the foot of the rail is for getting into settings at all; which page +you want is a question that has a rail of its own once you are there. + +Nothing became unreachable: both pages are one click deeper, from the rail that was always going to be the +way to them. `NavRailTests` asserts the rows are gone from the markup rather than merely unwired, because a +row left behind with no handler is a menu entry that does nothing when pressed — which reads as a broken +application rather than a tidied menu. + +Logout stays, and still lands on a page rather than on General: its confirmation card is drawn inline on the +Account page and nowhere else, so arming it from anywhere else would be a card raised where nobody could see +it. The vault switches and **New vault** above the divider stay too — they are what the popover is for +besides settings, and neither is a page of the settings mode. diff --git a/docs/manual-checks.md b/docs/manual-checks.md index 836458f..8f10ba2 100644 --- a/docs/manual-checks.md +++ b/docs/manual-checks.md @@ -118,15 +118,17 @@ view models — this check is the version with a real connection on the end of i ### 1.8 Entering and leaving settings mode -From HOSTS, press the user chip at the foot of the nav rail and choose **Settings**. Then repeat from a -fresh open, choosing **Vaults**, and again choosing **Preferences**. +From HOSTS, press the user chip at the foot of the nav rail and choose **Settings** — which is the menu's +only way in now; the Vaults and Preferences rows beside it were folded back into it, because all three +opened this same mode and differed only in which page they landed on. -**Pass:** each of the three swaps the whole window's chrome — the titlebar becomes the 53px "Back to -application" bar, the ordinary nav rail is replaced by the 340px SettingsNav, and the status bar and the -update banner (if either was showing) are both gone. **Settings** lands on General; **Vaults** and -**Preferences** land on their own pages, each lit in SettingsNav's own list — General/Vaults/Account under -SETTINGS, Security/Preferences/Groups/Tags under CUSTOMIZE, Logout pinned below both. Click every one of the -seven rows in turn: each swaps the content column without leaving settings mode or touching the titlebar. +**Pass:** it swaps the whole window's chrome — the titlebar becomes the 53px "Back to application" bar, the +ordinary nav rail is replaced by the 340px SettingsNav, and the status bar and the update banner (if either +was showing) are both gone. It lands on **General**, with SettingsNav's own list beside it — +General/Vaults/Account under SETTINGS, Security/Preferences/Groups/Tags under CUSTOMIZE, Logout pinned below +both. Click every one of the seven rows in turn: each swaps the content column without leaving settings mode +or touching the titlebar, and Vaults and Preferences are among them — which is the whole reason the popover +no longer carries its own rows for those two. Now open a terminal, leave it showing, and open Settings from the user chip again. Press **Back to application** — or, without touching anything else, press Esc. @@ -134,7 +136,8 @@ application** — or, without touching anything else, press Esc. **Pass:** both return to exactly the screen that was showing before Settings was opened — the terminal, still running, rather than HOSTS or anywhere else. Switching between settings pages first (General → Vaults → Preferences) does not change what "back" goes back to; only the screen open the moment Settings was -**first** entered does. +**first** entered does. The other doors into this mode — the palette, and the Preferences page's own two +importer rows — behave the same way, so the popover having one row rather than three changes nothing here. **Failure means:** a return to HOSTS regardless of where Settings was opened from is `MainWindowViewModel.settingsReturnScreen` being recaptured on every `EnterSettings` call rather than only on diff --git a/src/DodoSSH.Client.App/Views/NavRail.axaml b/src/DodoSSH.Client.App/Views/NavRail.axaml index dc22863..aa64626 100644 --- a/src/DodoSSH.Client.App/Views/NavRail.axaml +++ b/src/DodoSSH.Client.App/Views/NavRail.axaml @@ -252,13 +252,23 @@ - - - - -