Compare commits

...
Author SHA1 Message Date
jaap-jan b20f7cae04 Let a host marked for the relay actually be reached through it
ci / build and test (pull_request) Successful in 6m27s
ci / desktop nightly (pull_request) Skipped
ci / android head (pull_request) Successful in 15m47s
ci / api image (pull_request) Failing after 28s
The relay checkbox said it was not wired up, and the plan said the server
half was built and shipped. It was not: there was ADR 0004, the contract
records, RelayOptions and a CHECK constraint, and RelayOptions said in its
own remarks that there was no endpoint and no dialler. So both halves are
built here, as step 3 of docs/reaching-a-host-you-cannot-dial.md.

Server, in Features/Relay:

- POST /api/v1/relay/tickets makes every decision: the host, Connect on
  its vault, the relay switched on, and the stored name resolved once and
  judged by RelayAddressPolicy. Loopback, link-local, 0.0.0.0/8,
  multicast and the metadata endpoints are refused with no configuration
  escape, with IPv4-mapped and NAT64 spellings unwrapped first; then the
  operator's denials, allow-list and private-network switch. What passes
  goes into a Data Protection ticket, and nothing resolves the name again.
  Every target refusal is the same 403, so the endpoint cannot be used to
  map the operator's DNS; the real reason is logged.
- GET /api/v1/relay/connect takes the ticket as a second subprotocol,
  checks its expiry against TimeProvider and spends it with a unique
  insert into relay_ticket_use before accepting the upgrade. After the
  upgrade a refusal is a close code: 4502 for a host the server could not
  reach, 4429 for a limit, 4408 idle, 4409 lifetime, 1001 after a drain.
- relay_session is the audit row, written from short-lived scopes.

Client:

- RelayBridge is a loopback SOCKS5 listener that accepts once and pipes
  to the relay socket. It rides on the new SshLoopbackProxy.Lifetime, so
  the connection disposes it on every way a session ends and a failed
  connect disposes it before throwing.
- ServerRelay, exposed as IVaultServer.Relay from /api/v1/meta, asks for
  the ticket, opens the socket, starts the bridge and turns every refusal
  into a sentence.
- VaultViewModel and TransfersViewModel reach a relayed host through it,
  never fall back to dialling it directly, and replace SSH.NET's transport
  error with the relay's own reason when it gave one.

Neither side ever cancels a WebSocket operation. Cancelling one aborts
the socket, and an aborted socket sends no close frame, which is the only
way the client learns the server could not reach the host.
AnIdleSession_IsClosedWithTheIdleCode asserts that the code arrives.

Three departures from ADR 0004, recorded in it: awaited copy loops rather
than Pipelines (same backpressure, two 32 KiB buffers), no ?ticket=
fallback, and no device id in the ticket.

Tests: API 245, shell 582 (5 skipped), layout 170, SSH 110 including a
real login through the bridge, API client 30, contracts 25. Not run: the
Android build (its change is copy only) and the Alpine layout oracle.
2026-09-28 14:37:20 +02:00
jaap-jan 54bc142dce Merge pull request 'Stop an attach's own replay landing in the middle of a test's frames' (#18) from claude/fix-failed-test-3e1719 into main
ci / build and test (push) Successful in 3m23s
ci / android head (push) Successful in 3m48s
ci / api image (push) Failing after 15s
ci / desktop nightly (push) Successful in 1m29s
Reviewed-on: #18
2026-09-15 12:46:46 +00:00
jaap-jan 8e61fc72b4 Stop an attach's own replay landing in the middle of a test's frames
ci / build and test (pull_request) Successful in 7m43s
ci / desktop nightly (pull_request) Skipped
ci / api image (pull_request) Failing after 11s
ci / android head (pull_request) Successful in 8m7s
TheClipboard_ReachesThePaneThatAskedForIt failed in CI on an opcode of 2
where it wanted 8: a second SessionOpened frame where the clipboard's
should have been. Only one thing sends a session a second SessionOpened,
and that is ReplayAfterAttachAsync, the replay a reattaching page gets.

It arrives there because the replay is fired and forgotten from the
socket-accept thread immediately after the attach is signalled, and the
test helper returned on that signal. Deschedule the accept thread for a
timeslice between the two -- which a loaded CI box does -- and the test
opens its session first, so the replay finds that session live and sends
it a replay-flagged SessionOpened after its real one.

Nothing is wrong with the workspace. The page treats a replay onto a pane
it still has as idempotent, and ReplayAfterAttachAsync's own remarks
already say racing a fresh page's first frames is harmless. What was
wrong is a helper that waited for the attach and then let its callers
count frames as though the attach were finished, so ConnectRendererAsync
now waits for RendererReattached as well -- raised as the last thing the
replay does. The remark there argued a replay could not be sent early; it
missed that it can be sent late, and now says so.

The same late replay could reset the credit window out from under
ANewRenderer_ReplaysTheLiveSessionAndResetsItsCredits, which shares the
helper, so that latent flake goes with it.

Verified by delaying the replay's snapshot by a millisecond: the old test
fails under that, and the fixed class passes it eight runs running.
2026-09-15 14:29:08 +02:00
jaap-jan 8a4058ce3a Merge pull request 'Stop a reconnect dialling a different machine of the same name' (#17) from claude/reconnect-wrong-server-9cccfb into main
ci / desktop nightly (push) Skipped
ci / api image (push) Skipped
ci / android head (push) Successful in 3m24s
ci / build and test (push) Failing after 2m20s
Reviewed-on: #17
2026-09-14 11:31:04 +00:00
jaap-jan 2d95366552 Stop a reconnect dialling a different machine of the same name
ci / build and test (pull_request) Successful in 3m31s
ci / desktop nightly (pull_request) Skipped
ci / android head (pull_request) Successful in 7m42s
ci / api image (pull_request) Failing after 13s
A tab remembered what its host was called and nothing else, and the reconnect
under a stopped tab looked the host up by that name: HostFor took the first row
in the keychain whose label matched. Nothing in this application stops two hosts
being called the same thing — a team's vault beside a personal one makes it
ordinary, and "prod-db" is what the database server gets called in both — so the
button dialled whichever namesake sat earliest in the list. A dropped session on
one machine came back as a live shell on another, with the tab, the address and
the status bar all still naming the first. There was nothing on screen to read
the substitution off.

The name match was not an oversight; it was an argument, written into the remark
on HostFor and repeated on RefreshConnectedHosts: a tab outlives the vault that
opened it, so it "cannot hold an entity id that would still mean anything after a
lock". That is not so. EntityId is the item's own sync identity rather than a
reference to a row object, so a vault that is locked and opened again rebuilds
every row around the same ids. The one handle that was rejected as too fragile to
survive a lock is the handle that survives it.

So the id now travels with the connection. ConnectionAttemptEventArgs and
TerminalSessionEventArgs carry it, taken from ConnectionTarget.HostId, which the
connect path has had all along for the log; TerminalTabViewModel keeps it; and
HostFor matches on it. A host renamed since the tab opened is found too, which a
name match by definition cannot. Null is not missing data — it is the whole of
what makes a typed-in address different, and it is why such a tab is refused a
reconnect rather than offered one that would dial a stranger sharing its name.

Three other lookups had grown their own copy of the same match and so had the
same fault, where it is read rather than dialled: the green connected dot, which
lit on every machine answering to the name and claimed a shell on hosts nobody
had connected to; the pinned paths QUICK ACCESS offers, which come from whichever
row that same match found; and the sidebar's "Pin folder" and the SFTP tab row,
which would have edited and browsed the wrong host. All four now go through
HostFor, so "which machine is this tab" has one answer.

Both new tests assert on the address actually dialled rather than on anything the
tab says about itself. The two rows agree on every string a tab carries, which is
exactly why this went unnoticed: a test written against the label would have
passed on the day the wrong machine was being opened.
2026-09-14 10:18:58 +02:00
jaap-jan 9ead42171c Stop a flooding remote growing the process, and let an ended session go
ci / build and test (push) Successful in 3m12s
ci / desktop nightly (push) Successful in 1m16s
ci / api image (push) Successful in 45s
ci / android head (push) Successful in 7m11s
The terminal's memory was bounded by an argument that is not true of the SSH
library underneath it, and the whole of CreditWindow's remark was that argument:
the pump stops reading when the renderer falls behind, SSH's own receive window
closes, the remote sshd blocks on write, and the backpressure reaches the process
producing the output. The middle step does not happen. Renci.SshNet's
Channels.Channel.OnData calls its window adjustment before it raises DataReceived
and re-opens the channel window as soon as it drops below one packet, and
ShellStream's own handler copies the bytes into a System.Net.ArrayBuffer without
blocking and without a ceiling — a buffer that doubles on demand and is not given
back until the stream is disposed. So a reader that stopped reading slowed the
remote down by nothing at all. It only chose whose buffer the flood landed in,
and it chose the one nothing bounds.

Measured against the container this repository already runs sshd in: a reader
that reads nothing while `yes` runs leaves ShellStream holding 8.9 MB after one
second, 26.8 MB after three and 44.3 MB after five, its capacity stepping 16 → 32
→ 64 MB. That is the report of "a massive memory leak on Windows"; it is not a
Windows fault, it is simply where long sessions with heavy output live.

The fix is to read continuously, which is what keeps SSH.NET's buffer empty, and
to put the bound where it can actually be enforced. OutputBacklog is that bound:
a byte-capped queue of unsent output, 4 MiB by default, which drops its oldest
bytes when full and counts what it discarded. Oldest rather than newest, because
the tail of a flood is the prompt somebody is waiting for.

The two bounds are now separate and each is enforced where it means something.
The backlog bounds what is waiting to be sent. The credit window goes on bounding
what has been sent and not yet drawn — the queue inside the WebView that nothing
on this side can measure — and is reserved against in the flush loop rather than
the read loop. Reading is part of neither, because reading was never what the
remote was waiting on.

Dropping is announced rather than silent. A terminal quietly showing a different
transcript from the one the remote sent is worse than one that says it could not
keep up, because the second can be believed. The line goes out under its own
opcode, TerminalServerOpcode.OutputDropped, rather than spliced into the output
stream: what this application says about the transcript is not part of the
transcript, and keeping them apart is also what makes the arithmetic hold — every
byte read is either in an Output payload or counted in BytesDropped. It opens
with an SGR reset, because the cut lands at an arbitrary offset and whatever
escape sequence the remote was in the middle of has been left half-said.

Frames are now capped at 64 KiB and taken straight into the frame buffer. The cap
is the large-object-heap threshold rather than a guess — a quarter-megabyte array
allocated sixty times a second is collected only by a generation 2 pass — and the
direct take removes an allocation and a copy of every byte the terminal shows.

The second half is the one that made the first half's cost persist. Nothing gave
a session back when the remote hung up: TerminalWorkspace kept the entry, and
with it an undisposed ISshConnection — an authenticated socket, its cipher state,
and a keep-alive putting a packet on the wire every thirty seconds — plus the
pump and SSH.NET's read buffer at whatever size the session's busiest moment had
grown it to, for as long as the tab stayed open. A tab somebody typed `exit` into
an hour ago was indistinguishable from a live one in everything except what it
drew. ReleaseAsync disposes both, from AnnounceEndedAsync and after the
announcement: the tab is told first, because tearing down an SSH connection in
front of that would be latency on the one thing the user is watching for. The
dictionary entry stays, because LiveSessionCount, IsSessionLive and the tab's own
ENDED and RECONNECT all read it. SendInputAsync therefore asks about liveness
rather than presence, since the shell channel is gone the moment the remote is.

Two faults introduced on the way here and fixed, both worth naming because
neither would have been visible from the outside:

The read loop left through a condition on its cancellation token, and RunAsync
reads a read loop that returns as the remote having closed the channel. A tab the
user closed would have reported itself as a shell that exited on its own. It
throws instead.

With the reader finished and a renderer that had stopped acknowledging, the flush
loop span: output to send, no credit to send it with, and a wait for more output
that returned at once because there was some. RunAsync never completed, so the tab
was never told and the connection was never released — a session invisible and
permanent. The loop now leaves for the drain as soon as the backlog is complete,
and RunAsync resets the credit window alongside completing it so a flusher already
parked on an acknowledgement that will never come is released.

Four tests asserted the old contract and now assert its reverse, which is the
point rather than a relaxation — WhenCreditRunsOut_ThePumpStopsReading is now
WhenCreditRunsOut_ThePumpKeepsReadingAndTheBacklogHoldsTheLine, and has to prove
both halves at once. The throughput harness gained a counting transport, because
a consumer that copies every frame into a 32 MB list was the slowest thing in the
pipeline and a harness whose consumer cannot keep up measures itself. The fake
shell gained a pace, so "a renderer that keeps up loses nothing" can be asked of a
producer a network could actually deliver rather than of one running at memory
bandwidth.

The test that would have caught this in the first place is
ARunawayRemote_KeepsBeingReadAndStaysInsideTheBacklog, and it needs the real
SSH.NET and the real sshd to say anything: a fake shell hands over bytes when it
is asked, and a real channel hands them over when they arrive. Under the old code
its BytesRead would have stopped at exactly WindowBytes.

121 terminal tests pass over three consecutive runs with no flakes, 105 against
the container, and the app, session, layout and remaining suites are unchanged and
green. Manual checks 1.10a and 1.10b cover the two symptoms a person can see: a
working set that plateaus under `yes`, and a connection that goes when the shell
does rather than when the tab does.
2026-09-04 17:16:23 +02:00
laurensandClaude Opus 5 597e5ae016 Take the release credentials off the command line, where anyone could read them
ci / build and test (push) Successful in 3m17s
ci / desktop nightly (push) Successful in 1m19s
ci / android head (push) Successful in 3m45s
ci / api image (push) Successful in 24s
Three scripts prompted for a secret with Read-Host -AsSecureString or read -s,
said in a comment that it therefore never lands in shell history, and then wrote
it straight into the arguments of the next process. The comment was true and was
answering the wrong question. A command line is not private: on Windows one call
to Get-CimInstance Win32_Process hands every argument of every process running as
this user to anything that asks, /proc/<pid>/cmdline is world-readable on Linux,
and process-creation auditing and EDR agents keep their own copy either way. The
values were the Android release signing key's passwords and the forge token —
between them the whole capability to ship an update that every installed copy
will fetch and run, which ADR 0011 rule 1 and ADR 0013 go to some length to keep
off a runner and which was then left in a process listing on a desk.

Both replacements are documented features of the tools rather than tricks.

The Android passwords use .NET for Android's env: prefix, which puts the name of
a variable on the command line and lets MSBuild read the value out of the
environment itself. Set immediately before the build and cleared in a finally, so
a failed signing does not leave them in the shell for whatever runs next, and
-nodeReuse:false so no persistent MSBuild worker outlives the call still holding
the inherited copy in its own environment.

That prefix is unsupported when AndroidPackageFormat is aab, and the failure is
silent — the package would be signed with the literal string
"env:DODOSSH_ANDROID_STOREPASS" as its password. So the format is read back and
the build stops if it is ever changed, in the same shape as the versionCode guard
a few lines above: a wrong release refused here rather than discovered later on
somebody's phone.

vpk documents VPK_TOKEN as --token's environment fallback, so the flag is simply
gone from both desktop scripts and the token never becomes an argument at all.
Unset afterwards on the failure path too, which on macOS needs the exit status
captured rather than a bare || stop_with.

release-macos.sh had the same fault and was missed when the other two were first
reported. Its Apple credentials were already right — a notarytool keychain profile
rather than --password — and only the forge token was exposed.

What this does not claim: an environment block is readable by a process holding
rights over this one, the same as its memory is. The comments say so rather than
implying the values are now safe. What is bought is real and narrower — off the
command line, out of every process listing, out of the audit trail, and out of any
log that echoes the invocation.

Both PowerShell files parse, all three shell scripts pass bash -n, the
AndroidPackageFormat probe evaluates and answers empty so the guard passes, and
dotnet build accepts -nodeReuse:false. The signing itself is not exercised here:
it needs the release keystore, which by design is not on this machine.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-09-01 14:31:02 +02:00
laurensandClaude Opus 5 483ae1fed9 Stop three notes in this repository claiming things that are not so
ci / build and test (push) Successful in 3m3s
ci / android head (push) Successful in 4m2s
ci / desktop nightly (push) Successful in 1m30s
ci / api image (push) Successful in 43s
A scan of the working tree and all 335 commits for anything that should not be
public found no leaked secret. What it did find was three places where a reader
is told something the repository does not back up, and in a public repository a
confident wrong note is worse than silence: nobody goes and checks a sentence
that sounds settled.

The ignore list stopped at *.pfx, *.p12 and *.snk, so a keystore was not covered
at all. The one that matters is the release keystore ADR 0011 rule 1 keeps off
runners — drop it in the tree while cutting a release and nothing would have said
a word. *.keystore and *.jks now, with build/nightly.keystore negated: an ignore
rule cannot untrack a tracked file, so the negation changes no behaviour and is
there so the next reader does not take the committed one for an accident. ADR
0014 is cited beside it, because "a signing key is committed here on purpose" is
a claim that needs its argument within reach.

Also gone from that list: a negation for deploy/.env.example, which has never
existed in any commit.

RelayOptions.AllowPrivateNetworks said loopback, link-local and cloud metadata
ranges "are denied unconditionally and are not configurable" — present tense, in
the voice of a control that exists. Nothing reads the setting. There is no relay
endpoint and no dialler; the relay is ADR 0004 and a contract type. So the
sentence most likely to be read by somebody auditing this repository's SSRF
posture was describing code nobody has written. It now says that outright, and
hands the obligation to whoever builds the dialler with ADR 0004 §3 named in
full, including the IPv4-mapped IPv6 re-check, which is the clause a fresh
implementation is likeliest to miss. The flag governs RFC1918 and never that
list, which was the other half the old wording ran together.

docker-compose.dev.yml pointed at deploy/docker-compose.yml as "the production
stack". That file has never existed here either. Says what does ship — the image
the CI image job builds and pushes — and puts a compose file to run it where it
belongs, in M4's self-hosting guide.

Comments and an ignore list only; no behaviour moves. The API builds clean, and
the two tests that mention the dev compose file read its Postgres version, which
is untouched.

Left alone deliberately: release-android.ps1 and release-windows.ps1 pass the
keystore password and the forge token as arguments to a child process, where
another process on the machine can read them off the command line. That is a real
if small hole and a code change rather than a comment — the vpk half needs
somebody to find out whether it takes the token from the environment first.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-08-31 16:35:14 +02:00
laurensandClaude Opus 5 7ee2aacdc9 Put check 1.12 back in step with the splash it describes
ci / build and test (push) Successful in 2m57s
ci / android head (push) Successful in 3m38s
ci / api image (push) Successful in 22s
ci / desktop nightly (push) Successful in 1m9s
The progress bar went in "Take the frozen bar off the splash, and leave the line
that is true" and the manual check still told a person to watch it move, and then
to watch it stop. A check that names something not on the screen is worse than no
check: whoever runs it has to decide whether they are looking at a regression or
at a stale document, and the honest answer is not available from the page.

Says what the failure state looks like now — the line changes and nothing else on
the card is there to contradict it — and records where the bar went, so the next
reader is not left wondering whether it was lost by accident.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-08-26 17:26:52 +02:00
laurensandClaude Opus 5 dec2cf164a Let the connecting card's host name and address be taken away
The card that fills the terminal's rectangle while a connection is being made
prints two lines saying which machine and at what address, and both were
TextBlocks — which in Avalonia is a drawing of a string rather than a string.

It is the one place the shell says what it is dialling *before* anything has
answered, and on a refusal it is the only copy of that on screen: there is no
prompt yet and there may never be one. That is exactly when the value is wanted
somewhere else — in a ticket, in a message to whoever owns the host, in the ssh
command being written in the window beside this one — and retyping it off the
screen is how a digit goes missing from an address that is mostly digits.

SelectableTextBlock, the same change the session column's own address got in
"Let the session address be selected, and copied whole" and for the same reason.
Nothing else about either line moves: same font, size, weight, colour, trimming
and centring. The refusal underneath them was already selectable, which made the
pair above it the odd ones out.

Both lines rather than only the name. They are two lines of one identifier, and a
pair where the first can be taken and the second cannot is a worse answer than
either.

Tooltips are new, and they are what makes the trimming safe rather than a trap.
A drag reaches only the glyphs that were drawn, so a name or an address wearing
an ellipsis has to be taken with select-all — which takes the whole value,
because the ellipsis is a drawing and not a shorter string. The hover says what
the whole value is, so nobody copies half of one without having been told there
is a half. Same argument, same shape, as the sidebar's.

The test asserts that half rather than the easy one, on values long enough to be
trimmed inside the card's 460 pixels; values that fit would pass whether the
trimming were render-only or not. Confirmed it bites by putting the two
TextBlocks back and watching it fail.

The phone draws the same two lines in the same state — TerminalScreen.axaml's
IsConnectingShowing block — and is deliberately left alone. Its captions are
styled by TextBlock.title and TextBlock.detail selectors in Phone.axaml, so the
same substitution there silently drops the styling until those rules gain
SelectableTextBlock siblings, which is a theme change rather than this one. Worth
doing; not worth smuggling in here.

Also: WindowDecorations on the splash instead of SystemDecorations, which
Avalonia 12 has deprecated in favour of it. That warning was mine, added two
commits ago; the main window's own is older and is not this change's to move.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-08-26 17:25:43 +02:00
73 changed files with 8063 additions and 303 deletions

No files matched your search

+8 -1
View File
@@ -87,9 +87,16 @@ Releases/
*.pfx *.pfx
*.p12 *.p12
*.snk *.snk
# Signing keystores, with one exception that is tracked deliberately. build/nightly.keystore is
# committed in the open on purpose — see ADR 0014 for why a key everybody holds is what makes the
# nightly channel safe to run in CI — and a file already tracked is unaffected by an ignore rule
# anyway. The negation is here so that reading this list does not suggest the tracked one is an
# oversight. The *release* keystore is a real secret under ADR 0011 rule 1 and must never land here.
*.keystore
*.jks
!build/nightly.keystore
appsettings.Local.json appsettings.Local.json
appsettings.*.Local.json appsettings.*.Local.json
.env .env
.env.* .env.*
!deploy/.env.example
secrets/ secrets/
+7
View File
@@ -873,6 +873,13 @@ keychain plus a terminal — and the spike that gates all of it.
[Moving files](#moving-files) for the two things about it worth knowing before you use it, both of which [Moving files](#moving-files) for the two things about it worth knowing before you use it, both of which
are consequences rather than choices. are consequences rather than choices.
*Relay done:* a host with "Connect through the server relay" ticked is reached through the deployment,
for a machine this one cannot dial. The server issues a single-use, thirty-second ticket for that host
alone, resolves its address and checks it against a deny list with no configuration escape — loopback,
link-local, metadata endpoints — and then pipes raw TCP; the SSH session still ends on your machine, so
the relay sees ciphertext. It is off by default (`Relay:Enabled`), and it only helps when the server can
reach what you cannot. See [ADR 0004](docs/adr/0004-relay-authorization.md).
*Organising done:* hosts can be filed into groups, and commands can be saved as snippets. Both are ordinary *Organising done:* hosts can be filed into groups, and commands can be saved as snippets. Both are ordinary
synced items — encrypted, merged and pushed like every other — and both are invisible until used: a synced items — encrypted, merged and pushed like every other — and both are invisible until used: a
keychain with no groups draws the flat host list it always did. Two things about them are deliberate. keychain with no groups draws the flat host list it always did. Two things about them are deliberate.
+6 -1
View File
@@ -1,7 +1,12 @@
# Development dependencies only: PostgreSQL and Keycloak. # Development dependencies only: PostgreSQL and Keycloak.
# #
# The API itself runs from the IDE or `dotnet run`, so the inner loop stays fast while the # The API itself runs from the IDE or `dotnet run`, so the inner loop stays fast while the
# schema is still churning. The production stack is deploy/docker-compose.yml. # schema is still churning.
#
# There is no production compose file in this repository. This one said there was, naming a
# deploy/docker-compose.yml that has never existed in any commit. What ships instead is the
# container image the CI image job builds and pushes; a compose file to run it belongs to the
# self-hosting guide in M4, and until that exists the honest thing to say is that it does not.
# #
# docker compose -f deploy/docker-compose.dev.yml up -d # docker compose -f deploy/docker-compose.dev.yml up -d
# dotnet run --project src/DodoSSH.Api # dotnet run --project src/DodoSSH.Api
+19
View File
@@ -99,3 +99,22 @@ real ones.
- **Client-supplied target address.** One line of convenience, and the relay becomes an open - **Client-supplied target address.** One line of convenience, and the relay becomes an open
proxy into the operator's network. proxy into the operator's network.
- **Allow-listing by hostname.** Defeated by DNS rebinding. - **Allow-listing by hostname.** Defeated by DNS rebinding.
## Implementation notes
Built in `DodoSSH.Api/Features/Relay` and, on the client, `RelayBridge` and `ServerRelay`; see
`docs/reaching-a-host-you-cannot-dial.md`, "What step 3 built". Three places differ from the text above:
- **Backpressure is an awaited copy loop, not `System.IO.Pipelines`.** Each direction reads one buffer and
writes it before reading again. The property is the same — a slow peer stops the read, and TCP throttles
the origin — and the bound is tighter: two 32 KiB buffers per session.
- **There is no `?ticket=` fallback.** Both clients can set a subprotocol, and the fallback's cost — a bearer
credential in the URL — was the reason it needed scrubbing at all. It can be added if a constrained
client ever needs it; the scrubbing requirement stands.
- **The ticket carries no device id.** The server does not see a device on an ordinary request, so there was
nothing to put there. `PortForwardId` on the request is refused: a forward's port is ciphertext, and
honouring one would mean taking the port from the client.
The loopback bridge serves the relay only. SSH.NET's `ForwardedPortDynamic` already is the jump-host path's
listener, so "one mechanism, two features" is true one level down: both features reach their target through
a loopback SOCKS5 proxy named on the connection request.
+1 -1
View File
@@ -254,7 +254,7 @@ the chrome, hosts and terminals, file transfer, the vault, teams, and preference
> | v5 element | What ships instead | > | v5 element | What ships instead |
> | --- | --- | > | --- | --- |
> | The status dot's third, amber state | ◆ **Still two states, on the same reasoning v3 and v4 both gave and v5 was asked to reconsider.** Green means a terminal is open on that host, grey means one is not; nothing here pings a machine, so the amber "reachable but not connected" state has no fact behind it to draw. | > | The status dot's third, amber state | ◆ **Still two states, on the same reasoning v3 and v4 both gave and v5 was asked to reconsider.** Green means a terminal is open on that host, grey means one is not; nothing here pings a machine, so the amber "reachable but not connected" state has no fact behind it to draw. |
> | The relay checkbox's mock copy | The pre-existing sentence, unchanged, "(not wired up yet)" included — restyled into the mock's own nested-card shape (radius 12, a title beside the box rather than under it) but not reworded. The mock's own copy implies a relay this client can dial; it cannot, for the reason `HostDrawer.axaml`'s own remarks give. | > | The relay checkbox's mock copy | Restyled into the mock's own nested-card shape (radius 12, a title beside the box rather than under it). The "(not wired up yet)" it carried while this client could not dial the relay came out when it could; the sentence under it now says what ticking it does — the server dials the host, so the server has to be able to reach it, and the address is stored in plain text. |
> | The host card as a link straight to a terminal | Click still selects, double-click still connects, and the pencil still opens the pane — the mock's card-as-link is not adopted, because multi-select (Ctrl, Shift, the marquee band) depends on a plain click meaning "choose this one" rather than "go". | > | The host card as a link straight to a terminal | Click still selects, double-click still connects, and the pencil still opens the pane — the mock's card-as-link is not adopted, because multi-select (Ctrl, Shift, the marquee band) depends on a plain click meaning "choose this one" rather than "go". |
> | Quick connect's SSH/SFTP kind column | The auth word — credential, key, or password — see above. | > | Quick connect's SSH/SFTP kind column | The auth word — credential, key, or password — see above. |
> | A collapsed section staying collapsed after a restart | In memory only, for the running session. `settings.json` holds two scalars by decision — the terminal's text size and whether this machine checks for updates on its own — and collapse state is not judged worth a third. | > | A collapsed section staying collapsed after a restart | In memory only, for the running session. `settings.json` holds two scalars by decision — the terminal's text size and whether this machine checks for updates on its own — and collapse state is not judged worth a third. |
+46 -4
View File
@@ -202,6 +202,44 @@ That is what the "is this still the page's socket" guard in `connect()` exists t
input while the banner is *clear* is neither: the socket is open and dead, which nothing on this page can input while the banner is *clear* is neither: the socket is open and dead, which nothing on this page can
currently see — see the note at the end of 11.12a. currently see — see the note at the end of 11.12a.
### 1.10a A remote that floods the terminal does not grow the process · **watch Task Manager**
Open a shell and run `yes dodossh`. Leave it running for a full minute with the tab in front of you, then
switch to another screen and leave it another minute, then come back. Watch the application's memory in
Task Manager (Details tab, *Memory (active private working set)*) the whole time.
**Pass:** memory settles at a plateau and stays there — the number moves as the GC breathes, but there is no
staircase. Ctrl+C, and the prompt comes back straight away. Somewhere in the scrollback there may be a dim
grey line reading `── N MB of output was dropped; the terminal could not keep up ──`; that line is a pass,
not a failure. It is this client saying it discarded output it could not draw, which is what keeps the
plateau flat, and the number after it tells you how far behind the display got.
**Failure means:** a working set that climbs steadily for the whole minute and does not come back down after
Ctrl+C is the defect this check exists for, and it will not be in this repository's own buffers — it is
SSH.NET's. `ShellStream` copies everything the channel delivers into a buffer that doubles and is never
given back, and the channel keeps delivering because `Channel.OnData` re-opens the SSH receive window as
bytes *arrive* rather than as they are consumed. Measured against the container in
`DodoSSH.Client.Ssh.Tests`, a reader that stops entirely leaves that buffer holding 44 MB after five
seconds. The only thing that keeps it empty is `TerminalSessionPump` reading continuously and bounding what
it holds in `OutputBacklog` instead — so a staircase here means something has put a wait back into that read
loop. `ARunawayRemote_KeepsBeingReadAndStaysInsideTheBacklog` is the test that fails first.
### 1.10b A tab whose shell exited stops costing anything · **needs a debugger or `netstat`**
Open a shell, type `exit`, and **leave the tab open**. Note the host and port. Then, from a terminal outside
the application, run `netstat -ano | findstr <port>` and look for the connection to that host.
**Pass:** the connection is gone within a second or two of the shell exiting, even though the tab is still on
screen showing the session ended and still offering RECONNECT. Clicking that reconnect still works, and
closing the tab afterwards still works.
**Failure means:** a connection that is still ESTABLISHED for as long as the tab is open is the session
holding an authenticated socket it has no further use for — with a keep-alive putting a packet on the wire
every thirty seconds and SSH.NET's read buffer still at whatever size the session's busiest moment grew it
to. It used to do exactly that, until whichever tab it was got closed. `TerminalWorkspace.ReleaseAsync` is
what gives it back now, and `ASessionWhoseRemoteHasExited_GivesBackItsConnectionWithoutWaitingForTheTab` is
the test that says so.
### 1.11 The right button copies and pastes, and never opens a menu ### 1.11 The right button copies and pastes, and never opens a menu
Open a shell and run something that prints a few lines — `ls -la /etc`. Drag a selection across part of the Open a shell and run something that prints a few lines — `ls -la /etc`. Drag a selection across part of the
@@ -256,8 +294,8 @@ registered in the capture phase, that no native menu is drawn once it is prevent
Close DodoSSH and start it again. Watch the first second. Close DodoSSH and start it again. Watch the first second.
**Pass:** a small panel — about 420 pixels wide, no titlebar — appears saying **DodoSSH** and *Starting…* **Pass:** a small panel — about 420 pixels wide, no titlebar — appears saying **DodoSSH** and *Starting…*,
with a bar moving under it, and is then replaced by the main window. Measured on a debug build against a cold and is then replaced by the main window. Measured on a debug build against a cold
profile: the panel at 668 ms, the window at 3.1 s. A release install is quicker and the shape is the same. profile: the panel at 668 ms, the window at 3.1 s. A release install is quicker and the shape is the same.
What must never come back is the old behaviour, which was nothing at all on screen for the whole of it. What must never come back is the old behaviour, which was nothing at all on screen for the whole of it.
@@ -270,8 +308,12 @@ over whatever you gave up and went back to.
*directory* where `cache.db` should be — `%LOCALAPPDATA%\DodoSSH.Nightly\cache.db` for the nightly — and *directory* where `cache.db` should be — `%LOCALAPPDATA%\DodoSSH.Nightly\cache.db` for the nightly — and
start the application. start the application.
**Pass:** the panel stays, the bar stops moving, and it reads *DodoSSH could not start:* followed by the **Pass:** the panel stays and the line becomes *DodoSSH could not start:* followed by the reason and
reason and *Press Escape to close.* Escape closes it. Remove the directory afterwards. *Press Escape to close.* Escape closes it. Remove the directory afterwards.
There is deliberately nothing else on the card to contradict that line — the progress bar this check used to
describe was taken off in "Take the frozen bar off the splash, and leave the line that is true", because an
indeterminate bar over a composition that had stopped was the one thing a splash must never do.
**Failure means:** a panel left saying *Starting…* is the main window having failed to show with nothing **Failure means:** a panel left saying *Starting…* is the main window having failed to show with nothing
catching it, which is the one outcome worse than the crash it replaced — `DodoSshApp.ComposeBehind` exists to catching it, which is the one outcome worse than the crash it replaced — `DodoSshApp.ComposeBehind` exists to
+71 -10
View File
@@ -1,26 +1,30 @@
# Reaching a host you cannot dial # Reaching a host you cannot dial
Some machines do not answer from where the user is sitting. This product has **two** answers to that, and Some machines do not answer from where the user is sitting. This product has **two** answers to that, and
neither of them works. one of them works.
- The **relay** pipes raw TCP through the deployment. The server half is built and shipped; the client - The **relay** pipes raw TCP through the deployment. Both halves are built: the server issues a ticket and
half does not exist, and both heads offer a checkbox that promises it. pipes a WebSocket to the host, and the client reaches it through a loopback SOCKS5 bridge. Step 3 below.
- A **jump host** reaches the target through a machine already in the keychain. `HostSecret.JumpHostIds` - A **jump host** reaches the target through a machine already in the keychain. `HostSecret.JumpHostIds`
stores the chain; nothing writes it and nothing reads it. stores the chain; nothing writes it and nothing reads it.
◆ **An earlier version of this page said the relay's server half was "built and shipped". It was not.** What
existed was ADR 0004, the contract records, the options and the CHECK constraint — and `RelayOptions` said,
in its own remarks, that there was no endpoint and no dialler. Both halves were built together at step 3.
This document is the comparison between them, which is the thing that has to be settled before either is This document is the comparison between them, which is the thing that has to be settled before either is
built, and then the plan. It replaces an earlier draft of `docs/jump-hosts.md` that recommended deleting the built, and then the plan. It replaces an earlier draft of `docs/jump-hosts.md` that recommended deleting the
jump chain — see the last section for why that was wrong. jump chain — see the last section for why that was wrong.
> **Status: step 0 done, the rest planned.** > **Status: steps 0, 1 and 3 done, and step 4 for the relay. Jump hosts are next.**
> >
> | Step | State | Notes | > | Step | State | Notes |
> | --- | --- | --- | > | --- | --- | --- |
> | 0. Stop promising the relay | **Done** | Both heads say the box is not wired up and that ticking it stores the address and changes nothing. Left tickable, so a host already carrying the flag can lose it | > | 0. Stop promising the relay | **Done, then retired at step 3** | The "not wired up yet" sentence came out of both heads when the relay started working |
> | 1. Dial through a loopback proxy | **Done** | `SshLoopbackProxy` on the request, honoured in `BuildConnectionInfo`. **Not the bridge** — see below | > | 1. Dial through a loopback proxy | **Done** | `SshLoopbackProxy` on the request, honoured in `BuildConnectionInfo`. **Not the bridge** — see below |
> | 2. Jump hosts over it | Not started | No server change, and no bridge either: SSH.NET's own forward is the proxy | > | 2. Jump hosts over it | Not started | No server change, and no bridge either: SSH.NET's own forward is the proxy |
> | 3. The relay: the bridge, then the ticket | Not started | The bridge's only consumer, so it lands with the feature that uses it | > | 3. The relay: the bridge, then the ticket | **Done** | Server: `Features/Relay`. Client: `RelayBridge`, `ServerRelay`, and `VaultViewModel.OpenThroughAsync`. See "What step 3 built" |
> | 4. File transfer parity | Not started | The transfers screen opens its own connection. Already half-done — `OpenSftpAsync` shares `BuildConnectionInfo`, so it honours a proxy today; what is missing is anything passing it one | > | 4. File transfer parity | **Done for the relay** | `TransfersViewModel` opens a relay for a relayed host exactly as the shell does. A jump chain will need the same line when step 2 lands |
## ◆ The relay's checkbox is a false promise, and that is a defect ## ◆ The relay's checkbox is a false promise, and that is a defect
@@ -171,7 +175,64 @@ the sentence step 0 added comes out of both heads.
**4. File transfer.** `ISftpSessionFactory.OpenSftpAsync` opens its own second connection, so a host that **4. File transfer.** `ISftpSessionFactory.OpenSftpAsync` opens its own second connection, so a host that
needs a chain or a relay to reach needs it there too, or SFTP silently fails for exactly the hosts this needs a chain or a relay to reach needs it there too, or SFTP silently fails for exactly the hosts this
work exists for. work exists for. ✅ for the relay.
## What step 3 built
**The server**, in `DodoSSH.Api/Features/Relay`:
- `POST /api/v1/relay/tickets` makes every decision. It finds the host, requires Connect on its vault and
the relay switched on, resolves the stored name, and runs every answer through `RelayAddressPolicy` —
the non-overridable list first, then the operator's denials, allow-list and private-network switch. What
passes goes into a Data Protection ticket; the name is not resolved again. **Every target refusal is one
answer**, 403 `relay-target-rejected` with one sentence, because anybody who can write a host can point
it anywhere, and a distinct "resolves, but refused" would be a scanner for the operator's DNS. The real
reason is logged (event 2301).
- `GET /api/v1/relay/connect` is anonymous at the HTTP layer and takes the ticket as the second
subprotocol. It verifies, checks expiry against `TimeProvider`, and spends the ticket with a unique
insert into `relay_ticket_use` before accepting the upgrade — so a refused ticket is a 401 and no socket.
After the upgrade, a refusal the client could not have avoided is a close code: 4429 for a limit, 4502
for a host the server could not reach, 4408 idle, 4409 lifetime, 1001 at the end of a shutdown's drain.
- `relay_session` is the audit row: opened before the dial, closed after, each from a scope of its own.
**The client:**
- `RelayBridge` (Client.Ssh) is the loopback SOCKS5 listener. It binds `127.0.0.1`, accepts once, answers
one CONNECT without acting on its target, and pipes to the WebSocket. It is handed to the connection as
the new `SshLoopbackProxy.Lifetime`, so the connection disposes it on every way a session ends, and a
failed connect disposes it before throwing.
- `ServerRelay` (Client.Session) asks for the ticket, opens the socket and starts the bridge, and turns
every refusal into a sentence. It is `IVaultServer.Relay`, decided from `/api/v1/meta` the way `Events`
is; a server without the feature supplies `UnavailableServerRelay`.
- `VaultViewModel` opens a relay for a host with the box ticked and **never falls back to dialling it
directly** — the user ticked it because that path does not work, or goes somewhere they do not mean. A
relay that closed with a reason replaces SSH.NET's transport error with that reason, and the
reachability probe is skipped for a relayed host, because it would test the direct path.
### ◆ Two things that are not what ADR 0004 wrote
- **No `System.IO.Pipelines`.** Each direction reads one buffer and does not read again until the write
has completed. That is the same end-to-end backpressure — a slow peer stops the read, which fills the
kernel's window, which throttles the far sender — with a tighter bound: two 32 KiB buffers a session
rather than ~2 MiB.
- **No `?ticket=` fallback, and no device id in the ticket.** The fallback exists for clients that cannot
set a subprotocol, which neither head is, and it would put a bearer credential in the one place — the
URL — that access logs keep. A device is never visible to the server on an ordinary request.
### ◆ A WebSocket operation is never cancelled, on either side
Cancelling a pending receive or send on a .NET WebSocket aborts it, and an aborted socket sends no close
frame. The close frame is the only way the client learns that the server could not reach the host, so both
the server's pump and the client's bridge stop a direction by closing and waiting a bounded time instead.
`AnIdleSession_IsClosedWithTheIdleCode` holds the server to it: it asserts the code arrives, not merely that
the socket ended.
### What a developer meets
The relay refuses loopback with no configuration escape, so the development stack's sshd on
`localhost:2222` cannot be reached through it. Point a relayed host at an address the API process reaches
on a real interface — the machine's own LAN address works — or at the container's address on the Docker
network.
## Traps already known ## Traps already known
@@ -226,8 +287,8 @@ is right, sharing a lifetime policy is not.
row, and the status bar's `via bastion-eu` row, all of which say jump hosts are data-only. row, and the status bar's `via bastion-eu` row, all of which say jump hosts are data-only.
- `Client.Import/ImportedHost.cs` — the note written onto every imported host with a `ProxyJump`, and the - `Client.Import/ImportedHost.cs` — the note written onto every imported host with a `ProxyJump`, and the
remark above it. remark above it.
- `README.md` and `docs/android-port.md` wherever the relay is described as available. - `README.md` and `docs/android-port.md` wherever the relay is described as available. ✅ at step 3.
- ADR 0004 gains a note that its last consequence was built, and how. - ADR 0004 gains a note that its last consequence was built, and how. ✅ at step 3.
## What the first draft of this document got wrong ## What the first draft of this document got wrong
+60 -10
View File
@@ -169,16 +169,66 @@ Bump ApplicationVersion, commit, move the tag, and run this again.
if (Test-Path $Staging) { Remove-Item -Recurse -Force $Staging } if (Test-Path $Staging) { Remove-Item -Recurse -Force $Staging }
New-Item -ItemType Directory -Path $Staging | Out-Null New-Item -ItemType Directory -Path $Staging | Out-Null
# No RuntimeIdentifier, so every supported ABI is packaged. An arm64-only APK will not install on a # ◆ THE PASSWORDS GO THROUGH THE ENVIRONMENT, BECAUSE -p: PUTS THEM ON A COMMAND LINE.
# 32-bit handset or an x86_64 emulator, and this is the package strangers are pointed at. #
& dotnet build $Project --no-restore --configuration Release ` # They used to be written straight into -p:AndroidSigningStorePass=..., which reads as private and is
-t:SignAndroidPackage ` # not. A process's command line is not a secret on Windows: any process running as this user can read
-p:DodoChannel=release ` # every argument of every other with one call —
-p:AndroidKeyStore=true ` #
-p:AndroidSigningKeyStore=$KeystorePath ` # Get-CimInstance Win32_Process | Select-Object Name, CommandLine
-p:AndroidSigningKeyAlias=$KeyAlias ` #
-p:AndroidSigningStorePass=$storePlain ` # — and process-creation auditing, EDR agents and crash dumps all record it as a matter of course. The
-p:AndroidSigningKeyPass=$keyPlain # comment above says the passwords are never stored, and with the arguments written that way it was
# true of the disk and false of everything watching the machine.
#
# env: is .NET for Android's own answer to exactly this, and it names the variable rather than carrying
# the value: MSBuild is handed the string "env:DODOSSH_ANDROID_STOREPASS" and reads the password out of
# the environment itself. The one restriction is $(AndroidPackageFormat) = aab, where env: is not
# supported and file: is the documented alternative; this channel ships an APK, and the guard below
# fails loudly rather than silently signing with the literal string if that ever changes.
#
# Not a perfect channel — an environment block is readable by a process with rights over this one, the
# same as memory is — but it is off the command line, out of the audit trail and out of any log that
# echoes the build invocation, which is the whole of the difference being bought here.
#
# -nodeReuse:false so no MSBuild worker outlives this call holding the variables in its environment.
# The finally clears them from this process either way, and a persistent node would have kept its own
# inherited copy for the next quarter of an hour regardless of what happens here.
$packageFormat = (& dotnet msbuild $Project -getProperty:AndroidPackageFormat -nologo `
-p:DodoChannel=release | ForEach-Object { $_.Trim() } | Where-Object { $_ })
if ($packageFormat -eq 'aab') {
Stop-With @'
This channel now builds an aab, and the env: prefix this script signs with is not supported for that
format. The signing would silently take "env:DODOSSH_ANDROID_STOREPASS" for the password itself.
Switch both passwords to the file: prefix, which is supported for aab, and make sure whatever writes
that file removes it again.
'@
}
try {
$env:DODOSSH_ANDROID_STOREPASS = $storePlain
$env:DODOSSH_ANDROID_KEYPASS = $keyPlain
# No RuntimeIdentifier, so every supported ABI is packaged. An arm64-only APK will not install on a
# 32-bit handset or an x86_64 emulator, and this is the package strangers are pointed at.
& dotnet build $Project --no-restore --configuration Release `
-nodeReuse:false `
-t:SignAndroidPackage `
-p:DodoChannel=release `
-p:AndroidKeyStore=true `
-p:AndroidSigningKeyStore=$KeystorePath `
-p:AndroidSigningKeyAlias=$KeyAlias `
-p:AndroidSigningStorePass=env:DODOSSH_ANDROID_STOREPASS `
-p:AndroidSigningKeyPass=env:DODOSSH_ANDROID_KEYPASS
}
finally {
# SetEnvironmentVariable rather than Remove-Item, which throws when the variable is not there —
# and this runs on the failure path, where it may well not be.
[Environment]::SetEnvironmentVariable('DODOSSH_ANDROID_STOREPASS', $null)
[Environment]::SetEnvironmentVariable('DODOSSH_ANDROID_KEYPASS', $null)
}
if ($LASTEXITCODE -ne 0) { Stop-With 'The build failed.' } if ($LASTEXITCODE -ne 0) { Stop-With 'The build failed.' }
+23 -5
View File
@@ -38,9 +38,11 @@
# xcrun notarytool store-credentials DodoSSH \ # xcrun notarytool store-credentials DodoSSH \
# --apple-id you@example.com --team-id TEAMID --password <app-specific-password> # --apple-id you@example.com --team-id TEAMID --password <app-specific-password>
# #
# The forge token is the one real secret, and it is prompted for rather than read from a file or the # The forge token is the one real secret, and it is prompted for rather than read from a file or an
# environment, and only in the phase that needs it — for the reason the Windows script gives: the fewer # ambient environment variable, and only in the phase that needs it — for the reason the Windows script
# minutes a credential that can publish an update spends in a shell's memory the better. # gives: the fewer minutes a credential that can publish an update spends in a shell's memory the better.
# It reaches vpk through VPK_TOKEN, exported for that one call and unset afterwards, because the
# alternative is --token on a command line that is not private. See the comment at the upload itself.
# #
# Usage: # Usage:
# bash scripts/release-macos.sh # bash scripts/release-macos.sh
@@ -195,10 +197,18 @@ if [ "$UPLOAD" -eq 1 ]; then
# also already hold the Windows package for the same tag, which is the case --merge is really doing # also already hold the Windows package for the same tag, which is the case --merge is really doing
# the work for: without it the second platform to publish a given version fails on a release that # the work for: without it the second platform to publish a given version fails on a release that
# exists, and with it the two sit side by side under one tag. --channel keeps the indexes apart. # exists, and with it the two sit side by side under one tag. --channel keeps the indexes apart.
#
# No --token in this array, and that is deliberate. It used to be there, and an argument is not a
# private place to put a credential: /proc/<pid>/cmdline is world-readable on Linux, `ps` hands out
# other processes' arguments freely, and whatever agent is auditing process creation on this machine
# keeps its own copy. The comment above is about shell history and was never the whole story.
#
# vpk documents VPK_TOKEN as --token's environment fallback, so the value never becomes an argument.
# Exported for the one call and unset straight after; an environment block is still readable by a
# process with rights over this one, but it is out of every process listing and audit log.
UPLOAD_ARGS=( UPLOAD_ARGS=(
upload gitea upload gitea
--repoUrl "$REPO_URL" --repoUrl "$REPO_URL"
--token "$TOKEN"
--outputDir "$RELEASES_DIR" --outputDir "$RELEASES_DIR"
--channel "$CHANNEL" --channel "$CHANNEL"
--releaseName "$TAG" --releaseName "$TAG"
@@ -214,7 +224,15 @@ if [ "$UPLOAD" -eq 1 ]; then
esac esac
write_step 'Uploading' write_step 'Uploading'
dotnet vpk "${UPLOAD_ARGS[@]}" || stop_with 'vpk upload failed.'
# Unset on the way out whether or not the upload worked, so a failed release does not leave the token
# sitting in this shell for whatever runs next.
export VPK_TOKEN="$TOKEN"
vpk_status=0
dotnet vpk "${UPLOAD_ARGS[@]}" || vpk_status=$?
unset VPK_TOKEN
[ "$vpk_status" -eq 0 ] || stop_with 'vpk upload failed.'
write_step "Published $TAG." write_step "Published $TAG."
exit 0 exit 0
+31 -5
View File
@@ -16,9 +16,11 @@
2. With -Upload: asks for the forge token and publishes what phase 1 produced. It does not rebuild, 2. With -Upload: asks for the forge token and publishes what phase 1 produced. It does not rebuild,
so the bytes that reach users are the bytes that were installed and checked. so the bytes that reach users are the bytes that were installed and checked.
The token is prompted for rather than read from a file or an environment variable, and only in the phase The token is prompted for rather than read from a file or an ambient environment variable, and only in
that needs it — the build does not, and the fewer minutes a credential that can publish an update spends the phase that needs it — the build does not, and the fewer minutes a credential that can publish an
in a shell's memory the better. update spends in a shell's memory the better. It reaches vpk through VPK_TOKEN, set for that one call
and cleared afterwards, because the alternative is --token on a command line every process on this
machine can read. See the comment at the upload itself.
.PARAMETER Upload .PARAMETER Upload
Publish the packages already in Releases/ instead of building. Publish the packages already in Releases/ instead of building.
@@ -152,10 +154,24 @@ try {
# --merge because Gitea already has a release entry for the pushed tag, and without it the upload # --merge because Gitea already has a release entry for the pushed tag, and without it the upload
# fails on a release that exists. --pre mirrors the rule the docker image job already applies to the # fails on a release that exists. --pre mirrors the rule the docker image job already applies to the
# same tag, so a release candidate is a prerelease in both channels or in neither. # same tag, so a release candidate is a prerelease in both channels or in neither.
#
# ◆ NO --token HERE. IT WAS AN ARGUMENT, AND AN ARGUMENT IS PUBLIC ON THIS MACHINE.
#
# The comment above says the token never lands in shell history, which was true and was not the
# whole story: it went straight into vpk's command line, and any process running as this user can
# read that off a running process with one call —
#
# Get-CimInstance Win32_Process | Select-Object Name, CommandLine
#
# — with process-creation auditing and EDR agents keeping their own copy afterwards. A token that
# can publish an update every installed copy will fetch and run deserves better than that.
#
# vpk documents VPK_TOKEN as --token's environment fallback, so the flag simply goes away and the
# value never becomes an argument at all. An environment block is still readable by a process with
# rights over this one; what it is not is a string sitting in a process listing and an audit log.
$uploadArgs = @( $uploadArgs = @(
'upload', 'gitea', 'upload', 'gitea',
'--repoUrl', $RepoUrl, '--repoUrl', $RepoUrl,
'--token', $token,
'--outputDir', $ReleasesDir, '--outputDir', $ReleasesDir,
'--channel', $Channel, '--channel', $Channel,
'--releaseName', $tag, '--releaseName', $tag,
@@ -169,7 +185,17 @@ try {
} }
Write-Step 'Uploading' Write-Step 'Uploading'
& dotnet vpk @uploadArgs
try {
$env:VPK_TOKEN = $token
& dotnet vpk @uploadArgs
}
finally {
# SetEnvironmentVariable rather than Remove-Item, which throws when the variable is not there —
# and this runs on the failure path, where it may well not be.
[Environment]::SetEnvironmentVariable('VPK_TOKEN', $null)
}
if ($LASTEXITCODE -ne 0) { Stop-With 'vpk upload failed.' } if ($LASTEXITCODE -ne 0) { Stop-With 'vpk upload failed.' }
Write-Step "Published $tag." Write-Step "Published $tag."
@@ -26,9 +26,6 @@ internal sealed class GetMetaEndpoint(
/// <summary>Sync semantics version. Bumped when push or pull behaviour changes.</summary> /// <summary>Sync semantics version. Bumped when push or pull behaviour changes.</summary>
internal const int SyncProtocolVersion = 1; internal const int SyncProtocolVersion = 1;
/// <summary>Feature flag for the relay.</summary>
internal const string RelayFeature = "relay";
/// <inheritdoc /> /// <inheritdoc />
public override void Configure() public override void Configure()
{ {
@@ -50,7 +47,7 @@ internal sealed class GetMetaEndpoint(
List<string> features = ["teams"]; List<string> features = ["teams"];
if (relay.Value.Enabled) if (relay.Value.Enabled)
{ {
features.Add(RelayFeature); features.Add(RelayProtocol.Feature);
} }
// Advertised so a client knows whether to hold a socket open or rely on its timer. Absence is // Advertised so a client knows whether to hold a socket open or rely on its timer. Absence is
@@ -0,0 +1,192 @@
using System.Net;
using System.Net.Sockets;
using DodoSSH.Api.Setup;
namespace DodoSSH.Api.Features.Relay;
/// <summary>
/// Decides which addresses and ports the relay may dial. ADR 0004 §3, in the order it is written.
/// </summary>
/// <remarks>
/// <para>
/// This runs on <em>addresses</em>, never on names. The name is resolved once, at ticket issue, and what
/// this permits goes into the ticket; the socket dials those addresses and nothing else. A check on the
/// name would be defeated by DNS rebinding — answer with a public address for the check and a loopback
/// one for the dial — which is the attack ADR 0004 is built around.
/// </para>
/// <para>
/// Three layers, and the order is the security property. The <see cref="Refused"/> list comes first and
/// has no configuration at all: nothing an operator sets, and nothing a host row says, reaches a
/// loopback, link-local, unspecified, multicast or metadata address. Then the operator's own denials,
/// then their allow-list, then the private-network switch.
/// </para>
/// <para>
/// <b>An address that embeds another is judged as the one it embeds.</b> <c>::ffff:127.0.0.1</c> is
/// loopback however it is spelled, and a check that compared it against IPv6 loopback alone would pass
/// it — the classic bypass the ADR names. The NAT64 well-known prefix is unwrapped the same way, because
/// on a network with a NAT64 gateway <c>64:ff9b::a9fe:a9fe</c> <em>is</em> the metadata endpoint.
/// </para>
/// </remarks>
internal sealed class RelayAddressPolicy
{
/// <summary>
/// Addresses the relay never dials, whatever it is configured to do.
/// </summary>
/// <remarks>
/// Broader than the ADR's list in two places, both deliberately. <c>240.0.0.0/4</c> — reserved, and
/// containing the limited broadcast address — has no host worth reaching. And IPv6 <c>::/96</c>, the
/// deprecated IPv4-compatible block, covers the unspecified address and loopback while also refusing
/// the spellings of IPv4 that a stack may or may not map; nothing legitimate lives there.
/// </remarks>
private static readonly IPNetwork[] Refused =
[
// IPv4: "this network", loopback, link-local (which holds 169.254.169.254), multicast, reserved.
IPNetwork.Parse("0.0.0.0/8"),
IPNetwork.Parse("127.0.0.0/8"),
IPNetwork.Parse("169.254.0.0/16"),
IPNetwork.Parse("224.0.0.0/4"),
IPNetwork.Parse("240.0.0.0/4"),
// Alibaba Cloud's metadata endpoint, which sits inside carrier-grade NAT space and so would
// otherwise be permitted as private — the range a Tailnet also uses, which is why the whole
// block cannot simply be refused.
IPNetwork.Parse("100.100.100.200/32"),
// IPv6: IPv4-compatible (with unspecified and loopback), link-local, multicast, and the AWS
// metadata endpoint's IPv6 address.
IPNetwork.Parse("::/96"),
IPNetwork.Parse("fe80::/10"),
IPNetwork.Parse("ff00::/8"),
IPNetwork.Parse("fd00:ec2::254/128"),
];
/// <summary>
/// Ranges <see cref="RelayOptions.AllowPrivateNetworks"/> governs.
/// </summary>
/// <remarks>
/// Carrier-grade NAT is here rather than treated as public, because it is where a Tailnet lives and
/// "the server is on the same Tailnet" is one of the shapes the relay exists for. Site-local
/// <c>fec0::/10</c> is deprecated and was private while it lived.
/// </remarks>
private static readonly IPNetwork[] Private =
[
IPNetwork.Parse("10.0.0.0/8"),
IPNetwork.Parse("172.16.0.0/12"),
IPNetwork.Parse("192.168.0.0/16"),
IPNetwork.Parse("100.64.0.0/10"),
IPNetwork.Parse("fc00::/7"),
IPNetwork.Parse("fec0::/10"),
];
/// <summary>The NAT64 well-known prefix, RFC 6052, whose low 32 bits are an IPv4 address.</summary>
private static readonly IPNetwork Nat64 = IPNetwork.Parse("64:ff9b::/96");
/// <summary>
/// Ports the relay never dials.
/// </summary>
/// <remarks>
/// SMTP and nothing else, per ADR 0004: a relay that reached port 25 is a spam cannon with the
/// operator's address on it. Database ports stay open, because forwarding to one is a headline use,
/// and the control that matters there is who may dial the host at all.
/// </remarks>
private static readonly int[] RefusedPorts = [25, 465, 587];
private readonly bool allowPrivate;
private readonly IPNetwork[] allowed;
private readonly IPNetwork[] denied;
public RelayAddressPolicy(RelayOptions options)
{
ArgumentNullException.ThrowIfNull(options);
allowPrivate = options.AllowPrivateNetworks;
allowed = ParseAll(options.AllowedNetworks);
denied = ParseAll(options.DeniedNetworks);
}
/// <summary>Whether a port may be dialled at all.</summary>
internal static bool PermitsPort(int port) =>
port is >= 1 and <= 65535 && !RefusedPorts.Contains(port);
/// <summary>
/// Whether every entry is a network this policy can read.
/// </summary>
/// <remarks>
/// For startup validation. A typo in a deny list that was silently skipped would be a hole the
/// operator believes is closed, so an unreadable entry stops the server instead.
/// <para>
/// Host bits are refused as well, although <see cref="IPNetwork.TryParse(string?, out IPNetwork)"/>
/// would mask them off quietly. <c>10.20.5.7/16</c> could be a /16 written from memory or a /32 with
/// the wrong suffix, and in a deny list those differ by sixty-five thousand addresses.
/// </para>
/// </remarks>
internal static bool AreNetworks(IEnumerable<string> entries) =>
entries.All(entry =>
IPNetwork.TryParse(entry, out var network)
&& IPAddress.TryParse(entry.AsSpan(0, entry.IndexOf('/', StringComparison.Ordinal)), out var written)
&& written.Equals(network.BaseAddress));
/// <summary>
/// The address the relay would actually be talking to, with any embedding unwrapped.
/// </summary>
internal static IPAddress Normalise(IPAddress address)
{
ArgumentNullException.ThrowIfNull(address);
if (address.IsIPv4MappedToIPv6)
{
return address.MapToIPv4();
}
if (address.AddressFamily == AddressFamily.InterNetworkV6 && Nat64.Contains(address))
{
var bytes = address.GetAddressBytes();
return new IPAddress(bytes.AsSpan(12, 4));
}
// A scope id is how an address names an interface on this machine, which is not something a
// host row gets to choose. Dropped, so what is judged is what is dialled.
return address.AddressFamily == AddressFamily.InterNetworkV6 && address.ScopeId != 0
? new IPAddress(address.GetAddressBytes())
: address;
}
/// <summary>Whether the relay may dial this address.</summary>
/// <remarks>
/// Judges the normalised address. Callers should dial <see cref="Normalise"/>'s answer too, so that
/// the address checked and the address connected to are the same object rather than two spellings
/// the operating system is trusted to agree about.
/// </remarks>
internal bool Permits(IPAddress address)
{
var target = Normalise(address);
if (Refused.Any(network => Within(network, target)))
{
return false;
}
if (denied.Any(network => Within(network, target)))
{
return false;
}
if (allowed.Length > 0)
{
return allowed.Any(network => Within(network, target));
}
return allowPrivate || !Private.Any(network => Within(network, target));
}
/// <remarks>
/// <see cref="IPNetwork.Contains"/> answers false across address families rather than throwing, so
/// a list mixing IPv4 and IPv6 needs no sorting — but it is spelled out here because the one-line
/// alternative reads as though it compared across families.
/// </remarks>
private static bool Within(IPNetwork network, IPAddress address) =>
network.BaseAddress.AddressFamily == address.AddressFamily && network.Contains(address);
private static IPNetwork[] ParseAll(IEnumerable<string> entries) =>
[.. entries.Select(entry => IPNetwork.Parse(entry))];
}
@@ -0,0 +1,722 @@
using System.Buffers;
using System.Net;
using System.Net.WebSockets;
using DodoSSH.Api.Setup;
using DodoSSH.Contracts;
using DodoSSH.Domain;
using DodoSSH.Infrastructure;
using FastEndpoints;
using Microsoft.EntityFrameworkCore;
using Microsoft.Extensions.Options;
using Npgsql;
namespace DodoSSH.Api.Features.Relay;
/// <summary>
/// The relay socket: a ticket in, raw bytes to one host and back.
/// </summary>
/// <remarks>
/// <para>
/// Anonymous at the HTTP layer, because the ticket is the authorization and it is the whole of it. A
/// ticket carries no API authority — it names one host, one set of addresses and one session — so this
/// endpoint can accept it from a client that cannot set an <c>Authorization</c> header on an upgrade,
/// which is the constraint ADR 0004 was written around. It is verified, checked for freshness and
/// redeemed before the upgrade is accepted, so a refused ticket costs a problem document and no socket.
/// </para>
/// <para>
/// <b>Nothing here is scoped to the request.</b> A session lasts as long as a shell does, which is hours,
/// and anything scoped held across it is a pooled database connection held across it. The database is
/// touched three times — redeem, open the audit row, close it — each from a scope of its own that is
/// disposed before the next byte moves. That is ADR 0004's consequence about <c>DbContext</c> lifetime.
/// </para>
/// <para>
/// Backpressure is the await. Each direction reads one buffer, writes it, and does not read again until
/// the write has completed, so a slow reader on either side stops this side reading, which fills the
/// kernel's receive window, which throttles the sender at the far end. Nothing is queued in between, and
/// a session costs its two buffers whatever the peers do.
/// </para>
/// </remarks>
internal sealed class RelayConnectEndpoint(
IServiceScopeFactory scopes,
IRelayNetwork network,
RelayTicketCodec codec,
RelaySessionRegistry sessions,
IOptions<RelayOptions> options,
TimeProvider clock,
IHostApplicationLifetime lifetime,
ILogger<RelayConnectEndpoint> logger)
: EndpointWithoutRequest
{
/// <summary>
/// One direction's buffer.
/// </summary>
/// <remarks>
/// Room for an SSH packet at the size OpenSSH sends them, so a bulk transfer moves in one read and
/// one write per packet rather than several.
/// </remarks>
private const int BufferBytes = 32 * 1024;
/// <summary>How long a close handshake, or a peer's last write, may take before the socket is dropped.</summary>
private static readonly TimeSpan CloseTimeout = TimeSpan.FromSeconds(5);
/// <inheritdoc />
public override void Configure()
{
Get(RelayProtocol.ConnectPath);
// The ticket is the authorization. See the remarks on this class, and ADR 0004.
AllowAnonymous();
Description(b => b
.WithName("RelayConnect")
.WithSummary("Pipes raw bytes between a WebSocket and the host a relay ticket names.")
.WithTags("Relay"));
}
/// <inheritdoc />
public override async Task HandleAsync(CancellationToken ct)
{
var ticket = await AdmitTicketAsync(ct).ConfigureAwait(false);
if (ticket is null)
{
return;
}
var lease = sessions.TryAdmit(ticket.UserId);
try
{
using var socket = await HttpContext.WebSockets
.AcceptWebSocketAsync(new WebSocketAcceptContext { SubProtocol = RelayProtocol.SubProtocol })
.ConfigureAwait(false);
if (lease is null)
{
RelayLog.LimitReached(logger, ticket.UserId, sessions.Count);
await CloseAsync(
socket,
new Ending(
RelayCloseReason.Unspecified,
RelayProtocol.TooManySessionsCloseCode,
"Too many relay sessions are open."))
.ConfigureAwait(false);
return;
}
if (lifetime.ApplicationStopping.IsCancellationRequested)
{
await CloseAsync(socket, ShuttingDown).ConfigureAwait(false);
return;
}
await RelayAsync(socket, ticket, ct).ConfigureAwait(false);
}
finally
{
// Inside a try that starts before the upgrade, for the reason VaultEventsEndpoint gives: an
// accept that throws would otherwise hold a place against this user's cap forever.
lease?.Dispose();
}
}
private static Ending ShuttingDown { get; } = new(
RelayCloseReason.ServerShutdown,
(int)WebSocketCloseStatus.EndpointUnavailable,
"The server is shutting down.");
/// <summary>
/// Answers everything that is not a redeemable ticket, as ordinary HTTP, before any socket exists.
/// </summary>
/// <returns>The redeemed ticket, or null when a response has been sent.</returns>
/// <remarks>
/// A ticket that is forged, expired, spent, or simply absent all answer 401
/// <c>relay-ticket-invalid</c>, with one remedy — ask for another — and no hint of which it was.
/// </remarks>
private async Task<RelayTicket?> AdmitTicketAsync(CancellationToken cancellationToken)
{
if (!options.Value.Enabled)
{
await Send.ResultAsync(Problems.Coded(
StatusCodes.Status404NotFound,
ProblemCodes.RelayUnavailable,
"This server does not relay. GET /api/v1/meta lists the features it does offer."))
.ConfigureAwait(false);
return null;
}
var offered = HttpContext.WebSockets.WebSocketRequestedProtocols;
if (!HttpContext.WebSockets.IsWebSocketRequest
|| !offered.Contains(RelayProtocol.SubProtocol, StringComparer.Ordinal))
{
await Send.ResultAsync(Problems.Coded(
StatusCodes.Status400BadRequest,
ProblemCodes.MalformedRequest,
"This endpoint is a WebSocket. Send an upgrade request offering the "
+ $"'{RelayProtocol.SubProtocol}' subprotocol and the ticket as a second one, "
+ $"'{RelayProtocol.TicketProtocolPrefix}<ticket>'."))
.ConfigureAwait(false);
return null;
}
var sealedTicket = offered
.FirstOrDefault(protocol => protocol.StartsWith(RelayProtocol.TicketProtocolPrefix, StringComparison.Ordinal))
?[RelayProtocol.TicketProtocolPrefix.Length..];
var ticket = sealedTicket is { Length: > 0 } ? codec.TryOpen(sealedTicket) : null;
if (ticket is null || !await RedeemAsync(ticket, cancellationToken).ConfigureAwait(false))
{
RelayLog.TicketRefused(logger, ticket?.SessionId);
await Send.ResultAsync(Problems.Coded(
StatusCodes.Status401Unauthorized,
ProblemCodes.RelayTicketInvalid,
"This relay ticket is not valid: it is expired, already used, or was not issued here. "
+ $"Ask for another from POST {RelayProtocol.TicketsPath}."))
.ConfigureAwait(false);
return null;
}
return ticket;
}
/// <summary>
/// Spends the ticket, or answers false when it has been spent already.
/// </summary>
/// <remarks>
/// <para>
/// A unique insert, which is the only form of "once" that holds across nodes: two redemptions racing
/// on two nodes both attempt the insert and the database lets exactly one of them win.
/// </para>
/// <para>
/// Rows for tickets that can no longer verify are swept on the way. They guard nothing, and sweeping
/// here — on a path that runs once per session rather than once per request — keeps the table the
/// size of the last thirty seconds without a background job to forget about.
/// </para>
/// </remarks>
private async Task<bool> RedeemAsync(RelayTicket ticket, CancellationToken cancellationToken)
{
var scope = scopes.CreateAsyncScope();
await using var _ = scope.ConfigureAwait(false);
var database = scope.ServiceProvider.GetRequiredService<DodoDbContext>();
var now = clock.GetUtcNow();
await database.RelayTicketUses
.Where(use => use.ExpiresAtUtc < now)
.ExecuteDeleteAsync(cancellationToken)
.ConfigureAwait(false);
database.RelayTicketUses.Add(new RelayTicketUse
{
TicketId = ticket.TicketId,
ExpiresAtUtc = ticket.ExpiresAt,
UsedAtUtc = now,
});
try
{
await database.SaveChangesAsync(cancellationToken).ConfigureAwait(false);
return true;
}
catch (DbUpdateException exception)
when (string.Equals(
(exception.InnerException as PostgresException)?.SqlState,
PostgresErrorCodes.UniqueViolation,
StringComparison.Ordinal))
{
return false;
}
}
/// <summary>Dials the target, pipes until something ends it, and writes down what happened.</summary>
private async Task RelayAsync(WebSocket socket, RelayTicket ticket, CancellationToken requestAborted)
{
var started = clock.GetUtcNow();
await OpenAuditAsync(ticket, started).ConfigureAwait(false);
var dialled = await DialAsync(ticket, requestAborted).ConfigureAwait(false);
if (dialled is not var (target, address))
{
RelayLog.TargetUnreachable(logger, ticket.SessionId, ticket.HostId);
var unreachable = new Ending(
RelayCloseReason.TargetUnreachable,
RelayProtocol.TargetUnreachableCloseCode,
"The relay could not reach the host.");
await CloseAsync(socket, unreachable).ConfigureAwait(false);
await CloseAuditAsync(ticket.SessionId, null, new Counters(clock, started), unreachable.Reason).ConfigureAwait(false);
return;
}
var counters = new Counters(clock, started);
Ending ending;
await using (target.ConfigureAwait(false))
{
RelayLog.SessionOpened(logger, ticket.SessionId, ticket.UserId, ticket.HostId, sessions.Count);
ending = await PumpAsync(socket, target, counters, started, requestAborted).ConfigureAwait(false);
}
RelayLog.SessionClosed(
logger,
ticket.SessionId,
ending.Reason,
counters.ClientToTarget,
counters.TargetToClient);
await CloseAuditAsync(ticket.SessionId, address, counters, ending.Reason).ConfigureAwait(false);
}
/// <summary>
/// Connects to the first of the ticket's addresses that answers, within the connect timeout overall.
/// </summary>
/// <remarks>
/// Overall rather than per address, so a name with sixteen dead addresses costs five seconds rather
/// than eighty. In the order resolved, which is the order the operating system's resolver prefers.
/// </remarks>
private async Task<(Stream Target, IPAddress Address)?> DialAsync(
RelayTicket ticket,
CancellationToken cancellationToken)
{
using var timeout = CancellationTokenSource.CreateLinkedTokenSource(cancellationToken);
timeout.CancelAfter(options.Value.ConnectTimeout);
foreach (var address in ticket.TargetAddresses)
{
try
{
var target = await network
.ConnectAsync(address, ticket.TargetPort, timeout.Token)
.ConfigureAwait(false);
return (target, address);
}
catch (OperationCanceledException)
{
return null;
}
catch (Exception exception) when (exception is IOException or System.Net.Sockets.SocketException)
{
// The next address, if there is one.
}
}
return null;
}
/// <summary>
/// Runs both directions and the clock until one of them ends the session, then ends it politely.
/// </summary>
/// <remarks>
/// <para>
/// <b>No operation on the WebSocket is ever cancelled.</b> Cancelling a pending receive or send on a
/// .NET WebSocket aborts it, and an aborted socket cannot send the close frame that is the only way
/// a client learns <em>why</em> its session ended — which, for an idle timeout or a drain, is the
/// difference between "reconnect" and "something is broken". So the token stops the target side and
/// the clock; the sender is let finish its last write; the close goes out; and the receiver ends on
/// the client's answering close. Each wait is bounded, and the socket is aborted only when a peer
/// has stopped answering altogether.
/// </para>
/// </remarks>
private async Task<Ending> PumpAsync(
WebSocket socket,
Stream target,
Counters counters,
DateTimeOffset started,
CancellationToken requestAborted)
{
using var pump = CancellationTokenSource.CreateLinkedTokenSource(requestAborted);
var upstream = ClientToTargetAsync(socket, target, counters, pump.Token);
var downstream = TargetToClientAsync(target, socket, counters, pump.Token);
var minding = MindAsync(counters, started, pump.Token);
var first = await Task.WhenAny(upstream, downstream, minding).ConfigureAwait(false);
var ending = await first.ConfigureAwait(false) ?? new Ending(
RelayCloseReason.ClientClosed, (int)WebSocketCloseStatus.NormalClosure, string.Empty);
await pump.CancelAsync().ConfigureAwait(false);
// The only sender must be done before the close frame is written: a WebSocket permits one send
// at a time and faults permanently on a second.
if (!await SettlesAsync(downstream).ConfigureAwait(false))
{
socket.Abort();
}
await CloseAsync(socket, ending).ConfigureAwait(false);
if (!await SettlesAsync(upstream).ConfigureAwait(false))
{
socket.Abort();
await SettlesAsync(upstream).ConfigureAwait(false);
}
await SettlesAsync(minding).ConfigureAwait(false);
return ending;
}
/// <summary>Client to target: every binary message is the next bytes of the stream.</summary>
private static async Task<Ending?> ClientToTargetAsync(
WebSocket socket,
Stream target,
Counters counters,
CancellationToken cancellationToken)
{
var buffer = ArrayPool<byte>.Shared.Rent(BufferBytes);
try
{
while (true)
{
ValueWebSocketReceiveResult received;
try
{
// Not cancellable, deliberately. See PumpAsync.
received = await socket.ReceiveAsync(buffer.AsMemory(), CancellationToken.None)
.ConfigureAwait(false);
}
catch (Exception exception) when (exception is WebSocketException or OperationCanceledException)
{
return ClientGone;
}
if (received.MessageType == WebSocketMessageType.Close)
{
return ClientGone;
}
// A byte pipe has no text. A client sending some has the wrong idea about this endpoint,
// and forwarding it into an SSH stream would corrupt that stream at best.
if (received.MessageType != WebSocketMessageType.Binary)
{
return new Ending(
RelayCloseReason.Error,
(int)WebSocketCloseStatus.InvalidMessageType,
"The relay carries binary messages only.");
}
try
{
await target.WriteAsync(buffer.AsMemory(0, received.Count), cancellationToken)
.ConfigureAwait(false);
}
catch (OperationCanceledException)
{
return null;
}
catch (IOException)
{
return TargetGone;
}
counters.AddClientToTarget(received.Count);
}
}
finally
{
ArrayPool<byte>.Shared.Return(buffer);
}
}
/// <summary>Target to client: every read becomes one binary message.</summary>
private static async Task<Ending?> TargetToClientAsync(
Stream target,
WebSocket socket,
Counters counters,
CancellationToken cancellationToken)
{
var buffer = ArrayPool<byte>.Shared.Rent(BufferBytes);
try
{
while (true)
{
int read;
try
{
read = await target.ReadAsync(buffer.AsMemory(0, BufferBytes), cancellationToken)
.ConfigureAwait(false);
}
catch (OperationCanceledException)
{
return null;
}
catch (IOException)
{
return TargetGone;
}
if (read == 0)
{
return TargetGone;
}
try
{
// Not cancellable, deliberately. See PumpAsync.
await socket
.SendAsync(
buffer.AsMemory(0, read),
WebSocketMessageType.Binary,
endOfMessage: true,
CancellationToken.None)
.ConfigureAwait(false);
}
catch (Exception exception) when (exception is WebSocketException or ObjectDisposedException)
{
return ClientGone;
}
counters.AddTargetToClient(read);
}
}
finally
{
ArrayPool<byte>.Shared.Return(buffer);
}
}
/// <summary>
/// Ends the session at the idle timeout, the lifetime cap, or the end of a shutdown's drain.
/// </summary>
/// <remarks>
/// <para>
/// A shutdown does not end a session; it starts a countdown. ADR 0004 asks that a
/// <c>docker compose up -d</c> not guillotine live shells, so a session in progress when the server is
/// told to stop is given the drain timeout to finish — most will, because the user was already
/// closing it or the deployment waits — and is closed with 1001 only when that runs out, which tells
/// the client to reconnect rather than to report a fault. The host's own shutdown timeout is set
/// longer than the drain for this to be possible at all.
/// </para>
/// <para>
/// Idle means no bytes in either direction. WebSocket pings are not bytes of the stream and do not
/// count; SSH's own keepalives do, which is how a client that wants an idle shell kept open says so.
/// </para>
/// </remarks>
private async Task<Ending?> MindAsync(Counters counters, DateTimeOffset started, CancellationToken cancellationToken)
{
var settings = options.Value;
var hardDeadline = started + settings.MaxSessionDuration;
DateTimeOffset? drainDeadline = null;
while (!cancellationToken.IsCancellationRequested)
{
var now = clock.GetUtcNow();
if (drainDeadline is null && lifetime.ApplicationStopping.IsCancellationRequested)
{
drainDeadline = now + settings.DrainTimeout;
}
if (now >= hardDeadline)
{
return new Ending(
RelayCloseReason.DurationLimit,
RelayProtocol.DurationLimitCloseCode,
"This relay session reached its maximum lifetime.");
}
if (drainDeadline is { } drain && now >= drain)
{
return ShuttingDown;
}
var idleDeadline = counters.LastActivity + settings.IdleTimeout;
if (now >= idleDeadline)
{
return new Ending(
RelayCloseReason.IdleTimeout,
RelayProtocol.IdleTimeoutCloseCode,
"This relay session carried nothing for the idle timeout.");
}
var next = new[] { hardDeadline, idleDeadline, drainDeadline ?? DateTimeOffset.MaxValue }.Min();
// Woken early by the start of a shutdown, so the drain is measured from when it began rather
// than from whenever the idle clock next came round.
using var wake = drainDeadline is null
? CancellationTokenSource.CreateLinkedTokenSource(cancellationToken, lifetime.ApplicationStopping)
: CancellationTokenSource.CreateLinkedTokenSource(cancellationToken);
try
{
await Task.Delay(next - now, clock, wake.Token).ConfigureAwait(false);
}
catch (OperationCanceledException) when (!cancellationToken.IsCancellationRequested)
{
// The shutdown began. Round again to start the drain.
}
catch (OperationCanceledException)
{
return null;
}
}
return null;
}
private static Ending ClientGone { get; } =
new(RelayCloseReason.ClientClosed, (int)WebSocketCloseStatus.NormalClosure, string.Empty);
private static Ending TargetGone { get; } =
new(RelayCloseReason.TargetClosed, (int)WebSocketCloseStatus.NormalClosure, "The host closed the connection.");
/// <summary>
/// Opens the audit row, before the target is dialled, so a session that never reached its host is
/// still one the operator can see.
/// </summary>
private async Task OpenAuditAsync(RelayTicket ticket, DateTimeOffset started)
{
var scope = scopes.CreateAsyncScope();
await using var _ = scope.ConfigureAwait(false);
var database = scope.ServiceProvider.GetRequiredService<DodoDbContext>();
database.RelaySessions.Add(new RelaySession
{
Id = ticket.SessionId,
UserId = ticket.UserId,
HostId = ticket.HostId,
VaultId = ticket.VaultId,
TargetHost = ticket.TargetHost,
TargetPort = ticket.TargetPort,
ClientAddress = HttpContext.Connection.RemoteIpAddress?.ToString(),
StartedAtUtc = started,
});
// Not the request's token: the row has to be written even for a client that has already gone,
// or a session that was cut off would be the one with no record.
await database.SaveChangesAsync(CancellationToken.None).ConfigureAwait(false);
}
/// <summary>
/// Closes the audit row. A failure is logged and swallowed: the bytes have already moved, and
/// throwing here would only turn a finished session into an unhandled exception.
/// </summary>
private async Task CloseAuditAsync(
Guid sessionId,
IPAddress? address,
Counters counters,
RelayCloseReason reason)
{
try
{
var scope = scopes.CreateAsyncScope();
await using var _ = scope.ConfigureAwait(false);
var database = scope.ServiceProvider.GetRequiredService<DodoDbContext>();
var ended = clock.GetUtcNow();
var dialled = address?.ToString();
await database.RelaySessions
.Where(session => session.Id == sessionId)
.ExecuteUpdateAsync(
set => set
.SetProperty(session => session.EndedAtUtc, ended)
.SetProperty(session => session.TargetAddress, dialled)
.SetProperty(session => session.BytesClientToTarget, counters.ClientToTarget)
.SetProperty(session => session.BytesTargetToClient, counters.TargetToClient)
.SetProperty(session => session.CloseReason, reason),
CancellationToken.None)
.ConfigureAwait(false);
}
catch (Exception exception) when (exception is DbUpdateException or NpgsqlException or InvalidOperationException)
{
RelayLog.AuditCloseFailed(logger, sessionId, exception);
}
}
private static async Task CloseAsync(WebSocket socket, Ending ending)
{
if (socket.State is not (WebSocketState.Open or WebSocketState.CloseReceived))
{
return;
}
using var timeout = new CancellationTokenSource(CloseTimeout);
try
{
await socket
.CloseOutputAsync((WebSocketCloseStatus)ending.Code, ending.Description, timeout.Token)
.ConfigureAwait(false);
}
catch (Exception exception)
when (exception is OperationCanceledException or WebSocketException or ObjectDisposedException)
{
// The peer is already gone. There is nothing to tell it.
}
}
/// <summary>Waits for a loop to finish, for at most the close timeout.</summary>
/// <returns>Whether it finished.</returns>
private static async Task<bool> SettlesAsync(Task loop)
{
try
{
await loop.WaitAsync(CloseTimeout).ConfigureAwait(false);
return true;
}
catch (TimeoutException)
{
return false;
}
catch (Exception exception)
when (exception is OperationCanceledException or WebSocketException or IOException or ObjectDisposedException)
{
return true;
}
}
/// <summary>How a session ended, and what the client is told.</summary>
private sealed record Ending(RelayCloseReason Reason, int Code, string Description);
/// <summary>
/// Byte counts and the time of the last byte, written by the two directions and read by the clock.
/// </summary>
private sealed class Counters(TimeProvider clock, DateTimeOffset started)
{
private long clientToTarget;
private long targetToClient;
private long lastActivityTicks = started.UtcTicks;
internal long ClientToTarget => Interlocked.Read(ref clientToTarget);
internal long TargetToClient => Interlocked.Read(ref targetToClient);
internal DateTimeOffset LastActivity => new(Interlocked.Read(ref lastActivityTicks), TimeSpan.Zero);
internal void AddClientToTarget(int count)
{
Interlocked.Add(ref clientToTarget, count);
Interlocked.Exchange(ref lastActivityTicks, clock.GetUtcNow().UtcTicks);
}
internal void AddTargetToClient(int count)
{
Interlocked.Add(ref targetToClient, count);
Interlocked.Exchange(ref lastActivityTicks, clock.GetUtcNow().UtcTicks);
}
}
}
@@ -0,0 +1,94 @@
using DodoSSH.Domain;
namespace DodoSSH.Api.Features.Relay;
/// <summary>Source-generated log messages for the relay.</summary>
/// <remarks>
/// <para>
/// Ids, counts and reasons. Never a ticket, which is a bearer credential for thirty seconds, and never
/// the target's address: that is in the audit table, where retention is the operator's decision, and
/// copying it into a log would make it the log pipeline's decision too.
/// </para>
/// <para>
/// <see cref="TargetRejected"/> is the one place the reason for a refused target is written down. The
/// client is told nothing specific, deliberately — see <c>RelayTicketEndpoint</c> — so this line is how
/// an operator answers "why will the relay not reach this host".
/// </para>
/// </remarks>
internal static partial class RelayLog
{
[LoggerMessage(
EventId = 2301,
Level = LogLevel.Information,
Message = "Relay ticket refused for user {UserId} and host {HostId}: {Reason}.")]
internal static partial void TargetRejected(ILogger logger, Guid userId, Guid hostId, string reason);
[LoggerMessage(
EventId = 2302,
Level = LogLevel.Debug,
Message = "Relay ticket issued to user {UserId} for host {HostId}, session {SessionId}, with "
+ "{AddressCount} permitted address(es).")]
internal static partial void TicketIssued(
ILogger logger,
Guid userId,
Guid hostId,
Guid sessionId,
int addressCount);
/// <remarks>
/// The session id is known only for a ticket that verified and had already been spent, which is the
/// case worth an operator's attention: a replay, or a client retrying a redemption it thinks failed.
/// </remarks>
[LoggerMessage(
EventId = 2303,
Level = LogLevel.Information,
Message = "Relay ticket refused at the socket (session {SessionId}): forged, expired or already used.")]
internal static partial void TicketRefused(ILogger logger, Guid? sessionId);
[LoggerMessage(
EventId = 2304,
Level = LogLevel.Information,
Message = "Relay session refused for user {UserId}: a session limit is met, with {SessionCount} "
+ "open on this node.")]
internal static partial void LimitReached(ILogger logger, Guid userId, int sessionCount);
[LoggerMessage(
EventId = 2305,
Level = LogLevel.Information,
Message = "Relay session {SessionId} could not reach host {HostId} on any permitted address.")]
internal static partial void TargetUnreachable(ILogger logger, Guid sessionId, Guid hostId);
[LoggerMessage(
EventId = 2306,
Level = LogLevel.Debug,
Message = "Relay session {SessionId} opened for user {UserId} to host {HostId}; {SessionCount} "
+ "open on this node.")]
internal static partial void SessionOpened(
ILogger logger,
Guid sessionId,
Guid userId,
Guid hostId,
int sessionCount);
[LoggerMessage(
EventId = 2307,
Level = LogLevel.Debug,
Message = "Relay session {SessionId} closed ({Reason}) after {ClientToTarget} byte(s) up and "
+ "{TargetToClient} down.")]
internal static partial void SessionClosed(
ILogger logger,
Guid sessionId,
RelayCloseReason reason,
long clientToTarget,
long targetToClient);
/// <remarks>
/// A warning rather than an error: the session itself is over and was fine. What is lost is the
/// audit row's second half, which leaves it looking like a session still open.
/// </remarks>
[LoggerMessage(
EventId = 2308,
Level = LogLevel.Warning,
Message = "Relay session {SessionId} ended but its audit record could not be closed.")]
internal static partial void AuditCloseFailed(ILogger logger, Guid sessionId, Exception exception);
}
@@ -0,0 +1,61 @@
using System.Net;
using System.Net.Sockets;
namespace DodoSSH.Api.Features.Relay;
/// <summary>
/// The two things the relay asks of the network: what a name resolves to, and a connection to an address.
/// </summary>
/// <remarks>
/// <para>
/// A seam for tests, and a narrow one on purpose. <see cref="RelayAddressPolicy"/> is not behind it:
/// whatever this answers, the policy judges, and a test that replaces this still runs every address
/// through the real rules. What a test cannot do without the seam is dial anything, because every
/// address a test machine can reach on its own — loopback — is one the policy refuses outright.
/// </para>
/// </remarks>
internal interface IRelayNetwork
{
/// <summary>Resolves a stored hostname, which may be an address literal.</summary>
Task<IPAddress[]> ResolveAsync(string host, CancellationToken cancellationToken);
/// <summary>Opens a TCP connection to one address.</summary>
/// <returns>A stream that owns the connection.</returns>
Task<Stream> ConnectAsync(IPAddress address, int port, CancellationToken cancellationToken);
}
/// <summary>The operating system's resolver and sockets.</summary>
internal sealed class SystemRelayNetwork : IRelayNetwork
{
/// <inheritdoc />
public Task<IPAddress[]> ResolveAsync(string host, CancellationToken cancellationToken) =>
// A literal parses to itself without a lookup, which is what an address typed into a host
// editor should do — and what makes "10.0.0.5" mean the same thing on every node.
IPAddress.TryParse(host, out var literal)
? Task.FromResult<IPAddress[]>([literal])
: Dns.GetHostAddressesAsync(host, cancellationToken);
/// <inheritdoc />
public async Task<Stream> ConnectAsync(IPAddress address, int port, CancellationToken cancellationToken)
{
var socket = new Socket(address.AddressFamily, SocketType.Stream, ProtocolType.Tcp)
{
// An interactive shell is a stream of keystrokes; Nagle would hold each one back for the
// acknowledgement of the last, which is the latency the user feels as a sticky terminal.
NoDelay = true,
};
try
{
await socket.ConnectAsync(new IPEndPoint(address, port), cancellationToken).ConfigureAwait(false);
return new NetworkStream(socket, ownsSocket: true);
}
catch
{
socket.Dispose();
throw;
}
}
}
@@ -0,0 +1,111 @@
using DodoSSH.Api.Setup;
using Microsoft.Extensions.Options;
namespace DodoSSH.Api.Features.Relay;
/// <summary>
/// Counts the relay sessions open on this node, and refuses the ones over ADR 0004's limits.
/// </summary>
/// <remarks>
/// <para>
/// Per node, and so per user <em>per node</em>: a user behind a round-robin balancer with three nodes
/// could hold three times the per-user cap. That is accepted rather than fixed, because fixing it means
/// shared state on the hot path of every connect, and the cap exists to stop one account exhausting a
/// node — which a per-node count does exactly.
/// </para>
/// <para>
/// A singleton, because a session outlives the request that opened it. It holds counts and nothing else;
/// the sockets belong to the handlers that opened them.
/// </para>
/// </remarks>
internal sealed class RelaySessionRegistry(IOptions<RelayOptions> options)
{
private readonly Lock gate = new();
private readonly Dictionary<Guid, int> perUser = [];
private int total;
/// <summary>How many sessions are open on this node.</summary>
internal int Count
{
get
{
lock (gate)
{
return total;
}
}
}
/// <summary>Whether a session for this user would be admitted now.</summary>
/// <remarks>
/// Advisory, for the ticket endpoint: it lets a caller already at the cap hear so as an HTTP status
/// before it has spent a ticket, but only <see cref="TryAdmit"/> decides, since the answer here can
/// be stale by the time the socket arrives — possibly at another node.
/// </remarks>
internal bool HasRoomFor(Guid userId)
{
var settings = options.Value;
lock (gate)
{
return total < settings.MaxConcurrentSessionsTotal
&& perUser.GetValueOrDefault(userId) < settings.MaxConcurrentSessionsPerUser;
}
}
/// <summary>Admits a session, or answers null when a limit is met.</summary>
/// <returns>A lease that gives the place back when disposed.</returns>
internal Lease? TryAdmit(Guid userId)
{
var settings = options.Value;
lock (gate)
{
var held = perUser.GetValueOrDefault(userId);
if (total >= settings.MaxConcurrentSessionsTotal || held >= settings.MaxConcurrentSessionsPerUser)
{
return null;
}
perUser[userId] = held + 1;
total++;
return new Lease(this, userId);
}
}
private void Release(Guid userId)
{
lock (gate)
{
total--;
// Removed at zero rather than left behind, so the dictionary is the size of the users with a
// session open and not of every user who ever had one.
if (perUser[userId] <= 1)
{
perUser.Remove(userId);
}
else
{
perUser[userId]--;
}
}
}
/// <summary>One admitted session's place. Idempotent to dispose.</summary>
internal sealed class Lease(RelaySessionRegistry registry, Guid userId) : IDisposable
{
private int released;
/// <inheritdoc />
public void Dispose()
{
if (Interlocked.Exchange(ref released, 1) == 0)
{
registry.Release(userId);
}
}
}
}
@@ -0,0 +1,171 @@
using System.Net;
using System.Security.Cryptography;
using Microsoft.AspNetCore.DataProtection;
using Microsoft.AspNetCore.WebUtilities;
namespace DodoSSH.Api.Features.Relay;
/// <summary>
/// Everything the relay socket needs to know, decided by the ticket endpoint.
/// </summary>
/// <remarks>
/// The addresses are the resolved ones and the socket dials nothing else. There is no hostname for it
/// to resolve again — <see cref="TargetHost"/> is carried for the audit row only — which is what keeps a
/// DNS answer that changes between issue and connect from changing where the bytes go.
/// </remarks>
/// <param name="TicketId">The replay guard's key.</param>
/// <param name="SessionId">The audit row's id, already given to the client.</param>
/// <param name="UserId">Who asked.</param>
/// <param name="HostId">The host it is for.</param>
/// <param name="VaultId">The host's vault at issue.</param>
/// <param name="TargetHost">The hostname as stored, for the audit row.</param>
/// <param name="TargetAddresses">The permitted addresses the name resolved to, in the order to try.</param>
/// <param name="TargetPort">The port.</param>
/// <param name="ExpiresAt">When the ticket stops verifying.</param>
internal sealed record RelayTicket(
Guid TicketId,
Guid SessionId,
Guid UserId,
Guid HostId,
Guid VaultId,
string TargetHost,
IReadOnlyList<IPAddress> TargetAddresses,
int TargetPort,
DateTimeOffset ExpiresAt);
/// <summary>
/// Seals and opens relay tickets.
/// </summary>
/// <remarks>
/// <para>
/// A Data Protection payload, per ADR 0004: authenticated and encrypted, with key rotation handled by
/// the framework, and verifiable on any node that shares the key ring. Encrypted rather than merely
/// signed because the ticket travels in a header every proxy on the way can read, and what it holds is
/// the resolved address of a machine on the operator's network.
/// </para>
/// <para>
/// The expiry is inside the payload and checked against <see cref="TimeProvider"/>, rather than left to
/// the framework's time-limited protector, which reads the system clock directly — the thing this
/// repository bans so that time can be faked in tests.
/// </para>
/// <para>
/// The layout is a version byte and fixed fields, written by hand. Small enough that a serialiser would
/// be the larger half of the code, and a hand layout has no reflection for trimming to break.
/// </para>
/// </remarks>
internal sealed class RelayTicketCodec(IDataProtectionProvider protection, TimeProvider clock)
{
/// <summary>The purpose string, which isolates these payloads from every other protector's.</summary>
private const string Purpose = "DodoSSH.Relay.Ticket";
private const byte LayoutVersion = 1;
/// <summary>More addresses than any real name resolves to, and a bound on what a ticket can carry.</summary>
internal const int MaxAddresses = 16;
private readonly IDataProtector protector = protection.CreateProtector(Purpose);
internal string Seal(RelayTicket ticket)
{
ArgumentNullException.ThrowIfNull(ticket);
using var buffer = new MemoryStream();
using (var writer = new BinaryWriter(buffer))
{
writer.Write(LayoutVersion);
writer.Write(ticket.TicketId.ToByteArray());
writer.Write(ticket.SessionId.ToByteArray());
writer.Write(ticket.UserId.ToByteArray());
writer.Write(ticket.HostId.ToByteArray());
writer.Write(ticket.VaultId.ToByteArray());
writer.Write(ticket.ExpiresAt.ToUnixTimeMilliseconds());
writer.Write(ticket.TargetPort);
writer.Write(ticket.TargetHost);
writer.Write((byte)ticket.TargetAddresses.Count);
foreach (var address in ticket.TargetAddresses)
{
var bytes = address.GetAddressBytes();
writer.Write((byte)bytes.Length);
writer.Write(bytes);
}
}
// Base64url, whose alphabet is all token characters, so it can stand in a subprotocol name.
return WebEncoders.Base64UrlEncode(protector.Protect(buffer.ToArray()));
}
/// <summary>Opens a ticket, or answers null for one that is forged, damaged or expired.</summary>
/// <remarks>
/// One answer for all three, because the caller's remedy is the same — ask for another — and a
/// distinct "expired" would tell a forger which of their attempts had verified.
/// </remarks>
internal RelayTicket? TryOpen(string sealedTicket)
{
byte[] payload;
try
{
payload = protector.Unprotect(WebEncoders.Base64UrlDecode(sealedTicket));
}
catch (Exception exception) when (exception is CryptographicException or FormatException)
{
return null;
}
RelayTicket ticket;
try
{
ticket = Read(payload);
}
catch (Exception exception)
when (exception is EndOfStreamException or ArgumentException or FormatException)
{
return null;
}
return ticket.ExpiresAt > clock.GetUtcNow() ? ticket : null;
}
private static RelayTicket Read(byte[] payload)
{
using var reader = new BinaryReader(new MemoryStream(payload));
if (reader.ReadByte() != LayoutVersion)
{
throw new FormatException("Unknown ticket layout.");
}
var ticketId = new Guid(reader.ReadBytes(16));
var sessionId = new Guid(reader.ReadBytes(16));
var userId = new Guid(reader.ReadBytes(16));
var hostId = new Guid(reader.ReadBytes(16));
var vaultId = new Guid(reader.ReadBytes(16));
var expiresAt = DateTimeOffset.FromUnixTimeMilliseconds(reader.ReadInt64());
var port = reader.ReadInt32();
var host = reader.ReadString();
var count = reader.ReadByte();
if (count is 0 or > MaxAddresses)
{
throw new FormatException("A ticket names between one and sixteen addresses.");
}
var addresses = new IPAddress[count];
for (var index = 0; index < count; index++)
{
var length = reader.ReadByte();
if (length is not (4 or 16))
{
throw new FormatException("An address is four or sixteen bytes.");
}
addresses[index] = new IPAddress(reader.ReadBytes(length));
}
return new RelayTicket(ticketId, sessionId, userId, hostId, vaultId, host, addresses, port, expiresAt);
}
}
@@ -0,0 +1,231 @@
using System.Net;
using System.Net.Sockets;
using DodoSSH.Api.Authorization;
using DodoSSH.Api.Setup;
using DodoSSH.Contracts;
using DodoSSH.Domain.Authorization;
using DodoSSH.Infrastructure;
using FastEndpoints;
using Microsoft.AspNetCore.Http.HttpResults;
using Microsoft.EntityFrameworkCore;
using Microsoft.Extensions.Options;
namespace DodoSSH.Api.Features.Relay;
/// <summary>
/// Issues the ticket that lets exactly one relay socket reach exactly one host.
/// </summary>
/// <remarks>
/// <para>
/// Every decision the relay makes is made here, with the full bearer token and the full access model in
/// hand: which host, whether the caller may connect to it, which addresses its name resolves to and
/// which of those the policy permits. The socket that follows decides nothing. It checks that the ticket
/// is genuine, fresh and unused, and dials what the ticket says. See ADR 0004.
/// </para>
/// <para>
/// <b>Every refusal about the target is the same refusal.</b> A host that does not exist, one in a vault
/// the caller cannot reach, one without the relay switched on, one whose name does not resolve, and one
/// whose every address the policy refuses all answer 403 <c>relay-target-rejected</c> with the same
/// sentence. Anyone who can write a host can set its address to anything, so a distinct answer for
/// "resolves, but refused" would turn this endpoint into a scanner for the operator's internal DNS. The
/// real reason goes to the server log, where the operator can read it.
/// </para>
/// </remarks>
internal sealed class RelayTicketEndpoint(
ICurrentUserContext currentUser,
IVaultAccessService vaultAccess,
DodoDbContext database,
IRelayNetwork network,
RelayTicketCodec codec,
RelaySessionRegistry sessions,
IOptions<RelayOptions> options,
TimeProvider clock,
ILogger<RelayTicketEndpoint> logger)
: Endpoint<RelayTicketRequest, Results<Ok<RelayTicketResponse>, ProblemHttpResult>>
{
/// <summary>What every target refusal says, whatever the reason was.</summary>
private const string RejectedDetail =
"The relay will not connect to this host. Check that the relay is switched on for it and that its "
+ "address is one this server may reach; the server's log records which.";
/// <inheritdoc />
public override void Configure()
{
Post(RelayProtocol.TicketsPath);
// Enrolled, matching sync. A relayed host is still a host whose name, username and key are
// ciphertext, so a caller with no identity key has no way to have learned which host to ask for.
Policies(Auth.EnrolledPolicy);
Description(b => b
.WithName("IssueRelayTicket")
.WithSummary("Issues a single-use ticket for one relay connection to one host.")
.WithTags("Relay"));
}
/// <inheritdoc />
public override async Task<Results<Ok<RelayTicketResponse>, ProblemHttpResult>> ExecuteAsync(
RelayTicketRequest req,
CancellationToken ct)
{
var settings = options.Value;
if (!settings.Enabled)
{
return Problems.Coded(
StatusCodes.Status404NotFound,
ProblemCodes.RelayUnavailable,
"This server does not relay. Connect to the host directly; GET /api/v1/meta lists the "
+ "features this server does offer.");
}
var user = await currentUser.GetOrProvisionAsync(ct).ConfigureAwait(false);
var (target, refusal) = await FindTargetAsync(user.Id, req, ct).ConfigureAwait(false);
if (target is not var (hostname, port, vaultId))
{
return Rejected(user.Id, req.HostId, refusal!);
}
// Before resolving rather than after: a caller already at the cap is told so without this server
// spending a DNS query on a ticket that could not be redeemed.
if (!sessions.HasRoomFor(user.Id))
{
RelayLog.LimitReached(logger, user.Id, sessions.Count);
return Problems.Coded(
StatusCodes.Status429TooManyRequests,
ProblemCodes.RelayLimitReached,
"You have as many relay sessions open as this server allows. Close one and try again.");
}
var addresses = await ResolvePermittedAsync(hostname, ct).ConfigureAwait(false);
if (addresses is not { Length: > 0 })
{
return Rejected(user.Id, req.HostId, addresses is null
? "its name did not resolve"
: "every address its name resolved to is refused by policy");
}
var ticket = new RelayTicket(
TicketId: Guid.CreateVersion7(),
SessionId: Guid.CreateVersion7(),
UserId: user.Id,
HostId: req.HostId,
VaultId: vaultId,
TargetHost: hostname,
TargetAddresses: addresses,
TargetPort: port,
ExpiresAt: clock.GetUtcNow() + settings.TicketLifetime);
RelayLog.TicketIssued(logger, user.Id, req.HostId, ticket.SessionId, addresses.Length);
return TypedResults.Ok(new RelayTicketResponse(
Ticket: codec.Seal(ticket),
WebSocketUrl: new Uri(settings.WebSocketUrl!, UriKind.Absolute),
SubProtocol: RelayProtocol.SubProtocol,
SessionId: ticket.SessionId,
ExpiresAt: ticket.ExpiresAt));
}
/// <summary>
/// Finds the host, and decides whether this caller may be relayed to it at all.
/// </summary>
/// <returns>The stored target, or the reason there is none — for the log, never for the caller.</returns>
private async Task<((string Hostname, int Port, Guid VaultId)? Target, string? Refusal)> FindTargetAsync(
Guid userId,
RelayTicketRequest req,
CancellationToken cancellationToken)
{
if (req.PortForwardId is not null)
{
return (null, "a port forward was requested, which v1 does not relay");
}
var host = await database.Hosts
.AsNoTracking()
.SingleOrDefaultAsync(h => h.Id == req.HostId && h.DeletedAtUtc == null, cancellationToken)
.ConfigureAwait(false);
if (host is null)
{
return (null, "no such host");
}
var access = await vaultAccess.ResolveAsync(userId, host.VaultId, cancellationToken).ConfigureAwait(false);
// Connect rather than Read, because Connect is the permission that says what this is. Every role
// that reads today also connects — see VaultAccessService.ForRole — but a role that ever split
// them should be refused a relay here without anybody remembering to look.
if (!access.Granted || !access.Permissions.HasFlag(PermissionFlags.Connect))
{
return (null, "the caller may not connect to this host's vault");
}
// The CHECK constraint makes the second half unreachable while the first is true. Tested anyway,
// because the cost of trusting it is dialling a null.
if (!host.RelayEnabled || host.Hostname is not { } hostname || host.Port is not { } port)
{
return (null, "the relay is not switched on for this host");
}
return RelayAddressPolicy.PermitsPort(port)
? ((hostname, port, host.VaultId), null)
: (null, $"port {port} is refused by policy");
}
/// <summary>
/// Resolves the stored name, and keeps the addresses the policy permits.
/// </summary>
/// <returns>The permitted addresses, possibly none; or null when the name did not resolve.</returns>
/// <remarks>
/// <para>
/// Filtered rather than refused as a whole when one answer is bad. A name that resolves to a public
/// address and a link-local one is dialled on the public address, and never on the other — the
/// ticket carries only what passed, so there is nothing else for the socket to try.
/// </para>
/// <para>
/// The addresses kept are the normalised ones, so what is dialled is exactly what was judged rather
/// than a second spelling of it.
/// </para>
/// </remarks>
private async Task<IPAddress[]?> ResolvePermittedAsync(string hostname, CancellationToken cancellationToken)
{
var policy = new RelayAddressPolicy(options.Value);
using var timeout = CancellationTokenSource.CreateLinkedTokenSource(cancellationToken);
timeout.CancelAfter(options.Value.ConnectTimeout);
IPAddress[] resolved;
try
{
resolved = await network.ResolveAsync(hostname, timeout.Token).ConfigureAwait(false);
}
catch (SocketException)
{
return null;
}
catch (OperationCanceledException) when (!cancellationToken.IsCancellationRequested)
{
return null;
}
return
[
.. resolved
.Where(policy.Permits)
.Select(RelayAddressPolicy.Normalise)
.Distinct()
.Take(RelayTicketCodec.MaxAddresses),
];
}
private ProblemHttpResult Rejected(Guid userId, Guid hostId, string reason)
{
RelayLog.TargetRejected(logger, userId, hostId, reason);
return Problems.Coded(StatusCodes.Status403Forbidden, ProblemCodes.RelayTargetRejected, RejectedDetail);
}
}
+3
View File
@@ -49,6 +49,9 @@ builder.Services.AddSingleton<VaultEventHub>();
builder.Services.AddSingleton<IVaultEventPublisher>( builder.Services.AddSingleton<IVaultEventPublisher>(
provider => provider.GetRequiredService<VaultEventHub>()); provider => provider.GetRequiredService<VaultEventHub>());
// The relay's services, its ticket key ring, and a shutdown long enough for its drain. See ADR 0004.
builder.Services.AddDodoRelay();
// Scoped rather than the AddAuthorization default of singleton: the handler reads the request's // Scoped rather than the AddAuthorization default of singleton: the handler reads the request's
// DbContext, and a singleton would capture one for the lifetime of the process. // DbContext, and a singleton would capture one for the lifetime of the process.
builder.Services.AddScoped<IAuthorizationHandler, EnrolledHandler>(); builder.Services.AddScoped<IAuthorizationHandler, EnrolledHandler>();
+27 -3
View File
@@ -54,6 +54,13 @@ internal static class Configuration
+ "setting exists to provide.") + "setting exists to provide.")
.ValidateOnStart(); .ValidateOnStart();
services.AddRelayOptions();
return services;
}
/// <summary>The relay's options, which carry more rules than any other section. See ADR 0004.</summary>
private static void AddRelayOptions(this IServiceCollection services) =>
services.AddOptions<RelayOptions>() services.AddOptions<RelayOptions>()
.BindConfiguration(RelayOptions.SectionName) .BindConfiguration(RelayOptions.SectionName)
.ValidateDataAnnotations() .ValidateDataAnnotations()
@@ -63,11 +70,28 @@ internal static class Configuration
.Validate( .Validate(
options => options.IdleTimeout < options.MaxSessionDuration, options => options.IdleTimeout < options.MaxSessionDuration,
"Relay:IdleTimeout must be shorter than Relay:MaxSessionDuration.") "Relay:IdleTimeout must be shorter than Relay:MaxSessionDuration.")
.Validate(
options => options.TicketLifetime > TimeSpan.Zero
&& options.TicketLifetime <= TimeSpan.FromSeconds(30),
"Relay:TicketLifetime must be positive and at most 30 seconds. A ticket is a bearer "
+ "credential in a header; ADR 0004 bounds how long one may be worth stealing.")
.Validate(
options => options.ConnectTimeout > TimeSpan.Zero && options.DrainTimeout >= TimeSpan.Zero,
"Relay:ConnectTimeout must be positive and Relay:DrainTimeout must not be negative.")
.Validate(
options => Features.Relay.RelayAddressPolicy.AreNetworks(options.AllowedNetworks)
&& Features.Relay.RelayAddressPolicy.AreNetworks(options.DeniedNetworks),
"Relay:AllowedNetworks and Relay:DeniedNetworks must hold CIDR networks such as "
+ "10.20.0.0/16, with no host bits set. An entry this server cannot read would be a gap "
+ "the operator believes is closed.")
.Validate(
options => !options.Enabled
|| (Uri.TryCreate(options.WebSocketUrl, UriKind.Absolute, out var url)
&& (string.Equals(url.Scheme, Uri.UriSchemeWs, StringComparison.Ordinal)
|| string.Equals(url.Scheme, Uri.UriSchemeWss, StringComparison.Ordinal))),
"Relay:WebSocketUrl must be an absolute ws:// or wss:// URL.")
.ValidateOnStart(); .ValidateOnStart();
return services;
}
/// <summary> /// <summary>
/// Warns about configuration that is individually valid but dangerous in combination. /// Warns about configuration that is individually valid but dangerous in combination.
/// </summary> /// </summary>
+39 -2
View File
@@ -115,13 +115,50 @@ public sealed class RelayOptions
/// Whether RFC1918 and other private ranges may be dialled. /// Whether RFC1918 and other private ranges may be dialled.
/// </summary> /// </summary>
/// <remarks> /// <remarks>
/// <para>
/// Defaults to true, unlike a typical SSRF allow-list, because reaching private /// Defaults to true, unlike a typical SSRF allow-list, because reaching private
/// infrastructure is the entire purpose of a self-hosted SSH tool. The control that matters is /// infrastructure is the entire purpose of a self-hosted SSH tool. The control that matters is
/// the ACL: only hosts in a vault the caller holds Connect on can be dialled at all. Loopback, /// the ACL: only hosts in a vault the caller holds Connect on can be dialled at all.
/// link-local and cloud metadata ranges are denied unconditionally and are not configurable. /// </para>
/// <para>
/// Governs the private ranges only — RFC1918, carrier-grade NAT (which is where a Tailnet lives) and
/// IPv6 unique-local — and never the list <c>RelayAddressPolicy</c> refuses with no configuration
/// escape: loopback, link-local, <c>0.0.0.0/8</c>, multicast and the cloud metadata addresses.
/// Nothing here can re-open those, which is what ADR 0004 §3 means by non-overridable.
/// </para>
/// </remarks> /// </remarks>
public bool AllowPrivateNetworks { get; set; } = true; public bool AllowPrivateNetworks { get; set; } = true;
/// <summary>
/// Networks, in CIDR form, that a relay target must fall inside. Empty means any network the other
/// rules permit.
/// </summary>
/// <remarks>
/// When set, this is the whole answer for the ranges it names: a target inside one is permitted even
/// with <see cref="AllowPrivateNetworks"/> off, because "only 10.20.0.0/16" is the precise thing an
/// operator means by setting both. It still cannot reach the non-overridable list, and
/// <see cref="DeniedNetworks"/> still wins over it.
/// </remarks>
public IList<string> AllowedNetworks { get; } = [];
/// <summary>Networks, in CIDR form, that a relay target may never fall inside.</summary>
/// <remarks>
/// Checked before <see cref="AllowedNetworks"/>, so a deny inside an allow is a hole in it — the way
/// round that lets an operator carve the database subnet out of an otherwise permitted range.
/// </remarks>
public IList<string> DeniedNetworks { get; } = [];
/// <summary>
/// A directory to keep the ticket key ring in. Unset means the platform default.
/// </summary>
/// <remarks>
/// Losing the key ring is harmless in the way losing <c>Sync:CursorSigningKey</c> is: a ticket lives
/// thirty seconds, so a restart invalidates at most the connects in flight and the client asks
/// again. What does need it is more than one node — every node must be able to read every other's
/// tickets for round-robin to work, so a multi-node deployment points this at shared storage.
/// </remarks>
public string? KeyRingDirectory { get; set; }
/// <summary>Maximum concurrent sessions per user.</summary> /// <summary>Maximum concurrent sessions per user.</summary>
[Range(1, 1000)] [Range(1, 1000)]
public int MaxConcurrentSessionsPerUser { get; set; } = 10; public int MaxConcurrentSessionsPerUser { get; set; } = 10;
@@ -1,6 +1,7 @@
using DodoSSH.Api.Features.Events; using DodoSSH.Api.Features.Events;
using DodoSSH.Api.Features.Identity; using DodoSSH.Api.Features.Identity;
using DodoSSH.Api.Features.Meta; using DodoSSH.Api.Features.Meta;
using DodoSSH.Api.Features.Relay;
using DodoSSH.Api.Features.Sync; using DodoSSH.Api.Features.Sync;
using DodoSSH.Api.Features.Teams; using DodoSSH.Api.Features.Teams;
using DodoSSH.Contracts; using DodoSSH.Contracts;
@@ -45,6 +46,8 @@ internal static class EndpointRegistration
typeof(SyncPullEndpoint), typeof(SyncPullEndpoint),
typeof(SyncPushEndpoint), typeof(SyncPushEndpoint),
typeof(VaultEventsEndpoint), typeof(VaultEventsEndpoint),
typeof(RelayTicketEndpoint),
typeof(RelayConnectEndpoint),
typeof(CreateTeamEndpoint), typeof(CreateTeamEndpoint),
typeof(ListTeamsEndpoint), typeof(ListTeamsEndpoint),
typeof(UpdateTeamEndpoint), typeof(UpdateTeamEndpoint),
@@ -65,7 +68,6 @@ internal static class EndpointRegistration
// Registered as each feature lands: // Registered as each feature lands:
// Identity — key rotation, passphrase change // Identity — key rotation, passphrase change
// Vaults — per-item ACLs // Vaults — per-item ACLs
// Relay — tickets and the WebSocket
// Audit, Admin // Audit, Admin
}); });
+59
View File
@@ -0,0 +1,59 @@
using DodoSSH.Api.Features.Relay;
using Microsoft.AspNetCore.DataProtection;
using Microsoft.AspNetCore.DataProtection.KeyManagement;
using Microsoft.AspNetCore.DataProtection.Repositories;
using Microsoft.Extensions.Options;
namespace DodoSSH.Api.Setup;
/// <summary>The relay's services. See ADR 0004.</summary>
internal static class RelaySetup
{
/// <summary>
/// How much longer than the drain the host waits before it stops regardless.
/// </summary>
/// <remarks>
/// Room for the close handshakes and the audit rows' final writes once the drain has run out, which
/// is the part of a shutdown an operator would otherwise lose without noticing.
/// </remarks>
private static readonly TimeSpan ShutdownMargin = TimeSpan.FromSeconds(10);
internal static IServiceCollection AddDodoRelay(this IServiceCollection services)
{
// Singletons: a session outlives the request that opened it, a protector is safe to share, and
// the network seam holds no state.
services.AddSingleton<RelayTicketCodec>();
services.AddSingleton<RelaySessionRegistry>();
services.AddSingleton<IRelayNetwork, SystemRelayNetwork>();
// The application name isolates this deployment's payloads from any other ASP.NET application
// sharing a key directory, and — unlike the default, which is derived from the content root —
// is the same on every node, which is what lets any node verify any node's ticket.
services.AddDataProtection().SetApplicationName("DodoSSH");
services.AddOptions<KeyManagementOptions>()
.Configure<IOptions<RelayOptions>, ILoggerFactory>((keys, relay, loggers) =>
{
if (relay.Value.KeyRingDirectory is { Length: > 0 } directory)
{
keys.XmlRepository = new FileSystemXmlRepository(new DirectoryInfo(directory), loggers);
}
});
// Longer than the drain, or the host would stop waiting for live sessions before the drain ADR 0004
// promises them had run. Harmless with the relay off: nothing else holds a request open that long,
// and the host stops as soon as the last request has.
services.AddOptions<HostOptions>()
.Configure<IOptions<RelayOptions>>((host, relay) =>
{
var wanted = relay.Value.DrainTimeout + ShutdownMargin;
if (wanted > host.ShutdownTimeout)
{
host.ShutdownTimeout = wanted;
}
});
return services;
}
}
@@ -1199,19 +1199,18 @@
port into plaintext columns the server can read, which is the single deliberate concession in port into plaintext columns the server can read, which is the single deliberate concession in
the design — see ADR 0004 — so it says so rather than being a switch labelled "relay". the design — see ADR 0004 — so it says so rather than being a switch labelled "relay".
◆ AND IT SAYS, FIRST, THAT IT BUYS NOTHING TODAY. The relay's server half is built and this It also says the two things a user would otherwise find out by failing: the server, not this
client has no path to it — the connect path dials the address directly whether this is ticked or phone, has to be able to reach the address, and a relayed host does not fall back to dialling
not — so the box as it stood spent that concession and delivered nothing for it. Left tickable directly, so it connects only while the server is reachable. See
rather than disabled, so a host already carrying the flag can lose it. See
docs/reaching-a-host-you-cannot-dial.md. docs/reaching-a-host-you-cannot-dial.md.
--> -->
<CheckBox IsChecked="{Binding EditorRelayEnabled}" MinHeight="44"> <CheckBox IsChecked="{Binding EditorRelayEnabled}" MinHeight="44">
<TextBlock Classes="mono" FontSize="11.5" <TextBlock Classes="mono" FontSize="11.5"
Text="Reach this host through the server relay (not wired up yet)" Text="Reach this host through the server relay"
TextWrapping="Wrap" /> TextWrapping="Wrap" />
</CheckBox> </CheckBox>
<TextBlock Classes="body" <TextBlock Classes="body"
Text="Not built yet: this app always dials the host itself, so ticking this stores the address on the server and changes nothing about how the host is reached. When it works, the relay will dial on your behalf — which is why the address and port have to be stored in the clear. Everything else about the host stays encrypted either way, and a relayed host needs a port of its own rather than its group's." /> Text="The server dials this host on your behalf, for a machine this phone cannot reach — so the server has to be able to reach it. That is why the address and port are stored on the server in the clear; everything else about the host stays encrypted. A relayed host needs a port of its own rather than its group's, and connects only while you are online." />
<!-- <!--
This page covers the whole screen while it is open, which is why it needs a Status line of its This page covers the whole screen while it is open, which is why it needs a Status line of its
+31 -1
View File
@@ -259,6 +259,22 @@ public interface ISyncApi
CancellationToken cancellationToken); CancellationToken cancellationToken);
} }
/// <summary>Asks the server for leave to relay one connection to one host.</summary>
/// <remarks>
/// The request names a host and nothing else. Where it is, and whether this caller may reach it, is the
/// server's decision, made from its own copy of the host's relay address — which is what keeps the relay
/// from being an open proxy that a client points wherever it likes. See ADR 0004.
/// </remarks>
public interface IRelayApi
{
/// <summary>Issues a single-use ticket, good for thirty seconds, for one relay socket to this host.</summary>
/// <exception cref="DodoSshApiException">
/// The server refused: <c>relay-unavailable</c>, <c>relay-target-rejected</c> or
/// <c>relay-limit-reached</c>, each with its own remedy.
/// </exception>
Task<RelayTicketResponse> IssueRelayTicketAsync(Guid hostId, CancellationToken cancellationToken);
}
/// <summary> /// <summary>
/// The typed client for one DodoSSH server. /// The typed client for one DodoSSH server.
/// </summary> /// </summary>
@@ -275,7 +291,7 @@ public interface ISyncApi
/// </para> /// </para>
/// </remarks> /// </remarks>
public sealed class DodoSshApiClient(HttpClient http, IAccessTokenProvider tokens) public sealed class DodoSshApiClient(HttpClient http, IAccessTokenProvider tokens)
: IAccountApi, ISyncApi, ITeamApi, IDirectoryApi, IVaultGrantApi : IAccountApi, ISyncApi, ITeamApi, IDirectoryApi, IVaultGrantApi, IRelayApi
{ {
private const string MetaPath = "/api/v1/meta"; private const string MetaPath = "/api/v1/meta";
private const string ConfigurationPath = "/.well-known/dodossh-configuration"; private const string ConfigurationPath = "/.well-known/dodossh-configuration";
@@ -310,6 +326,20 @@ public sealed class DodoSshApiClient(HttpClient http, IAccessTokenProvider token
DodoSshJsonContext.Default.DodoSshConfiguration, DodoSshJsonContext.Default.DodoSshConfiguration,
cancellationToken); cancellationToken);
/// <inheritdoc />
/// <remarks>
/// Never cached, and never fetched ahead of need: a ticket is spent by the socket it opens and is
/// worthless thirty seconds after issue, so the only right moment to ask for one is the connect that
/// will use it.
/// </remarks>
public Task<RelayTicketResponse> IssueRelayTicketAsync(Guid hostId, CancellationToken cancellationToken) =>
SendAsync(
HttpMethod.Post,
RelayProtocol.TicketsPath,
JsonContent.Create(new RelayTicketRequest(hostId, PortForwardId: null), DodoSshJsonContext.Default.RelayTicketRequest),
DodoSshJsonContext.Default.RelayTicketResponse,
cancellationToken);
/// <summary> /// <summary>
/// Reads the caller's profile, unlock material and reachable vaults. /// Reads the caller's profile, unlock material and reachable vaults.
/// </summary> /// </summary>
@@ -111,13 +111,33 @@
<StackPanel VerticalAlignment="Center" HorizontalAlignment="Center" Spacing="18" MaxWidth="460" <StackPanel VerticalAlignment="Center" HorizontalAlignment="Center" Spacing="18" MaxWidth="460"
Margin="24"> Margin="24">
<!--
Which machine, and at what address. Both selectable, for the reason the session column's own address
is — see SessionSidebar.axaml: a TextBlock in Avalonia is a drawing of a string rather than a string,
and this pair is the one place the shell says what it is dialling *before* anything has answered.
That is exactly when the value is wanted somewhere else: in a ticket, in a message to whoever owns
the host, in the ssh command being written in the window beside this one. It is also the moment it is
least available anywhere else, because there is no prompt yet and may never be one — a refused
connection leaves this card holding the only copy on screen.
Both rather than only the name. They are two lines of one identifier, and a pair where the first can
be taken and the second cannot is a worse answer than either.
The trimming stays, and the tooltips are what make it safe rather than a trap. A drag reaches only
the glyphs that were drawn, so a name or an address wearing an ellipsis has to be taken with
select-all — Ctrl+A, then Ctrl+C — which takes the whole value, because the ellipsis is a drawing and
not a shorter string. The hover says what the whole value is, so nobody copies half of one without
having been told there is a half. Same argument, same shape, as the sidebar's.
-->
<StackPanel Spacing="6" HorizontalAlignment="Center"> <StackPanel Spacing="6" HorizontalAlignment="Center">
<TextBlock Classes="mono" Text="{Binding SelectedTab.Label}" FontSize="16" FontWeight="Medium" <SelectableTextBlock Classes="mono" Text="{Binding SelectedTab.Label}" FontSize="16"
Foreground="{StaticResource Text}" HorizontalAlignment="Center" FontWeight="Medium" Foreground="{StaticResource Text}"
TextTrimming="CharacterEllipsis" /> HorizontalAlignment="Center" TextTrimming="CharacterEllipsis"
<TextBlock Classes="mono" Text="{Binding SelectedTab.Address}" FontSize="11.5" ToolTip.Tip="{Binding SelectedTab.Label}" />
Foreground="{StaticResource TextFaint}" HorizontalAlignment="Center" <SelectableTextBlock Classes="mono" Text="{Binding SelectedTab.Address}" FontSize="11.5"
TextTrimming="CharacterEllipsis" /> Foreground="{StaticResource TextFaint}" HorizontalAlignment="Center"
TextTrimming="CharacterEllipsis"
ToolTip.Tip="{Binding SelectedTab.Address}" />
</StackPanel> </StackPanel>
<!-- <!--
+9 -16
View File
@@ -636,16 +636,15 @@
<!-- <!--
◆ THE RELAY CARD, restyled to the mock's nested-card shape — radius 12, a checkbox with the ◆ THE RELAY CARD, restyled to the mock's nested-card shape — radius 12, a checkbox with the
title beside it rather than under it — but NOT to the mock's copy. The sentence stays title beside it rather than under it. The "(not wired up yet)" this title carried while the
exactly what it was, "(not wired up yet)" included: the design's own wording implies a relay client had no path to the relay is gone, because it has one: a relayed host is connected
this client can dial, and it cannot. See the remark under the hint below, which is unchanged through a ticket, a WebSocket and a loopback bridge. See docs/reaching-a-host-you-cannot-dial.md.
and still the reason this box says what it says.
--> -->
<Border CornerRadius="12" Background="{StaticResource Field}" <Border CornerRadius="12" Background="{StaticResource Field}"
BorderBrush="{StaticResource Border}" BorderThickness="1" Padding="12"> BorderBrush="{StaticResource Border}" BorderThickness="1" Padding="12">
<StackPanel Spacing="6"> <StackPanel Spacing="6">
<CheckBox IsChecked="{Binding EditorRelayEnabled}" VerticalContentAlignment="Center"> <CheckBox IsChecked="{Binding EditorRelayEnabled}" VerticalContentAlignment="Center">
<TextBlock Text="Connect through the server relay (not wired up yet)" FontSize="13" <TextBlock Text="Connect through the server relay" FontSize="13"
FontWeight="SemiBold" Foreground="{StaticResource Text}" FontWeight="SemiBold" Foreground="{StaticResource Text}"
TextWrapping="Wrap" /> TextWrapping="Wrap" />
</CheckBox> </CheckBox>
@@ -655,19 +654,13 @@
to resolve the target, or it becomes an authenticated open proxy into the operator's to resolve the target, or it becomes an authenticated open proxy into the operator's
network. network.
◆ AND IT SAYS, FIRST, THAT TICKING IT BUYS NOTHING TODAY. The server half of the relay It also says the two things a user would otherwise find out by failing: the server,
is built and this client has no path to it: VaultViewModel dials the address directly not this machine, has to be able to reach the address — the relay is no help against a
whether this is ticked or not. So the box as it stood spent the one deliberate privacy deployment outside the target's network — and a relayed host does not fall back to
concession in the design — the address in plaintext columns — and delivered a dialling directly, so it connects only while the server is reachable.
connection that failed exactly as it had before, with nothing saying why.
Left tickable rather than disabled, because a host that already carries the flag has to
be able to lose it, and a disabled control would trap the concession on. See
docs/reaching-a-host-you-cannot-dial.md, which is the plan that makes this sentence
removable.
--> -->
<TextBlock Classes="hint" FontSize="11.5" <TextBlock Classes="hint" FontSize="11.5"
Text="Not built yet: this client always dials the host itself, so ticking this stores the address on the server and changes nothing about how the host is reached. When it does work, the relay will dial on your behalf — which is why the address and port have to be stored in plain text. Everything else about the host stays encrypted either way." /> Text="The server dials this host on your behalf, for a machine this computer cannot reach — so the server has to be able to reach it. That is why the address and port are stored on the server in plain text; everything else about the host stays encrypted. A relayed host connects only while you are online." />
</StackPanel> </StackPanel>
</Border> </Border>
@@ -10,7 +10,7 @@
CanResize="False" CanResize="False"
WindowStartupLocation="CenterScreen" WindowStartupLocation="CenterScreen"
Background="{StaticResource Chrome}" Background="{StaticResource Chrome}"
SystemDecorations="None"> WindowDecorations="None">
<!-- <!--
── WHY THERE IS A SPLASH AT ALL ─────────────────────────────────────────────────────────────────────── ── WHY THERE IS A SPLASH AT ALL ───────────────────────────────────────────────────────────────────────
@@ -30,8 +30,10 @@
look to find out whether anything is happening says nothing. It is a window, briefly, and behaves like look to find out whether anything is happening says nothing. It is a window, briefly, and behaves like
one. one.
SystemDecorations="None" rather than BorderOnly, which the main window uses: this cannot be resized, has WindowDecorations="None" rather than the BorderOnly the main window asks for: this cannot be resized, has
no titlebar of its own to drag by, and lives for about a second. What replaces the frame is the card's no titlebar of its own to drag by, and lives for about a second. (The main window still says
SystemDecorations, which Avalonia 12 has deprecated in favour of this property; that one is not this
change's to move.) What replaces the frame is the card's
own one-pixel border. Escape closes it only once there is nothing left to wait for — see the code-behind. own one-pixel border. Escape closes it only once there is nothing left to wait for — see the code-behind.
── SizeToContent, WHICH IS ABOUT THE FAILURE AND NOT ABOUT THE SPLASH ───────────────────────────────── ── SizeToContent, WHICH IS ABOUT THE FAILURE AND NOT ABOUT THE SPLASH ─────────────────────────────────
@@ -36,6 +36,8 @@
<ItemGroup> <ItemGroup>
<InternalsVisibleTo Include="DodoSSH.Client.Session.Tests" /> <InternalsVisibleTo Include="DodoSSH.Client.Session.Tests" />
<!-- The shell suite drives a real ServerRelay over an in-process socket through its test constructor. -->
<InternalsVisibleTo Include="DodoSSH.Client.App.Tests" />
</ItemGroup> </ItemGroup>
</Project> </Project>
@@ -161,6 +161,15 @@ public interface IVaultServer : IDisposable
/// </remarks> /// </remarks>
IVaultEventStream Events { get; } IVaultEventStream Events { get; }
/// <summary>
/// Reaches a host through the server, for a host set to connect that way.
/// </summary>
/// <remarks>
/// Never null, for the reason <see cref="Events"/> is not: a server without a relay supplies
/// <see cref="UnavailableServerRelay"/>, which refuses in words. See ADR 0004.
/// </remarks>
IServerRelay Relay { get; }
/// <summary>Obtains the identity provider's signature over a key statement.</summary> /// <summary>Obtains the identity provider's signature over a key statement.</summary>
IKeyBindingAuthorizer KeyBinding { get; } IKeyBindingAuthorizer KeyBinding { get; }
@@ -226,6 +235,12 @@ public sealed class ServerConnection : IVaultServer
Events = meta.Features.Contains(VaultEvents.Feature, StringComparer.Ordinal) Events = meta.Features.Contains(VaultEvents.Feature, StringComparer.Ordinal)
? new VaultEventStream(serverUrl, tokens, clock) ? new VaultEventStream(serverUrl, tokens, clock)
: IdleVaultEventStream.Instance; : IdleVaultEventStream.Instance;
// Decided the same way and for the same reason. Configuration.Relay says the same thing twice;
// meta is what the server says it does, and is what Events is decided from.
Relay = meta.Features.Contains(RelayProtocol.Feature, StringComparer.Ordinal)
? new ServerRelay(api)
: UnavailableServerRelay.Instance;
} }
/// <summary>The server this is connected to.</summary> /// <summary>The server this is connected to.</summary>
@@ -261,6 +276,9 @@ public sealed class ServerConnection : IVaultServer
/// <inheritdoc /> /// <inheritdoc />
public IVaultEventStream Events { get; } public IVaultEventStream Events { get; }
/// <inheritdoc />
public IServerRelay Relay { get; }
/// <inheritdoc /> /// <inheritdoc />
public IKeyBindingAuthorizer KeyBinding => Oidc; public IKeyBindingAuthorizer KeyBinding => Oidc;
+262
View File
@@ -0,0 +1,262 @@
using System.Net;
using System.Net.WebSockets;
using DodoSSH.Client.Api;
using DodoSSH.Client.Ssh;
using DodoSSH.Contracts;
namespace DodoSSH.Client.Session;
/// <summary>
/// Reaches a host through the server, for a host this machine cannot dial itself.
/// </summary>
/// <remarks>
/// Always present on <see cref="IVaultServer"/>, like <see cref="IVaultServer.Events"/>: a server that does
/// not relay supplies <see cref="UnavailableServerRelay"/>, whose answer is a sentence saying so. That keeps
/// the connect path on one shape, and it means the refusal a user reads is the same whether the server said
/// no before being asked or when it was.
/// </remarks>
public interface IServerRelay
{
/// <summary>Whether this server advertises a relay at all.</summary>
bool IsOffered { get; }
/// <summary>
/// Opens a relay to one host, ready for a connection to be made through it.
/// </summary>
/// <remarks>
/// Asks for a ticket, opens the socket and starts the bridge, in that order and at once — the ticket is
/// spent by the socket and dead thirty seconds after issue, so this is called by the connect that will
/// use it and never ahead of one.
/// </remarks>
/// <exception cref="ServerRelayException">The relay could not be opened; the message says why.</exception>
Task<RelayRoute> OpenAsync(Guid hostId, CancellationToken cancellationToken);
}
/// <summary>
/// An open relay, one connection long.
/// </summary>
/// <remarks>
/// Handing <see cref="Proxy"/> to a connection hands the bridge over with it, so the connection's own
/// disposal is what closes the relay. <see cref="DisposeAsync"/> is for a caller that ends up not
/// connecting; after a hand-over it does nothing, because the bridge's disposal is idempotent.
/// </remarks>
public sealed class RelayRoute : IAsyncDisposable
{
private readonly RelayBridge bridge;
internal RelayRoute(RelayBridge bridge) => this.bridge = bridge;
/// <summary>The loopback proxy to connect through, which owns the relay from then on.</summary>
public SshLoopbackProxy Proxy => bridge.Proxy;
/// <summary>
/// What the relay said when it closed, in words a user can act on; null when it has not closed, or
/// closed with nothing to say.
/// </summary>
/// <remarks>
/// For a connect that failed. SSH.NET reports a relay that hung up as a stream that ended — which reads
/// exactly like the direct connection that failed and sent the user to the relay — so the relay's own
/// reason, when it gave one, replaces it.
/// </remarks>
public string? Failure => bridge.CloseStatus is { } status ? Describe((int)status) : null;
/// <inheritdoc />
public ValueTask DisposeAsync() => bridge.DisposeAsync();
private static string? Describe(int code) => code switch
{
RelayProtocol.TargetUnreachableCloseCode =>
"The server relay could not reach this host. The server dials it on your behalf, so the "
+ "address has to be one the server can reach — check it from the server's side.",
RelayProtocol.TooManySessionsCloseCode =>
"The server relay has as many sessions open as it allows. Close one and try again.",
(int)WebSocketCloseStatus.EndpointUnavailable =>
"The server relay is restarting. Try again in a moment.",
RelayProtocol.IdleTimeoutCloseCode => "The server relay closed the connection for being idle.",
RelayProtocol.DurationLimitCloseCode =>
"The server relay closed the connection: it reached the longest session the server allows.",
_ => null,
};
}
/// <summary>A relay that could not be opened, with the reason in its message.</summary>
/// <remarks>
/// Its own type so the connect path can tell a relay refusal from a connection failure. The first has an
/// exact reason already, and running the reachability probe over it would dial the direct address — the one
/// the user chose the relay because they cannot reach — and append a finding about the wrong path.
/// </remarks>
public sealed class ServerRelayException : Exception
{
/// <summary>A refusal with nothing underneath it.</summary>
public ServerRelayException(string message)
: base(message)
{
}
/// <summary>A refusal and what caused it.</summary>
public ServerRelayException(string message, Exception innerException)
: base(message, innerException)
{
}
}
/// <summary>The relay of a server that does not offer one.</summary>
public sealed class UnavailableServerRelay : IServerRelay
{
private UnavailableServerRelay()
{
}
/// <summary>The one instance.</summary>
public static UnavailableServerRelay Instance { get; } = new();
/// <inheritdoc />
public bool IsOffered => false;
/// <inheritdoc />
public Task<RelayRoute> OpenAsync(Guid hostId, CancellationToken cancellationToken) =>
Task.FromException<RelayRoute>(new ServerRelayException(ServerRelay.NotOffered));
}
/// <summary>
/// The relay of a server that offers one: a ticket from the API, a socket, and a bridge.
/// </summary>
/// <remarks>
/// See ADR 0004 for the protocol and <c>docs/reaching-a-host-you-cannot-dial.md</c> for why the bridge
/// speaks SOCKS5. Every way this can fail is turned into a sentence here, because the codes are the
/// server's and the one place that should know what each means is the one that asked.
/// </remarks>
public sealed class ServerRelay : IServerRelay
{
/// <summary>What a user is told when the server they are signed in to does not relay.</summary>
internal const string NotOffered =
"This host is set to connect through the server relay, and this server does not offer one. "
+ "Untick “Connect through the server relay” in the host's settings to dial it directly.";
private readonly IRelayApi api;
private readonly Func<Uri, IReadOnlyList<string>, CancellationToken, Task<WebSocket>> connect;
/// <summary>A relay reached through this API client.</summary>
public ServerRelay(IRelayApi api)
: this(api, DialAsync)
{
}
/// <summary>A relay whose socket is opened by <paramref name="connect"/>, for tests.</summary>
internal ServerRelay(
IRelayApi api,
Func<Uri, IReadOnlyList<string>, CancellationToken, Task<WebSocket>> connect)
{
this.api = api;
this.connect = connect;
}
/// <inheritdoc />
public bool IsOffered => true;
/// <inheritdoc />
public async Task<RelayRoute> OpenAsync(Guid hostId, CancellationToken cancellationToken)
{
RelayTicketResponse ticket;
try
{
ticket = await api.IssueRelayTicketAsync(hostId, cancellationToken).ConfigureAwait(false);
}
catch (DodoSshApiException exception)
{
throw new ServerRelayException(Describe(exception), exception);
}
catch (HttpRequestException exception)
{
throw new ServerRelayException(
$"The server could not be reached to open the relay: {exception.Message}",
exception);
}
// The ticket as a second subprotocol, which is how ADR 0004 carries it: a header every WebSocket
// client can set. The server echoes the first alone.
var socket = await connect(
ticket.WebSocketUrl,
[RelayProtocol.SubProtocol, RelayProtocol.TicketProtocolPrefix + ticket.Ticket],
cancellationToken)
.ConfigureAwait(false);
return new RelayRoute(RelayBridge.Start(socket));
}
private static string Describe(DodoSshApiException exception) => exception.Code switch
{
ProblemCodes.RelayUnavailable => NotOffered,
// Deliberately unspecific on the server's side, so that it cannot be used to map the operator's
// network. The likeliest causes from here are the two this machine can check.
ProblemCodes.RelayTargetRejected =>
"The server refused to relay to this host. Check that the change turning the relay on has "
+ "synchronised, and that the address is one the server is allowed to reach; the server's log "
+ "records which.",
ProblemCodes.RelayLimitReached =>
"You have as many relay sessions open as the server allows. Close one and try again.",
_ => $"The server would not open the relay: {exception.Message}",
};
/// <summary>Opens the relay socket, and translates a refused upgrade into its reason.</summary>
/// <remarks>
/// The status of a refused upgrade is collected, which a constrained client could not do and this one
/// can: a 401 is a ticket the relay would not take — spent, expired, or issued by a node whose key ring
/// this one does not share — and asking again is the remedy.
/// </remarks>
private static async Task<WebSocket> DialAsync(
Uri url,
IReadOnlyList<string> protocols,
CancellationToken cancellationToken)
{
var socket = new ClientWebSocket();
try
{
foreach (var protocol in protocols)
{
socket.Options.AddSubProtocol(protocol);
}
socket.Options.CollectHttpResponseDetails = true;
await socket.ConnectAsync(url, cancellationToken).ConfigureAwait(false);
}
catch (WebSocketException exception)
{
var status = socket.HttpStatusCode;
socket.Dispose();
throw new ServerRelayException(
status == HttpStatusCode.Unauthorized
? "The server relay refused its ticket. Try connecting again."
: $"The server relay could not be reached: {exception.Message}",
exception);
}
catch
{
socket.Dispose();
throw;
}
if (!string.Equals(socket.SubProtocol, RelayProtocol.SubProtocol, StringComparison.Ordinal))
{
socket.Abort();
socket.Dispose();
throw new ServerRelayException(
"The server relay answered in a protocol this app does not speak. Update the app or the server.");
}
return socket;
}
}
@@ -3761,7 +3761,7 @@ internal sealed partial class MainWindowViewModel : ObservableObject, IAsyncDisp
return; return;
} }
var tab = new TerminalTabViewModel(e.Label, e.Address); var tab = new TerminalTabViewModel(e.Label, e.Address) { HostId = e.HostId };
attempts[e.AttemptId] = tab; attempts[e.AttemptId] = tab;
AdoptTab(tab); AdoptTab(tab);
@@ -3825,6 +3825,7 @@ internal sealed partial class MainWindowViewModel : ObservableObject, IAsyncDisp
// dropping it would leave a shell running with nothing in the window naming it. // dropping it would leave a shell running with nothing in the window naming it.
var adopted = new TerminalTabViewModel(e.SessionId, e.Label, e.Address) var adopted = new TerminalTabViewModel(e.SessionId, e.Label, e.Address)
{ {
HostId = e.HostId,
StartedAt = clock.GetUtcNow(), StartedAt = clock.GetUtcNow(),
Cipher = NullIfEmpty(e.Cipher), Cipher = NullIfEmpty(e.Cipher),
HostKeyAlgorithm = NullIfEmpty(e.HostKeyAlgorithm), HostKeyAlgorithm = NullIfEmpty(e.HostKeyAlgorithm),
@@ -4036,13 +4037,22 @@ internal sealed partial class MainWindowViewModel : ObservableObject, IAsyncDisp
} }
/// <summary> /// <summary>
/// The host this tab was opened against, or null when the keychain has nothing under that name. /// The host this tab was opened against, or null when the keychain no longer holds it.
/// </summary> /// </summary>
/// <remarks> /// <remarks>
/// <para> /// <para>
/// Matched on the label, which is the same handle <see cref="RefreshConnectedHosts"/> matches on and for /// ◆ <b>Matched on the keychain item's id, never on the name.</b> Nothing stops two hosts being called
/// the same reason: a tab outlives the vault that opened it, so it cannot hold an entity id that would /// the same thing — a team's vault beside a personal one makes it ordinary, and "db" is what people call
/// still mean anything after a lock. /// their database server in both — and this is the lookup <see cref="ReconnectTabAsync"/> dials the
/// answer to. A name match would take a dropped session on one machine and quietly reopen a shell on
/// another, with the tab, the status bar and the address all still naming the first. The id is carried
/// from the attempt that opened the tab; see <see cref="TerminalTabViewModel.HostId"/>.
/// </para>
/// <para>
/// <b>It outlives a lock, which is what the name match was here to survive.</b> The id is the item's own
/// sync identity rather than a reference to a row object, so a vault that is locked and opened again
/// rebuilds its list around the same ids and a tab from before the lock finds its host in it. A host
/// renamed since the tab opened is found too.
/// </para> /// </para>
/// <para> /// <para>
/// Null is the ordinary answer for two real cases, and both of them are why the reconnect below has to be /// Null is the ordinary answer for two real cases, and both of them are why the reconnect below has to be
@@ -4051,10 +4061,9 @@ internal sealed partial class MainWindowViewModel : ObservableObject, IAsyncDisp
/// </para> /// </para>
/// </remarks> /// </remarks>
private HostRowViewModel? HostFor(TerminalTabViewModel? tab) => private HostRowViewModel? HostFor(TerminalTabViewModel? tab) =>
tab is null || Vault is not { } vault tab?.HostId is not { } hostId || Vault is not { } vault
? null ? null
: vault.Hosts.FirstOrDefault( : vault.Hosts.FirstOrDefault(row => row.EntityId == hostId);
row => string.Equals(row.Label, tab.Label, StringComparison.Ordinal));
/// <summary> /// <summary>
/// Whether the selected tab has stopped and there is something to dial again. /// Whether the selected tab has stopped and there is something to dial again.
@@ -4382,10 +4391,15 @@ internal sealed partial class MainWindowViewModel : ObservableObject, IAsyncDisp
/// </summary> /// </summary>
/// <remarks> /// <remarks>
/// <para> /// <para>
/// Matched on the label, which is what a tab was named after, because that is the only handle the two /// Matched on the keychain item's id, the same handle <see cref="HostFor"/> matches on and for the
/// lists share — a tab outlives the vault that opened it, so it cannot hold an entity id that would /// reason given there: two hosts may share a name, and this list is read as "which machines am I on".
/// still mean anything after a lock. Two hosts sharing a name would light both dots, which is a smaller /// Lighting both dots for a name two machines answer to would say the user has a shell open on a host
/// wrong than a dot that goes dark when the vault is reopened. /// they have never connected to — and it is the same match that decides whose pinned paths the sidebar
/// offers, which would then be another host's folders.
/// </para>
/// <para>
/// A tab with no item behind it — a machine reached by typing an address — lights nothing, which is
/// correct: there is no row here that it is a session on.
/// </para> /// </para>
/// <para> /// <para>
/// <see cref="ActiveTabPinnedPaths"/> is rebuilt here, on the same match, rather than from a subscription /// <see cref="ActiveTabPinnedPaths"/> is rebuilt here, on the same match, rather than from a subscription
@@ -4408,14 +4422,11 @@ internal sealed partial class MainWindowViewModel : ObservableObject, IAsyncDisp
foreach (var host in vault.Hosts) foreach (var host in vault.Hosts)
{ {
host.IsConnected = Tabs.Any( host.IsConnected = Tabs.Any(tab => tab.IsLive && tab.HostId == host.EntityId);
tab => tab.IsLive && string.Equals(tab.Label, host.Label, StringComparison.Ordinal));
// The active tab's host, and only when it is actually connected: the sidebar is for a session // The active tab's host, and only when it is actually connected: the sidebar is for a session
// that is open, not for whichever machine's tab happens to be selected while it is still dialling. // that is open, not for whichever machine's tab happens to be selected while it is still dialling.
if (host.IsConnected if (host.IsConnected && SelectedTab is { } selected && selected.HostId == host.EntityId)
&& SelectedTab is { } selected
&& string.Equals(host.Label, selected.Label, StringComparison.Ordinal))
{ {
connectedActiveHost = host; connectedActiveHost = host;
} }
@@ -4549,15 +4560,14 @@ internal sealed partial class MainWindowViewModel : ObservableObject, IAsyncDisp
/// is drawn and not what it does. It shares <see cref="OnVaultFilesRequested"/>'s plumbing — the same /// is drawn and not what it does. It shares <see cref="OnVaultFilesRequested"/>'s plumbing — the same
/// <see cref="ShowFiles"/> refusal, the same re-found row, the same password-sheet branch for a host /// <see cref="ShowFiles"/> refusal, the same re-found row, the same password-sheet branch for a host
/// that cannot be dialled unattended — through <see cref="GoToHostFilesAsync"/>, and the host is found by /// that cannot be dialled unattended — through <see cref="GoToHostFilesAsync"/>, and the host is found by
/// the same label match <see cref="RefreshConnectedHosts"/> used to decide the row is there to click. /// the same <see cref="HostFor"/> match <see cref="RefreshConnectedHosts"/> used to decide the row is
/// there to click — which is the point: the pins on screen and the host they are opened on come from one
/// answer to "which machine is this tab", and two hosts of the same name cannot pull them apart.
/// </remarks> /// </remarks>
[RelayCommand] [RelayCommand]
private async Task OpenPinnedPathAsync(string path) private async Task OpenPinnedPathAsync(string path)
{ {
if (Vault is not { } vault if (HostFor(SelectedTab) is not { } host)
|| SelectedTab is not { } tab
|| vault.Hosts.FirstOrDefault(
host => string.Equals(host.Label, tab.Label, StringComparison.Ordinal)) is not { } host)
{ {
return; return;
} }
@@ -4638,10 +4648,7 @@ internal sealed partial class MainWindowViewModel : ObservableObject, IAsyncDisp
[RelayCommand] [RelayCommand]
private void PinFolderFromSidebar() private void PinFolderFromSidebar()
{ {
if (Vault is not { } vault if (Vault is not { } vault || HostFor(SelectedTab) is not { } host)
|| SelectedTab is not { } tab
|| vault.Hosts.FirstOrDefault(
host => string.Equals(host.Label, tab.Label, StringComparison.Ordinal)) is not { } host)
{ {
return; return;
} }
@@ -4674,10 +4681,7 @@ internal sealed partial class MainWindowViewModel : ObservableObject, IAsyncDisp
[RelayCommand] [RelayCommand]
private async Task SelectFilesHostAsync(TerminalTabViewModel tab) private async Task SelectFilesHostAsync(TerminalTabViewModel tab)
{ {
if (Vault is not { } vault if (HostFor(tab) is not { } host)
|| tab is null
|| vault.Hosts.FirstOrDefault(
host => string.Equals(host.Label, tab.Label, StringComparison.Ordinal)) is not { } host)
{ {
return; return;
} }
@@ -229,6 +229,31 @@ internal sealed partial class TerminalTabViewModel : ObservableObject
internal string Label { get; } internal string Label { get; }
/// <summary>
/// The keychain item this tab was opened from, or null for a machine reached by typing an address.
/// </summary>
/// <remarks>
/// <para>
/// ◆ <b>What the shell matches this tab back to a host row with, because the name will not do it.</b>
/// Nothing stops two hosts being called the same thing, and a team's vault beside a personal one makes it
/// ordinary — so a lookup on <see cref="Label"/> can answer with a different machine that happens to
/// share the name. The reconnect under a stopped tab <em>dials</em> whatever that lookup finds, which is
/// the one place being approximately right is dialling a stranger. See
/// <c>MainWindowViewModel.HostFor</c>.
/// </para>
/// <para>
/// <b>It survives a lock, which the row objects do not.</b> This is the item's sync identity rather than
/// an index into the list on screen — see <c>VaultItem&lt;TSecret&gt;.EntityId</c> — so a vault that is
/// locked and opened again rebuilds every row around the same ids, and a tab that outlived the vault
/// finds its host again. A rename finds it too, which a name match by definition cannot.
/// </para>
/// <para>
/// Null is not missing data: it is the whole of what makes a typed-in address different, and it is why
/// such a tab is honestly refused a reconnect rather than offered one that would dial a namesake.
/// </para>
/// </remarks>
internal Guid? HostId { get; init; }
/// <summary>The account and endpoint, for the pane header and the status bar.</summary> /// <summary>The account and endpoint, for the pane header and the status bar.</summary>
internal string Address { get; } internal string Address { get; }
@@ -1795,25 +1795,9 @@ internal sealed partial class TransfersViewModel : ObservableObject, IAsyncDispo
{ {
await CloseSessionAsync().ConfigureAwait(true); await CloseSessionAsync().ConfigureAwait(true);
ISftpSession opened; if (await OpenHostSessionAsync(open, row, request, cancellationToken).ConfigureAwait(true)
is not { } opened)
try
{ {
opened = await sftp.OpenSftpAsync(request, cancellationToken).ConfigureAwait(true);
}
catch (SshHostKeyUnknownException exception)
{
// First contact, decided here rather than inherited from a terminal. File transfer is
// its own connection, so it makes its own trust decision — and the pin it writes is the
// same pin a shell would then find.
PendingHostKey = exception.Presentation;
Status = "This host has not been seen before.";
return;
}
catch (SshHostKeyMismatchException exception)
{
HostKeyMismatch = exception.Message;
Status = "The host key has changed. Nothing was connected.";
return; return;
} }
@@ -1831,6 +1815,55 @@ internal sealed partial class TransfersViewModel : ObservableObject, IAsyncDispo
}).ConfigureAwait(true); }).ConfigureAwait(true);
} }
/// <summary>
/// Opens the session on a host, through the relay when the host uses it, or says why not.
/// </summary>
/// <returns>The session, or null with <see cref="Status"/> saying why there is none.</returns>
private async Task<ISftpSession?> OpenHostSessionAsync(
VaultViewModel open,
HostRowViewModel row,
SshConnectionRequest request,
CancellationToken cancellationToken)
{
RelayRoute? relay = null;
try
{
// Through the relay for a host set to use it, exactly as a shell to it would be. The
// session owns the relay from here, on success and on failure alike.
relay = row.Host.RelayEnabled
? await open.OpenRelayAsync(row.Label, row.EntityId, cancellationToken).ConfigureAwait(true)
: null;
return await sftp
.OpenSftpAsync(relay is null ? request : request with { Proxy = relay.Proxy }, cancellationToken)
.ConfigureAwait(true);
}
catch (Exception exception)
when (relay?.Failure is { } failure
&& exception is not (OperationCanceledException or SshHostKeyUnknownException or SshHostKeyMismatchException))
{
// See VaultViewModel.OpenThroughAsync: the relay's reason is the true one.
Status = failure;
return null;
}
catch (SshHostKeyUnknownException exception)
{
// First contact, decided here rather than inherited from a terminal. File transfer is
// its own connection, so it makes its own trust decision — and the pin it writes is the
// same pin a shell would then find.
PendingHostKey = exception.Presentation;
Status = "This host has not been seen before.";
return null;
}
catch (SshHostKeyMismatchException exception)
{
HostKeyMismatch = exception.Message;
Status = "The host key has changed. Nothing was connected.";
return null;
}
}
/// <summary> /// <summary>
/// Records that a host connection just succeeded: the address, the negotiated facts, and the ticket the /// Records that a host connection just succeeded: the address, the negotiated facts, and the ticket the
/// disconnect log closes out later. /// disconnect log closes out later.
@@ -947,6 +947,7 @@ internal static class ItemBadge
/// <param name="identityLabel"> /// <param name="identityLabel">
/// The display name of the key or credential that authenticated, or null when a typed password did. /// The display name of the key or credential that authenticated, or null when a typed password did.
/// </param> /// </param>
/// <param name="hostId">The keychain item this was dialled from, or null for a typed-in address.</param>
internal sealed class TerminalSessionEventArgs( internal sealed class TerminalSessionEventArgs(
Guid attemptId, Guid attemptId,
uint sessionId, uint sessionId,
@@ -954,7 +955,8 @@ internal sealed class TerminalSessionEventArgs(
string address, string address,
string cipher, string cipher,
string hostKeyAlgorithm, string hostKeyAlgorithm,
string? identityLabel) : EventArgs string? identityLabel,
Guid? hostId) : EventArgs
{ {
/// <summary>Which attempt this session came out of.</summary> /// <summary>Which attempt this session came out of.</summary>
/// <inheritdoc cref="ConnectionAttemptEventArgs.AttemptId" path="/remarks" /> /// <inheritdoc cref="ConnectionAttemptEventArgs.AttemptId" path="/remarks" />
@@ -971,19 +973,27 @@ internal sealed class TerminalSessionEventArgs(
internal string HostKeyAlgorithm { get; } = hostKeyAlgorithm; internal string HostKeyAlgorithm { get; } = hostKeyAlgorithm;
internal string? IdentityLabel { get; } = identityLabel; internal string? IdentityLabel { get; } = identityLabel;
/// <inheritdoc cref="ConnectionAttemptEventArgs.HostId" />
internal Guid? HostId { get; } = hostId;
} }
/// <summary>A connection that has been asked for, and has not answered yet.</summary> /// <summary>A connection that has been asked for, and has not answered yet.</summary>
/// <param name="attemptId">Identifies this attempt for the whole of its life.</param> /// <param name="attemptId">Identifies this attempt for the whole of its life.</param>
/// <param name="label">The host's name, as the vault has it.</param> /// <param name="label">The host's name, as the vault has it.</param>
/// <param name="address">Who this will be logged in as, and where.</param> /// <param name="address">Who this will be logged in as, and where.</param>
/// <param name="hostId">The keychain item this is being dialled from, or null for a typed-in address.</param>
/// <remarks> /// <remarks>
/// The vault says a connection has started before it says whether it worked, so that the shell can put a /// The vault says a connection has started before it says whether it worked, so that the shell can put a
/// tab in the strip at the moment the user asks for one rather than however many seconds later a handshake /// tab in the strip at the moment the user asks for one rather than however many seconds later a handshake
/// takes. Everything a tab needs to name itself is here, because the name is a decrypted item and the shell /// takes. Everything a tab needs to name itself is here, because the name is a decrypted item and the shell
/// has no vault to read it from. /// has no vault to read it from.
/// </remarks> /// </remarks>
internal sealed class ConnectionAttemptEventArgs(Guid attemptId, string label, string address) : EventArgs internal sealed class ConnectionAttemptEventArgs(
Guid attemptId,
string label,
string address,
Guid? hostId) : EventArgs
{ {
/// <summary>Identifies this attempt for the whole of its life.</summary> /// <summary>Identifies this attempt for the whole of its life.</summary>
/// <remarks> /// <remarks>
@@ -995,6 +1005,19 @@ internal sealed class ConnectionAttemptEventArgs(Guid attemptId, string label, s
internal string Label { get; } = label; internal string Label { get; } = label;
internal string Address { get; } = address; internal string Address { get; } = address;
/// <summary>
/// The keychain item this connection was made from, or null for a machine that is not in the keychain.
/// </summary>
/// <remarks>
/// ◆ <b>The name is not an identifier and this is.</b> Two hosts may be called the same thing — nothing
/// stops it, and a team vault next to a personal one makes it ordinary — so a tab that remembered only
/// what it was called could be matched back to the wrong machine. That is not a cosmetic mix-up: the
/// reconnect below the tab dials whichever row the match found, so the one thing that must not be
/// guessed is which machine a reconnect goes to. Carried from here because a tab has no vault to ask —
/// see <c>TerminalTabViewModel.HostId</c>.
/// </remarks>
internal Guid? HostId { get; } = hostId;
} }
/// <summary>A connection that has got as far as a named step.</summary> /// <summary>A connection that has got as far as a named step.</summary>
@@ -11326,7 +11349,8 @@ internal sealed partial class VaultViewModel(
var attempt = new ConnectionAttemptEventArgs( var attempt = new ConnectionAttemptEventArgs(
Guid.CreateVersion7(), Guid.CreateVersion7(),
target.Label, target.Label,
Dialled(target, authentication)); Dialled(target, authentication),
target.HostId);
ConnectionStarting?.Invoke(this, attempt); ConnectionStarting?.Invoke(this, attempt);
Status = $"Connecting to {target.Label}…"; Status = $"Connecting to {target.Label}…";
@@ -11647,7 +11671,10 @@ internal sealed partial class VaultViewModel(
PhaseReporter reporter, PhaseReporter reporter,
CancellationToken cancellationToken) CancellationToken cancellationToken)
{ {
if (reporter.Furthest != SshConnectionPhase.Reaching) // A relay refusal already says exactly what happened, and a relayed host is reached by a path the
// probe does not take: it would dial the host directly — the route the user chose the relay because
// they cannot use — and report on that instead.
if (reporter.Furthest != SshConnectionPhase.Reaching || exception is ServerRelayException || target.Relayed)
{ {
return exception.Message; return exception.Message;
} }
@@ -11752,9 +11779,7 @@ internal sealed partial class VaultViewModel(
authentication.Username, authentication.Username,
authentication.Credential); authentication.Credential);
var sessionId = await workspace var sessionId = await OpenThroughAsync(target, request, reporter, cancellationToken).ConfigureAwait(true);
.OpenSessionAsync(request, TerminalSize.Default, reporter, cancellationToken)
.ConfigureAwait(true);
// The workspace has already opened a ticket for this session, with the address and the moment it // The workspace has already opened a ticket for this session, with the address and the moment it
// connected. What it could not know is which keychain item this was — an SshConnectionRequest has no // connected. What it could not know is which keychain item this was — an SshConnectionRequest has no
@@ -11784,7 +11809,8 @@ internal sealed partial class VaultViewModel(
Dialled(target, authentication), Dialled(target, authentication),
facts?.Cipher ?? string.Empty, facts?.Cipher ?? string.Empty,
facts?.HostKeyAlgorithm ?? string.Empty, facts?.HostKeyAlgorithm ?? string.Empty,
authentication.IdentityLabel)); authentication.IdentityLabel,
target.HostId));
// Last, and after the tab exists: keeping the password is a favour, and the session the user asked // Last, and after the tab exists: keeping the password is a favour, and the session the user asked
// for must not wait on a vault write to appear. // for must not wait on a vault write to appear.
@@ -11798,6 +11824,90 @@ internal sealed partial class VaultViewModel(
} }
} }
/// <summary>
/// Opens a relay to a host set to connect through the server, or says why there is none.
/// </summary>
/// <remarks>
/// <para>
/// <b>There is no falling back to a direct connection.</b> A user who ticked the relay did so because
/// the direct path does not work, or goes somewhere they do not mean — and dialling it anyway on a
/// failure would be the old defect in reverse: the box would say one thing and the connection do
/// another. So a relay that cannot be opened is the failure, stated as such.
/// </para>
/// <para>
/// The server is resolved the way a synchronisation resolves it, which comes back online quietly when a
/// sign-in is remembered. Offline is its own sentence, because it is the one case the user can fix from
/// this machine without touching the host.
/// </para>
/// <para>
/// Internal because file transfer opens a connection of its own and a relayed host needs the relay
/// there too — or the transfers screen would fail for exactly the hosts the relay exists for.
/// </para>
/// </remarks>
internal async Task<RelayRoute> OpenRelayAsync(string label, Guid hostId, CancellationToken cancellationToken)
{
if (await ResolveServerAsync(cancellationToken).ConfigureAwait(true) is not { } server)
{
throw new ServerRelayException(
$"{label} connects through the server relay, and this machine is not connected to the "
+ "server right now. Try again once it is back online.");
}
return await server.Relay.OpenAsync(hostId, cancellationToken).ConfigureAwait(true);
}
/// <summary>
/// Opens the session, through the relay when there is one, and puts the relay's reason on a failure.
/// </summary>
/// <remarks>
/// <para>
/// A relay that hung up reaches SSH.NET as a stream that ended, and it reports that the way it reports
/// every lost transport — a sentence that reads exactly like the direct failure the relay was ticked to
/// get around. When the relay said why it closed, that sentence is the true one and replaces it. The
/// host key refusals are left alone: a key was presented, so the relay did its job.
/// </para>
/// <para>
/// The relay is disposed on every failure. The connection owns it once it is handed over and disposes
/// it on its own failure paths too, but a throw before the factory is reached would otherwise leave a
/// bridge listening until its own timeout; disposing twice is safe.
/// </para>
/// </remarks>
private async Task<uint> OpenThroughAsync(
ConnectionTarget target,
SshConnectionRequest request,
PhaseReporter reporter,
CancellationToken cancellationToken)
{
// After the renderer rather than before it: a ticket is dead thirty seconds after issue, and the
// renderer's wait is the one step of a connect with no bound a user would recognise.
var relay = target.Relayed
? await OpenRelayAsync(target.Label, target.HostId!.Value, cancellationToken).ConfigureAwait(true)
: null;
try
{
return await workspace
.OpenSessionAsync(
relay is null ? request : request with { Proxy = relay.Proxy },
TerminalSize.Default,
reporter,
cancellationToken)
.ConfigureAwait(true);
}
catch (Exception exception) when (relay is not null)
{
await relay.DisposeAsync().ConfigureAwait(true);
if (relay.Failure is { } failure
&& exception is not (OperationCanceledException or SshHostKeyUnknownException or SshHostKeyMismatchException))
{
throw new ServerRelayException(failure, exception);
}
throw;
}
}
/// <summary> /// <summary>
/// Turns the password that just worked into a keychain credential bound to this host. /// Turns the password that just worked into a keychain credential bound to this host.
/// </summary> /// </summary>
@@ -12016,6 +12126,15 @@ internal sealed partial class VaultViewModel(
{ {
/// <summary>The keychain item, or null for a machine that is not in it.</summary> /// <summary>The keychain item, or null for a machine that is not in it.</summary>
internal Guid? HostId => Row?.EntityId; internal Guid? HostId => Row?.EntityId;
/// <summary>
/// Whether this is reached through the server relay rather than dialled.
/// </summary>
/// <remarks>
/// Only a keychain host can be: the relay dials the address the server holds for an item, and a
/// machine typed into the manual box has no item and therefore nothing on the server to dial.
/// </remarks>
internal bool Relayed => Row?.Host.RelayEnabled is true;
} }
/// <summary> /// <summary>
@@ -34,6 +34,7 @@ const SERVER_SESSION_REMOVED = 5;
const SERVER_PASTE = 6; const SERVER_PASTE = 6;
const SERVER_FONT_SIZE = 7; const SERVER_FONT_SIZE = 7;
const SERVER_CLIPBOARD = 8; const SERVER_CLIPBOARD = 8;
const SERVER_OUTPUT_DROPPED = 9;
const CLIENT_INPUT = 1; const CLIENT_INPUT = 1;
const CLIENT_ACKNOWLEDGE = 2; const CLIENT_ACKNOWLEDGE = 2;
@@ -534,6 +535,24 @@ function handleFrame(buffer) {
break; break;
} }
case SERVER_OUTPUT_DROPPED: {
const session = sessions.get(sessionId) ?? createSession(sessionId);
/*
The host could not keep the whole of a flood, and this is the line saying where the gap is. It
goes in exactly here, between the bytes either side of it — the socket keeps order within a
session, so nothing has to be done to place it.
Written without an acknowledgement, deliberately. Credit describes what the remote sent and what
this page has drawn of it; these bytes came from the host itself, and acknowledging them would
hand back credit for output that was never reserved against the window in the first place. The
payload arrives already styled and already terminated by a reset — see the host's own remark for
why the reset comes first as well.
*/
session.term.write(payload);
break;
}
case SERVER_SESSION_ACTIVATED: { case SERVER_SESSION_ACTIVATED: {
const session = sessions.get(sessionId); const session = sessions.get(sessionId);
+369
View File
@@ -0,0 +1,369 @@
using System.Buffers;
using System.Net;
using System.Net.Sockets;
using System.Net.WebSockets;
namespace DodoSSH.Client.Ssh;
/// <summary>
/// A loopback SOCKS5 proxy that carries exactly one connection over one relay WebSocket.
/// </summary>
/// <remarks>
/// <para>
/// SSH.NET cannot be handed a stream, only an address — so the relay, which is a WebSocket, is reached by
/// giving SSH.NET an address that leads into one. This listens on <c>127.0.0.1</c> at a port the system
/// chooses, answers one SOCKS5 CONNECT, and from then on moves bytes: what SSH.NET writes goes out as binary
/// messages, and what the relay sends comes back as the stream SSH.NET reads. That is ADR 0004's loopback
/// bridge, and step 3 of <c>docs/reaching-a-host-you-cannot-dial.md</c>.
/// </para>
/// <para>
/// <b>SOCKS5 rather than a plain pipe, so the host stays the host.</b> The connection made through this is
/// told the target's real name and port, and pins its host key under them; the CONNECT carrying that name
/// arrives here and is answered without being acted on, because where the bytes go was decided by the
/// server when it issued the ticket, and nothing this side says can change it.
/// </para>
/// <para>
/// Three properties are the security of this, and each is held by a test. It binds loopback and nothing
/// else — asserted on the bound address, because a bridge on every interface would be a proxy into the
/// relay for anyone on the network and nothing would report it. It accepts once and stops listening, so a
/// second process on this machine cannot take a turn. And it gives up if nobody arrives within
/// <see cref="AcceptTimeout"/>, so a connect that failed before dialling cannot leave it waiting.
/// </para>
/// <para>
/// <b>No operation on the WebSocket is cancelled.</b> Cancelling one aborts a .NET WebSocket, and an aborted
/// one never reads the close frame that says why the relay ended — which is the one thing the user needs to
/// be told when the server could not reach the host. The bridge stops a direction by closing, and waits a
/// bounded time for the other side to agree, as the relay's own endpoint does.
/// </para>
/// </remarks>
public sealed class RelayBridge : IAsyncDisposable
{
/// <summary>How long the bridge waits for its one connection before closing the relay unused.</summary>
/// <remarks>
/// The connection is made the moment the bridge exists, so this bounds a caller that failed between the
/// two. Longer than any SSH connect timeout, so it never ends a connect that is merely slow.
/// </remarks>
public static readonly TimeSpan AcceptTimeout = TimeSpan.FromSeconds(60);
private const int BufferBytes = 32 * 1024;
private static readonly TimeSpan CloseTimeout = TimeSpan.FromSeconds(5);
private readonly TcpListener listener;
private readonly WebSocket socket;
private readonly CancellationTokenSource stopping = new();
private readonly Task running;
private int disposed;
private RelayBridge(WebSocket socket, TimeSpan acceptTimeout)
{
this.socket = socket;
// The address rather than "localhost", so there is no resolver and no hosts file between this and
// the interface it means. See the remarks on SshLoopbackProxy.
listener = new TcpListener(IPAddress.Loopback, 0);
listener.Start(backlog: 1);
Endpoint = (IPEndPoint)listener.LocalEndpoint;
running = RunAsync(acceptTimeout);
}
/// <summary>Where the bridge is listening. Loopback, always.</summary>
public IPEndPoint Endpoint { get; }
/// <summary>The proxy to hand the connection, which then owns this bridge.</summary>
public SshLoopbackProxy Proxy => new(Endpoint.Port, this);
/// <summary>
/// How the relay closed the socket, once it has; null while it is open or when it vanished without
/// saying.
/// </summary>
/// <remarks>
/// Read after a connect through the bridge fails. The relay says in a close code what went wrong on its
/// side — the server could not reach the host, or has too many sessions open — and that is the sentence
/// the user needs in place of the transport error SSH.NET reports for a stream that ended.
/// </remarks>
public WebSocketCloseStatus? CloseStatus { get; private set; }
/// <summary>The relay's own words about why it closed, alongside <see cref="CloseStatus"/>.</summary>
public string? CloseDescription { get; private set; }
/// <summary>Completes when the bridge has finished: its one connection is over, or nobody came.</summary>
public Task Completion => running;
/// <summary>Starts a bridge over an open relay socket, which it then owns.</summary>
public static RelayBridge Start(WebSocket socket) => Start(socket, AcceptTimeout);
/// <summary>Starts a bridge with a shorter wait for its connection, for tests.</summary>
internal static RelayBridge Start(WebSocket socket, TimeSpan acceptTimeout)
{
ArgumentNullException.ThrowIfNull(socket);
return new RelayBridge(socket, acceptTimeout);
}
/// <inheritdoc />
/// <remarks>
/// Idempotent, because two owners may reach it: the connection that was handed the proxy, and a caller
/// tidying up after a connect that never got that far.
/// </remarks>
public async ValueTask DisposeAsync()
{
if (Interlocked.Exchange(ref disposed, 1) != 0)
{
return;
}
await stopping.CancelAsync().ConfigureAwait(false);
listener.Stop();
if (!await SettlesAsync(running, CloseTimeout * 2).ConfigureAwait(false))
{
socket.Abort();
await SettlesAsync(running, CloseTimeout).ConfigureAwait(false);
}
socket.Dispose();
stopping.Dispose();
}
private async Task RunAsync(TimeSpan acceptTimeout)
{
TcpClient? client = null;
try
{
using (var accepting = CancellationTokenSource.CreateLinkedTokenSource(stopping.Token))
{
accepting.CancelAfter(acceptTimeout);
client = await listener.AcceptTcpClientAsync(accepting.Token).ConfigureAwait(false);
}
// Once. A second connection to this port is somebody else's, and there is nothing for it here.
listener.Stop();
client.NoDelay = true;
var stream = client.GetStream();
if (await Socks5.AcceptConnectAsync(stream, stopping.Token).ConfigureAwait(false))
{
await PipeAsync(stream).ConfigureAwait(false);
}
}
catch (Exception exception)
when (exception is OperationCanceledException or SocketException or IOException or ObjectDisposedException)
{
// Nobody came, the bridge was disposed, or the connection went away mid-handshake. The relay is
// closed below either way.
}
finally
{
listener.Stop();
client?.Dispose();
await CloseSocketAsync(WebSocketCloseStatus.NormalClosure).ConfigureAwait(false);
}
}
/// <summary>Moves bytes both ways until either side ends, then lets the other finish.</summary>
private async Task PipeAsync(NetworkStream stream)
{
var upstream = TcpToRelayAsync(stream);
var downstream = RelayToTcpAsync(stream);
var first = await Task.WhenAny(upstream, downstream).ConfigureAwait(false);
if (first == upstream)
{
// SSH.NET closed its end. Say so to the relay, then give it a moment to answer, which is what
// ends the receive in progress without aborting it.
await CloseSocketAsync(WebSocketCloseStatus.NormalClosure).ConfigureAwait(false);
if (!await SettlesAsync(downstream, CloseTimeout).ConfigureAwait(false))
{
socket.Abort();
}
}
else
{
// The relay ended. Closing the TCP side is how SSH.NET hears it, as the end of its stream.
stream.Socket.Shutdown(SocketShutdown.Both);
await SettlesAsync(upstream, CloseTimeout).ConfigureAwait(false);
}
}
private async Task TcpToRelayAsync(NetworkStream stream)
{
var buffer = ArrayPool<byte>.Shared.Rent(BufferBytes);
try
{
int read;
while ((read = await stream.ReadAsync(buffer.AsMemory(0, BufferBytes), stopping.Token).ConfigureAwait(false)) > 0)
{
// Not cancellable, deliberately. See the remarks on this class.
await socket
.SendAsync(buffer.AsMemory(0, read), WebSocketMessageType.Binary, endOfMessage: true, CancellationToken.None)
.ConfigureAwait(false);
}
}
catch (Exception exception)
when (exception is OperationCanceledException or IOException or WebSocketException or ObjectDisposedException)
{
// Either end went away. PipeAsync decides what that means.
}
finally
{
ArrayPool<byte>.Shared.Return(buffer);
}
}
private async Task RelayToTcpAsync(NetworkStream stream)
{
var buffer = ArrayPool<byte>.Shared.Rent(BufferBytes);
try
{
while (true)
{
// Not cancellable, deliberately. See the remarks on this class.
var received = await socket.ReceiveAsync(buffer.AsMemory(), CancellationToken.None)
.ConfigureAwait(false);
if (received.MessageType == WebSocketMessageType.Close)
{
CloseStatus = socket.CloseStatus;
CloseDescription = socket.CloseStatusDescription;
return;
}
await stream.WriteAsync(buffer.AsMemory(0, received.Count), stopping.Token).ConfigureAwait(false);
}
}
catch (Exception exception)
when (exception is OperationCanceledException or IOException or WebSocketException or ObjectDisposedException)
{
// Either end went away. PipeAsync decides what that means.
}
finally
{
ArrayPool<byte>.Shared.Return(buffer);
}
}
/// <summary>Sends a close, if one can still be sent, bounded so a vanished peer cannot hold it.</summary>
private async Task CloseSocketAsync(WebSocketCloseStatus status)
{
if (socket.State is not (WebSocketState.Open or WebSocketState.CloseReceived))
{
return;
}
using var timeout = new CancellationTokenSource(CloseTimeout);
try
{
await socket.CloseOutputAsync(status, string.Empty, timeout.Token).ConfigureAwait(false);
}
catch (Exception exception)
when (exception is OperationCanceledException or WebSocketException or ObjectDisposedException)
{
// Gone already.
}
}
private static async Task<bool> SettlesAsync(Task task, TimeSpan within)
{
try
{
await task.WaitAsync(within).ConfigureAwait(false);
return true;
}
catch (TimeoutException)
{
return false;
}
}
/// <summary>
/// The server half of SOCKS5 (RFC 1928), as much of it as SSH.NET speaks: no authentication, CONNECT.
/// </summary>
private static class Socks5
{
private const byte Version = 5;
private const byte NoAuthentication = 0;
private const byte NoAcceptableMethod = 0xFF;
private const byte Connect = 1;
private const byte Succeeded = 0;
private const byte CommandNotSupported = 7;
private const byte AddressTypeNotSupported = 8;
/// <summary>
/// Answers the greeting and one CONNECT, whatever it names.
/// </summary>
/// <returns>Whether the stream is now a tunnel; false when the client asked for something else.</returns>
/// <remarks>
/// The target in the request is read and discarded. It is the host the connection is <em>about</em>,
/// which is why SSH.NET sends it, and it is not where the bytes go, which the relay decided. The bound
/// address in the reply is all zeroes: nothing on the far side of a relay has an address the client
/// could use, and SSH.NET does not read it.
/// </remarks>
internal static async Task<bool> AcceptConnectAsync(Stream stream, CancellationToken cancellationToken)
{
var header = await ReadAsync(stream, 2, cancellationToken).ConfigureAwait(false);
if (header[0] != Version)
{
return false;
}
var methods = await ReadAsync(stream, header[1], cancellationToken).ConfigureAwait(false);
if (!methods.Contains(NoAuthentication))
{
await stream.WriteAsync(new byte[] { Version, NoAcceptableMethod }, cancellationToken).ConfigureAwait(false);
return false;
}
await stream.WriteAsync(new byte[] { Version, NoAuthentication }, cancellationToken).ConfigureAwait(false);
var request = await ReadAsync(stream, 4, cancellationToken).ConfigureAwait(false);
if (request[0] != Version || request[1] != Connect)
{
await ReplyAsync(stream, CommandNotSupported, cancellationToken).ConfigureAwait(false);
return false;
}
var addressLength = request[3] switch
{
1 => 4,
4 => 16,
3 => (await ReadAsync(stream, 1, cancellationToken).ConfigureAwait(false))[0],
_ => -1,
};
if (addressLength < 0)
{
await ReplyAsync(stream, AddressTypeNotSupported, cancellationToken).ConfigureAwait(false);
return false;
}
// The address, then the port. Neither is used; see the remarks above.
await ReadAsync(stream, addressLength + 2, cancellationToken).ConfigureAwait(false);
await ReplyAsync(stream, Succeeded, cancellationToken).ConfigureAwait(false);
return true;
}
private static Task ReplyAsync(Stream stream, byte status, CancellationToken cancellationToken) =>
stream.WriteAsync(new byte[] { Version, status, 0, 1, 0, 0, 0, 0, 0, 0 }, cancellationToken).AsTask();
private static async Task<byte[]> ReadAsync(Stream stream, int count, CancellationToken cancellationToken)
{
var buffer = new byte[count];
await stream.ReadExactlyAsync(buffer, cancellationToken).ConfigureAwait(false);
return buffer;
}
}
}
+11 -4
View File
@@ -38,12 +38,19 @@ public sealed record SshPrivateKeyCredential(byte[] PrivateKeyPem, string? Passp
/// stand-in. See the gate in <c>SshNetConnectionFactory</c>, which pins what this request names. /// stand-in. See the gate in <c>SshNetConnectionFactory</c>, which pins what this request names.
/// </para> /// </para>
/// <para> /// <para>
/// Nothing in this assembly opens one. The proxy is somebody else's — a forward on a bastion connection, /// <b>Whoever opens a proxy may hand it to the connection made through it.</b> A proxy with no
/// or the relay bridge — and its lifetime belongs to whoever opened it, which must outlast the connection /// <see cref="Lifetime"/> belongs to its opener, which must keep it listening for as long as the connection
/// made through it. See <c>docs/reaching-a-host-you-cannot-dial.md</c>. /// lives. One with a lifetime is given away: the connection disposes it after itself, and a connect that
/// fails disposes it before throwing — so a proxy opened for one connection, which is what the relay bridge
/// is, cannot outlive it on any of the paths a session ends by. See
/// <c>docs/reaching-a-host-you-cannot-dial.md</c>.
/// </para> /// </para>
/// </remarks> /// </remarks>
public sealed record SshLoopbackProxy(int Port); /// <param name="Port">The loopback port the proxy listens on.</param>
/// <param name="Lifetime">
/// What keeps the proxy listening, when the connection is to own it; null when its opener does.
/// </param>
public sealed record SshLoopbackProxy(int Port, IAsyncDisposable? Lifetime = null);
/// <summary>Everything needed to reach one host.</summary> /// <summary>Everything needed to reach one host.</summary>
/// <param name="Host">Hostname or address.</param> /// <param name="Host">Hostname or address.</param>
@@ -75,12 +75,22 @@ public sealed class SshNetConnectionFactory(IKnownHostStore knownHosts)
{ {
ArgumentNullException.ThrowIfNull(request); ArgumentNullException.ThrowIfNull(request);
var client = new SshClient(BuildConnectionInfo(request)) { KeepAliveInterval = KeepAliveInterval }; var lifetime = request.Proxy?.Lifetime;
var gate = await ConnectThroughHostKeyGateAsync(client, request, progress, cancellationToken) try
.ConfigureAwait(false); {
var client = new SshClient(BuildConnectionInfo(request)) { KeepAliveInterval = KeepAliveInterval };
return new SshNetConnection(client, gate.Presented!); var gate = await ConnectThroughHostKeyGateAsync(client, request, progress, cancellationToken)
.ConfigureAwait(false);
return new SshNetConnection(client, gate.Presented!, lifetime);
}
catch
{
await DisposeAsync(lifetime).ConfigureAwait(false);
throw;
}
} }
/// <inheritdoc /> /// <inheritdoc />
@@ -95,6 +105,40 @@ public sealed class SshNetConnectionFactory(IKnownHostStore knownHosts)
{ {
ArgumentNullException.ThrowIfNull(request); ArgumentNullException.ThrowIfNull(request);
var lifetime = request.Proxy?.Lifetime;
try
{
return await OpenSftpCoreAsync(request, lifetime, cancellationToken).ConfigureAwait(false);
}
catch
{
await DisposeAsync(lifetime).ConfigureAwait(false);
throw;
}
}
/// <summary>
/// Disposes a proxy the connection was given, when the connection it was given for did not happen.
/// </summary>
/// <remarks>
/// Every failure path, including the ones before a socket exists — an unreadable key throws from
/// <see cref="BuildConnectionInfo"/> — because a relay bridge left listening after a failed connect is a
/// loopback SOCKS proxy with an open relay session behind it, and nothing would ever close it.
/// </remarks>
private static async ValueTask DisposeAsync(IAsyncDisposable? lifetime)
{
if (lifetime is not null)
{
await lifetime.DisposeAsync().ConfigureAwait(false);
}
}
private async Task<ISftpSession> OpenSftpCoreAsync(
SshConnectionRequest request,
IAsyncDisposable? lifetime,
CancellationToken cancellationToken)
{
// Keep-alive here for the reason it is on the shell client: a transfer connection left open while // Keep-alive here for the reason it is on the shell client: a transfer connection left open while
// somebody browses is idle in exactly the same way, and a file listing against a machine that has // somebody browses is idle in exactly the same way, and a file listing against a machine that has
// since rebooted would otherwise wait on a socket nothing will ever answer. // since rebooted would otherwise wait on a socket nothing will ever answer.
@@ -125,7 +169,7 @@ public sealed class SshNetConnectionFactory(IKnownHostStore knownHosts)
throw; throw;
} }
return new SshNetSftpSession(client, gate.Presented!, home); return new SshNetSftpSession(client, gate.Presented!, home, lifetime);
} }
/// <summary> /// <summary>
@@ -326,7 +370,15 @@ public sealed class SshNetConnectionFactory(IKnownHostStore knownHosts)
} }
/// <summary>An SSH.NET-backed connection.</summary> /// <summary>An SSH.NET-backed connection.</summary>
internal sealed class SshNetConnection(SshClient client, HostKeyPresentation hostKey) : ISshConnection /// <remarks>
/// Owns the proxy it was reached through when it was given one, and disposes it after the client — the
/// order that lets SSH.NET close its end of the loopback socket before the thing on the other end goes.
/// </remarks>
internal sealed class SshNetConnection(
SshClient client,
HostKeyPresentation hostKey,
IAsyncDisposable? proxyLifetime = null)
: ISshConnection
{ {
/// <inheritdoc /> /// <inheritdoc />
public bool IsConnected => client.IsConnected; public bool IsConnected => client.IsConnected;
@@ -366,10 +418,14 @@ internal sealed class SshNetConnection(SshClient client, HostKeyPresentation hos
} }
/// <inheritdoc /> /// <inheritdoc />
public ValueTask DisposeAsync() public async ValueTask DisposeAsync()
{ {
client.Dispose(); client.Dispose();
return ValueTask.CompletedTask;
if (proxyLifetime is not null)
{
await proxyLifetime.DisposeAsync().ConfigureAwait(false);
}
} }
} }
+12 -2
View File
@@ -14,13 +14,23 @@ namespace DodoSSH.Client.Ssh;
internal sealed class SshNetSftpSession : ISftpSession internal sealed class SshNetSftpSession : ISftpSession
{ {
private readonly SftpClient client; private readonly SftpClient client;
private readonly IAsyncDisposable? proxyLifetime;
private string? transportFailure; private string? transportFailure;
private int announced; private int announced;
internal SshNetSftpSession(SftpClient client, HostKeyPresentation hostKey, string homeDirectory) /// <param name="client">The connected client.</param>
/// <param name="hostKey">What the server presented.</param>
/// <param name="homeDirectory">Where the session starts.</param>
/// <param name="proxyLifetime">The proxy this session was reached through, when it owns it.</param>
internal SshNetSftpSession(
SftpClient client,
HostKeyPresentation hostKey,
string homeDirectory,
IAsyncDisposable? proxyLifetime = null)
{ {
this.client = client; this.client = client;
this.proxyLifetime = proxyLifetime;
HostKey = hostKey; HostKey = hostKey;
HomeDirectory = homeDirectory; HomeDirectory = homeDirectory;
@@ -243,7 +253,7 @@ internal sealed class SshNetSftpSession : ISftpSession
client.Dispose(); client.Dispose();
return ValueTask.CompletedTask; return proxyLifetime?.DisposeAsync() ?? ValueTask.CompletedTask;
} }
/// <remarks> /// <remarks>
+18 -12
View File
@@ -1,27 +1,33 @@
namespace DodoSSH.Client.Terminal; namespace DodoSSH.Client.Terminal;
/// <summary> /// <summary>
/// Credit-based flow control over one terminal session's output. /// Credit-based flow control over what has been sent to the renderer and not yet drawn.
/// </summary> /// </summary>
/// <remarks> /// <remarks>
/// <para> /// <para>
/// This is what makes <c>yes</c> survivable. A terminal emulator renders at 60 Hz at best, while a /// A terminal emulator renders at 60 Hz at best, while a remote process can produce output as fast as
/// remote process can produce output as fast as the network allows. Without a limit the difference /// the network allows. The difference has to accumulate somewhere, and the one place it must never
/// accumulates somewhere — an unbounded queue in the client, or an ever-growing scrollback — and the /// accumulate is inside the WebView: xterm queues whatever it is written and nothing on this side can
/// application's memory grows until it dies. /// see how deep that queue is, so a page told to draw faster than it can grows until the tab dies.
/// </para> /// </para>
/// <para> /// <para>
/// The mechanism: the renderer is granted a window of bytes it is allowed to be behind by. Each byte /// The mechanism: the renderer is granted a window of bytes it is allowed to be behind by. Each byte
/// sent to it consumes credit; each byte it reports having actually rendered returns credit. When /// sent to it consumes credit; each byte it reports having actually rendered returns credit. When
/// credit reaches zero the pump <b>stops reading the SSH channel</b>. That closes SSH's own receive /// credit reaches zero the pump sends nothing more until some comes back.
/// window, which makes the remote <c>sshd</c> block on write, which propagates the backpressure all
/// the way to the process producing the output. Nothing buffers without bound because nothing is read
/// that cannot be delivered.
/// </para> /// </para>
/// <para> /// <para>
/// The window has to be large enough that a normal burst never stalls and small enough to bound /// ◆ <b>What this does not do is bound what the remote has sent</b>, and it used to be written as
/// memory. 256 KiB is roughly a screenful of dense output many times over, and it caps a session's /// though it did — the claim was that a pump which stops reading closes SSH's own receive window and
/// in-flight cost at a quarter of a megabyte. /// blocks the remote <c>sshd</c>. It does not, because SSH.NET re-opens that window as bytes arrive
/// rather than as they are consumed. Holding output back therefore never reached the remote at all;
/// it only chose which buffer the flood landed in, and the one it landed in had no ceiling. The bound
/// that was missing now lives in <see cref="OutputBacklog"/>, which is also where the evidence for
/// this paragraph is written down.
/// </para>
/// <para>
/// The window has to be large enough that a normal burst never stalls and small enough to bound what
/// the page is holding. 256 KiB is roughly a screenful of dense output many times over, and it caps a
/// session's in-flight cost at a quarter of a megabyte.
/// </para> /// </para>
/// </remarks> /// </remarks>
public sealed class CreditWindow public sealed class CreditWindow
@@ -0,0 +1,264 @@
namespace DodoSSH.Client.Terminal;
/// <summary>
/// One session's bounded queue of output waiting for the renderer, oldest first.
/// </summary>
/// <remarks>
/// <para>
/// ◆ <b>This is where a session's memory is actually bounded, and it exists because the obvious place
/// cannot do it.</b> The design used to be that <see cref="CreditWindow"/> bounded everything: the pump
/// stopped reading the SSH channel when the renderer fell behind, SSH's own receive window closed, and the
/// remote blocked on write. The middle step is not true of the library this client uses.
/// <c>Renci.SshNet.Channels.Channel.OnData</c> calls its window adjustment <em>before</em> raising
/// <c>DataReceived</c> and re-opens the channel window as soon as it drops below one packet, and
/// <c>ShellStream</c>'s own handler copies the bytes into a growable buffer without blocking and without a
/// ceiling. So a reader that stops reading does not slow the remote down by one byte; it only decides
/// whose buffer the flood accumulates in — and SSH.NET's grows by doubling and does not give the memory
/// back until the stream is disposed. A remote running <c>yes</c> took the process with it.
/// </para>
/// <para>
/// So the pump now reads continuously, which is what keeps SSH.NET's buffer empty, and the backlog it
/// reads into is this one, with a hard capacity. When the renderer cannot keep up the <em>oldest</em>
/// bytes go rather than the newest, because the newest are the ones somebody is waiting to see: the tail
/// of a flood is the prompt that comes back after it. Dropping is announced rather than silent — see
/// <see cref="Take"/> — and it is the honest end of the trade, since output arriving faster than the
/// terminal can draw it was going to scroll off a 5,000-line scrollback regardless.
/// </para>
/// <para>
/// The credit window is still here and still does its own job: it bounds what is in flight <em>to the
/// renderer</em>, which is the buffer inside the WebView that nothing on this side can see. What changed
/// is that it no longer pretends to bound what is in flight from the remote.
/// </para>
/// </remarks>
public sealed class OutputBacklog
{
/// <summary>
/// Default capacity: 4 MiB.
/// </summary>
/// <remarks>
/// Sixteen times the credit window, so nothing an ordinary burst produces is ever dropped — a
/// screenful of dense output is kilobytes, and a build that scrolls for a second is well under this.
/// It is a per-session cost, and it is the whole of what a runaway remote can take, which is the
/// number worth choosing against: twenty tabs all flooding at once is 80 MiB and survivable, where the
/// same twenty unbounded was whatever the machine had.
/// </remarks>
public const int DefaultCapacityBytes = 4 * 1024 * 1024;
private readonly Lock gate = new();
private readonly Queue<byte[]> segments = new();
private readonly int capacityBytes;
/// <summary>Signalled when output arrives at an empty backlog, and when it is completed.</summary>
private TaskCompletionSource available = CreateSignal();
/// <summary>How much of the head segment has already been taken.</summary>
private int head;
private int buffered;
private long droppedSinceTake;
private long droppedTotal;
private bool completed;
/// <param name="capacityBytes">How many unsent bytes to hold before dropping the oldest.</param>
public OutputBacklog(int capacityBytes = DefaultCapacityBytes)
{
ArgumentOutOfRangeException.ThrowIfLessThan(capacityBytes, 1);
this.capacityBytes = capacityBytes;
}
/// <summary>How many unsent bytes are held.</summary>
public int Buffered
{
get
{
lock (gate)
{
return buffered;
}
}
}
/// <summary>How many bytes this backlog has discarded over its whole life.</summary>
public long DroppedTotal
{
get
{
lock (gate)
{
return droppedTotal;
}
}
}
/// <summary>Whether the producer has said there will be no more output.</summary>
public bool IsCompleted
{
get
{
lock (gate)
{
return completed;
}
}
}
/// <summary>
/// Adds output, dropping the oldest already held if that puts the backlog over capacity.
/// </summary>
/// <remarks>
/// Takes ownership of <paramref name="segment"/>; the caller must not write to it afterwards.
/// Appending to a completed backlog does nothing rather than throwing, because a producer finding out
/// it has been shut down is a race rather than a mistake.
/// </remarks>
/// <param name="segment">Bytes read from the remote, in order.</param>
public void Append(byte[] segment)
{
ArgumentNullException.ThrowIfNull(segment);
if (segment.Length == 0)
{
return;
}
lock (gate)
{
if (completed)
{
return;
}
var wasEmpty = buffered == 0;
segments.Enqueue(segment);
buffered += segment.Length;
// Never the segment just added, however large it is. A read bigger than the whole capacity is
// possible if somebody configures one, and a backlog that answered every take with nothing
// would stall the session rather than bound it.
while (buffered > capacityBytes && segments.Count > 1)
{
var oldest = segments.Dequeue();
var discarded = oldest.Length - head;
head = 0;
buffered -= discarded;
droppedSinceTake += discarded;
droppedTotal += discarded;
}
// Only on the transition, because a waiter that found bytes here never captured the signal in
// the first place — see WaitForOutputAsync, which checks under this same lock. Signalling on
// every append would allocate a TaskCompletionSource per read of a session doing megabytes a
// second, for a waiter that is not there.
if (wasEmpty)
{
Signal();
}
}
}
/// <summary>
/// Moves the oldest output held into <paramref name="destination"/>, as much of it as will fit.
/// </summary>
/// <remarks>
/// <para>
/// Into a caller's span rather than into an array of its own, because this is the hot path: the pump
/// writes straight into the frame it is about to send, so a terminal showing a gigabyte costs one copy
/// of it here rather than two.
/// </para>
/// <para>
/// <paramref name="dropped"/> is what makes a drop visible instead of silent. It counts the bytes
/// discarded since the previous take, which is exactly the gap sitting immediately before the bytes
/// being handed over now. The caller writes a line saying so, and it has to — the alternative is a
/// terminal quietly showing a different transcript from the one the remote sent. It is reported even
/// when nothing is taken, so a drop at the very end of a session is still announced.
/// </para>
/// </remarks>
/// <param name="destination">Where the bytes go, oldest first.</param>
/// <param name="dropped">Bytes discarded since the previous take, and zero on the ordinary path.</param>
/// <returns>How many bytes were written, which is zero when nothing is held.</returns>
public int TakeInto(Span<byte> destination, out long dropped)
{
lock (gate)
{
dropped = droppedSinceTake;
droppedSinceTake = 0;
var take = Math.Min(destination.Length, buffered);
var offset = 0;
while (offset < take)
{
var oldest = segments.Peek();
var fromThis = Math.Min(oldest.Length - head, take - offset);
oldest.AsSpan(head, fromThis).CopyTo(destination[offset..]);
offset += fromThis;
head += fromThis;
buffered -= fromThis;
if (head == oldest.Length)
{
_ = segments.Dequeue();
head = 0;
}
}
return take;
}
}
/// <summary>Says there will be no more output, releasing anything waiting for some.</summary>
public void Complete()
{
lock (gate)
{
completed = true;
Signal();
}
}
/// <summary>Waits until there is output to take, or until there will never be any.</summary>
/// <param name="cancellationToken">Abandons the wait.</param>
/// <returns><see langword="false"/> once the backlog is completed and empty.</returns>
public async ValueTask<bool> WaitForOutputAsync(CancellationToken cancellationToken)
{
while (true)
{
Task signal;
lock (gate)
{
if (buffered > 0)
{
return true;
}
if (completed)
{
return false;
}
signal = available.Task;
}
await signal.WaitAsync(cancellationToken).ConfigureAwait(false);
}
}
/// <remarks>
/// Completed inside the lock so a waiter cannot miss the transition, and replaced there too so the
/// next wait is on a signal that has not already fired. Continuations run asynchronously, so nothing
/// resumes while the lock is held.
/// </remarks>
private void Signal()
{
_ = available.TrySetResult();
available = CreateSignal();
}
private static TaskCompletionSource CreateSignal() =>
new(TaskCreationOptions.RunContinuationsAsynchronously);
}
@@ -120,6 +120,32 @@ public enum TerminalServerOpcode : byte
/// </para> /// </para>
/// </remarks> /// </remarks>
Clipboard = 8, Clipboard = 8,
/// <summary>
/// A line for the pane saying that output was dropped. Payload is UTF-8, already styled.
/// </summary>
/// <remarks>
/// <para>
/// Written into the pane exactly where it arrives, which is where the gap is — the socket keeps order
/// within a session, so this frame lands between the bytes before the drop and the bytes after it.
/// </para>
/// <para>
/// <b>Its own opcode rather than a few bytes spliced into an <see cref="Output"/> frame</b>, which is
/// what it was first, and the reason is that the two are not the same kind of thing. Output is what the
/// remote said, and this is what this application says about it. Keeping them apart means the host's
/// own sentence is never mistaken for the transcript — by anything reading a frame, and in particular
/// by the arithmetic that has to hold if dropping is to stay honest: every byte read from the remote is
/// either in an <see cref="Output"/> payload or counted in <c>TerminalSessionPump.BytesDropped</c>, and
/// a notice inside the output stream would put this process's words on the left of that equation.
/// </para>
/// <para>
/// Not acknowledged, and so not part of the credit window: credit accounts for what the remote sent
/// and what the renderer has drawn of it. A notice is a few dozen bytes the host chose to add, and
/// billing them to a window that is meant to describe the remote would make the number mean two
/// things.
/// </para>
/// </remarks>
OutputDropped = 9,
} }
/// <summary>Frames the renderer sends to the host.</summary> /// <summary>Frames the renderer sends to the host.</summary>
+257 -102
View File
@@ -1,6 +1,6 @@
using System.Buffers; using System.Buffers;
using System.Globalization;
using System.Text; using System.Text;
using System.Threading.Channels;
using DodoSSH.Client.Ssh; using DodoSSH.Client.Ssh;
namespace DodoSSH.Client.Terminal; namespace DodoSSH.Client.Terminal;
@@ -49,6 +49,16 @@ public sealed class TerminalPumpOptions
/// <summary>How far behind the renderer may fall, in bytes.</summary> /// <summary>How far behind the renderer may fall, in bytes.</summary>
public int WindowBytes { get; init; } = CreditWindow.DefaultWindowBytes; public int WindowBytes { get; init; } = CreditWindow.DefaultWindowBytes;
/// <summary>
/// How much unsent output to hold for a renderer that is behind, before dropping the oldest.
/// </summary>
/// <remarks>
/// This is the number that bounds a session's memory, and <see cref="OutputBacklog"/> says at length
/// why it rather than <see cref="WindowBytes"/> is the one that does. Larger drops less and shows a
/// flood's tail later; smaller drops sooner and keeps the terminal closer to live.
/// </remarks>
public int BacklogBytes { get; init; } = OutputBacklog.DefaultCapacityBytes;
} }
/// <summary> /// <summary>
@@ -56,27 +66,45 @@ public sealed class TerminalPumpOptions
/// </summary> /// </summary>
/// <remarks> /// <remarks>
/// <para> /// <para>
/// Credit is reserved before reading, never after. That ordering is the whole design: because the pump /// ◆ <b>The pump reads the shell channel continuously and never stops, which is deliberate rather than
/// cannot read more than the renderer has room for, the coalescing buffer is bounded by the credit /// careless.</b> It used to stop as soon as the renderer fell behind, on the reasoning that a reader
/// window rather than by how fast the remote can talk. Reserving after reading would leave an /// which does not read closes SSH's receive window, blocks the remote <c>sshd</c> on write, and blocks
/// unbounded queue between the socket and the screen, which is the failure mode this exists to /// the process producing the output in turn — backpressure all the way to the source, with no custom
/// prevent. /// protocol. That reasoning is wrong for this client's SSH library, and wrong in the direction that costs
/// memory: SSH.NET re-opens the channel window when bytes <em>arrive</em> rather than when they are
/// consumed, and keeps everything it has been handed in a growable array it does not give back. Not
/// reading slowed nothing down; it only moved the flood into a buffer with no ceiling.
/// <see cref="OutputBacklog"/> carries the full account.
/// </para> /// </para>
/// <para> /// <para>
/// When credit runs out the pump stops reading. SSH's own receive window then closes, the remote /// So there are two bounds now, each enforced where it can be. The backlog bounds what is waiting to be
/// <c>sshd</c> blocks on write, and the process producing output blocks in turn — backpressure all the /// sent, by dropping its oldest bytes and saying so. The credit window bounds what has been sent and not
/// way to the source, with no custom protocol. /// yet drawn — the buffer inside the WebView that nothing on this side can measure — and the flush loop
/// reserves against it before every frame, holding off while there is none. Reading is no longer part of
/// either, because reading was never what the remote was waiting on.
/// </para> /// </para>
/// </remarks> /// </remarks>
public sealed class TerminalSessionPump : IAsyncDisposable public sealed class TerminalSessionPump : IAsyncDisposable
{ {
/// <summary>
/// The most output one frame carries.
/// </summary>
/// <remarks>
/// Under the 85,000-byte threshold at which the runtime allocates on the large object heap, and that is
/// the whole of why the number is here: a frame is allocated per send, and a session doing megabytes a
/// second would otherwise put a quarter-megabyte array on the LOH sixty times a second, which is not
/// compacted and is collected only with a generation 2 pass. Below the threshold the same traffic is
/// generation 0 garbage that costs nothing to collect. It is a ceiling rather than a target — a quiet
/// terminal sends whatever it has, which is a few bytes.
/// </remarks>
private const int MaximumFrameBytes = 64 * 1024;
private readonly uint sessionId; private readonly uint sessionId;
private readonly ISshShellSession session; private readonly ISshShellSession session;
private readonly ITerminalTransport transport; private readonly ITerminalTransport transport;
private readonly TimeProvider clock; private readonly TimeProvider clock;
private readonly TerminalPumpOptions options; private readonly TerminalPumpOptions options;
private readonly Channel<byte[]> pending = Channel.CreateUnbounded<byte[]>( private readonly OutputBacklog backlog;
new UnboundedChannelOptions { SingleReader = true, SingleWriter = true });
private readonly CancellationTokenSource lifetime = new(); private readonly CancellationTokenSource lifetime = new();
private int disposed; private int disposed;
@@ -104,6 +132,7 @@ public sealed class TerminalSessionPump : IAsyncDisposable
this.options = options ?? new TerminalPumpOptions(); this.options = options ?? new TerminalPumpOptions();
Credits = new CreditWindow(this.options.WindowBytes); Credits = new CreditWindow(this.options.WindowBytes);
backlog = new OutputBacklog(this.options.BacklogBytes);
} }
/// <summary>This session's flow-control window.</summary> /// <summary>This session's flow-control window.</summary>
@@ -112,6 +141,19 @@ public sealed class TerminalSessionPump : IAsyncDisposable
/// <summary>Total bytes read from the remote, for the throughput harness.</summary> /// <summary>Total bytes read from the remote, for the throughput harness.</summary>
public long BytesRead { get; private set; } public long BytesRead { get; private set; }
/// <summary>
/// Total bytes this session discarded because the renderer could not keep up with the remote.
/// </summary>
/// <remarks>
/// Zero for every ordinary session, and the number to look at first when somebody reports missing
/// output. The user is told as it happens — a dropped run puts a line in the pane rather than a gap —
/// so this is for a test or a report rather than for the interface.
/// </remarks>
public long BytesDropped => backlog.DroppedTotal;
/// <summary>Bytes read from the remote and not yet sent to the renderer.</summary>
public int BytesPending => backlog.Buffered;
/// <summary>Total frames sent to the renderer, for the throughput harness.</summary> /// <summary>Total frames sent to the renderer, for the throughput harness.</summary>
public long FramesSent { get; private set; } public long FramesSent { get; private set; }
@@ -152,31 +194,7 @@ public sealed class TerminalSessionPump : IAsyncDisposable
var reader = ReadLoopAsync(linked.Token); var reader = ReadLoopAsync(linked.Token);
var flusher = FlushLoopAsync(linked.Token); var flusher = FlushLoopAsync(linked.Token);
TerminalSessionOutcome outcome; var outcome = await ReadUntilItEndsAsync(reader).ConfigureAwait(false);
try
{
await reader.ConfigureAwait(false);
// The read loop finished of its own accord, which means the shell is over. Which of the two ways
// it is over is not a question asked of the transport now — by now the server has very likely hung
// up behind a clean exit, and asking would call `exit` a dropped connection — but of what the shell
// latched at the moment it happened. See ISshShellSession.TransportFailure.
outcome = session.TransportFailure is { Length: > 0 } failure
? new TerminalSessionOutcome(SshSessionEnd.ConnectionLost, failure)
: new TerminalSessionOutcome(SshSessionEnd.RemoteClosed, "The remote closed the session.");
}
catch (OperationCanceledException)
{
outcome = new TerminalSessionOutcome(SshSessionEnd.ClosedLocally, "The session was closed.");
}
catch (Exception exception)
{
// A read that threw rather than returning zero. Whatever it was, it was not this client asking —
// that arrives as the cancellation above — so it is the connection going out from under the read.
outcome = new TerminalSessionOutcome(
SshSessionEnd.ConnectionLost,
session.TransportFailure is { Length: > 0 } failure ? failure : exception.Message);
}
// Before the drain and the last frame, so that anything reading this off a completed run — the // Before the drain and the last frame, so that anything reading this off a completed run — the
// workspace's own announcement — cannot see the default. // workspace's own announcement — cannot see the default.
@@ -185,7 +203,17 @@ public sealed class TerminalSessionPump : IAsyncDisposable
// Stop the flusher, but only after draining what the reader already produced — the last thing // Stop the flusher, but only after draining what the reader already produced — the last thing
// a remote writes is often the most important, and dropping it makes a clean exit look like a // a remote writes is often the most important, and dropping it makes a clean exit look like a
// crash. // crash.
pending.Writer.TryComplete(); backlog.Complete();
// ◆ AND RELEASE THE FLUSHER IF IT IS PARKED ON CREDIT, WHICH IS NOT THE SAME SIGNAL. Completing
// the backlog wakes anything waiting for output; it says nothing to a flush loop that has output
// and is waiting for the renderer to make room for it. Against a renderer that has stopped
// acknowledging — the page's process killed, the window gone — that acknowledgement never comes,
// and without this the await below would never return: the shell would have ended, the tab would
// never be told, and the session would never be torn down. Resetting rather than waiting is
// right because the window describes a renderer's remaining room and there is nothing left to
// protect it from: what follows is one backlog's worth of tail and then the session is over.
Credits.Reset();
try try
{ {
@@ -203,6 +231,42 @@ public sealed class TerminalSessionPump : IAsyncDisposable
.ConfigureAwait(false); .ConfigureAwait(false);
} }
/// <summary>
/// Waits for the read loop to finish, and says which of the three ways it did.
/// </summary>
/// <remarks>
/// Split out of <see cref="RunAsync"/> for length rather than for reuse, and it is the half of that
/// method with no side effects: three branches, one answer, nothing touched.
/// </remarks>
/// <param name="reader">The read loop's task.</param>
private async Task<TerminalSessionOutcome> ReadUntilItEndsAsync(Task reader)
{
try
{
await reader.ConfigureAwait(false);
// The read loop finished of its own accord, which means the shell is over. Which of the two ways
// it is over is not a question asked of the transport now — by now the server has very likely hung
// up behind a clean exit, and asking would call `exit` a dropped connection — but of what the shell
// latched at the moment it happened. See ISshShellSession.TransportFailure.
return session.TransportFailure is { Length: > 0 } failure
? new TerminalSessionOutcome(SshSessionEnd.ConnectionLost, failure)
: new TerminalSessionOutcome(SshSessionEnd.RemoteClosed, "The remote closed the session.");
}
catch (OperationCanceledException)
{
return new TerminalSessionOutcome(SshSessionEnd.ClosedLocally, "The session was closed.");
}
catch (Exception exception)
{
// A read that threw rather than returning zero. Whatever it was, it was not this client asking —
// that arrives as the cancellation above — so it is the connection going out from under the read.
return new TerminalSessionOutcome(
SshSessionEnd.ConnectionLost,
session.TransportFailure is { Length: > 0 } failure ? failure : exception.Message);
}
}
/// <summary>Forwards keystrokes to the remote.</summary> /// <summary>Forwards keystrokes to the remote.</summary>
public ValueTask WriteInputAsync(ReadOnlyMemory<byte> data, CancellationToken cancellationToken) => public ValueTask WriteInputAsync(ReadOnlyMemory<byte> data, CancellationToken cancellationToken) =>
session.WriteAsync(data, cancellationToken); session.WriteAsync(data, cancellationToken);
@@ -227,44 +291,37 @@ public sealed class TerminalSessionPump : IAsyncDisposable
// Unblocks anything waiting on credit that will now never be acknowledged. // Unblocks anything waiting on credit that will now never be acknowledged.
Credits.Reset(); Credits.Reset();
pending.Writer.TryComplete(); backlog.Complete();
lifetime.Dispose(); lifetime.Dispose();
await session.DisposeAsync().ConfigureAwait(false); await session.DisposeAsync().ConfigureAwait(false);
} }
/// <remarks>
/// No credit is consulted here, and the class remark says at length why: the remote is not waiting on
/// this loop, so pausing it buys nothing and costs a buffer inside SSH.NET that grows without bound.
/// What this loop owes is to keep that buffer empty, which means reading as fast as the channel
/// delivers and putting the result somewhere with a ceiling.
/// </remarks>
private async Task ReadLoopAsync(CancellationToken cancellationToken) private async Task ReadLoopAsync(CancellationToken cancellationToken)
{ {
var buffer = ArrayPool<byte>.Shared.Rent(options.ReadBufferBytes); var buffer = ArrayPool<byte>.Shared.Rent(options.ReadBufferBytes);
try try
{ {
while (!cancellationToken.IsCancellationRequested) while (true)
{ {
await Credits.WaitForCreditAsync(cancellationToken).ConfigureAwait(false); // Thrown rather than tested in the loop condition, and the difference is the whole of how
// this session's ending is described. RunAsync reads a read loop that RETURNS as
// the remote having closed the channel, and one that throws OperationCanceledException as
// this client having ended it. A condition on the token would leave by the first door for
// a reason that belongs to the second, and a tab the user closed would report itself as a
// shell that exited on its own.
cancellationToken.ThrowIfCancellationRequested();
var granted = Credits.TryReserve(options.ReadBufferBytes); var read = await session
if (granted == 0) .ReadAsync(buffer.AsMemory(0, options.ReadBufferBytes), cancellationToken)
{ .ConfigureAwait(false);
continue;
}
int read;
try
{
read = await session
.ReadAsync(buffer.AsMemory(0, granted), cancellationToken)
.ConfigureAwait(false);
}
catch
{
Credits.Return(granted);
throw;
}
// Hand back what was reserved but not used, so a short read does not permanently
// shrink the window.
Credits.Return(granted - read);
if (read == 0) if (read == 0)
{ {
@@ -272,7 +329,10 @@ public sealed class TerminalSessionPump : IAsyncDisposable
} }
BytesRead += read; BytesRead += read;
await pending.Writer.WriteAsync(buffer[..read], cancellationToken).ConfigureAwait(false);
// Copied out of the rented buffer, because the backlog holds it until the renderer has
// room and the next read is already about to overwrite this one.
backlog.Append(buffer[..read]);
} }
} }
finally finally
@@ -283,65 +343,160 @@ public sealed class TerminalSessionPump : IAsyncDisposable
private async Task FlushLoopAsync(CancellationToken cancellationToken) private async Task FlushLoopAsync(CancellationToken cancellationToken)
{ {
var segments = new List<byte[]>(); while (await backlog.WaitForOutputAsync(cancellationToken).ConfigureAwait(false))
while (await pending.Reader.WaitToReadAsync(cancellationToken).ConfigureAwait(false))
{ {
if (!pending.Reader.TryRead(out var first)) if (backlog.IsCompleted)
{ {
// The reader has finished and what is left is the tail, which goes out regardless of
// credit. Leaving by this door rather than going round again is load-bearing: with the
// backlog complete, SendWhatCreditAllowsAsync declines to wait for an acknowledgement
// that may never come, so a renderer that has stopped would put this loop into a spin —
// output to send, no credit to send it with, and a wait for more output that returns at
// once because there is some.
break;
}
// Coalesce for one frame's worth of time before the first send, so a burst arriving at an idle
// terminal becomes a single write. Under sustained output the loop below never comes back
// here, and does not need to: credit is what paces it then, and a frame is as large as the
// renderer has room for.
await Task.Delay(options.FlushInterval, clock, cancellationToken).ConfigureAwait(false);
await SendWhatCreditAllowsAsync(cancellationToken).ConfigureAwait(false);
}
await DrainAsync().ConfigureAwait(false);
}
/// <summary>Sends until the backlog is empty or the renderer has no room left.</summary>
private async Task SendWhatCreditAllowsAsync(CancellationToken cancellationToken)
{
while (true)
{
var wanted = Math.Min(backlog.Buffered, MaximumFrameBytes);
if (wanted == 0)
{
return;
}
var granted = Credits.TryReserve(wanted);
if (granted == 0)
{
// The renderer is behind. Nothing more goes out until it acknowledges, and meanwhile the
// backlog holds what it can and drops its oldest for what it cannot — which is the whole
// of how this session's memory stays bounded.
if (backlog.IsCompleted)
{
// Except at the end, where waiting on an acknowledgement that may never come would
// hang the session's teardown behind a renderer that has already gone.
return;
}
await Credits.WaitForCreditAsync(cancellationToken).ConfigureAwait(false);
continue; continue;
} }
segments.Clear(); var sent = await SendFromBacklogAsync(granted, cancellationToken).ConfigureAwait(false);
segments.Add(first);
// Coalesce for one frame's worth of time, then send everything at once. Whatever the if (granted > sent)
// remote produced in that window becomes a single write to the terminal.
await Task.Delay(options.FlushInterval, clock, cancellationToken).ConfigureAwait(false);
while (pending.Reader.TryRead(out var more))
{ {
segments.Add(more); // Whatever was reserved and not used, so a backlog that shrank between the reservation
// and the take does not permanently narrow the window. Guarded rather than called with a
// zero, because returning credit wakes every waiter and replaces the signal they were
// waiting on, and this is the hot path.
Credits.Return(granted - sent);
} }
await SendOutputAsync(segments, cancellationToken).ConfigureAwait(false);
}
// The channel completed. Anything the reader wrote before finishing still has to go out.
segments.Clear();
while (pending.Reader.TryRead(out var trailing))
{
segments.Add(trailing);
}
if (segments.Count > 0)
{
await SendOutputAsync(segments, CancellationToken.None).ConfigureAwait(false);
} }
} }
private async ValueTask SendOutputAsync(List<byte[]> segments, CancellationToken cancellationToken) /// <summary>
/// Puts the last of the output out, regardless of credit.
/// </summary>
/// <remarks>
/// The session is over by the time this runs, so there is no renderer left to protect from a flood —
/// and what remains is bounded by the backlog's own capacity rather than by anything the remote can
/// still do. Waiting on credit here instead would mean a shell that exited against a renderer which
/// had gone never finished tearing down.
/// </remarks>
private async Task DrainAsync()
{ {
var total = 0; while (await SendFromBacklogAsync(MaximumFrameBytes, CancellationToken.None)
foreach (var segment in segments) .ConfigureAwait(false) > 0)
{ {
total += segment.Length; // Until it is empty.
}
}
/// <summary>
/// Moves up to <paramref name="maxBytes"/> out of the backlog and onto the wire.
/// </summary>
/// <returns>How many bytes of output were sent, which is zero once the backlog is empty.</returns>
private async ValueTask<int> SendFromBacklogAsync(int maxBytes, CancellationToken cancellationToken)
{
// Taken straight into the frame, header space and all. A second buffer here would be an
// allocation and a copy of every byte the terminal ever shows.
var frame = new byte[TerminalFrame.HeaderLength + maxBytes];
var taken = backlog.TakeInto(frame.AsSpan(TerminalFrame.HeaderLength), out var dropped);
if (dropped > 0)
{
// Sent immediately before the bytes it explains, and under its own opcode — see
// TerminalServerOpcode.OutputDropped for why this is not simply spliced into the output.
await SendAsync(TerminalServerOpcode.OutputDropped, DroppedNotice(dropped), cancellationToken)
.ConfigureAwait(false);
}
if (taken == 0)
{
return 0;
} }
var frame = new byte[TerminalFrame.HeaderLength + total];
TerminalFrame.Write(frame, (byte)TerminalServerOpcode.Output, sessionId, default); TerminalFrame.Write(frame, (byte)TerminalServerOpcode.Output, sessionId, default);
var offset = TerminalFrame.HeaderLength;
foreach (var segment in segments)
{
segment.CopyTo(frame, offset);
offset += segment.Length;
}
FramesSent++; FramesSent++;
await transport.SendAsync(frame, cancellationToken).ConfigureAwait(false);
await transport
.SendAsync(frame.AsMemory(0, TerminalFrame.HeaderLength + taken), cancellationToken)
.ConfigureAwait(false);
return taken;
} }
/// <summary>
/// The line a user sees where output was dropped.
/// </summary>
/// <remarks>
/// <para>
/// It opens with a reset rather than the colour, and that is the load-bearing part: the bytes were cut
/// at an arbitrary offset, so whatever escape sequence the remote was in the middle of has been left
/// half-said. Resetting first means the notice reads as a notice and the output after it starts from a
/// known state, instead of inheriting a colour or a mode from a sequence nobody finished.
/// </para>
/// <para>
/// Dim grey, matching the renderer's own banners for a session that closed and a view that
/// reconnected — this is the same kind of thing, a sentence from the application rather than from the
/// remote, and it should not read like part of the transcript.
/// </para>
/// </remarks>
private static byte[] DroppedNotice(long dropped) =>
Encoding.UTF8.GetBytes(string.Create(
CultureInfo.InvariantCulture,
$"\u001b[0m\r\n\u001b[38;5;244m── {Sized(dropped)} of output was dropped; "
+ $"the terminal could not keep up ──\u001b[0m\r\n"));
/// <remarks>
/// One decimal place from a megabyte up, because the number is an order of magnitude rather than an
/// accounting: what a person needs from it is whether they lost a screenful or a session's worth.
/// </remarks>
private static string Sized(long bytes) => bytes switch
{
< 1024 => string.Create(CultureInfo.CurrentCulture, $"{bytes} bytes"),
< 1024 * 1024 => string.Create(CultureInfo.CurrentCulture, $"{bytes / 1024.0:0.#} KB"),
< 1024L * 1024 * 1024 => string.Create(CultureInfo.CurrentCulture, $"{bytes / (1024.0 * 1024):0.#} MB"),
_ => string.Create(CultureInfo.CurrentCulture, $"{bytes / (1024.0 * 1024 * 1024):0.#} GB"),
};
private async ValueTask SendAsync( private async ValueTask SendAsync(
TerminalServerOpcode opcode, TerminalServerOpcode opcode,
ReadOnlyMemory<byte> payload, ReadOnlyMemory<byte> payload,
@@ -209,11 +209,12 @@ public sealed class TerminalWorkspace : IAsyncDisposable
/// </summary> /// </summary>
/// <remarks> /// <remarks>
/// <para> /// <para>
/// Not <c>sessions.Count</c>, which over-reports. Nothing removes an entry when the remote closes /// Not <c>sessions.Count</c>, which over-reports. Nothing removes an entry when the remote closes the
/// the channel on its own — <see cref="RunSessionAsync"/> only drops the renderer registration — so /// channel on its own — <see cref="ReleaseAsync"/> gives back what that session was holding but leaves
/// a session whose shell exited half an hour ago is still in the dictionary. A completed /// the entry, so the tab can go on saying it ended — and a session whose shell exited half an hour ago
/// <c>Run</c> task is what "the shell is gone" actually looks like: the pump's loops have finished /// is therefore still in the dictionary. A completed <c>Run</c> task is what "the shell is gone"
/// and it has already sent <c>SessionClosed</c> to the renderer. /// actually looks like: the pump's loops have finished and it has already sent <c>SessionClosed</c> to
/// the renderer.
/// </para> /// </para>
/// <para> /// <para>
/// This exists because the shell shows the number on the unlock screen, and a lock screen that /// This exists because the shell shows the number on the unlock screen, and a lock screen that
@@ -642,6 +643,13 @@ public sealed class TerminalWorkspace : IAsyncDisposable
/// A session id this workspace does not know is ignored rather than throwing. The caller is a tab /// A session id this workspace does not know is ignored rather than throwing. The caller is a tab
/// strip, and a tab that closed while a key was in flight is ordinary rather than exceptional. /// strip, and a tab that closed while a key was in flight is ordinary rather than exceptional.
/// </para> /// </para>
/// <para>
/// A session whose shell has <em>ended</em> is ignored the same way, and has to be: the tab is still on
/// screen and still selectable, so an accessory key pressed at one is as ordinary as a key pressed at a
/// tab that has closed. It is also the one of the two that would throw rather than fail quietly, since
/// <see cref="ReleaseAsync"/> disposes the shell channel the moment the remote hangs up. Liveness
/// rather than mere presence, which is the same question <see cref="IsSessionLive"/> answers.
/// </para>
/// </remarks> /// </remarks>
/// <param name="sessionId">The terminal to type into.</param> /// <param name="sessionId">The terminal to type into.</param>
/// <param name="data">Raw bytes, already encoded as the remote expects them.</param> /// <param name="data">Raw bytes, already encoded as the remote expects them.</param>
@@ -655,7 +663,9 @@ public sealed class TerminalWorkspace : IAsyncDisposable
lock (sessionGate) lock (sessionGate)
{ {
pump = sessions.TryGetValue(sessionId, out var session) ? session.Pump : null; pump = sessions.TryGetValue(sessionId, out var session) && !session.Run.IsCompleted
? session.Pump
: null;
} }
return pump is null ? ValueTask.CompletedTask : pump.WriteInputAsync(data, cancellationToken); return pump is null ? ValueTask.CompletedTask : pump.WriteInputAsync(data, cancellationToken);
@@ -848,14 +858,79 @@ public sealed class TerminalWorkspace : IAsyncDisposable
// tab, the remote hanging up, and the process shutting down. Every one of them arrives here as // tab, the remote hanging up, and the process shutting down. Every one of them arrives here as
// the pump unwinding, which is why CloseSessionAsync needs no call of its own — and why this // the pump unwinding, which is why CloseSessionAsync needs no call of its own — and why this
// must not do any work: it is running on a thread-pool thread inside DisposeAsync's loop when // must not do any work: it is running on a thread-pool thread inside DisposeAsync's loop when
// the application is closing. // the application is closing, and everything inside a finally is time the run task has not
// completed yet, which is time LiveSessionCount still counts this session as running.
// //
// SessionEnded is deliberately NOT raised from here, and it used to be — see // Neither SessionEnded nor the release of what the session held is done from here, and both
// AnnounceEndedAsync for what was wrong with that. // used to be candidates for it — see AnnounceEndedAsync, which is where they ended up and why.
ConnectionLog?.Closed(sessionId, clock.GetUtcNow()); ConnectionLog?.Closed(sessionId, clock.GetUtcNow());
} }
} }
/// <summary>
/// Gives back everything a session that ended on its own was still holding.
/// </summary>
/// <remarks>
/// <para>
/// ◆ <b>Nothing used to do this, and a shell that exited went on costing what a running one costs.</b>
/// The entry stayed in <see cref="sessions"/> until the user closed the tab, and with it an undisposed
/// <see cref="ISshConnection"/> — an authenticated socket to the remote, its cipher state, and a
/// keep-alive still putting a packet on the wire every thirty seconds — plus the pump and, underneath
/// it, SSH.NET's read buffer at whatever size the session's heaviest moment had grown it to. A tab
/// somebody typed <c>exit</c> into an hour ago and left open was indistinguishable from a live one in
/// everything except what it drew, and a working day of those is the memory a user actually notices.
/// </para>
/// <para>
/// <b>The dictionary entry stays even so, and that is not an oversight.</b>
/// <see cref="LiveSessionCount"/>, <see cref="IsSessionLive"/> and
/// <see cref="AnnounceEndedAsync"/>'s containment check are all written against it — a session that
/// ended still has to be able to say so, and a tab that shows ENDED and offers a reconnect is reading
/// exactly that. What goes is everything the entry was holding that costs anything; what is left is
/// three references and a completed task.
/// </para>
/// <para>
/// Skipped entirely when the entry has already been removed, which is precisely the deliberate path:
/// <see cref="CloseSessionAsync"/> takes the entry out before it disposes anything, so the two can
/// never both be tearing the same session down. That is also what makes this a no-op during
/// <see cref="DisposeAsync"/>, which closes every session by that route before anything here could run.
/// </para>
/// <para>
/// Every failure is swallowed. The caller is a fire-and-forget continuation with nobody to hand a fault
/// to, and the shell it would be about is already gone.
/// </para>
/// </remarks>
private async Task ReleaseAsync(uint sessionId)
{
LiveSession? session;
lock (sessionGate)
{
if (!sessions.TryGetValue(sessionId, out session))
{
return;
}
}
try
{
// The connection goes even if the pump's disposal throws, for the reason CloseSessionAsync
// gives at the same pair of calls: an undisposed ISshConnection is a live authenticated
// channel this process has forgotten about.
try
{
await session.Pump.DisposeAsync().ConfigureAwait(false);
}
finally
{
await session.Connection.DisposeAsync().ConfigureAwait(false);
}
}
catch (Exception exception) when (exception is not OutOfMemoryException)
{
// Best-effort. The shell is already gone; nothing a caller could do with this.
}
}
/// <summary>Announces a session's end once its run task has actually completed.</summary> /// <summary>Announces a session's end once its run task has actually completed.</summary>
/// <param name="sessionId">The session, as the renderer knows it.</param> /// <param name="sessionId">The session, as the renderer knows it.</param>
/// <param name="pump"> /// <param name="pump">
@@ -898,12 +973,25 @@ public sealed class TerminalWorkspace : IAsyncDisposable
announce = sessions.ContainsKey(sessionId); announce = sessions.ContainsKey(sessionId);
} }
if (announce) if (!announce)
{
return;
}
try
{ {
// Read after the await, which is the only point at which the pump has settled it — see // Read after the await, which is the only point at which the pump has settled it — see
// TerminalSessionPump.Outcome. // TerminalSessionPump.Outcome.
SessionEnded?.Invoke(this, new TerminalSessionEndedEventArgs(sessionId, pump.Outcome)); SessionEnded?.Invoke(this, new TerminalSessionEndedEventArgs(sessionId, pump.Outcome));
} }
finally
{
// After the announcement rather than before it, and in a finally so a handler that throws
// cannot leave a connection open. Tearing down an SSH connection is a socket closing and a
// library shutting down its listener; doing that first would put it between the shell ending
// and the tab being told, which is latency on the one thing the user is watching for.
await ReleaseAsync(sessionId).ConfigureAwait(false);
}
} }
/// <summary>The address as dialled, for the log.</summary> /// <summary>The address as dialled, for the log.</summary>
+11
View File
@@ -76,6 +76,17 @@ public static class ProblemCodes
/// </remarks> /// </remarks>
public const string EventsUnavailable = "events-unavailable"; public const string EventsUnavailable = "events-unavailable";
/// <summary>
/// This deployment does not relay.
/// </summary>
/// <remarks>
/// Its own code rather than <see cref="RelayTargetRejected"/>, because it is the one relay refusal
/// whose remedy is not about the host: nothing the user changes on this machine will make it work
/// here, and saying so is not an oracle for anything. <c>GET /api/v1/meta</c> says the same thing
/// without asking.
/// </remarks>
public const string RelayUnavailable = "relay-unavailable";
/// <summary>The relay refused the requested target. Never states why, to avoid a probe oracle.</summary> /// <summary>The relay refused the requested target. Never states why, to avoid a probe oracle.</summary>
public const string RelayTargetRejected = "relay-target-rejected"; public const string RelayTargetRejected = "relay-target-rejected";
@@ -966,3 +966,14 @@ static DodoSSH.Contracts.VaultKeyWrap.operator !=(DodoSSH.Contracts.VaultKeyWrap
static DodoSSH.Contracts.VaultKeyWrap.operator ==(DodoSSH.Contracts.VaultKeyWrap? left, DodoSSH.Contracts.VaultKeyWrap? right) -> bool static DodoSSH.Contracts.VaultKeyWrap.operator ==(DodoSSH.Contracts.VaultKeyWrap? left, DodoSSH.Contracts.VaultKeyWrap? right) -> bool
static DodoSSH.Contracts.VaultSummary.operator !=(DodoSSH.Contracts.VaultSummary? left, DodoSSH.Contracts.VaultSummary? right) -> bool static DodoSSH.Contracts.VaultSummary.operator !=(DodoSSH.Contracts.VaultSummary? left, DodoSSH.Contracts.VaultSummary? right) -> bool
static DodoSSH.Contracts.VaultSummary.operator ==(DodoSSH.Contracts.VaultSummary? left, DodoSSH.Contracts.VaultSummary? right) -> bool static DodoSSH.Contracts.VaultSummary.operator ==(DodoSSH.Contracts.VaultSummary? left, DodoSSH.Contracts.VaultSummary? right) -> bool
const DodoSSH.Contracts.ProblemCodes.RelayUnavailable = "relay-unavailable" -> string!
const DodoSSH.Contracts.RelayProtocol.ConnectPath = "/api/v1/relay/connect" -> string!
const DodoSSH.Contracts.RelayProtocol.DurationLimitCloseCode = 4409 -> int
const DodoSSH.Contracts.RelayProtocol.Feature = "relay" -> string!
const DodoSSH.Contracts.RelayProtocol.IdleTimeoutCloseCode = 4408 -> int
const DodoSSH.Contracts.RelayProtocol.SubProtocol = "dodossh.relay.v1" -> string!
const DodoSSH.Contracts.RelayProtocol.TargetUnreachableCloseCode = 4502 -> int
const DodoSSH.Contracts.RelayProtocol.TicketProtocolPrefix = "ticket." -> string!
const DodoSSH.Contracts.RelayProtocol.TicketsPath = "/api/v1/relay/tickets" -> string!
const DodoSSH.Contracts.RelayProtocol.TooManySessionsCloseCode = 4429 -> int
DodoSSH.Contracts.RelayProtocol
+77 -2
View File
@@ -1,5 +1,78 @@
namespace DodoSSH.Contracts; namespace DodoSSH.Contracts;
/// <summary>
/// The relay's routes, subprotocol and close codes.
/// </summary>
/// <remarks>
/// <para>
/// Two steps, per ADR 0004. <see cref="TicketsPath"/> is an ordinary authenticated request that decides
/// everything — which host, which addresses, whether the caller may — and answers with a ticket.
/// <see cref="ConnectPath"/> is a WebSocket that carries no API authority at all: it accepts the ticket
/// and nothing else, and pipes raw bytes to the addresses the ticket names. There is no framing of the
/// relay's own inside the socket. SSH is already a byte stream, so every binary message is simply the
/// next bytes of it, in order, and message boundaries mean nothing.
/// </para>
/// <para>
/// A refusal the client could not have avoided by asking differently — a limit, a target that did not
/// answer — is sent as a close code after the upgrade rather than as an HTTP status before it, for the
/// same reason as <see cref="VaultEvents"/>: a constrained WebSocket client cannot read the status of a
/// failed upgrade, and these are exactly the cases where the user needs to be told something specific.
/// </para>
/// </remarks>
public static class RelayProtocol
{
/// <summary>The <c>/api/v1/meta</c> feature flag advertising that this server relays at all.</summary>
public const string Feature = "relay";
/// <summary>Where a ticket is asked for, with a <see cref="RelayTicketRequest"/>.</summary>
public const string TicketsPath = "/api/v1/relay/tickets";
/// <summary>The path the relay socket is served from.</summary>
/// <remarks>
/// A client dials <see cref="RelayTicketResponse.WebSocketUrl"/> rather than building this itself,
/// because a deployment may publish the relay under a different host than the API.
/// </remarks>
public const string ConnectPath = "/api/v1/relay/connect";
/// <summary>The only subprotocol this version speaks.</summary>
public const string SubProtocol = "dodossh.relay.v1";
/// <summary>
/// The prefix of the second subprotocol an upgrade offers, which carries the ticket.
/// </summary>
/// <remarks>
/// The header rather than the query string, because a URL is what proxies, access logs and traces
/// keep. The server echoes <see cref="SubProtocol"/> alone and never the ticket.
/// </remarks>
public const string TicketProtocolPrefix = "ticket.";
/// <summary>
/// Close code for a caller, or a node, already holding as many relay sessions as it may.
/// </summary>
/// <remarks>
/// The same number as <see cref="VaultEvents.TooManyConnectionsCloseCode"/>, deliberately, for the
/// same meaning. Retrying at once is what caused it.
/// </remarks>
public const int TooManySessionsCloseCode = 4429;
/// <summary>
/// Close code for a target that did not accept the connection.
/// </summary>
/// <remarks>
/// The one failure a user needs told in so many words, because from the laptop it looks exactly like
/// the direct connection that failed and sent them to the relay in the first place. It says that the
/// <em>server</em> could not reach the machine, which is a different problem with a different owner.
/// </remarks>
public const int TargetUnreachableCloseCode = 4502;
/// <summary>Close code for a session that carried no bytes for the idle timeout.</summary>
public const int IdleTimeoutCloseCode = 4408;
/// <summary>Close code for a session that reached the maximum lifetime this server allows.</summary>
public const int DurationLimitCloseCode = 4409;
}
/// <summary> /// <summary>
/// A request for permission to relay to a host. /// A request for permission to relay to a host.
/// </summary> /// </summary>
@@ -11,8 +84,10 @@ namespace DodoSSH.Contracts;
/// </remarks> /// </remarks>
/// <param name="HostId">The host to reach.</param> /// <param name="HostId">The host to reach.</param>
/// <param name="PortForwardId"> /// <param name="PortForwardId">
/// A configured port forward to use instead of the host's own SSH port. Resolved server-side the /// A configured port forward to use instead of the host's own SSH port. Reserved, and refused when
/// same way. /// set: a port forward lives inside the host's encrypted payload, so the server has no plaintext port
/// to resolve it to, and taking one from the client is the open proxy this record exists to prevent.
/// Serving it needs a plaintext concession of its own, argued the way ADR 0004 argues the host's.
/// </param> /// </param>
public sealed record RelayTicketRequest( public sealed record RelayTicketRequest(
Guid HostId, Guid HostId,
+123
View File
@@ -0,0 +1,123 @@
namespace DodoSSH.Domain;
/// <summary>
/// A relay ticket that has been redeemed.
/// </summary>
/// <remarks>
/// <para>
/// The replay guard, and the only state the relay shares between nodes — see ADR 0004. A ticket is
/// verified without the database; what the database adds is that it is verified <em>once</em>, by a
/// unique insert on <see cref="TicketId"/> that a second redemption loses whichever node it reaches.
/// </para>
/// <para>
/// A row is worth keeping only while its ticket could still verify, so <see cref="ExpiresAtUtc"/> is
/// stored to let redemption sweep the rows that can no longer matter. Nothing else reads this table,
/// and it carries nothing about the target: the audit record is <see cref="RelaySession"/>.
/// </para>
/// </remarks>
public sealed class RelayTicketUse
{
/// <summary>The ticket's own id. Primary key, and the whole of the guard.</summary>
public Guid TicketId { get; set; }
/// <summary>When the ticket stops verifying, after which this row guards nothing.</summary>
public DateTimeOffset ExpiresAtUtc { get; set; }
/// <summary>When it was redeemed.</summary>
public DateTimeOffset UsedAtUtc { get; set; }
}
/// <summary>
/// The audit record of one relay session.
/// </summary>
/// <remarks>
/// <para>
/// What ADR 0004 says remains auditable in relay mode, and nothing more: who, to where, for how long,
/// how many bytes each way and why it ended. The relay forwards SSH ciphertext, so there is no content
/// to record and no column that pretends otherwise.
/// </para>
/// <para>
/// Written twice — once when the target answers, once when the session ends — each time from a scope
/// opened for that write alone. A session lasts hours and a scope held across it is a pooled database
/// connection held across it, which is the failure ADR 0004 records.
/// </para>
/// <para>
/// No foreign keys to the host or the vault, deliberately. An audit row has to outlive what it is
/// about: a host deleted a minute after a session is exactly the host an operator will want the
/// session for.
/// </para>
/// </remarks>
public sealed class RelaySession
{
/// <summary>The session id, minted with the ticket and returned to the client. Primary key.</summary>
public Guid Id { get; set; }
/// <summary>Who opened it.</summary>
public Guid UserId { get; set; }
/// <summary>The host it reached.</summary>
public Guid HostId { get; set; }
/// <summary>The vault the host was in when the ticket was issued.</summary>
public Guid VaultId { get; set; }
/// <summary>The hostname as the host row carried it at issue.</summary>
public string TargetHost { get; set; } = string.Empty;
/// <summary>The address actually dialled, which is the one that answered.</summary>
/// <remarks>Null only for a session whose target never answered.</remarks>
public string? TargetAddress { get; set; }
/// <summary>The port dialled.</summary>
public int TargetPort { get; set; }
/// <summary>The client's address as this node saw it, for the audit ADR 0004 promises.</summary>
public string? ClientAddress { get; set; }
/// <summary>When the socket was accepted.</summary>
public DateTimeOffset StartedAtUtc { get; set; }
/// <summary>When it closed, or null while it is open — or if the node died under it.</summary>
public DateTimeOffset? EndedAtUtc { get; set; }
/// <summary>Bytes forwarded from the client to the target.</summary>
public long BytesClientToTarget { get; set; }
/// <summary>Bytes forwarded from the target to the client.</summary>
public long BytesTargetToClient { get; set; }
/// <summary>Why it ended. <see cref="RelayCloseReason.Unspecified"/> while open.</summary>
public RelayCloseReason CloseReason { get; set; }
}
/// <summary>Why a relay session ended.</summary>
/// <remarks>
/// Numbered as <c>RelaySessionCloseReason</c> on the wire is, and held to it by a test rather than by
/// hope: the endpoint converts between the two by value.
/// </remarks>
public enum RelayCloseReason
{
/// <summary>Not a legal value for a closed session; what an open one carries.</summary>
Unspecified = 0,
/// <summary>The client closed the connection.</summary>
ClientClosed = 1,
/// <summary>The target closed the connection.</summary>
TargetClosed = 2,
/// <summary>No traffic within the idle timeout.</summary>
IdleTimeout = 3,
/// <summary>The maximum session duration was reached.</summary>
DurationLimit = 4,
/// <summary>The server is shutting down and drained the session.</summary>
ServerShutdown = 5,
/// <summary>The connection to the target failed.</summary>
TargetUnreachable = 6,
/// <summary>An error ended the session.</summary>
Error = 7,
}
@@ -0,0 +1,61 @@
using DodoSSH.Domain;
using Microsoft.EntityFrameworkCore;
using Microsoft.EntityFrameworkCore.Metadata.Builders;
namespace DodoSSH.Infrastructure.Configurations;
/// <summary>Maps <see cref="RelayTicketUse"/>.</summary>
public sealed class RelayTicketUseConfiguration : IEntityTypeConfiguration<RelayTicketUse>
{
/// <inheritdoc />
public void Configure(EntityTypeBuilder<RelayTicketUse> builder)
{
ArgumentNullException.ThrowIfNull(builder);
builder.ToTable("relay_ticket_use");
// The key is the guard. A second redemption of the same ticket is a unique violation, on whichever
// node it reaches, and nothing weaker — a lookup followed by an insert — would be one.
builder.HasKey(u => u.TicketId);
builder.Property(u => u.TicketId).ValueGeneratedNever();
// For the sweep, which deletes by expiry.
builder.HasIndex(u => u.ExpiresAtUtc);
}
}
/// <summary>Maps <see cref="RelaySession"/>.</summary>
public sealed class RelaySessionConfiguration : IEntityTypeConfiguration<RelaySession>
{
/// <inheritdoc />
public void Configure(EntityTypeBuilder<RelaySession> builder)
{
ArgumentNullException.ThrowIfNull(builder);
builder.ToTable("relay_session");
builder.HasKey(s => s.Id);
// Minted with the ticket and handed to the client before the row exists, so the client can name
// the session it opened.
builder.Property(s => s.Id).ValueGeneratedNever();
builder.Property(s => s.TargetHost).HasMaxLength(255).IsRequired();
// An address's text form: 45 characters is the longest IPv6 spelling with an embedded IPv4.
builder.Property(s => s.TargetAddress).HasMaxLength(45);
builder.Property(s => s.ClientAddress).HasMaxLength(45);
builder.Property(s => s.CloseReason).HasConversion<int>();
builder.HasIndex(s => new { s.UserId, s.StartedAtUtc });
builder.HasIndex(s => new { s.HostId, s.StartedAtUtc });
builder.ToTable(t => t.HasCheckConstraint(
"ck_relay_session_port_range",
"target_port BETWEEN 1 AND 65535"));
builder.ToTable(t => t.HasCheckConstraint(
"ck_relay_session_bytes",
"bytes_client_to_target >= 0 AND bytes_target_to_client >= 0"));
}
}
@@ -87,6 +87,12 @@ public class DodoDbContext(DbContextOptions<DodoDbContext> options) : DbContext(
/// <summary>Applied-operation receipts, for exactly-once retries.</summary> /// <summary>Applied-operation receipts, for exactly-once retries.</summary>
public DbSet<SyncOperationReceipt> SyncOperationReceipts => Set<SyncOperationReceipt>(); public DbSet<SyncOperationReceipt> SyncOperationReceipts => Set<SyncOperationReceipt>();
/// <summary>Redeemed relay tickets: the replay guard ADR 0004 shares between nodes.</summary>
public DbSet<RelayTicketUse> RelayTicketUses => Set<RelayTicketUse>();
/// <summary>The relay's audit record, one row per session.</summary>
public DbSet<RelaySession> RelaySessions => Set<RelaySession>();
/// <inheritdoc /> /// <inheritdoc />
protected override void OnModelCreating(ModelBuilder modelBuilder) protected override void OnModelCreating(ModelBuilder modelBuilder)
{ {
File diff suppressed because it is too large. Load diff
@@ -0,0 +1,92 @@
using System;
using Microsoft.EntityFrameworkCore.Migrations;
#nullable disable
namespace DodoSSH.Infrastructure.Migrations
{
/// <summary>
/// Adds the relay's two tables: the replay guard for its tickets, and its audit record.
/// </summary>
/// <remarks>
/// Both are new and empty, so this is additive and safe to roll back. Neither table references a
/// host or a vault by foreign key — an audit row has to outlive what it is about — and neither holds
/// anything the host row did not already hold in plaintext for a relay-enabled host. See ADR 0004.
/// </remarks>
public partial class AddRelaySessions : Migration
{
/// <inheritdoc />
protected override void Up(MigrationBuilder migrationBuilder)
{
migrationBuilder.CreateTable(
name: "relay_session",
schema: "dodo",
columns: table => new
{
id = table.Column<Guid>(type: "uuid", nullable: false),
user_id = table.Column<Guid>(type: "uuid", nullable: false),
host_id = table.Column<Guid>(type: "uuid", nullable: false),
vault_id = table.Column<Guid>(type: "uuid", nullable: false),
target_host = table.Column<string>(type: "character varying(255)", maxLength: 255, nullable: false),
target_address = table.Column<string>(type: "character varying(45)", maxLength: 45, nullable: true),
target_port = table.Column<int>(type: "integer", nullable: false),
client_address = table.Column<string>(type: "character varying(45)", maxLength: 45, nullable: true),
started_at_utc = table.Column<DateTimeOffset>(type: "timestamp with time zone", nullable: false),
ended_at_utc = table.Column<DateTimeOffset>(type: "timestamp with time zone", nullable: true),
bytes_client_to_target = table.Column<long>(type: "bigint", nullable: false),
bytes_target_to_client = table.Column<long>(type: "bigint", nullable: false),
close_reason = table.Column<int>(type: "integer", nullable: false)
},
constraints: table =>
{
table.PrimaryKey("pk_relay_session", x => x.id);
table.CheckConstraint("ck_relay_session_bytes", "bytes_client_to_target >= 0 AND bytes_target_to_client >= 0");
table.CheckConstraint("ck_relay_session_port_range", "target_port BETWEEN 1 AND 65535");
});
migrationBuilder.CreateTable(
name: "relay_ticket_use",
schema: "dodo",
columns: table => new
{
ticket_id = table.Column<Guid>(type: "uuid", nullable: false),
expires_at_utc = table.Column<DateTimeOffset>(type: "timestamp with time zone", nullable: false),
used_at_utc = table.Column<DateTimeOffset>(type: "timestamp with time zone", nullable: false)
},
constraints: table =>
{
table.PrimaryKey("pk_relay_ticket_use", x => x.ticket_id);
});
migrationBuilder.CreateIndex(
name: "ix_relay_session_host_id_started_at_utc",
schema: "dodo",
table: "relay_session",
columns: new[] { "host_id", "started_at_utc" });
migrationBuilder.CreateIndex(
name: "ix_relay_session_user_id_started_at_utc",
schema: "dodo",
table: "relay_session",
columns: new[] { "user_id", "started_at_utc" });
migrationBuilder.CreateIndex(
name: "ix_relay_ticket_use_expires_at_utc",
schema: "dodo",
table: "relay_ticket_use",
column: "expires_at_utc");
}
/// <inheritdoc />
protected override void Down(MigrationBuilder migrationBuilder)
{
migrationBuilder.DropTable(
name: "relay_session",
schema: "dodo");
migrationBuilder.DropTable(
name: "relay_ticket_use",
schema: "dodo");
}
}
}
@@ -135,6 +135,104 @@ namespace DodoSSH.Infrastructure.Migrations
b.ToTable("key_log", "dodo"); b.ToTable("key_log", "dodo");
}); });
modelBuilder.Entity("DodoSSH.Domain.RelaySession", b =>
{
b.Property<Guid>("Id")
.HasColumnType("uuid")
.HasColumnName("id");
b.Property<long>("BytesClientToTarget")
.HasColumnType("bigint")
.HasColumnName("bytes_client_to_target");
b.Property<long>("BytesTargetToClient")
.HasColumnType("bigint")
.HasColumnName("bytes_target_to_client");
b.Property<string>("ClientAddress")
.HasMaxLength(45)
.HasColumnType("character varying(45)")
.HasColumnName("client_address");
b.Property<int>("CloseReason")
.HasColumnType("integer")
.HasColumnName("close_reason");
b.Property<DateTimeOffset?>("EndedAtUtc")
.HasColumnType("timestamp with time zone")
.HasColumnName("ended_at_utc");
b.Property<Guid>("HostId")
.HasColumnType("uuid")
.HasColumnName("host_id");
b.Property<DateTimeOffset>("StartedAtUtc")
.HasColumnType("timestamp with time zone")
.HasColumnName("started_at_utc");
b.Property<string>("TargetAddress")
.HasMaxLength(45)
.HasColumnType("character varying(45)")
.HasColumnName("target_address");
b.Property<string>("TargetHost")
.IsRequired()
.HasMaxLength(255)
.HasColumnType("character varying(255)")
.HasColumnName("target_host");
b.Property<int>("TargetPort")
.HasColumnType("integer")
.HasColumnName("target_port");
b.Property<Guid>("UserId")
.HasColumnType("uuid")
.HasColumnName("user_id");
b.Property<Guid>("VaultId")
.HasColumnType("uuid")
.HasColumnName("vault_id");
b.HasKey("Id")
.HasName("pk_relay_session");
b.HasIndex("HostId", "StartedAtUtc")
.HasDatabaseName("ix_relay_session_host_id_started_at_utc");
b.HasIndex("UserId", "StartedAtUtc")
.HasDatabaseName("ix_relay_session_user_id_started_at_utc");
b.ToTable("relay_session", "dodo", t =>
{
t.HasCheckConstraint("ck_relay_session_bytes", "bytes_client_to_target >= 0 AND bytes_target_to_client >= 0");
t.HasCheckConstraint("ck_relay_session_port_range", "target_port BETWEEN 1 AND 65535");
});
});
modelBuilder.Entity("DodoSSH.Domain.RelayTicketUse", b =>
{
b.Property<Guid>("TicketId")
.HasColumnType("uuid")
.HasColumnName("ticket_id");
b.Property<DateTimeOffset>("ExpiresAtUtc")
.HasColumnType("timestamp with time zone")
.HasColumnName("expires_at_utc");
b.Property<DateTimeOffset>("UsedAtUtc")
.HasColumnType("timestamp with time zone")
.HasColumnName("used_at_utc");
b.HasKey("TicketId")
.HasName("pk_relay_ticket_use");
b.HasIndex("ExpiresAtUtc")
.HasDatabaseName("ix_relay_ticket_use_expires_at_utc");
b.ToTable("relay_ticket_use", "dodo");
});
modelBuilder.Entity("DodoSSH.Domain.SshHost", b => modelBuilder.Entity("DodoSSH.Domain.SshHost", b =>
{ {
b.Property<Guid>("Id") b.Property<Guid>("Id")
+25 -1
View File
@@ -1,9 +1,11 @@
using System.Net.Http.Headers; using System.Net.Http.Headers;
using System.Net.WebSockets; using System.Net.WebSockets;
using DodoSSH.Api.Features.Relay;
using DodoSSH.Contracts; using DodoSSH.Contracts;
using DodoSSH.Infrastructure; using DodoSSH.Infrastructure;
using Microsoft.AspNetCore.Hosting; using Microsoft.AspNetCore.Hosting;
using Microsoft.AspNetCore.Mvc.Testing; using Microsoft.AspNetCore.Mvc.Testing;
using Microsoft.AspNetCore.TestHost;
using Microsoft.EntityFrameworkCore; using Microsoft.EntityFrameworkCore;
using Microsoft.Extensions.Configuration; using Microsoft.Extensions.Configuration;
using Microsoft.Extensions.DependencyInjection; using Microsoft.Extensions.DependencyInjection;
@@ -70,7 +72,17 @@ public sealed class ApiFixture : WebApplicationFactory<Program>, IAsyncLifetime
// The stub serves plaintext HTTP on a loopback port. // The stub serves plaintext HTTP on a loopback port.
["DODOSSH_Oidc__RequireHttpsMetadata"] = "false", ["DODOSSH_Oidc__RequireHttpsMetadata"] = "false",
["DODOSSH_Relay__Enabled"] = "false", // On, so the relay's endpoints can be tested at all. Nothing dials a real network: the seam
// below answers every resolve and connect, and the address policy still judges what it says.
["DODOSSH_Relay__Enabled"] = "true",
["DODOSSH_Relay__WebSocketUrl"] = "ws://localhost" + RelayProtocol.ConnectPath,
// Small, so a test can reach the cap with two sockets rather than ten.
["DODOSSH_Relay__MaxConcurrentSessionsPerUser"] = "2",
// Short enough that a test can watch a session time out, long enough that no test which is
// moving bytes comes near it.
["DODOSSH_Relay__IdleTimeout"] = "00:00:03",
// Fixed so cursors stay valid for the lifetime of the test host. // Fixed so cursors stay valid for the lifetime of the test host.
["DODOSSH_Sync__CursorSigningKey"] = Convert.ToBase64String(new byte[32]), ["DODOSSH_Sync__CursorSigningKey"] = Convert.ToBase64String(new byte[32]),
@@ -80,8 +92,20 @@ public sealed class ApiFixture : WebApplicationFactory<Program>, IAsyncLifetime
{ {
Environment.SetEnvironmentVariable(name, value); Environment.SetEnvironmentVariable(name, value);
} }
builder.ConfigureTestServices(services => services.AddSingleton<IRelayNetwork>(RelayNetwork));
} }
/// <summary>
/// What the relay resolves and dials, in place of the machine's own resolver and sockets.
/// </summary>
/// <remarks>
/// Every address a test machine can reach by itself is loopback, which the relay refuses outright, so
/// a relay test needs a network that pretends. This one maps the addresses a test names onto loopback
/// listeners the test owns, and remembers what it was asked to dial.
/// </remarks>
internal FakeRelayNetwork RelayNetwork { get; } = new();
/// <summary>Creates a client carrying a valid token for the given subject.</summary> /// <summary>Creates a client carrying a valid token for the given subject.</summary>
/// <remarks> /// <remarks>
/// There is no verified-address knob here, and its absence is worth a sentence. It used to exist so /// There is no verified-address knob here, and its absence is worth a sentence. It used to exist so
@@ -62,6 +62,13 @@ public sealed class EndpointInventoryTests(ApiFixture fixture)
// the handshake, unlike the relay's ticket. See ADR 0012. // the handshake, unlike the relay's ticket. See ADR 0012.
"GET /api/v1/events name=VaultEvents tags=Events policies=Enrolled anon=False", "GET /api/v1/events name=VaultEvents tags=Events policies=Enrolled anon=False",
// The relay's two halves, and the split between them is the design. The ticket is Enrolled, as sync
// is, and every decision is made there with the full access model; the socket is anonymous because
// the ticket it carries is the whole of its authorization — single-use, thirty seconds, one host —
// and a constrained client cannot put a bearer token on an upgrade. See ADR 0004.
"POST /api/v1/relay/tickets name=IssueRelayTicket tags=Relay policies=Enrolled anon=False",
"GET /api/v1/relay/connect name=RelayConnect tags=Relay policies= anon=True",
// Enrolled, because the answer exists to be wrapped to and a caller with no key of their own has // Enrolled, because the answer exists to be wrapped to and a caller with no key of their own has
// nothing to wrap and no signature to attribute it with. There is no search here — see // nothing to wrap and no signature to attribute it with. There is no search here — see
// DirectoryService for why an exact-match-only directory is a decision rather than a shortcut. // DirectoryService for why an exact-match-only directory is a decision rather than a shortcut.
@@ -0,0 +1,68 @@
using System.Collections.Concurrent;
using System.Net;
using System.Net.Sockets;
using DodoSSH.Api.Features.Relay;
namespace DodoSSH.Api.Tests;
/// <summary>
/// A resolver and a dialler that reach only what a test has arranged.
/// </summary>
/// <remarks>
/// Names resolve to what <see cref="Resolve"/> says, and address literals to themselves, as the real
/// resolver does. An address dials the loopback endpoint <see cref="Route"/> mapped it to; anything
/// else is refused the way a closed port is, so a test that forgot to arrange a target sees the relay's
/// real "unreachable" path rather than a hang.
/// </remarks>
internal sealed class FakeRelayNetwork : IRelayNetwork
{
private readonly ConcurrentDictionary<string, IPAddress[]> names = new(StringComparer.OrdinalIgnoreCase);
private readonly ConcurrentDictionary<IPEndPoint, IPEndPoint> routes = new();
private readonly ConcurrentQueue<IPEndPoint> dialled = new();
/// <summary>Every endpoint the relay asked to connect to, in order.</summary>
internal IReadOnlyCollection<IPEndPoint> Dialled => dialled;
internal void Resolve(string name, params IPAddress[] addresses) => names[name] = addresses;
internal void Route(IPEndPoint target, IPEndPoint loopback) => routes[target] = loopback;
/// <inheritdoc />
public Task<IPAddress[]> ResolveAsync(string host, CancellationToken cancellationToken)
{
if (IPAddress.TryParse(host, out var literal))
{
return Task.FromResult<IPAddress[]>([literal]);
}
return names.TryGetValue(host, out var addresses)
? Task.FromResult(addresses)
: Task.FromException<IPAddress[]>(new SocketException((int)SocketError.HostNotFound));
}
/// <inheritdoc />
public async Task<Stream> ConnectAsync(IPAddress address, int port, CancellationToken cancellationToken)
{
var endpoint = new IPEndPoint(address, port);
dialled.Enqueue(endpoint);
if (!routes.TryGetValue(endpoint, out var loopback))
{
throw new SocketException((int)SocketError.ConnectionRefused);
}
var client = new TcpClient();
try
{
await client.ConnectAsync(loopback, cancellationToken);
return client.GetStream();
}
catch
{
client.Dispose();
throw;
}
}
}
@@ -0,0 +1,125 @@
using System.Net;
using DodoSSH.Api.Features.Relay;
using DodoSSH.Api.Setup;
namespace DodoSSH.Api.Tests;
/// <summary>
/// ADR 0004 §3, address by address.
/// </summary>
/// <remarks>
/// The refused list is tested against the most permissive configuration this server accepts — every
/// network allowed, private ranges on — because "no configuration escape" is a claim about exactly that
/// case. A test that ran it only under the defaults would pass for a policy an operator could open up.
/// </remarks>
public sealed class RelayAddressPolicyTests
{
[Theory]
[InlineData("127.0.0.1")]
[InlineData("127.255.255.254")]
[InlineData("0.0.0.0")]
[InlineData("0.1.2.3")]
[InlineData("169.254.169.254")]
[InlineData("169.254.0.1")]
[InlineData("224.0.0.251")]
[InlineData("255.255.255.255")]
[InlineData("100.100.100.200")]
[InlineData("::")]
[InlineData("::1")]
[InlineData("fe80::1")]
[InlineData("ff02::1")]
[InlineData("fd00:ec2::254")]
// The same addresses, spelled as IPv6 — the bypass ADR 0004 names, and its NAT64 cousin.
[InlineData("::ffff:127.0.0.1")]
[InlineData("::ffff:169.254.169.254")]
[InlineData("64:ff9b::a9fe:a9fe")]
[InlineData("64:ff9b::7f00:1")]
[InlineData("::127.0.0.1")]
public void TheRefusedList_HasNoConfigurationEscape(string address)
{
var wideOpen = new RelayOptions { AllowPrivateNetworks = true };
wideOpen.AllowedNetworks.Add("0.0.0.0/0");
wideOpen.AllowedNetworks.Add("::/0");
new RelayAddressPolicy(wideOpen).Permits(IPAddress.Parse(address)).ShouldBeFalse();
new RelayAddressPolicy(new RelayOptions()).Permits(IPAddress.Parse(address)).ShouldBeFalse();
}
[Fact]
public void ALinkLocalAddressWithAScope_IsStillLinkLocal()
{
var scoped = IPAddress.Parse("fe80::1%7");
new RelayAddressPolicy(new RelayOptions()).Permits(scoped).ShouldBeFalse();
}
[Theory]
[InlineData("10.0.0.5")]
[InlineData("172.16.4.4")]
[InlineData("192.168.1.10")]
[InlineData("100.101.102.103")] // A Tailnet address: carrier-grade NAT, beside the refused metadata one.
[InlineData("fd12:3456::1")]
[InlineData("::ffff:10.0.0.5")]
public void PrivateNetworks_ArePermittedByDefault_AndRefusedWhenSwitchedOff(string address)
{
new RelayAddressPolicy(new RelayOptions()).Permits(IPAddress.Parse(address)).ShouldBeTrue();
new RelayAddressPolicy(new RelayOptions { AllowPrivateNetworks = false })
.Permits(IPAddress.Parse(address))
.ShouldBeFalse();
}
[Theory]
[InlineData("203.0.113.10")]
[InlineData("2001:db8::10")]
public void PublicAddresses_ArePermitted(string address) =>
new RelayAddressPolicy(new RelayOptions { AllowPrivateNetworks = false })
.Permits(IPAddress.Parse(address))
.ShouldBeTrue();
[Fact]
public void AnAllowList_IsTheWholeAnswer_EvenWithPrivateNetworksOff()
{
var options = new RelayOptions { AllowPrivateNetworks = false };
options.AllowedNetworks.Add("10.20.0.0/16");
var policy = new RelayAddressPolicy(options);
policy.Permits(IPAddress.Parse("10.20.3.4")).ShouldBeTrue();
policy.Permits(IPAddress.Parse("10.21.3.4")).ShouldBeFalse();
policy.Permits(IPAddress.Parse("203.0.113.10")).ShouldBeFalse();
}
[Fact]
public void ADenial_IsAHoleInAnAllowance()
{
var options = new RelayOptions();
options.AllowedNetworks.Add("10.20.0.0/16");
options.DeniedNetworks.Add("10.20.5.0/24");
var policy = new RelayAddressPolicy(options);
policy.Permits(IPAddress.Parse("10.20.4.1")).ShouldBeTrue();
policy.Permits(IPAddress.Parse("10.20.5.1")).ShouldBeFalse();
}
[Theory]
[InlineData(25, false)]
[InlineData(465, false)]
[InlineData(587, false)]
[InlineData(0, false)]
[InlineData(65536, false)]
[InlineData(22, true)]
[InlineData(5432, true)]
public void Ports_RefuseSmtpAndNothingElse(int port, bool permitted) =>
RelayAddressPolicy.PermitsPort(port).ShouldBe(permitted);
[Theory]
[InlineData("10.0.0.0/8", true)]
[InlineData("fd00::/8", true)]
[InlineData("10.0.0.1/8", false)]
[InlineData("10.0.0.0", false)]
[InlineData("ten dot oh", false)]
public void NetworksAreReadStrictly(string entry, bool readable) =>
RelayAddressPolicy.AreNetworks([entry]).ShouldBe(readable);
}
@@ -0,0 +1,559 @@
using System.Net;
using System.Net.Sockets;
using System.Net.WebSockets;
using System.Text;
using DodoSSH.Contracts;
using DodoSSH.Domain;
using DodoSSH.Infrastructure;
using Microsoft.EntityFrameworkCore;
using Microsoft.Extensions.DependencyInjection;
namespace DodoSSH.Api.Tests;
/// <summary>
/// The relay, over a real socket, through the real ticket, against a target the test owns.
/// </summary>
/// <remarks>
/// <para>
/// The network is the only thing replaced — see <see cref="FakeRelayNetwork"/> — and it is replaced
/// <em>under</em> the address policy, so every address these tests arrange is still judged by the real
/// rules. That is what lets the refusals here be meaningful: a loopback target is refused because the
/// policy refused it, not because the fake had nothing to route it to, and the tests say which by
/// asserting that nothing was dialled.
/// </para>
/// <para>
/// The refusals share one answer on purpose, and a test holds them to it. A distinct response for "that
/// name resolves internally, but no" is a scanner for the operator's DNS in the hands of anyone who can
/// edit a host.
/// </para>
/// </remarks>
[Collection(ApiCollection.Name)]
public sealed class RelayEndpointTests(ApiFixture fixture)
{
private static readonly DateTimeOffset Now = new(2026, 9, 28, 12, 0, 0, TimeSpan.Zero);
/// <summary>How long a test waits for a frame. Generous, because it bounds a broken build, not a measurement.</summary>
private static readonly TimeSpan FrameTimeout = TimeSpan.FromSeconds(30);
// ---- The ticket ----
[Fact]
public async Task ATicket_NamesTheSocketAndExpiresWithinThirtySeconds()
{
var (subject, hostId) = await SeedRelayHostAsync("10.40.0.1", 22);
var ticket = await IssueAsync(subject, hostId);
ticket.SubProtocol.ShouldBe(RelayProtocol.SubProtocol);
ticket.WebSocketUrl.AbsolutePath.ShouldBe(RelayProtocol.ConnectPath);
ticket.ExpiresAt.ShouldBeLessThanOrEqualTo(TimeProvider.System.GetUtcNow().AddSeconds(31));
// It has to stand in a Sec-WebSocket-Protocol list, so it must be an HTTP token: no padding, no
// slash, no plus — which is what base64url is for.
ticket.Ticket.ShouldAllBe(c => char.IsAsciiLetterOrDigit(c) || c == '-' || c == '_');
}
[Fact]
public async Task EveryTargetRefusal_IsTheSameAnswer()
{
var (subject, relayOff) = await SeedHostAsync(relay: null);
var (_, others) = await SeedRelayHostAsync("10.40.0.2", 22);
var (_, loopback) = await SeedRelayHostAsync("127.0.0.1", 22, subject);
var (_, smtp) = await SeedRelayHostAsync("10.40.0.3", 25, subject);
var (_, unresolvable) = await SeedRelayHostAsync("nowhere.invalid", 22, subject);
var client = fixture.CreateClientFor(subject);
var answers = new List<JsonProblem>();
foreach (var hostId in new[] { relayOff, others, loopback, smtp, unresolvable, Guid.CreateVersion7() })
{
var response = await client.PostContractAsync(RelayProtocol.TicketsPath, new RelayTicketRequest(hostId, null));
response.StatusCode.ShouldBe(HttpStatusCode.Forbidden);
answers.Add((await response.Content.ReadProblemAsync()).ShouldNotBeNull());
}
answers.ShouldAllBe(problem => problem.Code == ProblemCodes.RelayTargetRejected);
answers.Select(problem => problem.Detail).Distinct(StringComparer.Ordinal).Count().ShouldBe(1);
}
[Theory]
[InlineData("127.0.0.1")]
[InlineData("::1")]
[InlineData("::ffff:127.0.0.1")]
[InlineData("169.254.169.254")]
[InlineData("::ffff:169.254.169.254")]
[InlineData("0.0.0.0")]
public async Task AnAddressThePolicyRefuses_IsNeverDialled(string address)
{
var (subject, hostId) = await SeedRelayHostAsync(address, 22);
var dialledBefore = fixture.RelayNetwork.Dialled.Count;
var response = await fixture.CreateClientFor(subject)
.PostContractAsync(RelayProtocol.TicketsPath, new RelayTicketRequest(hostId, null));
response.StatusCode.ShouldBe(HttpStatusCode.Forbidden);
fixture.RelayNetwork.Dialled.Count.ShouldBe(dialledBefore);
}
[Fact]
public async Task ANameResolvingToABadAndAGoodAddress_IsDialledOnlyOnTheGoodOne()
{
// The rebinding shape: one answer the policy likes and one it must never reach. The ticket carries
// only what passed, so the socket has nothing else it could try.
using var target = LoopbackTarget.Echo();
var good = new IPEndPoint(IPAddress.Parse("10.40.1.1"), 22);
fixture.RelayNetwork.Resolve("mixed.test", IPAddress.Parse("169.254.169.254"), good.Address);
fixture.RelayNetwork.Route(good, target.Endpoint);
var (subject, hostId) = await SeedRelayHostAsync("mixed.test", 22);
using var timeout = Timeout();
using var socket = await ConnectAsync(await IssueAsync(subject, hostId), timeout.Token);
await RoundTripAsync(socket, "hello", timeout.Token);
fixture.RelayNetwork.Dialled.ShouldNotContain(endpoint => endpoint.Address.Equals(IPAddress.Parse("169.254.169.254")));
}
[Fact]
public async Task APortForward_IsRefused()
{
// Its port lives in ciphertext, so honouring one would mean taking the port from the client.
var (subject, hostId) = await SeedRelayHostAsync("10.40.0.4", 22);
var response = await fixture.CreateClientFor(subject)
.PostContractAsync(RelayProtocol.TicketsPath, new RelayTicketRequest(hostId, Guid.CreateVersion7()));
response.StatusCode.ShouldBe(HttpStatusCode.Forbidden);
(await response.Content.ReadProblemAsync()).ShouldNotBeNull().Code.ShouldBe(ProblemCodes.RelayTargetRejected);
}
// ---- The socket ----
[Fact]
public async Task BytesGoBothWays_AndTheSessionIsAudited()
{
using var target = LoopbackTarget.Echo();
var (subject, hostId) = await SeedRoutedHostAsync(target, "10.40.2.1");
var ticket = await IssueAsync(subject, hostId);
using var timeout = Timeout();
using (var socket = await ConnectAsync(ticket, timeout.Token))
{
socket.SubProtocol.ShouldBe(RelayProtocol.SubProtocol);
await RoundTripAsync(socket, "SSH-2.0-test", timeout.Token);
await RoundTripAsync(socket, "a second message", timeout.Token);
await socket.CloseAsync(WebSocketCloseStatus.NormalClosure, string.Empty, timeout.Token);
}
var session = await WaitForClosedAuditAsync(ticket.SessionId, timeout.Token);
session.HostId.ShouldBe(hostId);
session.TargetAddress.ShouldBe("10.40.2.1");
session.TargetPort.ShouldBe(22);
session.CloseReason.ShouldBe(RelayCloseReason.ClientClosed);
var sent = Encoding.UTF8.GetByteCount("SSH-2.0-test") + Encoding.UTF8.GetByteCount("a second message");
session.BytesClientToTarget.ShouldBe(sent);
session.BytesTargetToClient.ShouldBe(sent);
}
[Fact]
public async Task ATicket_IsSpentByItsFirstUse()
{
using var target = LoopbackTarget.Echo();
var (subject, hostId) = await SeedRoutedHostAsync(target, "10.40.3.1");
var ticket = await IssueAsync(subject, hostId);
using var timeout = Timeout();
using var first = await ConnectAsync(ticket, timeout.Token);
var replay = await Should.ThrowAsync<InvalidOperationException>(ConnectAsync(ticket, timeout.Token));
replay.Message.ShouldContain("401");
}
[Theory]
[InlineData(null)]
[InlineData("")]
[InlineData("not-a-ticket")]
public async Task AnUpgradeWithoutAGenuineTicket_IsRefused(string? ticket)
{
var client = fixture.Server.CreateWebSocketClient();
client.SubProtocols.Add(RelayProtocol.SubProtocol);
if (ticket is not null)
{
client.SubProtocols.Add(RelayProtocol.TicketProtocolPrefix + ticket);
}
var refused = await Should.ThrowAsync<InvalidOperationException>(client.ConnectAsync(
new Uri(fixture.Server.BaseAddress, RelayProtocol.ConnectPath.TrimStart('/')),
TestContext.Current.CancellationToken));
refused.Message.ShouldContain("401");
}
[Fact]
public async Task APlainGet_SaysItIsAWebSocket()
{
var response = await fixture.CreateClient().GetAsync(
new Uri(RelayProtocol.ConnectPath, UriKind.Relative),
TestContext.Current.CancellationToken);
response.StatusCode.ShouldBe(HttpStatusCode.BadRequest);
(await response.Content.ReadProblemAsync()).ShouldNotBeNull().Code.ShouldBe(ProblemCodes.MalformedRequest);
}
[Fact]
public async Task ATargetThatDoesNotAnswer_ClosesWithItsOwnCode()
{
// Routed nowhere, so the fake refuses the connect the way a closed port does. The user has to be
// told the *server* could not reach the machine, which is not what a direct failure means.
var (subject, hostId) = await SeedRelayHostAsync("10.40.4.1", 22);
var ticket = await IssueAsync(subject, hostId);
using var timeout = Timeout();
using var socket = await ConnectAsync(ticket, timeout.Token);
await ReadUntilCloseAsync(socket, timeout.Token);
socket.CloseStatus.ShouldBe((WebSocketCloseStatus)RelayProtocol.TargetUnreachableCloseCode);
(await WaitForClosedAuditAsync(ticket.SessionId, timeout.Token)).CloseReason
.ShouldBe(RelayCloseReason.TargetUnreachable);
}
[Fact]
public async Task ATargetThatHangsUp_EndsTheSession()
{
using var target = LoopbackTarget.SayThenHangUp("bye");
var (subject, hostId) = await SeedRoutedHostAsync(target, "10.40.5.1");
var ticket = await IssueAsync(subject, hostId);
using var timeout = Timeout();
using var socket = await ConnectAsync(ticket, timeout.Token);
(await ReadTextAsync(socket, timeout.Token)).ShouldBe("bye");
await ReadUntilCloseAsync(socket, timeout.Token);
socket.CloseStatus.ShouldBe(WebSocketCloseStatus.NormalClosure);
(await WaitForClosedAuditAsync(ticket.SessionId, timeout.Token)).CloseReason
.ShouldBe(RelayCloseReason.TargetClosed);
}
[Fact]
public async Task AnIdleSession_IsClosedWithTheIdleCode()
{
// The close code has to arrive, not merely the close. Cancelling a pending receive aborts a .NET
// WebSocket, and an aborted one sends nothing — so a relay that stopped its reader by cancelling
// it would pass a test that only checked the socket ended.
using var target = LoopbackTarget.Echo();
var (subject, hostId) = await SeedRoutedHostAsync(target, "10.40.6.1");
var ticket = await IssueAsync(subject, hostId);
using var timeout = Timeout();
using var socket = await ConnectAsync(ticket, timeout.Token);
await ReadUntilCloseAsync(socket, timeout.Token);
socket.CloseStatus.ShouldBe((WebSocketCloseStatus)RelayProtocol.IdleTimeoutCloseCode);
(await WaitForClosedAuditAsync(ticket.SessionId, timeout.Token)).CloseReason
.ShouldBe(RelayCloseReason.IdleTimeout);
}
[Fact]
public async Task AUserAtTheCap_IsRefusedATicket_AndASocketOverItIsClosed()
{
using var target = LoopbackTarget.Echo();
var (subject, hostId) = await SeedRoutedHostAsync(target, "10.40.7.1");
// Three tickets while nothing is open, so the third reaches the socket and is refused there —
// the authoritative check, which the ticket endpoint's is only an early warning of.
var tickets = new[]
{
await IssueAsync(subject, hostId),
await IssueAsync(subject, hostId),
await IssueAsync(subject, hostId),
};
using var timeout = Timeout();
using var first = await ConnectAsync(tickets[0], timeout.Token);
using var second = await ConnectAsync(tickets[1], timeout.Token);
await RoundTripAsync(first, "one", timeout.Token);
await RoundTripAsync(second, "two", timeout.Token);
var early = await fixture.CreateClientFor(subject)
.PostContractAsync(RelayProtocol.TicketsPath, new RelayTicketRequest(hostId, null));
early.StatusCode.ShouldBe(HttpStatusCode.TooManyRequests);
(await early.Content.ReadProblemAsync()).ShouldNotBeNull().Code.ShouldBe(ProblemCodes.RelayLimitReached);
using var third = await ConnectAsync(tickets[2], timeout.Token);
await ReadUntilCloseAsync(third, timeout.Token);
third.CloseStatus.ShouldBe((WebSocketCloseStatus)RelayProtocol.TooManySessionsCloseCode);
}
// ---- Helpers ----
private static CancellationTokenSource Timeout()
{
var source = CancellationTokenSource.CreateLinkedTokenSource(TestContext.Current.CancellationToken);
source.CancelAfter(FrameTimeout);
return source;
}
private static string NewSubject() => $"relay-{Guid.CreateVersion7():N}";
private async Task<RelayTicketResponse> IssueAsync(string subject, Guid hostId)
{
var response = await fixture.CreateClientFor(subject)
.PostContractAsync(RelayProtocol.TicketsPath, new RelayTicketRequest(hostId, null));
response.StatusCode.ShouldBe(HttpStatusCode.OK);
return (await response.Content.ReadContractAsync<RelayTicketResponse>()).ShouldNotBeNull();
}
private Task<WebSocket> ConnectAsync(RelayTicketResponse ticket, CancellationToken cancellationToken)
{
var client = fixture.Server.CreateWebSocketClient();
client.SubProtocols.Add(RelayProtocol.SubProtocol);
client.SubProtocols.Add(RelayProtocol.TicketProtocolPrefix + ticket.Ticket);
return client.ConnectAsync(
new Uri(fixture.Server.BaseAddress, RelayProtocol.ConnectPath.TrimStart('/')),
cancellationToken);
}
private static async Task RoundTripAsync(WebSocket socket, string text, CancellationToken cancellationToken)
{
await socket.SendAsync(Encoding.UTF8.GetBytes(text), WebSocketMessageType.Binary, true, cancellationToken);
(await ReadTextAsync(socket, cancellationToken, Encoding.UTF8.GetByteCount(text))).ShouldBe(text);
}
/// <summary>
/// Reads until at least <paramref name="expected"/> bytes have arrived, because message boundaries
/// carry no meaning on the relay and an echo may come back split.
/// </summary>
private static async Task<string> ReadTextAsync(
WebSocket socket,
CancellationToken cancellationToken,
int expected = 1)
{
var buffer = new byte[64 * 1024];
var received = 0;
while (received < expected)
{
var result = await socket.ReceiveAsync(buffer.AsMemory(received), cancellationToken);
result.MessageType.ShouldBe(WebSocketMessageType.Binary);
received += result.Count;
}
return Encoding.UTF8.GetString(buffer, 0, received);
}
private static async Task ReadUntilCloseAsync(WebSocket socket, CancellationToken cancellationToken)
{
var buffer = new byte[64 * 1024];
while (true)
{
var result = await socket.ReceiveAsync(buffer.AsMemory(), cancellationToken);
if (result.MessageType == WebSocketMessageType.Close)
{
return;
}
}
}
/// <summary>
/// Waits for the audit row's second write, which lands after the close frame has gone out.
/// </summary>
private async Task<RelaySession> WaitForClosedAuditAsync(Guid sessionId, CancellationToken cancellationToken)
{
while (true)
{
await using (var scope = fixture.CreateScope())
{
var database = scope.ServiceProvider.GetRequiredService<DodoDbContext>();
var session = await database.RelaySessions
.AsNoTracking()
.SingleOrDefaultAsync(s => s.Id == sessionId, cancellationToken);
if (session?.EndedAtUtc is not null)
{
return session;
}
}
await Task.Delay(TimeSpan.FromMilliseconds(50), cancellationToken);
}
}
private async Task<(string Subject, Guid HostId)> SeedRoutedHostAsync(LoopbackTarget target, string address)
{
fixture.RelayNetwork.Route(new IPEndPoint(IPAddress.Parse(address), 22), target.Endpoint);
return await SeedRelayHostAsync(address, 22);
}
private Task<(string Subject, Guid HostId)> SeedRelayHostAsync(
string hostname,
int port,
string? subject = null) =>
SeedHostAsync((hostname, port), subject);
/// <summary>A user, their personal vault, and one host in it — relayed when an address is given.</summary>
private async Task<(string Subject, Guid HostId)> SeedHostAsync(
(string Hostname, int Port)? relay,
string? subject = null)
{
await using var scope = fixture.CreateScope();
var database = scope.ServiceProvider.GetRequiredService<DodoDbContext>();
var user = await FindOrAddUserAsync(database, subject);
var vault = await database.Vaults.FirstOrDefaultAsync(
v => v.OwnerUserId == user.Id,
TestContext.Current.CancellationToken)
?? database.Vaults.Add(new Vault
{
Id = Guid.CreateVersion7(),
Name = "Personal",
OwnerKind = VaultOwnerKind.Personal,
OwnerUserId = user.Id,
KeyGeneration = 1,
CreatedAtUtc = Now,
UpdatedAtUtc = Now,
}).Entity;
var host = new SshHost
{
Id = Guid.CreateVersion7(),
VaultId = vault.Id,
Payload = [1, 2, 3],
KeyGeneration = 1,
PayloadAadVersion = 1,
RelayEnabled = relay is not null,
Hostname = relay?.Hostname,
Port = relay?.Port,
Version = 1,
CreatedAtUtc = Now,
UpdatedAtUtc = Now,
CreatedByUserId = user.Id,
UpdatedByUserId = user.Id,
};
database.Hosts.Add(host);
await database.SaveChangesAsync(TestContext.Current.CancellationToken);
return (user.Subject, host.Id);
}
private async Task<UserAccount> FindOrAddUserAsync(DodoDbContext database, string? subject)
{
if (subject is not null
&& await database.Users.SingleOrDefaultAsync(
u => u.Subject == subject,
TestContext.Current.CancellationToken) is { } existing)
{
return existing;
}
var user = new UserAccount
{
Id = Guid.CreateVersion7(),
Issuer = fixture.IdentityProvider.Authority,
Subject = NewSubject(),
Status = UserStatus.Active,
CreatedAtUtc = Now,
UpdatedAtUtc = Now,
};
database.Users.Add(user);
database.UserKeys.Add(Seed.CurrentKey(user.Id, Now));
return user;
}
/// <summary>A TCP server on loopback, standing in for the machine the relay reaches.</summary>
private sealed class LoopbackTarget : IDisposable
{
private readonly TcpListener listener = new(IPAddress.Loopback, 0);
private readonly CancellationTokenSource stopping = new();
private LoopbackTarget(Func<NetworkStream, CancellationToken, Task> serve)
{
listener.Start();
_ = AcceptAsync(serve);
}
internal IPEndPoint Endpoint => (IPEndPoint)listener.LocalEndpoint;
/// <summary>Writes back everything it reads, on every connection.</summary>
internal static LoopbackTarget Echo() => new(static async (stream, token) =>
{
var buffer = new byte[16 * 1024];
int read;
while ((read = await stream.ReadAsync(buffer, token)) > 0)
{
await stream.WriteAsync(buffer.AsMemory(0, read), token);
}
});
/// <summary>Writes one line and closes, as a server does that refuses the client.</summary>
internal static LoopbackTarget SayThenHangUp(string text) => new(async (stream, token) =>
await stream.WriteAsync(Encoding.UTF8.GetBytes(text), token));
public void Dispose()
{
stopping.Cancel();
listener.Stop();
stopping.Dispose();
}
private async Task AcceptAsync(Func<NetworkStream, CancellationToken, Task> serve)
{
try
{
while (!stopping.IsCancellationRequested)
{
var client = await listener.AcceptTcpClientAsync(stopping.Token);
_ = Task.Run(
async () =>
{
using (client)
{
try
{
await serve(client.GetStream(), stopping.Token);
}
catch (Exception exception) when (exception is IOException or OperationCanceledException or ObjectDisposedException)
{
// The relay hung up, or the test is over.
}
}
},
CancellationToken.None);
}
}
catch (Exception exception) when (exception is SocketException or OperationCanceledException or ObjectDisposedException)
{
// Stopped.
}
}
}
}
@@ -73,4 +73,20 @@ public sealed class TeamEnumAlignmentTests
((int)PermissionFlags.Read).ShouldBe(1 << 0); ((int)PermissionFlags.Read).ShouldBe(1 << 0);
((int)PermissionFlags.Write).ShouldBe(1 << 1); ((int)PermissionFlags.Write).ShouldBe(1 << 1);
} }
/// <remarks>
/// Not a team enum, and here because this is where the wire-against-domain pairs live. The relay
/// writes its audit row's reason by value, so a renumbering would file every idle timeout as
/// something else.
/// </remarks>
[Fact]
public void EveryWireRelayCloseReason_HasADomainReasonWithTheSameValue()
{
Enum.GetValues<RelaySessionCloseReason>().Length.ShouldBe(Enum.GetValues<RelayCloseReason>().Length);
foreach (var reason in Enum.GetValues<RelaySessionCloseReason>())
{
((int)Enum.Parse<RelayCloseReason>(reason.ToString())).ShouldBe((int)reason);
}
}
} }
@@ -222,6 +222,43 @@ public sealed class DodoSshApiClientTests : IDisposable
exception.Code.ShouldBe(ProblemCodes.VaultConflict); exception.Code.ShouldBe(ProblemCodes.VaultConflict);
} }
[Fact]
public async Task ARelayTicket_IsAskedForByHostAlone()
{
// The request names a host and nothing else. An address in it would be the open proxy ADR 0004
// exists to prevent, and the server would be right to ignore it — so it is not sent.
var hostId = Guid.CreateVersion7();
var issued = new RelayTicketResponse(
"dGlja2V0",
new Uri("wss://relay.example" + RelayProtocol.ConnectPath),
RelayProtocol.SubProtocol,
Guid.CreateVersion7(),
new DateTimeOffset(2026, 9, 28, 12, 0, 30, TimeSpan.Zero));
server.StubRelayTicket(issued);
var ticket = await Client().IssueRelayTicketAsync(hostId, TestContext.Current.CancellationToken);
ticket.ShouldBe(issued);
server.LastAuthorization(RelayProtocol.TicketsPath).ShouldBe("Bearer test-access-token");
var body = System.Text.Json.Nodes.JsonNode.Parse(server.LastBody(RelayProtocol.TicketsPath))!.AsObject();
body["hostId"]!.GetValue<Guid>().ShouldBe(hostId);
body.Where(property => property.Key is not ("hostId" or "portForwardId")).ShouldBeEmpty();
}
[Fact]
public async Task ARefusedRelayTicket_CarriesItsCode()
{
server.StubProblem(
RelayProtocol.TicketsPath, "POST", 403, ProblemCodes.RelayTargetRejected, "The relay will not connect.");
var exception = await Should.ThrowAsync<DodoSshApiException>(async () =>
await Client().IssueRelayTicketAsync(Guid.CreateVersion7(), TestContext.Current.CancellationToken));
exception.Code.ShouldBe(ProblemCodes.RelayTargetRejected);
}
private DodoSshApiClient Client() => new(http, new StubTokenProvider()); private DodoSshApiClient Client() => new(http, new StubTokenProvider());
private static MeResponse UnenrolledMe() => private static MeResponse UnenrolledMe() =>
@@ -51,6 +51,10 @@ internal sealed class StubServer : IDisposable
response, DodoSshJsonContext.Default.SyncPullResponse)); response, DodoSshJsonContext.Default.SyncPullResponse));
/// <summary>Stubs an RFC 9457 problem response.</summary> /// <summary>Stubs an RFC 9457 problem response.</summary>
internal void StubRelayTicket(RelayTicketResponse response) =>
StubJson(RelayProtocol.TicketsPath, "POST", 200, JsonSerializer.Serialize(
response, DodoSshJsonContext.Default.RelayTicketResponse));
internal void StubProblem(string path, string method, int statusCode, string code, string detail) internal void StubProblem(string path, string method, int statusCode, string code, string detail)
{ {
var problem = new JsonObject var problem = new JsonObject
@@ -942,6 +942,49 @@ public sealed class ScreenLayoutTests : IAsyncLifetime
await MeasureConnectingAsync(faults => faults.ShouldBeEmpty("with a refusal to explain"), tab); await MeasureConnectingAsync(faults => faults.ShouldBeEmpty("with a refusal to explain"), tab);
} }
/// <remarks>
/// <para>
/// The card is the one place the shell says what it is dialling <em>before</em> anything answers, and on a
/// refusal it is the only copy of that on screen — so both lines are there to be taken away, and a
/// <c>TextBlock</c> in Avalonia is a drawing of a string rather than a string. Same change, same argument,
/// as the session column's own address; see <c>SessionSidebarTests</c>.
/// </para>
/// <para>
/// Asserted on values long enough to be trimmed, which is the half that could quietly break: an ellipsis
/// is a drawing and not a shorter string, so select-all has to reach the whole name and the whole address
/// rather than the part that happened to fit inside the card's 460 pixels. Values that fit would pass
/// whether that were true or not.
/// </para>
/// </remarks>
[Fact]
public async Task TheConnectingCardsNameAndAddressSelectAndCopyWhole()
{
const string label = "customer-production-database-01.eu-west-1.internal.example.company";
const string address = "a-very-long-deploy-account@db-primary.eu-west-1.internal.example:22022";
await OnTheConnectingCardAsync(
card =>
{
// Found by their text rather than by position: the order is the visual tree's, and a third
// selectable block is already in there — the refusal reason, hidden while this tab is only
// connecting. Single rather than First, so a duplicate would be a question rather than a
// silent pick.
var takeable = card.GetVisualDescendants().OfType<SelectableTextBlock>().ToList();
var name = takeable.Single(block => block.Text == label);
var endpoint = takeable.Single(block => block.Text == address);
name.SelectAll();
name.SelectedText.ShouldBe(label, "the ellipsis is a drawing, not a shorter string");
name.CanCopy.ShouldBeTrue("Ctrl+C and the right-click Copy item are both gated on this");
endpoint.SelectAll();
endpoint.SelectedText.ShouldBe(address, "the ellipsis is a drawing, not a shorter string");
endpoint.CanCopy.ShouldBeTrue("Ctrl+C and the right-click Copy item are both gated on this");
},
new TerminalTabViewModel(label, address));
}
// ---- The logs screen ---- // ---- The logs screen ----
[Fact] [Fact]
@@ -2043,6 +2086,40 @@ public sealed class ScreenLayoutTests : IAsyncLifetime
}, },
Token); Token);
/// <summary>Lays the connecting card out and hands it over, rather than measuring it.</summary>
/// <remarks>
/// The same rectangle <see cref="MeasureConnectingAsync"/> uses and for the same reasons — see its
/// remark. Separate because the claim is about a control's own state rather than about where anything was
/// arranged, and threading an assertion over the card through a method whose parameter is a fault list
/// would make both callers harder to read than two methods are.
/// </remarks>
private Task OnTheConnectingCardAsync(Action<ConnectingCard> body, TerminalTabViewModel tab) =>
LayoutHarness.OnTheUiThreadAsync(
() =>
{
shell.State = ShellState.Unlocked;
shell.Tabs.Clear();
shell.Tabs.Add(tab);
shell.SelectedTab = tab;
var card = new ConnectingCard { DataContext = shell };
var window = LayoutHarness.HostAtMinimumSize(
card,
LayoutHarness.SessionScreenWidth(sidebarVisible: true),
LayoutHarness.SessionScreenHeight);
try
{
body(card);
}
finally
{
window.Close();
}
},
Token);
/// <summary>Lays the host-key decision out in the rectangle it is drawn over.</summary> /// <summary>Lays the host-key decision out in the rectangle it is drawn over.</summary>
/// <remarks> /// <remarks>
/// <para> /// <para>
@@ -68,6 +68,9 @@ internal sealed class StubTeamServer : IVaultServer, ITeamApi, IVaultGrantApi
/// </remarks> /// </remarks>
public IVaultEventStream Events => IdleVaultEventStream.Instance; public IVaultEventStream Events => IdleVaultEventStream.Instance;
/// <inheritdoc />
public IServerRelay Relay => UnavailableServerRelay.Instance;
/// <inheritdoc /> /// <inheritdoc />
public SyncOptions SyncOptions => new(); public SyncOptions SyncOptions => new();
+15
View File
@@ -29,6 +29,16 @@ internal sealed class FakeSshConnectionFactory : ISshConnectionFactory, ISftpSes
/// <summary>Requests this factory was asked for, in order.</summary> /// <summary>Requests this factory was asked for, in order.</summary>
internal List<SshConnectionRequest> Requests { get; } = []; internal List<SshConnectionRequest> Requests { get; } = [];
/// <summary>
/// Runs against each shell request before it succeeds or fails, when set.
/// </summary>
/// <remarks>
/// How a test plays the part of SSH.NET arriving at a proxy: the relay tests use it to speak SOCKS to the
/// bridge the request names, so that what the relay then says reaches the bridge the way it would in a
/// real connect, before <see cref="Failure"/> is thrown.
/// </remarks>
internal Func<SshConnectionRequest, Task>? BeforeConnect { get; set; }
/// <summary>Every shell this factory has opened, in order.</summary> /// <summary>Every shell this factory has opened, in order.</summary>
/// <remarks> /// <remarks>
/// Exists so a test can reach one and drop it — see <see cref="FakeSshShellSession.Drop"/>. There was no /// Exists so a test can reach one and drop it — see <see cref="FakeSshShellSession.Drop"/>. There was no
@@ -93,6 +103,11 @@ internal sealed class FakeSshConnectionFactory : ISshConnectionFactory, ISftpSes
await gate.Task.WaitAsync(cancellationToken).ConfigureAwait(false); await gate.Task.WaitAsync(cancellationToken).ConfigureAwait(false);
} }
if (BeforeConnect is { } before)
{
await before(request).ConfigureAwait(false);
}
if (Failure is { } failure) if (Failure is { } failure)
{ {
throw failure; throw failure;
@@ -122,6 +122,12 @@ internal sealed partial class FakeVaultServer : IVaultServer, IAccountApi, ISync
/// <inheritdoc /> /// <inheritdoc />
public IVaultEventStream Events => Notices; public IVaultEventStream Events => Notices;
/// <summary>
/// The relay a relayed host is reached through. Unavailable unless a test sets one, which is what a
/// server that does not advertise the feature supplies.
/// </summary>
public IServerRelay Relay { get; set; } = UnavailableServerRelay.Instance;
/// <inheritdoc /> /// <inheritdoc />
public SyncOptions SyncOptions => SyncOptions.Default; public SyncOptions SyncOptions => SyncOptions.Default;
@@ -0,0 +1,244 @@
using System.Net;
using System.Net.Sockets;
using System.Net.WebSockets;
using System.Text;
using DodoSSH.Client.Api;
using DodoSSH.Client.Session;
using DodoSSH.Client.Shell.ViewModels;
using DodoSSH.Client.Ssh;
using DodoSSH.Contracts;
namespace DodoSSH.Client.App.Tests;
/// <summary>
/// A host set to connect through the server relay, from the Connect button to the request that reaches SSH.
/// </summary>
/// <remarks>
/// <para>
/// The relay here is the real <see cref="ServerRelay"/> — ticket, subprotocols and bridge — over an
/// in-process WebSocket pair, with only the API call and the far end of the socket stood in for. What these
/// hold is the promise the checkbox makes and used not to keep: ticking it changes how the host is reached,
/// and a relay that cannot be used is a stated failure rather than a quiet direct dial.
/// </para>
/// <para>
/// The bridge's own behaviour against a real sshd is <c>RelayBridgeTests</c>, and the server's is
/// <c>RelayEndpointTests</c>.
/// </para>
/// </remarks>
public sealed partial class ShellFlowTests
{
[Fact]
public async Task ARelayedHost_IsDialledThroughTheBridge_AndStillAsItself()
{
var tickets = new FakeRelayApi();
server.Relay = new ServerRelay(tickets, ConnectPairedAsync);
var vault = await ReadyToConnectRelayedAsync();
await using var renderer = await FakeRenderer.AttachAsync(workspace, Token);
await vault.ConnectCommand.ExecuteAsync(null);
tickets.HostIds.ShouldHaveSingleItem().ShouldBe(vault.SelectedHost.ShouldNotBeNull().EntityId);
// Through a loopback proxy — and still named as the host, because the name is what the host key is
// pinned under. The bridge carries the name in its CONNECT; it does not replace it.
var request = ssh.Requests.ShouldHaveSingleItem();
request.Proxy.ShouldNotBeNull().Lifetime.ShouldBeOfType<RelayBridge>();
request.Host.ShouldBe("db.internal");
request.Port.ShouldBe(22);
// The ticket travels as the second subprotocol and never as anything else.
offeredProtocols.ShouldBe([RelayProtocol.SubProtocol, RelayProtocol.TicketProtocolPrefix + FakeRelayApi.Ticket]);
shell.IsTerminalShowing.ShouldBeTrue();
await request.Proxy.Lifetime.DisposeAsync();
}
[Fact]
public async Task ARelayedHost_OnAServerWithoutARelay_IsRefusedWithoutDialling()
{
// The fake server's default: a server that does not advertise the feature.
var vault = await ReadyToConnectRelayedAsync();
await using var renderer = await FakeRenderer.AttachAsync(workspace, Token);
await vault.ConnectCommand.ExecuteAsync(null);
// No fallback to the direct address. The user ticked the relay because that path does not work, or
// goes somewhere they do not mean.
ssh.Requests.ShouldBeEmpty();
vault.Status.ShouldNotBeNull().ShouldContain("does not offer one");
}
[Theory]
[InlineData(ProblemCodes.RelayTargetRejected, "refused to relay")]
[InlineData(ProblemCodes.RelayLimitReached, "as many relay sessions")]
[InlineData(ProblemCodes.RelayUnavailable, "does not offer one")]
public async Task ARefusedTicket_IsExplained_AndNothingIsDialled(string code, string explanation)
{
server.Relay = new ServerRelay(
new FakeRelayApi { Refusal = new DodoSshApiException(HttpStatusCode.Forbidden, code, "no") },
ConnectPairedAsync);
var vault = await ReadyToConnectRelayedAsync();
await using var renderer = await FakeRenderer.AttachAsync(workspace, Token);
await vault.ConnectCommand.ExecuteAsync(null);
ssh.Requests.ShouldBeEmpty();
vault.Status.ShouldNotBeNull().ShouldContain(explanation);
}
[Fact]
public async Task ARelayThatCouldNotReachTheHost_SaysSo_InsteadOfTheTransportError()
{
// What the server does when it cannot dial the host: accept the socket, then close it with 4502.
server.Relay = new ServerRelay(new FakeRelayApi(), async (url, protocols, cancellationToken) =>
{
var socket = await ConnectPairedAsync(url, protocols, cancellationToken);
await relayEnd!.CloseOutputAsync(
(WebSocketCloseStatus)RelayProtocol.TargetUnreachableCloseCode,
"unreachable",
cancellationToken);
return socket;
});
// SSH.NET arriving at the bridge and then losing its stream, which is how a relay that hung up looks
// from inside the connect.
ssh.BeforeConnect = request => ThroughSocksToEndOfStreamAsync(request.Proxy.ShouldNotBeNull().Port);
ssh.Failure = new InvalidOperationException("An established connection was aborted by the server.");
var vault = await ReadyToConnectRelayedAsync();
await using var renderer = await FakeRenderer.AttachAsync(workspace, Token);
await vault.ConnectCommand.ExecuteAsync(null);
vault.Status.ShouldNotBeNull().ShouldContain("could not reach this host");
vault.Status.ShouldNotContain("aborted");
}
[Fact]
public async Task ARelayedHostsFileTransfer_GoesThroughTheRelayToo()
{
// Its own connection, so it needs its own relay — or the transfers screen would fail for exactly the
// hosts the relay exists for.
server.Relay = new ServerRelay(new FakeRelayApi(), ConnectPairedAsync);
var vault = await ReadyToConnectRelayedAsync();
shell.Transfers.Attach(vault, knownHosts);
shell.Transfers.SelectedHost = shell.Transfers.Hosts[0];
await shell.Transfers.ConnectCommand.ExecuteAsync(null);
var request = ssh.SftpRequests.ShouldHaveSingleItem();
request.Proxy.ShouldNotBeNull().Lifetime.ShouldBeOfType<RelayBridge>();
await request.Proxy.Lifetime.DisposeAsync();
}
/// <summary>The protocols the last relay socket was opened offering.</summary>
private IReadOnlyList<string>? offeredProtocols;
/// <summary>The far end of the last relay socket, which a test may close as the server would.</summary>
private WebSocket? relayEnd;
private async Task<VaultViewModel> ReadyToConnectRelayedAsync()
{
await UnlockedAsync();
var vault = shell.Vault!;
vault.NewHostCommand.Execute(null);
vault.EditorLabel = "behind-the-server";
vault.EditorHostname = "db.internal";
vault.EditorUsername = "deploy";
// A relayed host needs a port of its own; the server stores it and dials it.
vault.EditorPort = 22;
vault.EditorRelayEnabled = true;
await vault.SaveHostCommand.ExecuteAsync(null);
vault.SelectedHost = vault.Hosts.Single(row => row.Host.RelayEnabled);
return vault;
}
/// <summary>Opens both ends of a WebSocket over loopback, and keeps the far one.</summary>
private async Task<WebSocket> ConnectPairedAsync(
Uri url,
IReadOnlyList<string> protocols,
CancellationToken cancellationToken)
{
url.ShouldBe(FakeRelayApi.SocketUrl);
offeredProtocols = protocols;
using var listener = new TcpListener(IPAddress.Loopback, 0);
listener.Start();
var dialling = new TcpClient();
var connecting = dialling.ConnectAsync((IPEndPoint)listener.LocalEndpoint, cancellationToken);
var accepted = await listener.AcceptTcpClientAsync(cancellationToken);
await connecting;
relayEnd = WebSocket.CreateFromStream(
accepted.GetStream(),
new WebSocketCreationOptions { IsServer = true, KeepAliveInterval = TimeSpan.Zero });
return WebSocket.CreateFromStream(
dialling.GetStream(),
new WebSocketCreationOptions { IsServer = false, KeepAliveInterval = TimeSpan.Zero });
}
/// <summary>
/// Speaks SOCKS5 to the bridge as SSH.NET would, then reads until the bridge closes the stream — which
/// it does once the relay has closed, so the relay's reason is recorded by the time this returns.
/// </summary>
private static async Task ThroughSocksToEndOfStreamAsync(int port)
{
using var client = new TcpClient();
await client.ConnectAsync(IPAddress.Loopback, port, Token);
var stream = client.GetStream();
var name = Encoding.ASCII.GetBytes("db.internal");
await stream.WriteAsync(new byte[] { 5, 1, 0 }, Token);
await stream.ReadExactlyAsync(new byte[2], Token);
await stream.WriteAsync((byte[])[5, 1, 0, 3, (byte)name.Length, .. name, 0, 22], Token);
await stream.ReadExactlyAsync(new byte[10], Token);
var rest = new byte[256];
while (await stream.ReadAsync(rest, Token) > 0)
{
}
}
/// <summary>The ticket half of the API, answering or refusing as a test arranges.</summary>
private sealed class FakeRelayApi : IRelayApi
{
internal const string Ticket = "dGlja2V0";
internal static readonly Uri SocketUrl = new("ws://relay.test" + RelayProtocol.ConnectPath);
internal List<Guid> HostIds { get; } = [];
internal DodoSshApiException? Refusal { get; init; }
public Task<RelayTicketResponse> IssueRelayTicketAsync(Guid hostId, CancellationToken cancellationToken)
{
HostIds.Add(hostId);
return Refusal is { } refusal
? Task.FromException<RelayTicketResponse>(refusal)
: Task.FromResult(new RelayTicketResponse(
Ticket,
SocketUrl,
RelayProtocol.SubProtocol,
Guid.CreateVersion7(),
TimeProvider.System.GetUtcNow().AddSeconds(30)));
}
}
}
@@ -2099,6 +2099,82 @@ public sealed partial class ShellFlowTests : IAsyncLifetime
"the session that was replaced should have been released with its pane"); "the session that was replaced should have been released with its pane");
} }
/// <remarks>
/// <para>
/// ◆ THE ONE THIS EXISTS FOR: a reconnect that dialled a different machine of the same name. Nothing in
/// this application stops two hosts being called the same thing — a team's vault beside a personal one
/// makes it ordinary, and "prod-db" is what a database server gets called in both — and a tab used to
/// find its host by that name. A dropped session on one machine then came back as a live shell on the
/// other, with the tab, the address and the status bar all still naming the first.
/// </para>
/// <para>
/// Asserted on the address actually dialled rather than on anything the tab says about itself. The two
/// rows agree on every string a tab carries, which is exactly why this went unnoticed: a test written
/// against the label would have passed on the day the wrong machine was being opened.
/// </para>
/// </remarks>
[Fact]
public async Task ReconnectingATabWhoseHostHasANamesake_DialsTheMachineTheTabWasOpenedOn()
{
var vault = await ReadyToConnectAsync();
await AddKeyAsync(vault, "deploy");
// A second host under the name the fixture's own already has, on a different machine.
await AddHostAsync(vault, "prod-db", "db-replica.internal");
// Both bound to the key, so neither is diverted to the password sheet: what this asserts is which of
// the two gets dialled, not whether either can be. Re-found between the two, because saving a host
// rebuilds the list.
await BindKeyAsync(vault, Machine(vault, "db.internal"), vault.Keys[0].EntityId);
await BindKeyAsync(vault, Machine(vault, "db-replica.internal"), vault.Keys[0].EntityId);
await using var renderer = await FakeRenderer.AttachAsync(workspace, Token);
await vault.ConnectToRowCommand.ExecuteAsync(Machine(vault, "db-replica.internal"));
var tab = shell.Tabs.ShouldHaveSingleItem();
ssh.Requests.ShouldHaveSingleItem().Host.ShouldBe("db-replica.internal");
ssh.Shells[0].Drop("An established connection was aborted by the server.");
await EventuallyAsync(() => !tab.IsLive, "the dropped shell should have ended the session");
shell.CanReconnectSelectedTab.ShouldBeTrue("the machine this tab was opened on is still there");
await shell.ReconnectTabCommand.ExecuteAsync(tab);
tab.IsLive.ShouldBeTrue(tab.Status);
ssh.Requests.Count.ShouldBe(2);
ssh.Requests[1].Host.ShouldBe(
"db-replica.internal",
"a reconnect dials the machine the tab was opened on, not the one that shares its name");
}
/// <remarks>
/// The same mix-up as the test above, where it is read rather than dialled. A green dot is the host list
/// answering "am I on this machine", and the name two rows share is not an answer to it — a dot on the
/// machine nobody has a shell on claims a session that does not exist, and takes QUICK ACCESS's pins with
/// it, since the sidebar offers the pinned folders of whichever row that same match found.
/// </remarks>
[Fact]
public async Task ConnectingToOneOfTwoHostsOfTheSameName_LightsThatOneAlone()
{
var vault = await ReadyToConnectAsync();
await AddHostAsync(vault, "prod-db", "db-replica.internal");
await using var renderer = await FakeRenderer.AttachAsync(workspace, Token);
vault.SelectedHost = Machine(vault, "db-replica.internal");
await vault.ConnectCommand.ExecuteAsync(null);
shell.Tabs.ShouldHaveSingleItem().IsLive.ShouldBeTrue();
Machine(vault, "db-replica.internal").IsConnected.ShouldBeTrue();
Machine(vault, "db.internal").IsConnected.ShouldBeFalse(
"nobody has a shell on this machine; only its name was connected to");
}
/// <remarks> /// <remarks>
/// A connection that was refused is worth retrying for the same reason a dropped one is, and the /// A connection that was refused is worth retrying for the same reason a dropped one is, and the
/// commonest refusal — a machine that was not up yet — is the one most likely to succeed a minute later. /// commonest refusal — a machine that was not up yet — is the one most likely to succeed a minute later.
@@ -10377,11 +10453,14 @@ public sealed partial class ShellFlowTests : IAsyncLifetime
await vault.SaveHostCommand.ExecuteAsync(null); await vault.SaveHostCommand.ExecuteAsync(null);
} }
private static async Task AddHostAsync(VaultViewModel vault, string label) private static async Task AddHostAsync(
VaultViewModel vault,
string label,
string hostname = "db.internal")
{ {
vault.NewHostCommand.Execute(null); vault.NewHostCommand.Execute(null);
vault.EditorLabel = label; vault.EditorLabel = label;
vault.EditorHostname = "db.internal"; vault.EditorHostname = hostname;
vault.EditorUsername = "deploy"; vault.EditorUsername = "deploy";
await vault.SaveHostCommand.ExecuteAsync(null); await vault.SaveHostCommand.ExecuteAsync(null);
@@ -10405,6 +10484,14 @@ public sealed partial class ShellFlowTests : IAsyncLifetime
private static HostRowViewModel Host(VaultViewModel vault, string label) => private static HostRowViewModel Host(VaultViewModel vault, string label) =>
vault.Hosts.Single(row => string.Equals(row.Label, label, StringComparison.Ordinal)); vault.Hosts.Single(row => string.Equals(row.Label, label, StringComparison.Ordinal));
/// <summary>The host row for a given machine, for the tests whose rows deliberately share a name.</summary>
/// <remarks>
/// <see cref="Host"/> cannot be asked when two rows are called the same thing, which is the whole
/// situation those tests set up. Re-found rather than held, because saving any host rebuilds the list.
/// </remarks>
private static HostRowViewModel Machine(VaultViewModel vault, string hostname) =>
vault.Hosts.Single(row => string.Equals(row.Host.Hostname, hostname, StringComparison.Ordinal));
/// <summary>Deletes the selected host: the question, and then the answer to it.</summary> /// <summary>Deletes the selected host: the question, and then the answer to it.</summary>
/// <remarks> /// <remarks>
/// Both halves, because both are what deleting anything now takes — arming on its own changes nothing, /// Both halves, because both are what deleting anything now takes — arming on its own changes nothing,
@@ -162,6 +162,84 @@ public sealed class PumpOverRealSshTests(SshServerFixture fixture)
"the strip under the terminal prints this sentence, so an empty one is a blank status line"); "the strip under the terminal prints this sentence, so an empty one is a blank status line");
} }
/// <summary>
/// A remote flooding a renderer that never draws anything is bounded, and the pump keeps reading.
/// </summary>
/// <remarks>
/// <para>
/// ◆ THIS IS THE TEST THE OLD DESIGN WOULD FAIL, AND IT NEEDS A REAL SSH.NET UNDERNEATH IT TO SAY SO.
/// The pump used to stop reading once a renderer had a credit window's worth of unrendered output, on
/// the reasoning that SSH's own receive window would then close and block the remote. It does not:
/// <c>Renci.SshNet.Channels.Channel.OnData</c> adjusts the window as bytes <em>arrive</em>, before it
/// hands them on, so the remote goes on sending at full speed and <c>ShellStream</c> copies every byte
/// into a buffer that doubles and is never given back. Against this test, <c>yes</c> would have been
/// read at <c>BytesRead == WindowBytes</c> exactly and then stopped for ever while the process grew.
/// A fake shell cannot show that, because a fake hands over bytes when it is asked and a real channel
/// hands them over when they arrive.
/// </para>
/// <para>
/// So the assertion is in two halves and needs both. Reading keeps going, which is what keeps SSH.NET's
/// buffer drained; and what this side holds stays inside the backlog, which is what keeps the drained
/// bytes from simply piling up here instead. Either alone is satisfied by a design that leaks.
/// </para>
/// </remarks>
[Fact]
public async Task ARunawayRemote_KeepsBeingReadAndStaysInsideTheBacklog()
{
const int Window = 64 * 1024;
const int Backlog = 512 * 1024;
await using var connection = await ConnectTrustedAsync();
var shell = await connection.OpenShellAsync(
new TerminalSize(100, 30, 1000, 750), TestContext.Current.CancellationToken);
// Deliberately never acknowledges: this is a renderer that has stopped drawing, which is the whole
// condition under examination. CountingTransport only acknowledges when it is given a pump.
var transport = new CountingTransport();
await using var pump = new TerminalSessionPump(
1,
shell,
transport,
TimeProvider.System,
new TerminalPumpOptions
{
FlushInterval = TimeSpan.FromMilliseconds(20),
WindowBytes = Window,
BacklogBytes = Backlog,
});
var run = pump.RunAsync(TestContext.Current.CancellationToken);
await pump.WriteInputAsync("yes dodossh\n"u8.ToArray(), TestContext.Current.CancellationToken);
// Long enough that a pump which had stopped at the window would plainly have stopped, and that one
// which had not would have read many times the backlog's capacity.
var deadline = TimeProvider.System.GetUtcNow() + TimeSpan.FromSeconds(10);
while (TimeProvider.System.GetUtcNow() < deadline && pump.BytesRead < Backlog * 4L)
{
await Task.Delay(100, TestContext.Current.CancellationToken);
pump.BytesPending.ShouldBeLessThanOrEqualTo(
Backlog,
"output is accumulating on this side of the socket, which is the growth the backlog bounds");
}
pump.BytesRead.ShouldBeGreaterThan(
Backlog * 4L,
"the pump stopped reading, so the flood is piling up inside SSH.NET where nothing bounds it");
pump.BytesDropped.ShouldBeGreaterThan(
0,
"nothing was dropped, so something between here and the screen is still holding all of it");
await pump.DisposeAsync();
await Should.NotThrowAsync(() => run.WaitAsync(TimeSpan.FromSeconds(30), TestContext.Current.CancellationToken));
}
/// <summary>Trusts the relay's identity, then connects through it.</summary> /// <summary>Trusts the relay's identity, then connects through it.</summary>
/// <remarks> /// <remarks>
/// Pinned under the relay's own address, which is the honest thing here: what is under examination is a /// Pinned under the relay's own address, which is the honest thing here: what is under examination is a
@@ -0,0 +1,221 @@
using System.Net;
using System.Net.Sockets;
using System.Net.WebSockets;
namespace DodoSSH.Client.Ssh.Tests;
/// <summary>
/// The relay bridge: a real SSH connection, through a real SOCKS5 handshake, over a real WebSocket.
/// </summary>
/// <remarks>
/// <para>
/// The relay server is stood in for by the other end of an in-process WebSocket pair that pipes to the
/// fixture's sshd — which is the whole of what the server's socket does once a ticket is spent, so the
/// bytes on the wire here are the bytes a relayed session carries. What is not here is the ticket, which
/// is the server's half and is tested there.
/// </para>
/// <para>
/// Three of these are the security properties the bridge has to keep, from
/// <c>docs/reaching-a-host-you-cannot-dial.md</c>: it binds loopback only, it accepts once, and a
/// connection that goes away takes the bridge — and so the relay session — with it. The failure each
/// guards against is silent: an open proxy, or a relay session left running behind a closed tab.
/// </para>
/// </remarks>
[Collection(SshCollection.Name)]
public sealed class RelayBridgeTests(SshServerFixture fixture)
{
private static readonly TimeSpan Settles = TimeSpan.FromSeconds(20);
private static CancellationToken Token => TestContext.Current.CancellationToken;
[Fact]
public async Task TheBridge_ListensOnLoopbackOnly()
{
var (client, _) = await PairAsync();
await using var bridge = RelayBridge.Start(client);
// Asserted on the address rather than trusted to the constructor: a bridge on every interface
// would be a proxy into the relay for anyone on the network, and nothing would report it.
bridge.Endpoint.Address.ShouldBe(IPAddress.Loopback);
bridge.Proxy.Port.ShouldBe(bridge.Endpoint.Port);
bridge.Proxy.Lifetime.ShouldBeSameAs(bridge);
}
[Fact]
public async Task AShell_ThroughTheBridge_ReachesTheHost_AndGoesWithTheConnection()
{
var knownHosts = await TrustedStoreAsync();
var (client, server) = await PairAsync();
var relaying = RelayToSshdAsync(server);
var bridge = RelayBridge.Start(client);
// The host as the request names it, so the pin is the host's — the bridge is a SOCKS proxy, and
// the CONNECT carries this name through it rather than 127.0.0.1.
var connection = await new SshNetConnectionFactory(knownHosts)
.ConnectAsync(Request(bridge.Proxy), progress: null, Token);
connection.IsConnected.ShouldBeTrue();
connection.HostKey.Host.ShouldBe(fixture.Host);
// The connection owns the bridge. Closing the one is what closes the other, and the relay hears it
// as a close rather than as a socket that stopped answering.
await connection.DisposeAsync();
await bridge.Completion.WaitAsync(Settles, Token);
(await relaying.WaitAsync(Settles, Token)).ShouldBe(WebSocketMessageType.Close);
}
[Fact]
public async Task TheBridge_AcceptsOnce()
{
var (client, _) = await PairAsync();
await using var bridge = RelayBridge.Start(client);
using var first = new TcpClient();
await first.ConnectAsync(bridge.Endpoint, Token);
// A greeting answered means the first connection has been accepted, which is when the listener
// stops — so what the second attempt meets is a closed port, not a race with the backlog.
var stream = first.GetStream();
await stream.WriteAsync(new byte[] { 5, 1, 0 }, Token);
var reply = new byte[2];
await stream.ReadExactlyAsync(reply, Token);
reply.ShouldBe(new byte[] { 5, 0 });
using var second = new TcpClient();
await Should.ThrowAsync<SocketException>(second.ConnectAsync(bridge.Endpoint, Token).AsTask());
}
[Fact]
public async Task ARelayThatClosesWithAReason_FailsTheConnect_AndKeepsTheReason()
{
// What the server does when it cannot reach the host: accept the socket, then close it with 4502.
var (client, server) = await PairAsync();
await server.CloseOutputAsync((WebSocketCloseStatus)4502, "unreachable", Token);
var bridge = RelayBridge.Start(client);
var failure = await Should.ThrowAsync<Exception>(async () =>
await new SshNetConnectionFactory(new InMemoryKnownHostStore())
.ConnectAsync(Request(bridge.Proxy), progress: null, Token));
// A connection error, not a question about a host key nobody presented.
failure.ShouldNotBeOfType<SshHostKeyUnknownException>();
bridge.CloseStatus.ShouldBe((WebSocketCloseStatus)4502);
// And the failed connect disposed the bridge it was handed, rather than leaving it listening.
await bridge.Completion.WaitAsync(Settles, Token);
}
[Fact]
public async Task NobodyArriving_ClosesTheRelay()
{
var (client, server) = await PairAsync();
await using var bridge = RelayBridge.Start(client, TimeSpan.FromMilliseconds(200));
await bridge.Completion.WaitAsync(Settles, Token);
var received = await server.ReceiveAsync(new byte[16], Token);
received.MessageType.ShouldBe(WebSocketMessageType.Close);
}
/// <summary>Two ends of one WebSocket, over a loopback TCP connection this test owns.</summary>
private static async Task<(WebSocket Client, WebSocket Server)> PairAsync()
{
using var listener = new TcpListener(IPAddress.Loopback, 0);
listener.Start();
var dialling = new TcpClient();
var connecting = dialling.ConnectAsync((IPEndPoint)listener.LocalEndpoint, Token);
var accepted = await listener.AcceptTcpClientAsync(Token);
await connecting;
var client = WebSocket.CreateFromStream(
dialling.GetStream(),
new WebSocketCreationOptions { IsServer = false, KeepAliveInterval = TimeSpan.Zero });
var server = WebSocket.CreateFromStream(
accepted.GetStream(),
new WebSocketCreationOptions { IsServer = true, KeepAliveInterval = TimeSpan.Zero });
return (client, server);
}
/// <summary>
/// The relay's half: bytes from the socket to sshd and back, until one side ends.
/// </summary>
/// <returns>The type of the last message the relay received — a close, when the client said goodbye.</returns>
private Task<WebSocketMessageType> RelayToSshdAsync(WebSocket server) => Task.Run(async () =>
{
using var target = new TcpClient();
await target.ConnectAsync(fixture.Host, fixture.Port, Token);
var stream = target.GetStream();
var down = Task.Run(async () =>
{
var buffer = new byte[32 * 1024];
int read;
try
{
while ((read = await stream.ReadAsync(buffer, Token)) > 0)
{
await server.SendAsync(buffer.AsMemory(0, read), WebSocketMessageType.Binary, true, Token);
}
}
catch (Exception exception) when (exception is IOException or WebSocketException or ObjectDisposedException)
{
// The test's connection is over.
}
});
var inbound = new byte[32 * 1024];
while (true)
{
var received = await server.ReceiveAsync(inbound.AsMemory(), Token);
if (received.MessageType == WebSocketMessageType.Close)
{
await server.CloseOutputAsync(WebSocketCloseStatus.NormalClosure, string.Empty, Token);
target.Close();
await down;
return received.MessageType;
}
await stream.WriteAsync(inbound.AsMemory(0, received.Count), Token);
}
});
private SshConnectionRequest Request(SshLoopbackProxy proxy) =>
new(
fixture.Host,
fixture.Port,
SshServerFixture.Username,
new SshPasswordCredential(SshServerFixture.Password),
ConnectTimeout: null,
proxy);
/// <summary>A store that already trusts the container's host key, learned directly.</summary>
private async Task<InMemoryKnownHostStore> TrustedStoreAsync()
{
var knownHosts = new InMemoryKnownHostStore();
var unknown = await Should.ThrowAsync<SshHostKeyUnknownException>(async () =>
await new SshNetConnectionFactory(knownHosts).ConnectAsync(
new SshConnectionRequest(
fixture.Host,
fixture.Port,
SshServerFixture.Username,
new SshPasswordCredential(SshServerFixture.Password)),
progress: null,
Token));
await knownHosts.TrustAsync(unknown.Presentation, Token);
return knownHosts;
}
}
@@ -9,6 +9,7 @@ internal sealed class FakeShellSession : ISshShellSession
private readonly Lock gate = new(); private readonly Lock gate = new();
private readonly bool blockReads; private readonly bool blockReads;
private readonly TimeSpan? pacePerRead;
private long remaining; private long remaining;
private byte pattern; private byte pattern;
@@ -26,10 +27,26 @@ internal sealed class FakeShellSession : ISshShellSession
/// read loop racing the test for control of the pump's credit window — see the reattach tests in /// read loop racing the test for control of the pump's credit window — see the reattach tests in
/// <c>TerminalWorkspaceTests</c>. /// <c>TerminalWorkspaceTests</c>.
/// </param> /// </param>
internal FakeShellSession(long bytesToProduce = 0, bool blockReads = false) /// <param name="pacePerRead">
/// How long each read takes, or null for one that returns as fast as the CPU can fill a buffer.
/// </param>
/// <remarks>
/// <para>
/// The default producer emits at memory bandwidth, which is faster than any network and faster than
/// the pump can frame and send — useful for the throughput harness, and useless for asking whether a
/// terminal that <em>can</em> keep up loses anything, because nothing can keep up with it. A pace makes
/// the fake a link instead of a memcpy: 8 KiB every millisecond is 8 MB/s, which is a fast remote
/// rather than an impossible one.
/// </para>
/// </remarks>
internal FakeShellSession(
long bytesToProduce = 0,
bool blockReads = false,
TimeSpan? pacePerRead = null)
{ {
remaining = bytesToProduce; remaining = bytesToProduce;
this.blockReads = blockReads; this.blockReads = blockReads;
this.pacePerRead = pacePerRead;
} }
/// <inheritdoc /> /// <inheritdoc />
@@ -81,6 +98,11 @@ internal sealed class FakeShellSession : ISshShellSession
await Task.Delay(Timeout.InfiniteTimeSpan, cancellationToken).ConfigureAwait(false); await Task.Delay(Timeout.InfiniteTimeSpan, cancellationToken).ConfigureAwait(false);
} }
if (pacePerRead is { } pace)
{
await Task.Delay(pace, cancellationToken).ConfigureAwait(false);
}
await Task.Yield(); await Task.Yield();
cancellationToken.ThrowIfCancellationRequested(); cancellationToken.ThrowIfCancellationRequested();
@@ -212,6 +234,40 @@ internal sealed class FakeConnection(SshConnectionRequest request, long bytesPer
} }
} }
/// <summary>
/// Counts output without keeping it, and acknowledges it as a renderer that is keeping up would.
/// </summary>
/// <remarks>
/// <see cref="RecordingTransport"/>'s cheap sibling, and the throughput harness needs it to be the one
/// measuring rather than the one measured: recording copies every frame into a list that grows to the size
/// of the whole run, which at the rates that harness drives makes the <em>test double</em> the slowest thing
/// in the pipeline. A harness whose consumer cannot keep up is measuring itself.
/// </remarks>
internal sealed class CountingTransport : ITerminalTransport
{
private long outputBytes;
/// <summary>Set to acknowledge every output frame immediately, as a keeping-up renderer would.</summary>
internal TerminalSessionPump? AutoAcknowledge { get; set; }
/// <summary>Payload bytes of every output frame sent so far.</summary>
internal long OutputBytes => Interlocked.Read(ref outputBytes);
/// <inheritdoc />
public ValueTask SendAsync(ReadOnlyMemory<byte> frame, CancellationToken cancellationToken)
{
if (TerminalFrame.TryRead(frame.Span, out var opcode, out _, out var payload)
&& opcode == (byte)TerminalServerOpcode.Output)
{
_ = Interlocked.Add(ref outputBytes, payload.Length);
AutoAcknowledge?.Acknowledge((uint)payload.Length);
}
return ValueTask.CompletedTask;
}
}
/// <summary>Records frames, and can acknowledge them to keep credit flowing.</summary> /// <summary>Records frames, and can acknowledge them to keep credit flowing.</summary>
internal sealed class RecordingTransport : ITerminalTransport internal sealed class RecordingTransport : ITerminalTransport
{ {
@@ -270,6 +326,23 @@ internal sealed class RecordingTransport : ITerminalTransport
return [.. output]; return [.. output];
} }
/// <summary>Concatenated payloads of every frame of one opcode.</summary>
internal byte[] PayloadsOf(TerminalServerOpcode opcode)
{
var payloads = new List<byte>();
foreach (var frame in Frames)
{
if (TerminalFrame.TryRead(frame, out var actual, out _, out var payload)
&& actual == (byte)opcode)
{
payloads.AddRange(payload);
}
}
return [.. payloads];
}
/// <summary>Counts frames of one opcode.</summary> /// <summary>Counts frames of one opcode.</summary>
internal int CountOf(TerminalServerOpcode opcode) => internal int CountOf(TerminalServerOpcode opcode) =>
Frames.Count(frame => Frames.Count(frame =>
@@ -1,5 +1,6 @@
using System.Diagnostics; using System.Diagnostics;
using System.Globalization; using System.Globalization;
using System.Text;
using DodoSSH.Client.Ssh; using DodoSSH.Client.Ssh;
namespace DodoSSH.Client.Terminal.Tests; namespace DodoSSH.Client.Terminal.Tests;
@@ -84,13 +85,22 @@ public sealed class TerminalSessionPumpTests
await run; await run;
} }
/// <summary>
/// A renderer that has stopped acknowledging does not stop the pump reading, and does not grow it.
/// </summary>
/// <remarks>
/// ◆ THIS TEST REPLACES ONE THAT ASSERTED THE OPPOSITE, and the reversal is the point rather than a
/// relaxation. The old contract was that the pump reads exactly one credit window and then stops,
/// which was believed to close SSH's receive window and block the remote. It does not — see
/// <see cref="OutputBacklog"/> — so all the old behaviour bought was an unbounded buffer inside
/// SSH.NET instead of a bounded one here. What has to be true now is both halves at once: reading
/// continues, so nothing piles up underneath, <em>and</em> what is held stays inside the backlog.
/// </remarks>
[Fact] [Fact]
public async Task WhenCreditRunsOut_ThePumpStopsReading() public async Task WhenCreditRunsOut_ThePumpKeepsReadingAndTheBacklogHoldsTheLine()
{ {
// The property the whole design rests on. With no acknowledgement the pump must read exactly
// the window and then stop, so nothing accumulates between the socket and the screen. Left
// unbounded, a remote running `yes` grows the client's memory until it dies.
const int Window = 4 * 1024; const int Window = 4 * 1024;
const int Backlog = 64 * 1024;
await using var session = new FakeShellSession(bytesToProduce: long.MaxValue); await using var session = new FakeShellSession(bytesToProduce: long.MaxValue);
var transport = new RecordingTransport(); var transport = new RecordingTransport();
@@ -104,19 +114,32 @@ public sealed class TerminalSessionPumpTests
ReadBufferBytes = 1024, ReadBufferBytes = 1024,
FlushInterval = TimeSpan.FromMilliseconds(5), FlushInterval = TimeSpan.FromMilliseconds(5),
WindowBytes = Window, WindowBytes = Window,
BacklogBytes = Backlog,
}); });
var run = pump.RunAsync(TestContext.Current.CancellationToken); var run = pump.RunAsync(TestContext.Current.CancellationToken);
await Task.Delay(TimeSpan.FromMilliseconds(300), TestContext.Current.CancellationToken); await Task.Delay(TimeSpan.FromMilliseconds(300), TestContext.Current.CancellationToken);
pump.BytesRead.ShouldBe( var readByNow = pump.BytesRead;
Window,
"The pump read past its credit window, so output accumulates without bound.");
// Still stalled a moment later, rather than merely slow. readByNow.ShouldBeGreaterThan(
Window,
"The pump stopped reading, which leaves the flood accumulating inside SSH.NET instead.");
pump.BytesPending.ShouldBeLessThanOrEqualTo(
Backlog,
"The backlog grew past its capacity, which is the unbounded growth it exists to prevent.");
pump.BytesDropped.ShouldBeGreaterThan(
0,
"Nothing was dropped, so something is still holding what the renderer never took.");
// Still reading a moment later, rather than having quietly stalled once the backlog filled.
await Task.Delay(TimeSpan.FromMilliseconds(200), TestContext.Current.CancellationToken); await Task.Delay(TimeSpan.FromMilliseconds(200), TestContext.Current.CancellationToken);
pump.BytesRead.ShouldBe(Window);
pump.BytesRead.ShouldBeGreaterThan(readByNow);
pump.BytesPending.ShouldBeLessThanOrEqualTo(Backlog);
pump.Credits.Available.ShouldBe(0); pump.Credits.Available.ShouldBe(0);
@@ -125,10 +148,13 @@ public sealed class TerminalSessionPumpTests
} }
[Fact] [Fact]
public async Task AcknowledgingCredit_LetsThePumpResume() public async Task AcknowledgingCredit_LetsMoreOutputThrough()
{ {
const int Window = 4 * 1024; const int Window = 4 * 1024;
// Endless, so the backlog never completes while this is being measured: once it does, the tail
// goes out regardless of credit and there is nothing for the window to hold back. Drops along the
// way change which bytes are sent, never how many — and the notice they raise is its own opcode.
await using var session = new FakeShellSession(bytesToProduce: long.MaxValue); await using var session = new FakeShellSession(bytesToProduce: long.MaxValue);
var transport = new RecordingTransport(); var transport = new RecordingTransport();
@@ -145,13 +171,16 @@ public sealed class TerminalSessionPumpTests
var run = pump.RunAsync(TestContext.Current.CancellationToken); var run = pump.RunAsync(TestContext.Current.CancellationToken);
await Task.Delay(TimeSpan.FromMilliseconds(200), TestContext.Current.CancellationToken); await Task.Delay(TimeSpan.FromMilliseconds(200), TestContext.Current.CancellationToken);
pump.BytesRead.ShouldBe(Window);
// One window's worth has gone out and stopped there, because nothing has been rendered.
var sentBeforeAcknowledgement = transport.OutputBytes().Length;
sentBeforeAcknowledgement.ShouldBe(Window);
pump.Acknowledge(2048); pump.Acknowledge(2048);
await Task.Delay(TimeSpan.FromMilliseconds(200), TestContext.Current.CancellationToken); await Task.Delay(TimeSpan.FromMilliseconds(200), TestContext.Current.CancellationToken);
pump.BytesRead.ShouldBe(Window + 2048); transport.OutputBytes().Length.ShouldBe(sentBeforeAcknowledgement + 2048);
await pump.DisposeAsync(); await pump.DisposeAsync();
await run; await run;
@@ -161,9 +190,10 @@ public sealed class TerminalSessionPumpTests
public async Task AnOverLargeAcknowledgement_DoesNotWidenTheWindow() public async Task AnOverLargeAcknowledgement_DoesNotWidenTheWindow()
{ {
// The acknowledgement comes from JavaScript. A page claiming to have rendered a gigabyte must // The acknowledgement comes from JavaScript. A page claiming to have rendered a gigabyte must
// not be able to talk the host into an unbounded read. // not be able to talk the host into filling its own buffer without limit.
const int Window = 4 * 1024; const int Window = 4 * 1024;
// Endless for the reason the test above gives: a backlog that completes stops the window mattering.
await using var session = new FakeShellSession(bytesToProduce: long.MaxValue); await using var session = new FakeShellSession(bytesToProduce: long.MaxValue);
var transport = new RecordingTransport(); var transport = new RecordingTransport();
@@ -185,7 +215,8 @@ public sealed class TerminalSessionPumpTests
await Task.Delay(TimeSpan.FromMilliseconds(200), TestContext.Current.CancellationToken); await Task.Delay(TimeSpan.FromMilliseconds(200), TestContext.Current.CancellationToken);
// One further window's worth at most, never everything the endless producer could offer. // One further window's worth at most, never everything the endless producer could offer.
pump.BytesRead.ShouldBeLessThanOrEqualTo(Window * 2); transport.OutputBytes().Length.ShouldBeLessThanOrEqualTo(Window * 2);
pump.Credits.Outstanding.ShouldBeLessThanOrEqualTo(Window);
await pump.DisposeAsync(); await pump.DisposeAsync();
await run; await run;
@@ -344,7 +375,11 @@ public sealed class TerminalSessionPumpTests
const int Window = CreditWindow.DefaultWindowBytes; const int Window = CreditWindow.DefaultWindowBytes;
await using var session = new FakeShellSession(bytesToProduce: Target); await using var session = new FakeShellSession(bytesToProduce: Target);
var transport = new RecordingTransport();
// Counting rather than recording, for the reason CountingTransport carries: a consumer that
// copies every frame into a 32 MB list is the slowest thing in this pipeline, and a harness
// whose consumer cannot keep up measures the harness.
var transport = new CountingTransport();
await using var pump = CreatePump( await using var pump = CreatePump(
session, session,
@@ -369,7 +404,15 @@ public sealed class TerminalSessionPumpTests
var peakOutstanding = await sampler; var peakOutstanding = await sampler;
pump.BytesRead.ShouldBe(Target); pump.BytesRead.ShouldBe(Target);
transport.OutputBytes().Length.ShouldBe((int)Target);
// ◆ Every byte read either reached the renderer or was counted as dropped, and none of it went
// anywhere else. That is the invariant worth asserting here rather than "nothing was dropped":
// this producer emits at memory bandwidth with no network under it, which is faster than any
// real remote and faster than the pump can frame and send, so drops are the honest outcome and
// the harness would be lying to forbid them. What must never happen is a byte that is neither
// delivered nor accounted for — see NothingIsDropped_WhenTheRendererKeepsUpWithTheRemote for
// the case where the producer is one a network could actually deliver.
(transport.OutputBytes + pump.BytesDropped).ShouldBe(Target);
var megabytesPerSecond = Target / 1024d / 1024d / stopwatch.Elapsed.TotalSeconds; var megabytesPerSecond = Target / 1024d / 1024d / stopwatch.Elapsed.TotalSeconds;
@@ -387,6 +430,142 @@ public sealed class TerminalSessionPumpTests
$"Peak in-flight was {peakOutstanding} bytes against a {Window}-byte window.")); $"Peak in-flight was {peakOutstanding} bytes against a {Window}-byte window."));
} }
/// <summary>
/// A renderer that keeps up loses nothing, however much the remote sends.
/// </summary>
/// <remarks>
/// The other half of the trade the backlog makes, and the half a user actually lives in: dropping is
/// for a terminal that cannot keep up, and a terminal that can must show every byte. The producer here
/// is sized for a real link rather than for memory bandwidth — several times the backlog, delivered in
/// pieces a network could carry — so a drop would mean the pump losing output it had room for.
/// </remarks>
[Fact]
public async Task NothingIsDropped_WhenTheRendererKeepsUpWithTheRemote()
{
const int Backlog = 256 * 1024;
const long Target = 512L * 1024;
// 8 KiB a millisecond — 8 MB/s, a fast remote rather than an impossible one, and thirty-two
// times the backlog's capacity per second so the pump has no room to be merely lucky.
await using var session = new FakeShellSession(
bytesToProduce: Target,
pacePerRead: TimeSpan.FromMilliseconds(1));
var transport = new CountingTransport();
await using var pump = CreatePump(
session,
transport,
new TerminalPumpOptions
{
ReadBufferBytes = 8 * 1024,
FlushInterval = TimeSpan.FromMilliseconds(1),
WindowBytes = CreditWindow.DefaultWindowBytes,
BacklogBytes = Backlog,
});
transport.AutoAcknowledge = pump;
await pump.RunAsync(TestContext.Current.CancellationToken);
pump.BytesDropped.ShouldBe(0);
transport.OutputBytes.ShouldBe(Target);
}
/// <summary>
/// A shell that ends against a renderer which stopped acknowledging still finishes.
/// </summary>
/// <remarks>
/// ◆ THE HANG THIS DESIGN MAKES POSSIBLE, AND THE TEST THAT SAYS IT DOES NOT HAPPEN. The flush loop
/// waits on credit when the renderer is behind, and completing the backlog is a different signal from
/// returning credit — so a run whose reader finished while the flusher was parked on an
/// acknowledgement that will never come would wait for ever. Nothing above would notice: the shell has
/// ended, but the tab is told by <c>SessionEnded</c>, which fires off the run task completing, and the
/// connection is given back at the same moment. A session in that state is invisible and permanent.
/// </remarks>
[Fact]
public async Task WhenTheRemoteCloses_TheRunEndsEvenIfTheRendererNeverAcknowledged()
{
const int Window = 4 * 1024;
// More than the window, so the flusher has certainly run out of credit and parked by the time the
// producer reaches the end of what it has to give.
await using var session = new FakeShellSession(bytesToProduce: Window * 4);
// No AutoAcknowledge, ever: this renderer's process died holding the socket.
var transport = new RecordingTransport();
await using var pump = CreatePump(
session,
transport,
new TerminalPumpOptions
{
ReadBufferBytes = 1024,
FlushInterval = TimeSpan.FromMilliseconds(5),
WindowBytes = Window,
});
var run = pump.RunAsync(TestContext.Current.CancellationToken);
await Should.NotThrowAsync(() => run.WaitAsync(TimeSpan.FromSeconds(10), TestContext.Current.CancellationToken));
pump.Outcome.End.ShouldBe(SshSessionEnd.RemoteClosed);
// And the tail went out rather than being abandoned with the flusher: the last thing a remote
// writes is usually why it ended.
transport.OutputBytes().Length.ShouldBe(Window * 4);
transport.CountOf(TerminalServerOpcode.SessionClosed).ShouldBe(1);
}
/// <summary>
/// A drop is announced in the pane rather than leaving a silent gap.
/// </summary>
/// <remarks>
/// The thing that makes dropping defensible at all. A terminal quietly showing a different transcript
/// from the one the remote sent is worse than one that says it could not keep up, because the second
/// can be believed. Its own opcode, so the sentence is never counted as something the remote said —
/// see <see cref="TerminalServerOpcode.OutputDropped"/>.
/// </remarks>
[Fact]
public async Task WhenOutputIsDropped_TheUserIsToldInThePane()
{
const int Window = 4 * 1024;
const int Backlog = 16 * 1024;
await using var session = new FakeShellSession(bytesToProduce: long.MaxValue);
var transport = new RecordingTransport();
await using var pump = CreatePump(
session,
transport,
new TerminalPumpOptions
{
ReadBufferBytes = 1024,
FlushInterval = TimeSpan.FromMilliseconds(5),
WindowBytes = Window,
BacklogBytes = Backlog,
});
var run = pump.RunAsync(TestContext.Current.CancellationToken);
await Task.Delay(TimeSpan.FromMilliseconds(200), TestContext.Current.CancellationToken);
// Enough credit for one more frame, which is what carries the notice out.
pump.Acknowledge((uint)Window);
await Task.Delay(TimeSpan.FromMilliseconds(200), TestContext.Current.CancellationToken);
transport.CountOf(TerminalServerOpcode.OutputDropped).ShouldBeGreaterThan(0);
var notice = Encoding.UTF8.GetString(transport.PayloadsOf(TerminalServerOpcode.OutputDropped));
notice.ShouldContain("of output was dropped");
notice.ShouldStartWith("\u001b[0m");
await pump.DisposeAsync();
await run;
}
/// <summary>Watches in-flight bytes for the duration of a run, returning the highest seen.</summary> /// <summary>Watches in-flight bytes for the duration of a run, returning the highest seen.</summary>
private static async Task<int> SamplePeakOutstandingAsync( private static async Task<int> SamplePeakOutstandingAsync(
TerminalSessionPump pump, TerminalSessionPump pump,
@@ -27,6 +27,12 @@ public sealed class TerminalWorkspaceTests
/// <summary>How long <see cref="WaitUntilAsync"/> polls before calling it a failure.</summary> /// <summary>How long <see cref="WaitUntilAsync"/> polls before calling it a failure.</summary>
private static readonly TimeSpan PollTimeout = TimeSpan.FromSeconds(10); private static readonly TimeSpan PollTimeout = TimeSpan.FromSeconds(10);
/// <summary>
/// How long <see cref="ConnectRendererAsync"/> waits for the attach's replay before calling it a
/// failure. Generous, because it bounds a hang rather than timing anything.
/// </summary>
private static readonly TimeSpan ReplayTimeout = TimeSpan.FromSeconds(10);
[Fact] [Fact]
public async Task WaitingForARendererThatNeverAttaches_GivesUp() public async Task WaitingForARendererThatNeverAttaches_GivesUp()
{ {
@@ -83,9 +89,9 @@ public sealed class TerminalWorkspaceTests
} }
/// <remarks> /// <remarks>
/// The case a naive <c>sessions.Count</c> gets wrong. Nothing removes the entry when the remote /// The case a naive <c>sessions.Count</c> gets wrong. Nothing removes the entry when the remote closes
/// closes the channel by itself — the session is still in the dictionary, holding a connection that /// the channel by itself — what it held is given back, but the entry stays so the tab can go on saying
/// is finished — so counting entries would report a shell that exited as still running. A user /// the session ended — so counting entries would report a shell that exited as still running. A user
/// deciding whether it is safe to walk away is the person that lie is told to. /// deciding whether it is safe to walk away is the person that lie is told to.
/// </remarks> /// </remarks>
[Fact] [Fact]
@@ -645,6 +651,86 @@ public sealed class TerminalWorkspaceTests
await workspace.SendInputAsync(sessionId, "x"u8.ToArray(), TestContext.Current.CancellationToken)); await workspace.SendInputAsync(sessionId, "x"u8.ToArray(), TestContext.Current.CancellationToken));
} }
/// <summary>
/// A shell that ended on its own gives its connection back at once, without waiting for the tab.
/// </summary>
/// <remarks>
/// ◆ THE HALF THAT WAS MISSING. Closing a tab disposed the connection and always had; a remote hanging
/// up did not, so a session that ended went on holding an authenticated socket, a keep-alive putting a
/// packet on the wire every thirty seconds, and SSH.NET's read buffer at whatever size the session's
/// busiest moment had grown it to — for as long as the user left the tab open, which for a tab showing
/// the last thing a job said is indefinitely.
/// </remarks>
[Fact]
public async Task ASessionWhoseRemoteHasExited_GivesBackItsConnectionWithoutWaitingForTheTab()
{
// A shell with no output to give: its first read returns 0, which is the remote closing the
// channel, so the pump finishes with nobody having asked it to.
var connections = new FakeConnectionFactory(bytesPerShell: 0);
await using var workspace = CreateWorkspace(connections);
var sessionId = await workspace.OpenSessionAsync(
Request(), TerminalSize.Default, progress: null, TestContext.Current.CancellationToken);
await WaitUntilAsync(() => connections.Connections.TrueForAll(connection => connection.IsDisposed));
var connection = connections.Connections.ShouldHaveSingleItem();
connection.IsConnected.ShouldBeFalse();
connection.Shell.ShouldNotBeNull().IsOpen.ShouldBeFalse();
// The entry itself stays, and has to: the tab is still on screen, still says it ended, and still
// offers a reconnect — all of which read this workspace rather than the tab strip's own memory.
workspace.CreditsFor(sessionId).ShouldNotBeNull();
workspace.IsSessionLive(sessionId).ShouldBeFalse();
}
/// <remarks>
/// The consequence of the release above, and the reason <c>SendInputAsync</c> asks about liveness
/// rather than presence: the shell channel is disposed the moment the remote hangs up, so an accessory
/// key pressed at a tab that ended reaches a disposed stream. It has to be as ordinary as pressing one
/// at a tab that has closed, which is to say nothing happens.
/// </remarks>
[Fact]
public async Task SendingInputToASessionWhoseRemoteHasExited_IsIgnored()
{
var connections = new FakeConnectionFactory(bytesPerShell: 0);
await using var workspace = CreateWorkspace(connections);
var sessionId = await workspace.OpenSessionAsync(
Request(), TerminalSize.Default, progress: null, TestContext.Current.CancellationToken);
await WaitUntilAsync(() => !workspace.IsSessionLive(sessionId));
await Should.NotThrowAsync(async () =>
await workspace.SendInputAsync(sessionId, "x"u8.ToArray(), TestContext.Current.CancellationToken));
}
/// <remarks>
/// Closing a tab over a session that already released itself must still work, because that is the
/// ordinary way a dead tab goes away. Everything the close does is idempotent by construction — the
/// entry is removed under the lock, and both disposals are guarded — and this is the test that says so
/// rather than leaving it to be inferred from three separate classes.
/// </remarks>
[Fact]
public async Task ClosingATabOverASessionThatAlreadyEnded_IsStillSafe()
{
var connections = new FakeConnectionFactory(bytesPerShell: 0);
await using var workspace = CreateWorkspace(connections);
var sessionId = await workspace.OpenSessionAsync(
Request(), TerminalSize.Default, progress: null, TestContext.Current.CancellationToken);
await WaitUntilAsync(() => !workspace.IsSessionLive(sessionId));
await Should.NotThrowAsync(() => workspace.CloseSessionAsync(sessionId));
workspace.CreditsFor(sessionId).ShouldBeNull();
}
/// <param name="connections"> /// <param name="connections">
/// How connections are made. The renderer-gate tests never reach it — they stop at the gate — but they /// How connections are made. The renderer-gate tests never reach it — they stop at the gate — but they
/// take a fake anyway, because reaching a real host from here would make this a network test. /// take a fake anyway, because reaching a real host from here would make this a network test.
@@ -693,11 +779,20 @@ public sealed class TerminalWorkspaceTests
/// </para> /// </para>
/// <para> /// <para>
/// <c>WaitForRendererAsync</c> answers only for the first renderer ever to attach, so a second call /// <c>WaitForRendererAsync</c> answers only for the first renderer ever to attach, so a second call
/// returns immediately without proving anything about the second socket. That is enough here and is /// returns immediately without proving anything about the second socket — and even for the first it
/// not luck: the only frames a second socket is given are the replay, and the replay is *caused* by the /// answers too early for what the callers here need. It completes when the socket is attached, which
/// attach — <see cref="TerminalWorkspace.RendererReattached"/> and the frames before it cannot be sent /// is before <see cref="TerminalWorkspace.ReplayAfterAttachAsync"/> has run: that is fired and
/// early. The day a test sends something else down a reattached socket, this needs the data plane's own /// forgotten from the accept thread, and a thread-pool that deschedules it for a timeslice lets the
/// <c>SocketAttached</c>, which the workspace does not forward today. /// test open a session in the meantime. The replay then finds that session live and sends it a second,
/// replay-flagged <c>SessionOpened</c> — harmless to the page, which treats it as idempotent, but it
/// lands in the middle of the frames the test is counting on.
/// </para>
/// <para>
/// ◆ SO WAIT FOR THE REPLAY TO BE OVER, NOT ONLY FOR THE ATTACH. <c>RendererReattached</c> is raised
/// as the last thing the replay does, so a socket this returns has had every frame the attach itself
/// causes, and nothing but what the test does next can put another on it. Subscribed before the
/// upgrade, because the replay for a socket that attaches quickly can be over before this method gets
/// to look.
/// </para> /// </para>
/// </remarks> /// </remarks>
private static async Task<ClientWebSocket> ConnectRendererAsync(TerminalWorkspace workspace) private static async Task<ClientWebSocket> ConnectRendererAsync(TerminalWorkspace workspace)
@@ -715,17 +810,29 @@ public sealed class TerminalWorkspaceTests
"Origin", "Origin",
string.Create(CultureInfo.InvariantCulture, $"http://127.0.0.1:{workspace.PageUrl.Port}")); string.Create(CultureInfo.InvariantCulture, $"http://127.0.0.1:{workspace.PageUrl.Port}"));
var replayed = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);
void OnReattached(object? sender, EventArgs e) => replayed.TrySetResult();
workspace.RendererReattached += OnReattached;
try try
{ {
await client.ConnectAsync(new Uri(socketUrl), TestContext.Current.CancellationToken); await client.ConnectAsync(new Uri(socketUrl), TestContext.Current.CancellationToken);
await workspace.WaitForRendererAsync(TestContext.Current.CancellationToken); await workspace.WaitForRendererAsync(TestContext.Current.CancellationToken);
await replayed.Task.WaitAsync(ReplayTimeout, TestContext.Current.CancellationToken);
} }
catch catch
{ {
client.Dispose(); client.Dispose();
throw; throw;
} }
finally
{
workspace.RendererReattached -= OnReattached;
}
return client; return client;
} }