Public Access
jaap-jan
8d2416a602
Three new client projects, and the wire-contract fix they needed. DodoSSH.Client.Domain holds the decrypted item model and the three-way merge, with no I/O at all — so the suite that decides whether a credential can be lost runs in milliseconds with nothing to mock. Scalars defer to the server on a genuine clash so every replica resolves the same triple identically and two clients cannot ping-pong; directives merge per name so two people each adding one both keep theirs; the jump chain merges as a whole value because its order is the route. Whatever loses is returned rather than dropped. DodoSSH.Client.Storage is EF Core on SQLite, no SQLCipher: the rows are already ciphertext, so an encrypted file would protect protected bytes at the cost of a native dependency. It keeps the server's state and the outbox in separate tables, which is what preserves the common ancestor a merge needs. One pending operation per item, enforced by a unique index. DodoSSH.Client.Sync is the pull/apply/push loop. Pulling never decrypts — a change with no local work pending is plumbed as ciphertext — so a first sync of thousands of items does not run twice as many AEAD operations for nothing. Contracts: EncryptedPayload gains WrappedDataKey and DataKeyId. The specification has required a per-item data key since crypto.md §3, the columns have existed since the first migration and DshAad.ItemPayload binds the id, but this record had nowhere to put either — so a spec-compliant item could not be transmitted at all. Found by writing the client that has to produce one. Also closes a hole in AadResourceType, which had no value for the HostTag and HostCredential that SyncEntityType has always listed. Four bugs the tests found, not review: - SQLite refuses to order or compare its own DateTimeOffset mapping, and throws at execution rather than model build. Collecting tombstones and listing conflicts are both that shape, so this was a crash waiting for the first user with a deleted host. Timestamps are integers now, by convention so a later field cannot be the one left unconverted. - SQLitePCLRaw 2.1.11, which EF resolves, is covered by GHSA-2m69-gcr7-jv3q. Pinned forward as a family. - Resurrecting content from a remote deletion cleared the original before queueing the copy. Two transactions, so a crash between them lost the work; reversed, and the rescued id is derived from the tombstone so a replay coalesces instead of duplicating. - Several equality assertions went through Shouldly's ShouldBe, which compares IEnumerable element-wise and so tested nothing about the Equals these types exist to provide. Corrected; the falsification that caught it went from 2 failures to 6. The push response's cursor is deliberately ignored. It sits after this client's own writes, so adopting it skips anything another client committed at a lower sequence in the window between a pull and a push — permanently. Re-reading one's own writes is idempotent and costs a page. The Contracts doc that invited the shortcut now says so. 593 tests, up from 448. The delete-versus-edit rules, the ancestor retention, the fresh operation id on coalesce and the cursor safeguard were each verified by breaking them and watching the right test fail.
47 lines
1.7 KiB
C#
47 lines
1.7 KiB
C#
namespace DodoSSH.Client.Sync.Tests;
|
|
|
|
/// <summary>
|
|
/// The id a rescued item takes.
|
|
/// </summary>
|
|
/// <remarks>
|
|
/// Determinism here is what makes the rescue crash-safe. The reconciler queues the restored copy before
|
|
/// it clears the original, and those are two separate transactions — so a process that dies between them
|
|
/// leaves the original pending and resurrects again on the next pass. Landing on the same id means that
|
|
/// second attempt coalesces into the row already queued instead of leaving the user with duplicates.
|
|
/// </remarks>
|
|
public sealed class ResurrectionIdTests
|
|
{
|
|
private static readonly Guid Original = Guid.Parse("0192f0c8-1234-7c3d-8e4f-5a6b7c8d9e0f");
|
|
|
|
private static readonly Guid Other = Guid.Parse("0192f0c8-5678-7c3d-8e4f-5a6b7c8d9e0f");
|
|
|
|
[Fact]
|
|
public void TheSameTombstone_AlwaysYieldsTheSameId()
|
|
{
|
|
ResurrectionId.For(Original, 3).ShouldBe(ResurrectionId.For(Original, 3));
|
|
}
|
|
|
|
[Fact]
|
|
public void ADifferentItem_YieldsADifferentId()
|
|
{
|
|
ResurrectionId.For(Original, 3).ShouldNotBe(ResurrectionId.For(Other, 3));
|
|
}
|
|
|
|
[Fact]
|
|
public void ADifferentTombstoneVersion_YieldsADifferentId()
|
|
{
|
|
// An item deleted, restored, and deleted again must produce a second rescue rather than
|
|
// colliding with the first.
|
|
ResurrectionId.For(Original, 3).ShouldNotBe(ResurrectionId.For(Original, 4));
|
|
}
|
|
|
|
[Fact]
|
|
public void TheIdIsNotTheOriginal()
|
|
{
|
|
// The tombstone stands, so the rescued copy has to be a different item. Reusing the id would
|
|
// conflict against the tombstone for ever.
|
|
ResurrectionId.For(Original, 1).ShouldNotBe(Original);
|
|
ResurrectionId.For(Original, 1).ShouldNotBe(Guid.Empty);
|
|
}
|
|
}
|