Public Access
Two things the RPM shipped without, and the reason they arrive together is
that both are the same question — what may this platform ask of the machine,
and what must it not ask of the user.
◆ UPDATES: THIS CLIENT CHECKS AND FETCHES, AND PACKAGEKIT INSTALLS.
ADR 0013 rule 11 said there was no updater at all, and that went too far. It
conflated noticing that a newer build exists with installing it: the second is
what the trust argument is about, and the first is not — a client that checks
a fixed address and tells you what it found has taken no capability from
anybody. Written as a flat refusal, the rule bought its safety by paying a cost
that was avoidable, and the ADR now says so in its own words.
So LinuxUpdateChannel reads the rolling nightly release, compares versions the
way rpm compares them, downloads the package, verifies its digest and hands the
file to PackageKit over gdbus. Polkit asks; the user may say no; nothing is
torn down before the answer, because ApplyingEndsTheProcess is false and the
shell already knows what that means — it is the phone's shape, and declining an
update must not cost somebody their open shells.
Three details that are load-bearing rather than incidental:
- The comparison is rpmvercmp and not SemVer, because rpm is what will accept
or refuse the install. Same argument ADR 0014 makes for versionCode. The
installed side is read out of the rpm database rather than derived from the
assembly, so the SemVer-to-rpm translation exists in exactly one place. All
28 expected values in RpmVersionTests came out of rpm itself rather than out
of a reading of the algorithm.
- The digest is checked and is not a signature. Velopack verifies its own
downloads and Android checks a signature; an RPM over HTTPS has neither. The
manifest names a SHA-256 and a mismatch deletes the file rather than leaving
something installable-by-hand in the profile directory.
- ONLY_TRUSTED is cleared, which is what routes the request to polkit's
package-install-untrusted action. The package is unsigned, so requiring
trust would fail every update at the last step.
◆ THE DEVICE KEY: SEALED IN THE TPM, BEHIND A PIN THE TPM CHECKS.
ADR 0007's amendment is the bar: a gate inside the process is not a gate. The
key is sealed into a TPM 2.0 keyedhash object whose userAuth comes from a PIN,
so unsealing is a command the chip refuses; the blob is encrypted to the storage
hierarchy and is useless on any other machine; nothing here ever compares a PIN.
The sealed object deliberately carries no NoDA attribute, and that one omission
is the whole reason four digits is enough: every wrong answer advances the TPM's
dictionary-attack counter and the chip stops answering entirely once it trips.
Measured at four wrong tries against a software TPM, after which the correct PIN
gets nothing either. It is asserted by a test rather than left to a reading of
the template, because removing the attribute leaves every other assertion
passing.
This is weaker than Hello and Touch ID and the difference is invisible, so it is
written down in three places rather than smoothed over: those raise their prompt
from inside the platform and this one is a window we draw. The prompt is
deliberately plain for that reason — teaching people that a convincing DodoSSH
PIN box is a system dialog is the one thing this design must not do.
Rejected, each for failing the amendment: the Secret Service API, which has no
per-use consent and is DPAPI's shape exactly; fprintd, which answers a question
and holds nothing, so skipping the call skips the gate; and a polkit-gated root
helper, which would work and puts a privileged component in a package that
installs nothing setuid.
Availability is narrower than "has a TPM": on Fedora /dev/tpmrm0 is root:tss and
desktop users are not in tss, so the ordinary case reports unavailable and keeps
asking for the passphrase. Shipping a udev rule to widen that is refused — it is
the administrator's decision, not an application package's.
◆ WHAT IS ACTUALLY VERIFIED, SINCE THAT IS THE PART THAT USUALLY ISN'T.
This is the only device key store in the repository with real coverage, and it
is only possible because the PIN is a delegate and the TPM is a device: seal,
unseal, wrong PIN, lockout, decline and a foreign blob all run unattended
against a software TPM. Windows and macOS cannot be tested at all — their
prompts block a suite forever, which WindowsDeviceKeyStoreTests records.
TSS.Net's own TcpTpmDevice cannot reach swtpm: it opens the platform socket too
and exchanges a handshake only the Microsoft reference simulator answers, so
Connect() blocks with no error and no timeout. SoftwareTpm speaks the data
channel and nothing else.
The suite also lied once and was fixed: the lockout test trips shared state, and
without a DictionaryAttackLockReset in Dispose every later test got null from a
correct PIN — six of them assert null and passed for entirely the wrong reason.
End to end on a real Fedora 44: a genuine linux-x64 publish packages, installs,
and every DT_NEEDED in the installed tree resolves except liblttng-ust, which is
the one this spec deliberately excludes. What no runner covers is /dev/tpmrm0,
PackageKit and polkit, and Phase 19 grew five checks for exactly those.
Also fixed: the magic-bytes literal picked up raw control characters, which made
LinuxDeviceKeyStore.cs binary to git — no diffs and no line-ending normalisation.
116 lines
3.3 KiB
C#
116 lines
3.3 KiB
C#
using System.Buffers.Binary;
|
|
using System.Net.Sockets;
|
|
using Tpm2Lib;
|
|
|
|
namespace DodoSSH.Client.App.Tests;
|
|
|
|
/// <summary>
|
|
/// Talks to a software TPM over its TCP data channel, so the real store can be driven without hardware.
|
|
/// </summary>
|
|
/// <remarks>
|
|
/// <para>
|
|
/// <b>TSS.Net ships a TcpTpmDevice and it cannot be used here.</b> It also opens the simulator's
|
|
/// <em>platform</em> socket and exchanges a handshake that the Microsoft reference simulator answers and
|
|
/// swtpm does not, so <c>Connect()</c> blocks forever — with no error and no timeout. That was found by
|
|
/// watching it hang, and it is the whole reason this file exists.
|
|
/// </para>
|
|
/// <para>
|
|
/// The data channel is the framing <c>tcti-mssim</c> uses and swtpm does implement: a command word, a
|
|
/// locality byte, a length and the bytes, answered by a length, the bytes and an acknowledgement word.
|
|
/// Power management is unnecessary when swtpm is started with <c>--flags not-need-init,startup-clear</c>,
|
|
/// which is the invocation <see cref="LinuxDeviceKeyStoreTests"/> documents.
|
|
/// </para>
|
|
/// </remarks>
|
|
internal sealed class SoftwareTpm : Tpm2Device
|
|
{
|
|
/// <summary>tcti-mssim's "here is a command for the TPM".</summary>
|
|
private const uint SendCommand = 8;
|
|
|
|
private readonly string host;
|
|
private readonly int port;
|
|
|
|
private TcpClient? client;
|
|
private NetworkStream? stream;
|
|
|
|
internal SoftwareTpm(string host, int port)
|
|
{
|
|
this.host = host;
|
|
this.port = port;
|
|
}
|
|
|
|
public override void Connect()
|
|
{
|
|
client = new TcpClient();
|
|
client.Connect(host, port);
|
|
stream = client.GetStream();
|
|
}
|
|
|
|
public override void Close()
|
|
{
|
|
stream?.Dispose();
|
|
client?.Dispose();
|
|
|
|
stream = null;
|
|
client = null;
|
|
}
|
|
|
|
public override void DispatchCommand(CommandModifier active, byte[] inBuf, out byte[] outBuf)
|
|
{
|
|
ArgumentNullException.ThrowIfNull(active);
|
|
ArgumentNullException.ThrowIfNull(inBuf);
|
|
|
|
if (stream is null)
|
|
{
|
|
throw new InvalidOperationException("Not connected.");
|
|
}
|
|
|
|
Span<byte> header = stackalloc byte[9];
|
|
|
|
BinaryPrimitives.WriteUInt32BigEndian(header, SendCommand);
|
|
header[4] = active.ActiveLocality;
|
|
BinaryPrimitives.WriteUInt32BigEndian(header[5..], (uint)inBuf.Length);
|
|
|
|
stream.Write(header);
|
|
stream.Write(inBuf, 0, inBuf.Length);
|
|
stream.Flush();
|
|
|
|
outBuf = ReadExactly((int)ReadUInt32());
|
|
|
|
// The trailing acknowledgement word. It has to be consumed even though nothing reads it, or every
|
|
// response after this one is misframed by four bytes.
|
|
_ = ReadUInt32();
|
|
}
|
|
|
|
protected override void Dispose(bool disposing)
|
|
{
|
|
if (disposing)
|
|
{
|
|
Close();
|
|
}
|
|
|
|
base.Dispose(disposing);
|
|
}
|
|
|
|
private uint ReadUInt32() => BinaryPrimitives.ReadUInt32BigEndian(ReadExactly(4));
|
|
|
|
private byte[] ReadExactly(int count)
|
|
{
|
|
var buffer = new byte[count];
|
|
var read = 0;
|
|
|
|
while (read < count)
|
|
{
|
|
var got = stream!.Read(buffer, read, count - read);
|
|
|
|
if (got <= 0)
|
|
{
|
|
throw new IOException("The TPM closed the connection.");
|
|
}
|
|
|
|
read += got;
|
|
}
|
|
|
|
return buffer;
|
|
}
|
|
}
|