Public Access
jaap-janandClaude Opus 5
8c04ba60b0
Steps 1 to 3 of docs/adding-hosts-on-the-phone.md: the domain half. Nothing on either head has changed, which is deliberate — the plan orders these first because everything the editors will bind to has to exist and be merge-safe before a screen can offer it. HostGroupSecret gains a parent and four defaults, and the codec gains the version rule it never had. It stamped CurrentSchemaVersion unconditionally, which was harmless with one field and one version and stops being harmless here: upgrading one machine and renaming any group would have made that group uneditable on every machine still on the old build. It now emits the lowest version that loses nothing, so a flat group with no defaults still encodes at version 1, byte for byte, pinned against a literal. Tags become a real item over the reserved slot. Secret, codec, merge, cipher, repository, both registries, the EF entity and a generated AddTagItem migration. TagCipher names AadResourceType.Tag as a constant rather than casting the wire type, because Tag is 5 on the wire and 8 in the crypto enum and 5 there is Credential — a cast would seal every tag under the resource type for a password, encrypt and decrypt perfectly on the machine that wrote it, and only fail when another implementation refused the item, by which time the AAD is frozen into stored ciphertext. HostTag stays reserved and unused: the one thing the join buys over a set on the host is bought instead by merging TagIds per id. HostSecret grows TagIds and Port goes nullable, which is the change with the widest blast radius and the only one that loses an item rather than locking one. A host with no port of its own omits the property, an older build reads int Port as 0, and TryValidate refuses it — unreadable rather than read-only. That cost is confined to hosts which actually inherit, because the version is a maximum over the fields present; the alternative, writing 22 into every host, is the lie inheritance exists to stop telling. One decision the plan did not specify. "Three states where there were two" is four — key, credential, typed password, or the group's answer — and two nullable ids carry three. Naming neither id now means inherit, so AsksForPassword says "a typed password even under a group that lends a key" out loud. Only true is ever written and a decoded false folds back to null, so a host that never touched it encodes as it always did. Nothing already stored changed meaning: no group could lend a binding before this build, so every existing host resolves exactly as it did. HostInheritance is the resolver, and its visited set is load-bearing rather than defensive. Two clients can each re-parent A under B and B under A while offline; the merge sees one item against one item and the server sees ciphertext, so nothing upstream can refuse the pair. With inheritance the chain is walked at connect time, so an unguarded cycle is not an undrawable sidebar — it is a shell that never opens. Stopping at the first repeat degrades it to a group that reads as a root, and clearing the parent is the repair. A tag set turns out to be the one field on a host that can never ask the user anything. TagSet.ToIdMap keys by the value, so no key can hold two values, so the both-sides-moved-differently branch of the keyed merge is unreachable — asserted over the whole eight-row matrix. The conflict loop is kept anyway, because that proof is one edit from ceasing to hold and what it would cause is a discarded tag nothing records. Three guard tests failed by design and were fixed rather than relaxed: the ordered pull filter, the AAD pinning table, and the server's refusal of a plaintext parent — that last one survives with its reason rewritten, because the refusal now means "the parent is not the server's to hold" rather than "there is no such thing as a parent". The prose that said groups are flat is rewritten in all four places it appeared, not deleted. The five view-model sites that read Port directly now go through the resolver, which is a down payment on step 4 rather than the whole of it. HostFields.From still emits the stored port, and that is the one remaining place where an unresolved read would be a wrong wire rather than a wrong label. Verified by the whole suite: 1382 tests over nineteen projects, none failing. Both heads build. Nothing seen on a display, because nothing on a display has changed yet. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
87 lines
3.5 KiB
C#
87 lines
3.5 KiB
C#
namespace DodoSSH.Client.Domain.Tests;
|
|
|
|
/// <summary>
|
|
/// Builds hosts, and the groups they are filed under, so each test varies only what it is about.
|
|
/// </summary>
|
|
internal static class HostFactory
|
|
{
|
|
internal static Guid Bastion { get; } = Guid.Parse("0192f0c8-1111-7c3d-8e4f-5a6b7c8d9e01");
|
|
|
|
internal static Guid Relay { get; } = Guid.Parse("0192f0c8-2222-7c3d-8e4f-5a6b7c8d9e02");
|
|
|
|
/// <summary>A vault SSH key id, for the hosts that bind one.</summary>
|
|
internal static Guid DeployKey { get; } = Guid.Parse("0192f0c8-3333-7c3d-8e4f-5a6b7c8d9e03");
|
|
|
|
/// <summary>A group id, for the hosts that are filed under one.</summary>
|
|
internal static Guid Production { get; } = Guid.Parse("0192f0c8-4444-7c3d-8e4f-5a6b7c8d9e04");
|
|
|
|
/// <summary>A tag id, for the hosts that wear one.</summary>
|
|
internal static Guid Pci { get; } = Guid.Parse("0192f0c8-8888-7c3d-8e4f-5a6b7c8d9e08");
|
|
|
|
/// <summary>A second tag id, for the tests about two people tagging one host.</summary>
|
|
internal static Guid EuWest { get; } = Guid.Parse("0192f0c8-9999-7c3d-8e4f-5a6b7c8d9e09");
|
|
|
|
/// <remarks>
|
|
/// <paramref name="port"/> defaults to an explicit 22 rather than to null, so a test that says nothing
|
|
/// about ports gets the host shape that existed before inheritance did — which is what nearly every
|
|
/// suite here is still about. Passing <see langword="null"/> is how a test asks for the new one.
|
|
/// </remarks>
|
|
internal static HostSecret Host(
|
|
string label = "prod-db",
|
|
string hostname = "db.internal",
|
|
int? port = 22,
|
|
string? username = "deploy",
|
|
string? notes = null,
|
|
Guid[]? jumps = null,
|
|
(string Name, string Value)[]? options = null,
|
|
bool relayEnabled = false,
|
|
Guid? sshKeyId = null,
|
|
Guid? credentialId = null,
|
|
bool? asksForPassword = null,
|
|
Guid? groupId = null,
|
|
Guid[]? tags = null) =>
|
|
new()
|
|
{
|
|
Label = label,
|
|
Hostname = hostname,
|
|
Port = port,
|
|
Username = username,
|
|
Notes = notes,
|
|
JumpHostIds = jumps is null ? JumpChain.Empty : JumpChain.Create(jumps),
|
|
Options = options is null
|
|
? HostOptions.Empty
|
|
: HostOptions.Create(options.Select(o => new HostOption(o.Name, o.Value))),
|
|
RelayEnabled = relayEnabled,
|
|
SshKeyId = sshKeyId,
|
|
CredentialId = credentialId,
|
|
AsksForPassword = asksForPassword,
|
|
GroupId = groupId,
|
|
TagIds = tags is null ? TagSet.Empty : TagSet.Create(tags),
|
|
};
|
|
|
|
/// <summary>
|
|
/// A group, flat and defaulting nothing unless the test says otherwise.
|
|
/// </summary>
|
|
/// <remarks>
|
|
/// The defaults of this builder are the shape a group had before it could nest or default anything,
|
|
/// which is what most suites still want: a heading with a name. A test that passes nothing here is
|
|
/// asserting about the old shape on purpose.
|
|
/// </remarks>
|
|
internal static HostGroupSecret Group(
|
|
string label = "production",
|
|
Guid? parentId = null,
|
|
int? defaultPort = null,
|
|
string? defaultUsername = null,
|
|
Guid? defaultSshKeyId = null,
|
|
Guid? defaultCredentialId = null) =>
|
|
new()
|
|
{
|
|
Label = label,
|
|
ParentId = parentId,
|
|
DefaultPort = defaultPort,
|
|
DefaultUsername = defaultUsername,
|
|
DefaultSshKeyId = defaultSshKeyId,
|
|
DefaultCredentialId = defaultCredentialId,
|
|
};
|
|
}
|