Public Access
The connecting card set its status string once, when the tab was created, and never touched it again. Every connection therefore looked identical from the outside: one three seconds into a key exchange, one waiting out a fifteen-second timeout against a machine that is asleep, and one that had hung all drew the same "connecting…". The card now draws the five steps of getting there, each lit at the moment the handshake reports reaching it, over an amber track that fills as they finish. ◆ NOTHING ON THE LIST IS INVENTED. Every row changes state because a layer below it said so, at the instant the thing it names actually began. That is the whole reason it is worth showing, and it is why most of this commit is plumbing rather than XAML: there was no progress reporting anywhere in the stack to hook a step list onto, and a card animating plausible progress would have been indistinguishable from one that had stopped receiving any. SshConnectionPhase names four phases and deliberately not more. SSH.NET runs the entire handshake inside one ConnectAsync and raises exactly one event from the middle of it — HostKeyReceived, once the key exchange has produced a key to show — so that event is the only interior moment there is to report. Everything before it is Reaching and everything after it is Authenticating. A fifth phase in that assembly would have to be a timer, so there is not one. OpeningShell is reported by TerminalWorkspace instead, because that is where it happens: the factory's work ends with an authenticated connection, and asking for a pseudo-terminal on one is a separate round trip. The SFTP path passes null — a second connection opened behind an already-open shell has nobody watching a step list for it. The card's fifth step, "Starting the terminal", is the renderer wait and lives in the shell rather than in the SSH assembly, which has never heard of a renderer. On the first connection after a cold start it is a real wait with a real failure mode of its own — a missing WebView2 runtime — so a list that began at "reaching the host" would leave the one wait most likely to hang unnamed. Amber for the step in flight, and that follows the palette's rule rather than bending it. Green is what is true and purple is what you can press; a step still happening is neither, and it is exactly the caveat-worth-reading that amber exists for. Steps behind it go green as they become true. Nothing animates, which is the argument TransfersScreen.axaml already makes for its own track, reaching a screen with far more reason to want a spinner: a spinner is furniture invented to fill a state nobody measured, and these states are measured, so the track fills to what has finished and then waits there. A refusal keeps the step it stopped on, in red, with the ones behind it still green. That is the half a progress bar could not do, and it is the difference between "that host is not there" and "that host is there and would not have me" — a question the reason sentence alone frequently does not settle. The strip's dot goes amber while a tab is connecting, on both heads. It was grey, and so is a tab whose shell has exited: the two states in that strip with the least in common, one worth waiting for and one over. PhoneShell's own comment already recorded half of this — the dot stopped being green before anything had answered — and this is the other half. Progress is raised inline rather than through System.Progress<T>, which captures whatever synchronisation context it was constructed on and posts to it. That reads like a convenience and is really a second place the marshalling decision gets made: silently, differently under a test with no context, and out of order with respect to the failure that follows a phase. The shell marshals once, in one handler, through a new optional post parameter on MainWindowViewModel — the same seam TransfersViewModel already uses, and for the reason its own remark gives. The three Dispatcher.UIThread.Post calls that predate it are the ones this suite's comments record as out of reach; they are left alone rather than swept in here. Both heads draw the list. They differ in one place: Phone.axaml's mono class sets a colour and a size along with the family, so the caption rule names its own family instead of composing the two and asking two rules for one Foreground. The desktop's mono sets the family alone, which is why ConnectingCard does compose them. Each head also gains SHOW LOGS beside the button that gives up — the step list is this attempt and the log is every other one, which is what a connection taking too long actually raises. Seven tests, and the two that matter most run against the container rather than a fake: a real handshake reports its phases in order, and a host-key refusal never claims to have authenticated. A fake asserting what it was written to assert would have established nothing about either. The rest cover the tab advancing while the connection is gated, the step a refusal stops on, and a phase reported after the user has given up on the tab. 1,861 tests, none failing. The Android head's layout is not verified by anything. It compiles, and compiled bindings mean every new binding path resolves, but that project is not in DodoSSH.slnx, there is no test project for it and no device here — so unlike the desktop card, whose shapes the layout harness measures, these rows have not been drawn. Vertical fit is reasoned, not observed.
272 lines
9.2 KiB
C#
272 lines
9.2 KiB
C#
using DodoSSH.Client.Ssh;
|
|
|
|
namespace DodoSSH.Client.Terminal.Tests;
|
|
|
|
/// <summary>A shell session that produces output on demand, for exercising the pump.</summary>
|
|
internal sealed class FakeShellSession : ISshShellSession
|
|
{
|
|
private readonly List<byte> written = [];
|
|
private readonly Lock gate = new();
|
|
|
|
private readonly bool blockReads;
|
|
|
|
private long remaining;
|
|
private byte pattern;
|
|
|
|
/// <param name="bytesToProduce">
|
|
/// How many bytes to emit before reporting end of stream. <see cref="long.MaxValue"/> for an
|
|
/// endless producer, which is what a runaway remote process looks like — those sessions are ended
|
|
/// by disposing the pump rather than by running out of data.
|
|
/// </param>
|
|
/// <param name="blockReads">
|
|
/// True for a shell that is open and live but has nothing to say — an idle prompt, rather than either
|
|
/// end of the "produces bytes" and "hit end of stream" spectrum <paramref name="bytesToProduce"/>
|
|
/// covers. <see cref="ReadAsync"/> then blocks until cancelled, which is what a real idle SSH channel's
|
|
/// read does. Exists for tests that need a session whose <c>Run</c> stays live without a background
|
|
/// read loop racing the test for control of the pump's credit window — see the reattach tests in
|
|
/// <c>TerminalWorkspaceTests</c>.
|
|
/// </param>
|
|
internal FakeShellSession(long bytesToProduce = 0, bool blockReads = false)
|
|
{
|
|
remaining = bytesToProduce;
|
|
this.blockReads = blockReads;
|
|
}
|
|
|
|
/// <inheritdoc />
|
|
public bool IsOpen { get; private set; } = true;
|
|
|
|
/// <summary>Reads issued against this session, to detect a pump that kept reading.</summary>
|
|
public int ReadCount { get; private set; }
|
|
|
|
/// <summary>Bytes the pump wrote toward the remote.</summary>
|
|
public byte[] Written
|
|
{
|
|
get
|
|
{
|
|
lock (gate)
|
|
{
|
|
return [.. written];
|
|
}
|
|
}
|
|
}
|
|
|
|
/// <summary>The last size the pump forwarded, or null if it forwarded none.</summary>
|
|
public TerminalSize? LastResize { get; private set; }
|
|
|
|
/// <summary>How many resizes were forwarded, so a dropped one is observable.</summary>
|
|
public int ResizeCount { get; private set; }
|
|
|
|
/// <inheritdoc />
|
|
/// <remarks>
|
|
/// Returns 0 once the configured budget is spent, which is what a remote closing the channel looks
|
|
/// like. Not synchronous: a fake that never yields would let the pump's read loop monopolise the
|
|
/// thread and hide any ordering problem between reading and flushing.
|
|
/// </remarks>
|
|
public async ValueTask<int> ReadAsync(Memory<byte> buffer, CancellationToken cancellationToken)
|
|
{
|
|
ReadCount++;
|
|
|
|
if (blockReads)
|
|
{
|
|
// Never completes on its own. The only way out is the same way a real blocked read ends: the
|
|
// token being cancelled, which is what disposing the pump does.
|
|
await Task.Delay(Timeout.InfiniteTimeSpan, cancellationToken).ConfigureAwait(false);
|
|
}
|
|
|
|
await Task.Yield();
|
|
cancellationToken.ThrowIfCancellationRequested();
|
|
|
|
if (remaining <= 0)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
var count = (int)Math.Min(buffer.Length, remaining);
|
|
buffer.Span[..count].Fill(unchecked(pattern++));
|
|
remaining -= count;
|
|
|
|
return count;
|
|
}
|
|
|
|
/// <inheritdoc />
|
|
public ValueTask WriteAsync(ReadOnlyMemory<byte> data, CancellationToken cancellationToken)
|
|
{
|
|
lock (gate)
|
|
{
|
|
written.AddRange(data.ToArray());
|
|
}
|
|
|
|
return ValueTask.CompletedTask;
|
|
}
|
|
|
|
/// <inheritdoc />
|
|
public void Resize(TerminalSize size)
|
|
{
|
|
// Mirrors the real session: an unusable size is dropped rather than forwarded.
|
|
if (!size.IsUsable)
|
|
{
|
|
return;
|
|
}
|
|
|
|
ResizeCount++;
|
|
LastResize = size;
|
|
}
|
|
|
|
/// <inheritdoc />
|
|
public ValueTask DisposeAsync()
|
|
{
|
|
IsOpen = false;
|
|
remaining = 0;
|
|
|
|
return ValueTask.CompletedTask;
|
|
}
|
|
}
|
|
|
|
/// <summary>
|
|
/// Hands out <see cref="FakeShellSession"/>s, so a workspace can be driven with no network.
|
|
/// </summary>
|
|
/// <remarks>
|
|
/// Exists for the session-lifetime tests. Everything else in this suite works on a pump directly; the
|
|
/// workspace is the layer that decides when a session is over, and that decision is what needs a
|
|
/// connection whose shell can be made to end on cue.
|
|
/// </remarks>
|
|
internal sealed class FakeConnectionFactory(long bytesPerShell = long.MaxValue, bool blockShellReads = false)
|
|
: ISshConnectionFactory
|
|
{
|
|
/// <summary>Connections handed out, in order.</summary>
|
|
internal List<FakeConnection> Connections { get; } = [];
|
|
|
|
/// <inheritdoc />
|
|
public Task<ISshConnection> ConnectAsync(
|
|
SshConnectionRequest request,
|
|
IProgress<SshConnectionPhase>? progress,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
// The real factory's own order, so that a test watching this fake is watching the same sequence a
|
|
// real handshake produces. It cannot report CheckingHostKey — there is no key exchange here to
|
|
// produce a key — and inventing one would make this the only place that phase came from.
|
|
progress?.Report(SshConnectionPhase.Reaching);
|
|
progress?.Report(SshConnectionPhase.Authenticating);
|
|
|
|
var connection = new FakeConnection(request, bytesPerShell, blockShellReads);
|
|
Connections.Add(connection);
|
|
|
|
return Task.FromResult<ISshConnection>(connection);
|
|
}
|
|
}
|
|
|
|
/// <summary>A connection that opens fake shells and records its own disposal.</summary>
|
|
internal sealed class FakeConnection(SshConnectionRequest request, long bytesPerShell, bool blockShellReads = false)
|
|
: ISshConnection
|
|
{
|
|
/// <inheritdoc />
|
|
public bool IsConnected { get; private set; } = true;
|
|
|
|
/// <inheritdoc />
|
|
public HostKeyPresentation HostKey { get; } =
|
|
new(request.Host, request.Port, "ssh-ed25519", "SHA256:fake");
|
|
|
|
/// <inheritdoc />
|
|
public string Cipher { get; } = "aes256-gcm@openssh.com";
|
|
|
|
/// <summary>The shell this connection opened, if it opened one.</summary>
|
|
internal FakeShellSession? Shell { get; private set; }
|
|
|
|
/// <summary>Whether the connection was disposed, which is what closing a session must do.</summary>
|
|
internal bool IsDisposed { get; private set; }
|
|
|
|
/// <inheritdoc />
|
|
public Task<ISshShellSession> OpenShellAsync(TerminalSize size, CancellationToken cancellationToken)
|
|
{
|
|
Shell = new FakeShellSession(bytesPerShell, blockShellReads);
|
|
|
|
return Task.FromResult<ISshShellSession>(Shell);
|
|
}
|
|
|
|
/// <inheritdoc />
|
|
public ValueTask DisposeAsync()
|
|
{
|
|
IsDisposed = true;
|
|
IsConnected = false;
|
|
|
|
return ValueTask.CompletedTask;
|
|
}
|
|
}
|
|
|
|
/// <summary>Records frames, and can acknowledge them to keep credit flowing.</summary>
|
|
internal sealed class RecordingTransport : ITerminalTransport
|
|
{
|
|
private readonly List<byte[]> frames = [];
|
|
private readonly Lock gate = new();
|
|
|
|
/// <summary>Set to acknowledge every output frame immediately, as a keeping-up renderer would.</summary>
|
|
internal TerminalSessionPump? AutoAcknowledge { get; set; }
|
|
|
|
/// <summary>Frames sent so far.</summary>
|
|
internal IReadOnlyList<byte[]> Frames
|
|
{
|
|
get
|
|
{
|
|
lock (gate)
|
|
{
|
|
return [.. frames];
|
|
}
|
|
}
|
|
}
|
|
|
|
/// <inheritdoc />
|
|
public ValueTask SendAsync(ReadOnlyMemory<byte> frame, CancellationToken cancellationToken)
|
|
{
|
|
var copy = frame.ToArray();
|
|
|
|
lock (gate)
|
|
{
|
|
frames.Add(copy);
|
|
}
|
|
|
|
if (AutoAcknowledge is { } pump
|
|
&& TerminalFrame.TryRead(copy, out var opcode, out _, out var payload)
|
|
&& opcode == (byte)TerminalServerOpcode.Output)
|
|
{
|
|
pump.Acknowledge((uint)payload.Length);
|
|
}
|
|
|
|
return ValueTask.CompletedTask;
|
|
}
|
|
|
|
/// <summary>Concatenated payloads of every output frame.</summary>
|
|
internal byte[] OutputBytes()
|
|
{
|
|
var output = new List<byte>();
|
|
|
|
foreach (var frame in Frames)
|
|
{
|
|
if (TerminalFrame.TryRead(frame, out var opcode, out _, out var payload)
|
|
&& opcode == (byte)TerminalServerOpcode.Output)
|
|
{
|
|
output.AddRange(payload);
|
|
}
|
|
}
|
|
|
|
return [.. output];
|
|
}
|
|
|
|
/// <summary>Counts frames of one opcode.</summary>
|
|
internal int CountOf(TerminalServerOpcode opcode) =>
|
|
Frames.Count(frame =>
|
|
TerminalFrame.TryRead(frame, out var actual, out _, out _)
|
|
&& actual == (byte)opcode);
|
|
}
|
|
|
|
/// <summary>An <see cref="IProgress{T}"/> that runs its callback on the thread that reported.</summary>
|
|
/// <remarks>
|
|
/// <c>System.Progress<T></c> would post to a captured synchronisation context, or to the thread pool
|
|
/// when there is none — which is what a test has here — so a list it appended to would be asserted on before
|
|
/// it had been written. This is the same reason the shell does not use it either; see
|
|
/// <c>VaultViewModel.ReporterFor</c>.
|
|
/// </remarks>
|
|
internal sealed class DelegateProgress<T>(Action<T> report) : IProgress<T>
|
|
{
|
|
public void Report(T value) => report(value);
|
|
}
|