Files
DodoSSH/src/DodoSSH.Client.Domain/ConnectionLogSecret.cs
T
jaap-jan d07b336868 Free the terminal from the Hosts screen, and fill the room it left
The WebView sat inside the Hosts grid, so navigating to Files or the keychain
hid every open terminal and the strip that named them. A connection you had
opened was invisible from four of the five screens. The window now has two
surfaces rather than one: a nav rail that says which page you are on, and a
terminal strip that is always there and switches the whole content area to a
shell. Screen keeps meaning "which page" and never becomes a sixth kind of
page, which is why this is two properties instead of one enum with a terminal
member in it.

Every screen lives inside one wrapper panel that collapses when a terminal is
showing. That is not tidiness — the WebView hosts a Win32 child window that
composites above everything Avalonia draws, so a screen left visible over its
rectangle is a screen sliced in half, and this window has shipped that defect
once already. One decision point, IsTerminalShowing, and a nested panel rather
than five compound bindings nobody would remember to extend.

The focus choreography is the part no test in this repo can see. Every reveal
path now focuses in the same turn the WebView appeared, so all three of them
post at DispatcherPriority.Loaded and let the native control re-push its bounds
first. Going the other way had a real bug: the screen-changed branch called a
bare Focus() where it had to release the keyboard from the native child, so
switching from a terminal to Files silently ate the first keystrokes. Rare
before this commit and the primary gesture after it.

The tab strip grew a cross inside each tab, a plus that opens the quick-connect
palette, and middle-click close. Nested buttons are correct here: Avalonia
handles a left press on the cross and deliberately does not handle other
buttons, which is exactly what lets middle-click bubble up from the cross as
well as the tab. The test is PointerUpdateKind rather than
IsMiddleButtonPressed, because the latter reports button state and is also true
for a left press made while the middle button happens to be held. The handler
is on the tab and not the strip, so the background closes nothing by
construction. Plus opens the palette rather than a flyout, since a menu
dropping into the WebView's rectangle may or may not composite above a child
HWND and this repo does not make rendering claims it has not photographed.

Everything a user reads now says keychain. The wire, the database and the
cryptographic spec still say vault, deliberately: renaming those is a migration
and a protocol change for a word. That split is written down rather than left
to be rediscovered as an inconsistency.

Four things that were squeezed into the keychain's category rail, or into
nothing at all, now have screens. Pinned host keys get one, with fingerprints
never truncated and a filter that matches them, because comparing what you have
against what the operator published is the whole workflow; the approved date is
read out of the item's UUIDv7 rather than added as a column, and says so, since
it means first approval and not last use. Keys can be generated in the client,
which needed the openssh-key-v1 container written by hand — there is no BCL or
NSec helper, and the PKCS#8 route is unverified in the SSH library this uses.
The armour carries no passphrase: encrypting it needs bcrypt_pbkdf, which is
Blowfish with a swizzle, in a project whose crypto is otherwise entirely
libsodium, for a protection the key's own remarks argue is redundant inside a
vault. Generation fills the existing editor and stops, so SAVE stays the one
thing that writes. ~/.ssh/config can be imported behind a preview that is
ticked per row and writes nothing until the button; IdentityFile records the
path and imports the key material only on an explicit opt-in, because reading
somebody's private key into a vault is precisely the act this product exists to
make deliberate. Match blocks and ProxyJump are reported rather than obeyed —
one cannot be evaluated statically and the other has nothing behind it to route
with, and a preview that implied otherwise would be worse than one that admits
it.

Files can be dragged in all four directions that are honestly available. Remote
to Explorer does not ship and is not pretended to: the shell wants the bytes
during the drop, which needs a virtual file and a native COM data object,
outside what Avalonia offers. Note for the next person that Avalonia 12
replaced the drag model outright — DataObject and DataFormats are no-op stubs
and IDataObject is not in the reference assembly, so every tutorial written for
11 does not compile here.

Hosts can be grouped, flat and never nested. A parent id merged as a scalar
lets two offline clients each re-parent A under B and B under A, producing a
cycle inside an encrypted payload that no server can police and every reader
would have to detect for ever. Membership lives in that payload rather than in
the one plaintext concession ADR 0001 allows, whose test is that the relay
cannot function without it — nothing on the server reads a group, so what
plaintext would hand over is a clustering of the estate for nothing. The
plaintext column reserved for it is dropped, provably always null, and the
server now refuses a client that sends one; it was never populated, was copied
on apply, and was not cleared on delete, so a group id would have outlived the
host it described.

Snippets insert through xterm rather than through the pump, because xterm is
the only thing that knows whether the remote has bracketed paste on, and that
is what makes a shell treat embedded newlines as text instead of as execute.
The host process moves opaque bytes and never parses output, so it would have
to guess, and guessing wrong runs every line. Running is off by default and the
copy says the text goes into whatever is there — the terminal has no notion of
being at a prompt, and may be in vi or at a password prompt with echo off, so
the Enter the user presses themselves is the entire safety property.

Connections and keychain changes are recorded as synced encrypted items, which
is what makes them auditable by a team later and costs the server knowledge of
connection rate and timing from row counts alone. ADR 0001 already concedes it
cannot hide that class of metadata; the trade is now written into it rather
than left implicit. A connection entry is written once, at close, which is what
makes a synced log tractable: nothing to merge, one outbox row, no chance of
colliding with itself. Live sessions come from memory, not from the log. The
write is void by contract and posts to a bounded channel, because putting an
encrypt-and-write on the teardown path of every session is how closing the
application comes to take four seconds. A ticket opened before a lock still
closes afterwards, since a shell outlives the vault. The activity log hooks the
one generic repository every kind writes through, so it cannot miss a caller —
which is also why the log kinds themselves declare they are not audited, or the
first entry would write an entry about writing an entry. It records the names
of the fields that changed and never their values; a log with an old password
in it would be a plaintext credential store with no vault around it. Retention
is 90 days or 5,000 entries, whichever bites first, pruned on the sync loop
rather than on a second timer.

That log traffic then broke the status line, which is worth recording because
the fix is a shape and not a patch: background sync counted its own log rows as
pushed items, so the quiet rule stopped being quiet and every action's message
was overwritten a second later by a sync report. The report now separates log
rows from user items and the rule reads the latter.

S3 buckets appear as a remote in the file browser, behind the same interface an
SFTP session implements, so the queue and both panes did not have to learn what
they are talking to. Uploads go through a pipe, because the queue wants to
write and the SDK wants to read; memory is then bounded by the part size
instead of buffering a file to disk twice.

Finally, the Windows device key store moved out of the session project, which
was the one thing keeping it from being portable — everything else in it is
platform-neutral, and a Windows CNG dependency in the middle of the vault code
meant a second head could not reference it without dragging Windows along. The
seam that made the move free was already there. docs/android-port.md is the
audit behind that: what ports, what does not, in order of cost, the four
decisions taken, and an inventory of every screen and state the interface has
to carry, written so a design can be made from it directly.

dotnet build, dotnet test and dotnet format --verify-no-changes are all clean:
1240 tests at zero warnings, including the end-to-end suite against real
containers. The manual checks that headless Avalonia cannot make — the drag
from Explorer, a generated key against a real host, twelve tabs at the minimum
window width — are listed in docs/manual-checks.md and are still outstanding.
2026-07-31 20:30:05 +02:00

148 lines
6.3 KiB
C#

using System.Diagnostics.CodeAnalysis;
using System.Globalization;
namespace DodoSSH.Client.Domain;
/// <summary>How a connection ended.</summary>
public enum ConnectionOutcome
{
/// <summary>The session ran and then ended — by the user, by the remote, or by the process closing.</summary>
/// <remarks>
/// One value for all three, deliberately. From an auditor's side "this person had a shell on that machine
/// for eleven minutes" is the fact; which of the two ends hung up first is not something this client can
/// establish reliably — a tab close and a remote hangup both arrive as the pump finishing — and a field
/// that guessed would be worse than one that does not claim to know.
/// </remarks>
Closed = 0,
/// <summary>The connection was attempted and did not open.</summary>
Failed = 1,
/// <summary>The host key was not the pinned one, so the client refused before authenticating.</summary>
/// <remarks>
/// Its own outcome rather than a kind of <see cref="Failed"/>, because it is the only one that means
/// something about the <em>host</em> rather than about the network or the credentials. A run of these on
/// one machine is the single most interesting thing a connection log can show.
/// </remarks>
Refused = 2,
}
/// <summary>What kind of session a log entry is about.</summary>
public enum ConnectionKind
{
/// <summary>An interactive terminal.</summary>
Terminal = 0,
/// <summary>An SFTP session for moving files.</summary>
/// <remarks>
/// Recorded separately and not hidden. Opening the file browser is a second login as far as the remote's
/// own <c>auth.log</c> is concerned, so a log of ours that quietly omitted it would disagree with the
/// host's — and the person comparing the two would be right to trust the host.
/// </remarks>
Sftp = 1,
}
/// <summary>
/// One connection that was made, decrypted.
/// </summary>
/// <remarks>
/// <para>
/// <b>What is here, and what deliberately is not.</b> The host's label, its item id, the address as dialled,
/// when it started, how long it lasted, how it ended, and which user on which device did it. An audit log
/// with no actor is not an audit log — the whole reason these sync is that an administrator will read them
/// once teams land — so the actor is recorded and the SSH username is not. The two are different questions:
/// "who in this organisation opened a shell" is what an audit answers, and "which account they logged in as"
/// is a detail of the host that the host's own logs already have.
/// </para>
/// <para>
/// <b>Written once, at close.</b> Every field is known by then, so an entry never needs a second write —
/// which is what keeps a synced log from needing a merge, an outbox row per update, or any way to collide
/// with itself. A connection that is still running is not in here at all; it is shown from the workspace's
/// live state, which is the only place that knows.
/// </para>
/// </remarks>
public sealed record ConnectionLogSecret : IVaultSecret
{
/// <summary>What the host was called at the time, or a plain address when nothing named it.</summary>
/// <remarks>
/// A copy rather than a lookup through <see cref="HostId"/>, and that is the point of it: the bookmark
/// can be renamed or deleted, and a history that changed retroactively when somebody tidied their
/// keychain would be a history nobody could rely on.
/// </remarks>
public required string HostLabel { get; init; }
/// <summary>The address as dialled, <c>user@host:port</c> style, or whatever was typed.</summary>
public required string Address { get; init; }
/// <summary>The host item this was, or null when the connection did not come from one.</summary>
public Guid? HostId { get; init; }
/// <summary>Whether this was a terminal or a file-transfer session.</summary>
public ConnectionKind Kind { get; init; }
/// <summary>When it started.</summary>
public required DateTimeOffset StartedAt { get; init; }
/// <summary>How long it lasted.</summary>
/// <remarks>
/// A duration rather than an end time, because it is the thing anybody reads — and because the two clocks
/// involved are the same one, so storing both would be storing a value and its own arithmetic.
/// </remarks>
public TimeSpan Duration { get; init; }
/// <summary>How it ended.</summary>
public ConnectionOutcome Outcome { get; init; }
/// <summary>Which machine it was made from, as that machine calls itself.</summary>
public required string DeviceName { get; init; }
/// <summary>Which account in this organisation made it.</summary>
public Guid ActorUserId { get; init; }
/// <summary>What this entry is called, derived from what it records.</summary>
/// <inheritdoc cref="KnownHostSecret.Label" path="/remarks" />
public string Label => string.Create(CultureInfo.InvariantCulture, $"{HostLabel} ({Address})");
/// <summary>Whether this is storable, and why not if it is not.</summary>
/// <remarks>
/// A negative duration is refused rather than clamped. It can only come from a payload written elsewhere
/// — nothing here can produce one — and a log that displayed "-3 hours" would leave a reader unable to
/// tell a corrupt entry from a clock they should worry about.
/// </remarks>
public bool TryValidate([NotNullWhen(false)] out string? reason)
{
if (string.IsNullOrWhiteSpace(HostLabel))
{
reason = "A connection log entry needs the host it was about.";
return false;
}
if (string.IsNullOrWhiteSpace(Address))
{
reason = "A connection log entry needs the address that was dialled.";
return false;
}
if (string.IsNullOrWhiteSpace(DeviceName))
{
reason = "A connection log entry needs the machine it was made from.";
return false;
}
if (Duration < TimeSpan.Zero)
{
reason = "A connection cannot have lasted a negative amount of time.";
return false;
}
if (HostId == Guid.Empty)
{
reason = "A host reference cannot be an empty id; use no host instead.";
return false;
}
reason = null;
return true;
}
}