Public Access
jaap-jan
e24012b039
Closes the largest remaining M1 gap in the data layer: a username and password can live in the vault, sync between machines, and be named by a host as how it authenticates. What is not here is the interface for creating one — see the end of this message. The third item type, and the first one that cost almost nothing to add. Server: a VaultCredential row, an EF configuration, a migration, and a CredentialKind. Client: a secret, a codec, a merge, a cipher, a kind, a repository facade and a session property. No new reconciliation logic, no change to the sync engine, no client cache migration. That was the whole point of the item-kind seam, and this is the evidence it holds. The narrowest type of the three on plaintext, and not for symmetry. A host has a deliberate concession — the relay needs an address it can resolve. A key has a fingerprint, public by nature, which this client still declines to send. A password has no part that is safe to expose: not its length, not a hash, not a hint. So CredentialKind refuses every plaintext field there is, hydrates none, and the table has no column to put one in. HostSecret.CredentialId is the password counterpart of SshKeyId, and the two are mutually exclusive. SSH itself would happily try a key and fall back to a password, but a host naming both leaves "how does this authenticate?" without a single answer — the interface, the connect path and the user would each be free to guess differently. TryValidate refuses it. One consequence was not anticipated: "a full host" stops being a coherent idea, which is what broke AFullHost_RoundTrips and is now written into that test. The schema version became a ladder rather than a maximum: credential-bound is 3, key-bound is 2, neither is still 1. Adding credentials therefore does not drag every key-bound host in every vault onto a version that clients understanding keys perfectly well would refuse to edit. A test pins exactly that, because it is the property the whole content-dependent-version rule exists to provide, and the obvious implementation would quietly lose it. Two tests had become false and said so: - Push_AnUnsupportedEntityType_IsInvalidNotAFailedBatch used Credential as its example of a type this server does not implement. It now asks the server's own registry what is still missing, so it cannot go stale again, and skips with a reason if that set ever empties. - ThePullFilterNamesEveryTypeThisBuildSynchronises pinned the exact list, which is what it is for. Also fixes ten nullable warnings — eight in SyncEndpointTests, two in a test file added earlier today. Neither set was introduced here; both were invisible until an unrelated change forced their project to recompile, which means the zero-warning claims made earlier in this work only ever covered what happened to be rebuilt. 777 tests green. Zero warnings, dotnet format clean. Not done, and deliberately: the credential interface. The vault column is 340 pixels wide and already holds two lists and two editors, kept from clipping its own buttons at the window's minimum height only by the one-editor-at-a-time rule added earlier today. A third list and a third editor would recreate that defect rather than avoid it, so the column needs a shape decision first. Credentials sync; they cannot yet be created in the interface.
46 lines
1.9 KiB
C#
46 lines
1.9 KiB
C#
using DodoSSH.Contracts;
|
|
|
|
namespace DodoSSH.Client.Sync.Tests;
|
|
|
|
/// <summary>
|
|
/// The registry of synchronised item types, and the one property that has to hold about it.
|
|
/// </summary>
|
|
/// <remarks>
|
|
/// Adding an item type touches a cipher, a codec, a merge, a repository and a view. The failure this pins is
|
|
/// the one that none of those would reveal: a type that can be created, encrypted, merged and listed
|
|
/// perfectly, and is never asked for in a pull — so it works on the machine that made it and exists nowhere
|
|
/// else. Deriving the filter from the registry is what prevents it; these tests are what notice if the
|
|
/// derivation stops holding.
|
|
/// </remarks>
|
|
public sealed class ItemKindsTests
|
|
{
|
|
[Fact]
|
|
public void ThePullFilterNamesEveryTypeThisBuildSynchronises()
|
|
{
|
|
ItemKinds.SyncedTypes.ShouldBe(
|
|
[SyncEntityType.Host, SyncEntityType.SshKey, SyncEntityType.Credential]);
|
|
}
|
|
|
|
[Fact]
|
|
public void ThePullFilterIsNotEmpty()
|
|
{
|
|
// Stated separately from the list above because the consequence of an empty one is quiet rather
|
|
// than loud: the contract says an empty filter means every type, so the client would ask the server
|
|
// for everything it holds and then discard most of the answer in ApplyAsync. The way it could
|
|
// actually become empty is a static initialisation order slip — SyncedTypes projects Registry, and a
|
|
// reordering of the two declarations would leave it reading an unassigned array.
|
|
ItemKinds.SyncedTypes.ShouldNotBeEmpty();
|
|
}
|
|
|
|
[Fact]
|
|
public async Task EveryTypeInThePullFilter_HasAReconciler()
|
|
{
|
|
using var harness = await SyncHarness.CreateAsync();
|
|
|
|
var reconcilers = ItemKinds.Reconcilers(
|
|
harness.First.Outbox, harness.First.Conflicts, harness.First.Keyring);
|
|
|
|
reconcilers.Keys.Order().ShouldBe(ItemKinds.SyncedTypes.Order());
|
|
}
|
|
}
|