Public Access
Nothing in this repository loaded a .axaml, so the one class of defect this window has actually shipped — a control arranged past the edge of its container, where it cannot be clicked — was the one class nothing could catch. The setup screens rendered sliced once, with their buttons unreachable. The vault column is the next candidate: 340 pixels wide, two lists and two editors, and the only thing keeping it from clipping its own Save button at the window's 520-pixel minimum is a state rule that one editor may be open at a time. That rule was added on the strength of an argument. This adds an Avalonia.Headless project that lays real XAML out at a real size and reports what a user could not reach, and the argument is now a number: with both editors open the column overflows, so the rule is load-bearing rather than defensive. BothEditorsAtOnce_DoNotFit_WhichIsWhyTheRuleExists is the test, and it says what to do if it ever starts passing — the column has room, so delete the rule, not the test. Two findings arrived by measuring rather than by reasoning, and the first one changed the design. MainWindow cannot be shown headlessly at all. Showing it attaches the terminal's NativeWebView, whose Win32 adapter initialises WebView2 on attach, and WebView2 refuses a non-STA thread — which is exactly why Program.Main carries [STAThread] and is written down in that comment. A HeadlessUnitTestSession owns its dispatcher thread and offers no apartment choice, so the whole window is out of reach at any size. That is pinned as a test asserting RPC_E_CHANGED_MODE by HResult rather than by message, so a future Avalonia that makes the adapter lazy will fail it and the harness can be widened. So the column had to become its own control to be measurable, which is the extraction the type-selector rework wanted anyway. Keyboard release moved with it: MainWindow used to call Focus() on HostList by name, and now asks VaultColumn.KeyboardTarget. The window decides that the keyboard should leave the terminal and the column decides where it lands — which is the seam the rework needs, because once the column shows one list at a time, "which list owns the keyboard" is a question only the column can answer. The second finding is the way this kind of test lies quietly. The hint class lived in MainWindow.Styles and carries TextWrapping. A Window's styles reach its whole tree, so nothing about the application depended on where it lived — but a control laid out on its own loses them, and every hint paragraph would have measured as a single line. The harness would have passed while measuring heights that were all too small. The three shared classes now live in App.axaml, which changes no rendering and makes the measurement honest. The detector is calibrated in both directions, because a clipping detector that never fires reads as a guarantee: a deliberately clipped Save button is caught by name, and a list longer than its viewport is exempt. Scrolling is how a list is supposed to handle more rows than fit, and without that exemption the host list would fail the moment it had content. It also mis-fired once and the rule is narrower for it — an empty ListBox is zero pixels tall and correct, so "arranged with no size" now applies only to controls the theme gives a height to. Skia rather than the headless drawing stub, deliberately. The stub's font manager invents glyph metrics, and text height is an input to every stacked panel in this column, so measuring against it would produce numbers that are self-consistent and unrelated to the application. A separate test project rather than more tests in DodoSSH.Client.App.Tests. Avalonia's application, dispatcher and platform are process-global singletons initialised once, and that project's identity is the shell's state machine without Avalonia — the whole reason sign-in is a delegate. The fakes needed to reach a real unlocked vault are shared from DodoSSH.Client.Session.Tests by source link: a project reference would make one test project a library of another, and a copy would be a third implementation of the same decision table drifting from the other two. 855 tests green, 10 of them new. Zero warnings, dotnet format clean. Not done, and this is groundwork rather than the item itself: the type selector. The column still holds both lists at once, so a third item type would still recreate the defect the one-editor rule works around. What is different is that the rework can now be checked instead of eyeballed — including the claim it is being made for, that one editor at a time stops being a runtime rule and becomes a fact about what is in the visual tree. What this harness will never catch is the terminal's native child window compositing over Avalonia content. That is a Win32 property of a real window, no headless surface reproduces it, and it is the reason the WebView is collapsed rather than covered.
193 lines
6.6 KiB
C#
193 lines
6.6 KiB
C#
using System.Runtime.InteropServices;
|
|
using Avalonia.Controls;
|
|
using DodoSSH.Client.App.Views;
|
|
|
|
namespace DodoSSH.Client.App.Layout.Tests;
|
|
|
|
/// <summary>
|
|
/// The harness measuring itself.
|
|
/// </summary>
|
|
/// <remarks>
|
|
/// A clipping detector that never fires is worse than no detector, because it reads as a guarantee. So the
|
|
/// deliberately-broken window below is the most important test in this file: it is the one that proves the
|
|
/// green ones mean something. This is the same practice §5 of the handoff describes — a test proves nothing
|
|
/// until it has been seen to fail — applied to the instrument rather than to the code.
|
|
/// </remarks>
|
|
public sealed class LayoutHarnessTests
|
|
{
|
|
private static CancellationToken Token => TestContext.Current.CancellationToken;
|
|
|
|
[Fact]
|
|
public async Task AWindowWithRoomToSpare_ReportsNothing()
|
|
{
|
|
await LayoutHarness.OnTheUiThreadAsync(
|
|
() =>
|
|
{
|
|
var window = LayoutHarness.HostAtMinimumSize(
|
|
new Button { Content = "Save" },
|
|
LayoutHarness.MinimumWidth,
|
|
LayoutHarness.MinimumHeight);
|
|
|
|
try
|
|
{
|
|
LayoutHarness.Unreachable(window).ShouldBeEmpty();
|
|
}
|
|
finally
|
|
{
|
|
window.Close();
|
|
}
|
|
},
|
|
Token);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task AButtonPushedPastTheBottomEdge_IsReportedByName()
|
|
{
|
|
// The instrument's own calibration. A stack taller than its window is exactly the shape of the
|
|
// defect the vault column is one editor away from, and if this passes silently the harness is
|
|
// decoration.
|
|
await LayoutHarness.OnTheUiThreadAsync(
|
|
() =>
|
|
{
|
|
var stack = new StackPanel();
|
|
|
|
for (var i = 0; i < 8; i++)
|
|
{
|
|
stack.Children.Add(new Button { Content = i == 7 ? "Save" : $"filler {i}" });
|
|
}
|
|
|
|
var window = LayoutHarness.HostAtMinimumSize(stack, 300, 120);
|
|
|
|
try
|
|
{
|
|
var faults = LayoutHarness.Unreachable(window);
|
|
|
|
faults.ShouldNotBeEmpty();
|
|
faults.ShouldContain(fault => fault.Contains("'Save'", StringComparison.Ordinal));
|
|
}
|
|
finally
|
|
{
|
|
window.Close();
|
|
}
|
|
},
|
|
Token);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task AListLongerThanItsViewport_IsNotAFault()
|
|
{
|
|
// The exemption that keeps this harness usable. Scrolling is how a list is supposed to handle more
|
|
// rows than fit; without this the host list would fail the moment it had content.
|
|
await LayoutHarness.OnTheUiThreadAsync(
|
|
() =>
|
|
{
|
|
var stack = new StackPanel();
|
|
|
|
for (var i = 0; i < 40; i++)
|
|
{
|
|
stack.Children.Add(new Button { Content = $"row {i}" });
|
|
}
|
|
|
|
var window = LayoutHarness.HostAtMinimumSize(
|
|
new ScrollViewer { Content = stack },
|
|
300,
|
|
120);
|
|
|
|
try
|
|
{
|
|
LayoutHarness.Unreachable(window).ShouldBeEmpty();
|
|
}
|
|
finally
|
|
{
|
|
window.Close();
|
|
}
|
|
},
|
|
Token);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task TheWholeWindowsXamlParses()
|
|
{
|
|
// Constructing it runs InitializeComponent, so this is what catches malformed XAML, a style selector
|
|
// that no longer resolves or a converter reference that has gone stale. Cheap, and it covers the
|
|
// whole file including the setup cards no other test here touches.
|
|
//
|
|
// Constructed and never shown, deliberately — see WhyTheWindowItselfIsNeverShown.
|
|
await LayoutHarness.OnTheUiThreadAsync(
|
|
() =>
|
|
{
|
|
var window = new MainWindow();
|
|
|
|
try
|
|
{
|
|
window.Content.ShouldNotBeNull();
|
|
}
|
|
finally
|
|
{
|
|
window.Close();
|
|
}
|
|
},
|
|
Token);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task WhyTheWindowItselfIsNeverShown()
|
|
{
|
|
// Measured, not assumed, and pinned here so nobody spends an afternoon rediscovering it.
|
|
//
|
|
// Showing MainWindow attaches the terminal's NativeWebView, whose Win32 adapter initialises WebView2
|
|
// on attach — and WebView2 refuses an MTA thread, which is exactly why Program.Main is [STAThread].
|
|
// A HeadlessUnitTestSession owns its dispatcher thread and does not offer an apartment choice, so
|
|
// the whole window cannot be laid out here at any size.
|
|
//
|
|
// That is the reason this harness measures VaultColumn rather than MainWindow: the column is the
|
|
// part with a height budget to blow, and it has no native child window in it. If a future Avalonia
|
|
// makes the adapter lazy, this test starts failing and the harness can be widened.
|
|
await LayoutHarness.OnTheUiThreadAsync(
|
|
() =>
|
|
{
|
|
var window = new MainWindow();
|
|
|
|
try
|
|
{
|
|
var showing = Should.Throw<COMException>(() => LayoutHarness.Settle(
|
|
window,
|
|
LayoutHarness.MinimumWidth,
|
|
LayoutHarness.MinimumHeight));
|
|
|
|
// RPC_E_CHANGED_MODE. Asserted on the code rather than the message so a localised
|
|
// Windows does not break the build.
|
|
showing.HResult.ShouldBe(unchecked((int)0x80010106));
|
|
}
|
|
finally
|
|
{
|
|
window.Close();
|
|
}
|
|
},
|
|
Token);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task TheHarnessMeasuresTheSizeTheWindowDeclares()
|
|
{
|
|
// Pins the two constants against the XAML. A harness measuring 820x520 while the window lets itself
|
|
// be dragged to something smaller would be certifying a size no user is held to.
|
|
await LayoutHarness.OnTheUiThreadAsync(
|
|
() =>
|
|
{
|
|
var window = new MainWindow();
|
|
|
|
try
|
|
{
|
|
window.MinWidth.ShouldBe(LayoutHarness.MinimumWidth);
|
|
window.MinHeight.ShouldBe(LayoutHarness.MinimumHeight);
|
|
}
|
|
finally
|
|
{
|
|
window.Close();
|
|
}
|
|
},
|
|
Token);
|
|
}
|
|
}
|