Public Access
A terminal whose machine rebooted stayed green for ever. Not "went stale and
recovered late" — for ever: the tab claimed CONNECTED, the elapsed timer went
on counting, and the only thing that ever corrected it was closing the
application. That is the defect this fixes, and it turned out to be two
separate failures wearing one symptom.
◆ THE HANG IS IN SSH.NET, AND KEEP-ALIVE ALONE WOULD NOT HAVE FIXED IT.
ShellStream ends a blocked read from exactly two places: its channel being
closed, and the session raising Disconnected. A shell that exits gives the
first. But Session raises Disconnected from one method only — OnDisconnectReceived,
for a server that politely says goodbye — and a socket that simply fails goes
down a different path entirely: RaiseError fires the error event, sets the
disconnecting flag and disposes the socket, without ever raising Disconnected.
So the stream was never disposed, its Monitor.Wait was never pulsed, and the
read blocked until the process ended. The transport was gone, the client knew
the transport was gone, and nothing woke the one thread that was waiting.
That is why the first attempt at a test for this sat at thirty seconds and
failed. Both halves are needed and neither is sufficient:
- Keep-alive makes the failure HAPPEN. An idle SSH session is a socket
nobody writes to, and TCP has no way to discover that the far end has gone
without writing to it — nothing was asked, so nothing could fail. Thirty
seconds, matching OpenSSH's own ServerAliveInterval examples. It is the
write that matters and not a reply: SSH_MSG_IGNORE need not be answered,
so this is traffic rather than a heartbeat with a deadline, and there is
no timeout invented here to be wrong about a slow link.
- Disposing the stream from the error handler makes it ARRIVE. Queued to the
thread pool and not done inline, which is not tidiness: this runs on
SSH.NET's message-listener thread, and closing a channel waits for the
server's close — processed by that same thread — so an inline dispose is
the listener thread waiting on itself.
SFTP gets the keep-alive too. Its operations are request/response and bounded
by ConnectionInfo.Timeout already, so it needs no equivalent wake-up.
◆ exit AND reboot ARE TOLD APART BY A LATCH, BECAUSE THE OBVIOUS WAY IS A RACE.
Wait for the read to end and then ask whether the transport is still up, and
against a real server the answer is wrong about half the time: this was the
only channel on the connection, so sshd hangs up a millisecond after closing
it. By the time anything could ask, the transport is gone either way — and a
poll would report every ordinary `exit` as a dropped connection.
So ISshShellSession.TransportFailure is set at the moment SSH.NET raises the
failure, which its own ordering puts strictly before the disconnect that wakes
the read. A read that has just returned zero consults a settled value: set if
the transport failed, still null if the remote merely closed the channel. The
pump turns that into a TerminalSessionOutcome — RemoteClosed, ConnectionLost,
ClosedLocally — carried on SessionEnded, which used to hand over a session id
and nothing else. A subscriber cannot work this out afterwards; by the time it
hears, there is no transport left to interrogate.
Deliberately no fourth value for "the remote rebooted". Nothing on the wire
distinguishes a reboot from a cable being pulled, and a name this client
cannot check would be a guess dressed as a fact.
◆ WHAT IS DRAWN, AND WHY IT IS NOT DRAWN OVER THE PANE.
The status bar says DISCONNECTED or SHELL EXITED where it used to say NOT
CONNECTED for both — a word that is honest about a tab still dialling and
useless about one whose shell has stopped. Red for the first and grey for the
second: one is a machine that stopped answering and the other is work
finished, and crying wolf on the ordinary end of every session is its own bug.
The tab strip's dot gains the same fourth state, on both heads.
Under the terminal, a strip carrying the reason and two buttons. It takes its
own Auto grid row rather than overlaying the renderer, and that is forced
rather than chosen: the WebView is a native child view composited above
everything Avalonia draws, so the alternative is collapsing the terminal — and
the scrollback is precisely what the user wants to read, because the last
thing the remote said is usually why it went. terminal.js already writes the
same sentence into the pane; this is the copy that does not scroll away.
RECONNECT reuses the tab in place, which is what the word means to somebody
who pressed it: the terminal they were working in comes back, where it was.
It dials through the vault's ordinary connect path, so every refusal — a key
that has left the keychain, an unknown host key, a group default that has
changed since — is decided in the one place that already decides them; what
this adds is which tab the attempt belongs to. The old session is closed as
part of it, because a dead shell still holds an authenticated connection this
process has stopped reading, and its pane still holds an xterm, a scrollback
and a WebGL context, of which a browser hands out about sixteen.
Two refusals it makes rather than pretending: a host reached by typing an
address has no keychain entry to redial, and one that wants a password typed
goes to the keychain with the sheet raised rather than being dialled with an
empty box. Both say so on the strip where the button was pressed, not only in
the vault's status on a screen that surface is not.
TRY AGAIN appears on a refused connection for the same reason, and it is worth
as much: the commonest refusal is a host that was not up yet.
◆ WHAT IS ACTUALLY VERIFIED.
Two tests against a real sshd in a container. `exit` is reported as the remote
closing the session — the one a polling implementation fails, and a fake shell
cannot show it because a fake has no server behind it deciding to hang up. And
a live shell losing its transport is reported as a lost connection, produced
by dialling through a plain TCP relay the test owns and then cutting it; the
container is shared by the collection, so killing sshd was never an option.
The first draft of that second test used LoopbackProxyTests' SOCKS forward and
timed out: disconnecting the carrier of a ForwardedPortDynamic does not close
the loopback socket it accepted. Recorded in the test, because it is a
property of SSH.NET's forwarder rather than of anything here, and it is not
what a dying machine looks like.
What no test reproduces is the waiting. A relay that closes sends a FIN, so
the socket reports itself at once; a machine switched off sends nothing, and
finding that out is the keep-alive's business and the OS's retransmit budget's
— neither of which a test can hurry along without a clock this code does not
own. A reboot is prompt in practice because the machine comes back and RSTs.
Beside those: three pump outcomes, three workspace announcements, and seven
shell-flow tests covering the drop, the clean exit, reuse of the tab, retry
after a refusal, and both ways a reconnect can honestly come to nothing.
Also fixed in passing: SshNetShellSession.IsOpen read ShellStream.CanRead,
which is documented as always true — the stream stays readable after disposal
so buffered output can be drained — so it had answered "yes" for every shell
that ever existed. It reads CanWrite now. And MainWindowViewModel's session-
ended handler moved from Dispatcher.UIThread.Post to the injected post
delegate, which is what makes any of the shell half testable at all; the
remark listing the three unreachable posts is one shorter.
714 lines
31 KiB
C#
714 lines
31 KiB
C#
using System.Globalization;
|
|
using System.Net.WebSockets;
|
|
using System.Text;
|
|
using DodoSSH.Client.Ssh;
|
|
|
|
namespace DodoSSH.Client.Terminal.Tests;
|
|
|
|
/// <summary>
|
|
/// What the workspace waits for outside the process, and how long a session lives once it has one.
|
|
/// </summary>
|
|
/// <remarks>
|
|
/// <para>
|
|
/// The renderer gate itself is not in question. <see cref="TerminalDataPlane.SendAsync"/> drops frames when
|
|
/// nothing is attached, so a session opened before the renderer arrives loses its <c>SessionOpened</c> frame
|
|
/// and streams output at a terminal that was never created — and that it opens when a renderer does attach
|
|
/// is covered by <see cref="TerminalDataPlaneTests.TheRenderer_Attaches"/>. What is worth a test here is the
|
|
/// half that used to be missing: waiting for a renderer that never arrives has to end.
|
|
/// </para>
|
|
/// <para>
|
|
/// The session count is here for a different reason. It is shown to a user on the unlock screen, as the
|
|
/// disclosure that locking the vault leaves shells running, and a wrong number there is not a cosmetic bug:
|
|
/// it either hides a live connection or invents one.
|
|
/// </para>
|
|
/// </remarks>
|
|
public sealed class TerminalWorkspaceTests
|
|
{
|
|
/// <summary>How long <see cref="WaitUntilAsync"/> polls before calling it a failure.</summary>
|
|
private static readonly TimeSpan PollTimeout = TimeSpan.FromSeconds(10);
|
|
|
|
[Fact]
|
|
public async Task WaitingForARendererThatNeverAttaches_GivesUp()
|
|
{
|
|
// The shipped failure this stands in for is a WebView2 that never initialises — no Evergreen
|
|
// runtime, an install blocked by policy, an AppContainer that cannot reach loopback. From this
|
|
// side they are identical and all look like the listener being up with nothing ever connecting
|
|
// to it. Before the wait was bounded this test would have hung instead of failing.
|
|
await using var workspace = CreateWorkspace(
|
|
new FakeConnectionFactory(), rendererTimeout: TimeSpan.FromMilliseconds(250));
|
|
|
|
workspace.Start();
|
|
|
|
await Should.ThrowAsync<TimeoutException>(async () =>
|
|
await workspace.WaitForRendererAsync(TestContext.Current.CancellationToken));
|
|
}
|
|
|
|
[Fact]
|
|
public async Task WaitingForARenderer_ObeysItsCancellationToken()
|
|
{
|
|
// The timeout is the backstop; the caller's token is what makes a Connect the user gave up on
|
|
// return at once rather than sitting out the rest of the wait. The timeout here is long enough
|
|
// that only cancellation can end this.
|
|
await using var workspace = CreateWorkspace(
|
|
new FakeConnectionFactory(), rendererTimeout: TimeSpan.FromMinutes(5));
|
|
|
|
workspace.Start();
|
|
|
|
using var cancellation = new CancellationTokenSource();
|
|
var wait = workspace.WaitForRendererAsync(cancellation.Token);
|
|
|
|
await cancellation.CancelAsync();
|
|
|
|
await Should.ThrowAsync<OperationCanceledException>(async () => await wait);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task AnOpenSessionIsReportedAsLive()
|
|
{
|
|
var connections = new FakeConnectionFactory();
|
|
|
|
await using var workspace = CreateWorkspace(connections);
|
|
|
|
workspace.LiveSessionCount.ShouldBe(0);
|
|
|
|
await workspace.OpenSessionAsync(
|
|
Request(), TerminalSize.Default, progress: null, TestContext.Current.CancellationToken);
|
|
|
|
workspace.LiveSessionCount.ShouldBe(1);
|
|
|
|
await workspace.OpenSessionAsync(
|
|
Request(), TerminalSize.Default, progress: null, TestContext.Current.CancellationToken);
|
|
|
|
workspace.LiveSessionCount.ShouldBe(2);
|
|
}
|
|
|
|
/// <remarks>
|
|
/// The case a naive <c>sessions.Count</c> gets wrong. Nothing removes the entry when the remote
|
|
/// closes the channel by itself — the session is still in the dictionary, holding a connection that
|
|
/// is finished — so counting entries would report a shell that exited as still running. A user
|
|
/// deciding whether it is safe to walk away is the person that lie is told to.
|
|
/// </remarks>
|
|
[Fact]
|
|
public async Task ASessionWhoseRemoteHasExitedIsNotReportedAsLive()
|
|
{
|
|
// A shell with no output to give: its first read returns 0, which is a remote closing the
|
|
// channel, so the pump finishes on its own with nobody asking it to.
|
|
var connections = new FakeConnectionFactory(bytesPerShell: 0);
|
|
|
|
await using var workspace = CreateWorkspace(connections);
|
|
|
|
await workspace.OpenSessionAsync(
|
|
Request(), TerminalSize.Default, progress: null, TestContext.Current.CancellationToken);
|
|
|
|
await WaitUntilAsync(() => workspace.LiveSessionCount == 0);
|
|
}
|
|
|
|
/// <remarks>
|
|
/// <para>
|
|
/// <see cref="SshConnectionPhase.OpeningShell"/> is the one phase no connection factory can report,
|
|
/// because by the time it happens the factory has handed back a connection and gone. If this layer did
|
|
/// not report it the card's last step would light only when the whole session opened, which is the one
|
|
/// moment the card is already being taken down — a step nobody would ever see lit.
|
|
/// </para>
|
|
/// <para>
|
|
/// Asserted as the whole sequence rather than as "contains OpeningShell", because the order is the part
|
|
/// that matters: a step list is only readable if what it is told arrives in the order it draws.
|
|
/// </para>
|
|
/// </remarks>
|
|
[Fact]
|
|
public async Task OpeningASession_ReportsTheShellPhaseTheFactoryCannot()
|
|
{
|
|
var connections = new FakeConnectionFactory();
|
|
var reported = new List<SshConnectionPhase>();
|
|
|
|
await using var workspace = CreateWorkspace(connections);
|
|
|
|
await workspace.OpenSessionAsync(
|
|
Request(),
|
|
TerminalSize.Default,
|
|
new DelegateProgress<SshConnectionPhase>(reported.Add),
|
|
TestContext.Current.CancellationToken);
|
|
|
|
reported.ShouldBe(
|
|
[
|
|
SshConnectionPhase.Reaching,
|
|
SshConnectionPhase.Authenticating,
|
|
SshConnectionPhase.OpeningShell,
|
|
],
|
|
"the factory's own phases, then the one this layer performs itself");
|
|
}
|
|
|
|
/// <remarks>
|
|
/// Nobody watching is the ordinary case — every caller but the connecting card passes null — so it is
|
|
/// worth one test that the null is a null and not a null reference.
|
|
/// </remarks>
|
|
[Fact]
|
|
public async Task OpeningASession_WorksWithNobodyWatchingItsPhases()
|
|
{
|
|
var connections = new FakeConnectionFactory();
|
|
|
|
await using var workspace = CreateWorkspace(connections);
|
|
|
|
var sessionId = await workspace.OpenSessionAsync(
|
|
Request(), TerminalSize.Default, progress: null, TestContext.Current.CancellationToken);
|
|
|
|
workspace.IsSessionLive(sessionId).ShouldBeTrue();
|
|
}
|
|
|
|
[Fact]
|
|
public async Task ClosingASessionEndsItAndDisposesItsConnection()
|
|
{
|
|
var connections = new FakeConnectionFactory();
|
|
|
|
await using var workspace = CreateWorkspace(connections);
|
|
|
|
var sessionId = await workspace.OpenSessionAsync(
|
|
Request(), TerminalSize.Default, progress: null, TestContext.Current.CancellationToken);
|
|
|
|
await workspace.CloseSessionAsync(sessionId);
|
|
|
|
workspace.LiveSessionCount.ShouldBe(0);
|
|
connections.Connections.ShouldHaveSingleItem().IsDisposed.ShouldBeTrue();
|
|
}
|
|
|
|
/// <remarks>
|
|
/// <para>
|
|
/// Per-session liveness, which the tab strip's status dot is. The aggregate count answers "may I walk
|
|
/// away"; this answers "is <em>this</em> tab still connected", and a tab that went on claiming a shell
|
|
/// it no longer has would be the same lie one row down.
|
|
/// </para>
|
|
/// <para>
|
|
/// The unknown-id case is asserted because it is what a stale tab asks. A session id this workspace
|
|
/// never issued, or has already closed, is not live — it must not throw and must not be optimistic.
|
|
/// </para>
|
|
/// </remarks>
|
|
[Fact]
|
|
public async Task LivenessIsAnsweredPerSession()
|
|
{
|
|
var connections = new FakeConnectionFactory();
|
|
|
|
await using var workspace = CreateWorkspace(connections);
|
|
|
|
var first = await workspace.OpenSessionAsync(
|
|
Request(), TerminalSize.Default, progress: null, TestContext.Current.CancellationToken);
|
|
var second = await workspace.OpenSessionAsync(
|
|
Request(), TerminalSize.Default, progress: null, TestContext.Current.CancellationToken);
|
|
|
|
workspace.IsSessionLive(first).ShouldBeTrue();
|
|
workspace.IsSessionLive(second).ShouldBeTrue();
|
|
workspace.IsSessionLive(9999).ShouldBeFalse("this workspace never issued that id");
|
|
|
|
await workspace.CloseSessionAsync(first);
|
|
|
|
workspace.IsSessionLive(first).ShouldBeFalse();
|
|
workspace.IsSessionLive(second).ShouldBeTrue("closing one tab must not disturb another");
|
|
}
|
|
|
|
/// <remarks>
|
|
/// The shell's connect path reads these back once, right after <see cref="TerminalWorkspace.OpenSessionAsync"/>
|
|
/// returns, to fill in the status bar's cipher and host-key facts — see <c>VaultViewModel.ConnectAndAnnounceAsync</c>.
|
|
/// Asserted the same way <see cref="LivenessIsAnsweredPerSession"/> asserts liveness: per session, and
|
|
/// null rather than thrown for an id this workspace never issued.
|
|
/// </remarks>
|
|
[Fact]
|
|
public async Task SessionFactsAreReadPerSession()
|
|
{
|
|
var connections = new FakeConnectionFactory();
|
|
|
|
await using var workspace = CreateWorkspace(connections);
|
|
|
|
var sessionId = await workspace.OpenSessionAsync(
|
|
Request(), TerminalSize.Default, progress: null, TestContext.Current.CancellationToken);
|
|
|
|
var facts = workspace.GetSessionFacts(sessionId).ShouldNotBeNull();
|
|
var connection = connections.Connections.ShouldHaveSingleItem();
|
|
|
|
facts.Cipher.ShouldBe(connection.Cipher);
|
|
facts.HostKeyAlgorithm.ShouldBe(connection.HostKey.Algorithm);
|
|
|
|
workspace.GetSessionFacts(9999).ShouldBeNull("this workspace never issued that id");
|
|
}
|
|
|
|
/// <remarks>
|
|
/// <para>
|
|
/// Inserting a snippet has to be able to say whether it arrived, and the transport cannot: it drops
|
|
/// frames for a session nothing is listening to, so a send at a dead tab succeeds exactly as loudly as a
|
|
/// send at a live one. That is why <c>PasteAsync</c> answers rather than returning void — and why the
|
|
/// answer is a <see cref="bool"/> and not an exception, since a tab whose remote hung up an hour ago is
|
|
/// still on screen and still clickable.
|
|
/// </para>
|
|
/// <para>
|
|
/// What the renderer does with the frame — bracketed paste, and the Enter deliberately outside it —
|
|
/// cannot be reached from here at all. It is JavaScript inside a WebView, and it is in
|
|
/// <c>docs/manual-checks.md</c> for that reason.
|
|
/// </para>
|
|
/// </remarks>
|
|
[Fact]
|
|
public async Task PastingIntoADeadSessionSaysSoRatherThanDroppingIt()
|
|
{
|
|
var connections = new FakeConnectionFactory();
|
|
|
|
await using var workspace = CreateWorkspace(connections);
|
|
|
|
var sessionId = await workspace.OpenSessionAsync(
|
|
Request(), TerminalSize.Default, progress: null, TestContext.Current.CancellationToken);
|
|
|
|
(await workspace.PasteAsync(
|
|
sessionId, "uptime", execute: false, TestContext.Current.CancellationToken))
|
|
.ShouldBeTrue("the session is live");
|
|
|
|
(await workspace.PasteAsync(
|
|
9999, "uptime", execute: false, TestContext.Current.CancellationToken))
|
|
.ShouldBeFalse("this workspace never issued that id");
|
|
|
|
await workspace.CloseSessionAsync(sessionId);
|
|
|
|
(await workspace.PasteAsync(
|
|
sessionId, "uptime", execute: false, TestContext.Current.CancellationToken))
|
|
.ShouldBeFalse("the tab it names is gone");
|
|
}
|
|
|
|
/// <remarks>
|
|
/// The event the tab strip and the phone's keep-alive listen to, so a dot can go out — and a foreground
|
|
/// notification can come down — the moment a shell exits rather than at the next thing that happens to
|
|
/// repaint. The count captured inside the handler is the sharper half of this test: the announcement
|
|
/// used to fire from inside the run's own finally block, where the run task is not yet complete, so
|
|
/// <c>LiveSessionCount</c> read from the handler still said 1 — and the phone's notification went on
|
|
/// claiming a shell that was gone, with nothing left to fire and correct it.
|
|
/// </remarks>
|
|
[Fact]
|
|
public async Task ASessionEndingOnItsOwnIsAnnounced_AfterTheCountStoppedIncludingIt()
|
|
{
|
|
// A shell with no output to give: its first read returns 0, which is a remote closing the channel,
|
|
// so the pump finishes with nobody asking it to.
|
|
var connections = new FakeConnectionFactory(bytesPerShell: 0);
|
|
|
|
await using var workspace = CreateWorkspace(connections);
|
|
|
|
var ended = new List<uint>();
|
|
var liveAtAnnouncement = -1;
|
|
workspace.SessionEnded += (_, e) =>
|
|
{
|
|
lock (ended)
|
|
{
|
|
liveAtAnnouncement = workspace.LiveSessionCount;
|
|
ended.Add(e.SessionId);
|
|
}
|
|
};
|
|
|
|
var sessionId = await workspace.OpenSessionAsync(
|
|
Request(), TerminalSize.Default, progress: null, TestContext.Current.CancellationToken);
|
|
|
|
await WaitUntilAsync(() =>
|
|
{
|
|
lock (ended)
|
|
{
|
|
return ended.Contains(sessionId);
|
|
}
|
|
});
|
|
|
|
lock (ended)
|
|
{
|
|
liveAtAnnouncement.ShouldBe(0, "the announcement must wait for the run to actually complete");
|
|
}
|
|
}
|
|
|
|
/// <remarks>
|
|
/// The reversal of a recorded decision, and the event's own remark carries why: a close used to be
|
|
/// announced to nobody, on the theory that the caller already knew — but the phone's keep-alive is not
|
|
/// the caller, and a close it never heard about left the foreground notification claiming a shell that
|
|
/// was gone. Announced once, after the drain, so the count a handler reads is already honest.
|
|
/// </remarks>
|
|
[Fact]
|
|
public async Task ClosingASessionIsAnnounced_OnceItHasDrained()
|
|
{
|
|
var connections = new FakeConnectionFactory();
|
|
|
|
await using var workspace = CreateWorkspace(connections);
|
|
|
|
var announcements = 0;
|
|
var liveAtAnnouncement = -1;
|
|
workspace.SessionEnded += (_, _) =>
|
|
{
|
|
liveAtAnnouncement = workspace.LiveSessionCount;
|
|
Interlocked.Increment(ref announcements);
|
|
};
|
|
|
|
var sessionId = await workspace.OpenSessionAsync(
|
|
Request(), TerminalSize.Default, progress: null, TestContext.Current.CancellationToken);
|
|
|
|
await workspace.CloseSessionAsync(sessionId);
|
|
|
|
Volatile.Read(ref announcements)
|
|
.ShouldBe(1, "a close is news to the keep-alive even though it is an echo to the closer");
|
|
liveAtAnnouncement.ShouldBe(0, "announced after the drain, so the count already excludes it");
|
|
}
|
|
|
|
/// <remarks>
|
|
/// ◆ The announcement carries how it ended, not just that it did. A subscriber cannot work that out for
|
|
/// itself afterwards — by the time it hears, there is no transport left to interrogate — and the
|
|
/// difference between a shell that exited and a connection that broke is the difference between a tab
|
|
/// that is finished and one worth offering to dial again.
|
|
/// </remarks>
|
|
[Fact]
|
|
public async Task ASessionWhoseConnectionBroke_IsAnnouncedAsALostConnection()
|
|
{
|
|
var connections = new FakeConnectionFactory(bytesPerShell: 0)
|
|
{
|
|
TransportFailure = "An established connection was aborted by the server.",
|
|
};
|
|
|
|
await using var workspace = CreateWorkspace(connections);
|
|
|
|
TerminalSessionOutcome? outcome = null;
|
|
workspace.SessionEnded += (_, e) => Volatile.Write(ref outcome, e.Outcome);
|
|
|
|
await workspace.OpenSessionAsync(
|
|
Request(), TerminalSize.Default, progress: null, TestContext.Current.CancellationToken);
|
|
|
|
await WaitUntilAsync(() => Volatile.Read(ref outcome) is not null);
|
|
|
|
var announced = Volatile.Read(ref outcome)!;
|
|
|
|
announced.End.ShouldBe(SshSessionEnd.ConnectionLost);
|
|
announced.Description.ShouldBe("An established connection was aborted by the server.");
|
|
}
|
|
|
|
/// <remarks>
|
|
/// The same shell ending with nothing wrong underneath it, which is what <c>exit</c> looks like from
|
|
/// here. Its own test rather than an assertion tacked onto the one above, because the pair is the point:
|
|
/// one fake differs from the other by a latched failure and nothing else, and the two must not report
|
|
/// the same thing.
|
|
/// </remarks>
|
|
[Fact]
|
|
public async Task ASessionWhoseShellExited_IsAnnouncedAsTheRemoteClosingIt()
|
|
{
|
|
var connections = new FakeConnectionFactory(bytesPerShell: 0);
|
|
|
|
await using var workspace = CreateWorkspace(connections);
|
|
|
|
TerminalSessionOutcome? outcome = null;
|
|
workspace.SessionEnded += (_, e) => Volatile.Write(ref outcome, e.Outcome);
|
|
|
|
await workspace.OpenSessionAsync(
|
|
Request(), TerminalSize.Default, progress: null, TestContext.Current.CancellationToken);
|
|
|
|
await WaitUntilAsync(() => Volatile.Read(ref outcome) is not null);
|
|
|
|
Volatile.Read(ref outcome)!.End.ShouldBe(SshSessionEnd.RemoteClosed);
|
|
}
|
|
|
|
/// <remarks>
|
|
/// A tab being closed, announced as this client's own doing however the pump unwound. It matters for the
|
|
/// shell reusing a tab: a reconnect closes the session it is replacing, and an announcement blaming the
|
|
/// remote for that would draw a dropped connection over an attempt that is already under way.
|
|
/// </remarks>
|
|
[Fact]
|
|
public async Task ClosingASession_IsAnnouncedAsThisClientsDoing()
|
|
{
|
|
var connections = new FakeConnectionFactory();
|
|
|
|
await using var workspace = CreateWorkspace(connections);
|
|
|
|
TerminalSessionOutcome? outcome = null;
|
|
workspace.SessionEnded += (_, e) => outcome = e.Outcome;
|
|
|
|
var sessionId = await workspace.OpenSessionAsync(
|
|
Request(), TerminalSize.Default, progress: null, TestContext.Current.CancellationToken);
|
|
|
|
await workspace.CloseSessionAsync(sessionId);
|
|
|
|
outcome.ShouldNotBeNull();
|
|
outcome.End.ShouldBe(SshSessionEnd.ClosedLocally);
|
|
}
|
|
|
|
/// <remarks>
|
|
/// Disposal is the other path that closes sessions, because it is process shutdown. Asserted so
|
|
/// that the SSH connections are known to be released rather than assumed to be — and that these closes,
|
|
/// unlike a deliberate one, are announced to nobody: shutdown is dismantling every subscriber along
|
|
/// with the sessions, and news nobody is left to hear is not news.
|
|
/// </remarks>
|
|
[Fact]
|
|
public async Task DisposingTheWorkspaceClosesEverySession()
|
|
{
|
|
var connections = new FakeConnectionFactory();
|
|
|
|
var workspace = CreateWorkspace(connections);
|
|
|
|
var announcements = 0;
|
|
workspace.SessionEnded += (_, _) => Interlocked.Increment(ref announcements);
|
|
|
|
await workspace.OpenSessionAsync(
|
|
Request(), TerminalSize.Default, progress: null, TestContext.Current.CancellationToken);
|
|
await workspace.OpenSessionAsync(
|
|
Request(), TerminalSize.Default, progress: null, TestContext.Current.CancellationToken);
|
|
|
|
await workspace.DisposeAsync();
|
|
|
|
workspace.LiveSessionCount.ShouldBe(0);
|
|
connections.Connections.Count.ShouldBe(2);
|
|
connections.Connections.ShouldAllBe(connection => connection.IsDisposed);
|
|
Volatile.Read(ref announcements).ShouldBe(0, "shutdown closes are not announced");
|
|
}
|
|
|
|
// ---- Reattach ----
|
|
|
|
/// <remarks>
|
|
/// <para>
|
|
/// The scenario the whole fix exists for: a page that lost its socket — killed WebView renderer, or
|
|
/// simply a reload — reattaches, and the session that was already running has to come back rather than
|
|
/// sit there forever with its output going nowhere.
|
|
/// </para>
|
|
/// <para>
|
|
/// The session's shell blocks on every read rather than producing output, which is what an idle prompt
|
|
/// looks like and — for this test — is what keeps its <c>Run</c> live without a background read loop
|
|
/// competing with this test over the credit window's exact value.
|
|
/// </para>
|
|
/// <para>
|
|
/// Neither assertion below polls, deliberately. The "before" one does not need to: reserving credit is
|
|
/// a synchronous call, so it is true the instant it returns. The "after" one does not need to either,
|
|
/// for a subtler reason — <see cref="TerminalWorkspace.ReplayAfterAttachAsync"/> calls
|
|
/// <c>Credits.Reset()</c> and only then awaits sending the replay frame for that same session, with no
|
|
/// suspension between the two, so by the time this test has received that frame the reset has
|
|
/// necessarily already happened. A poll here would only have hidden a real ordering bug behind a
|
|
/// generous timeout instead of catching it.
|
|
/// </para>
|
|
/// </remarks>
|
|
[Fact]
|
|
public async Task ANewRenderer_ReplaysTheLiveSessionAndResetsItsCredits()
|
|
{
|
|
var connections = new FakeConnectionFactory(blockShellReads: true);
|
|
|
|
await using var workspace = CreateWorkspace(connections);
|
|
workspace.Start();
|
|
|
|
using var first = await ConnectRendererAsync(workspace);
|
|
|
|
var sessionId = await workspace.OpenSessionAsync(
|
|
Request(), TerminalSize.Default, progress: null, TestContext.Current.CancellationToken);
|
|
|
|
// The session's own opening frame, sent as soon as the pump starts running. Not a replay, and not
|
|
// what this test is about — read and discarded so it cannot be confused for one below.
|
|
await ReceiveFrameAsync(first);
|
|
|
|
var credits = workspace.CreditsFor(sessionId).ShouldNotBeNull();
|
|
credits.TryReserve(4096);
|
|
credits.Outstanding.ShouldBeGreaterThanOrEqualTo(
|
|
4096, "the pump's own read loop may have reserved a buffer's worth on top of this");
|
|
|
|
using var second = await ConnectRendererAsync(workspace);
|
|
|
|
var replay = await ReceiveFrameAsync(second);
|
|
replay.Opcode.ShouldBe((byte)TerminalServerOpcode.SessionOpened);
|
|
replay.SessionId.ShouldBe(sessionId);
|
|
replay.Payload.ShouldBe(new byte[] { 1 }, "a replay is flagged so the page can tell it apart from a fresh open");
|
|
|
|
credits.Outstanding.ShouldBe(0, "the replay frame above cannot have been sent before the reset that precedes it");
|
|
}
|
|
|
|
/// <remarks>
|
|
/// The other half of a reattach: the workspace has replayed what it owns, and this is the seam the
|
|
/// shell uses to replay what it owns instead — the font size and the selected tab, neither of which a
|
|
/// terminal session knows anything about. <c>MainWindowViewModel</c>'s subscription is what actually
|
|
/// does that; this only asserts that the workspace hands it the chance to.
|
|
/// </remarks>
|
|
[Fact]
|
|
public async Task ANewRenderer_RaisesRendererReattached()
|
|
{
|
|
var connections = new FakeConnectionFactory();
|
|
|
|
await using var workspace = CreateWorkspace(connections);
|
|
workspace.Start();
|
|
|
|
using var first = await ConnectRendererAsync(workspace);
|
|
|
|
var reattachedCount = 0;
|
|
workspace.RendererReattached += (_, _) => Interlocked.Increment(ref reattachedCount);
|
|
|
|
using var second = await ConnectRendererAsync(workspace);
|
|
|
|
await WaitUntilAsync(() => Volatile.Read(ref reattachedCount) > 0);
|
|
}
|
|
|
|
// ---- Helpers ----
|
|
|
|
/// <remarks>
|
|
/// <para>
|
|
/// Input that did not come from the keyboard. The Android head's accessory key row is what needs this —
|
|
/// a software keyboard has no Ctrl, Esc, Tab or arrows — and what it sends has to arrive at the remote
|
|
/// byte for byte, because an escape sequence that loses a byte is not a degraded arrow key, it is a
|
|
/// stray character in somebody's shell.
|
|
/// </para>
|
|
/// <para>
|
|
/// Ordinary typing does not come this way and is not what is being tested: that goes from the renderer
|
|
/// down the socket, which the pump's own tests cover.
|
|
/// </para>
|
|
/// </remarks>
|
|
[Fact]
|
|
public async Task SendingInput_ReachesTheRemoteUnchanged()
|
|
{
|
|
var connections = new FakeConnectionFactory();
|
|
|
|
await using var workspace = CreateWorkspace(connections);
|
|
|
|
var sessionId = await workspace.OpenSessionAsync(
|
|
Request(), TerminalSize.Default, progress: null, TestContext.Current.CancellationToken);
|
|
|
|
// The up-arrow, as a PTY expects it. Three bytes, and all three matter.
|
|
byte[] upArrow = [0x1B, (byte)'[', (byte)'A'];
|
|
|
|
await workspace.SendInputAsync(sessionId, upArrow, TestContext.Current.CancellationToken);
|
|
|
|
await WaitUntilAsync(() =>
|
|
connections.Connections.SingleOrDefault()?.Shell?.Written.SequenceEqual(upArrow) == true);
|
|
}
|
|
|
|
/// <remarks>
|
|
/// A tab can close while a key is still in flight, which on a phone is one mis-tap rather than a rare
|
|
/// race — the close cross sits inside the tab and the accessory row is directly under it. Throwing
|
|
/// would turn that into a crash on a keystroke that no longer matters.
|
|
/// </remarks>
|
|
[Fact]
|
|
public async Task SendingInputToASessionThatIsGone_IsIgnored()
|
|
{
|
|
await using var workspace = CreateWorkspace(new FakeConnectionFactory());
|
|
|
|
var sessionId = await workspace.OpenSessionAsync(
|
|
Request(), TerminalSize.Default, progress: null, TestContext.Current.CancellationToken);
|
|
|
|
await workspace.CloseSessionAsync(sessionId);
|
|
|
|
await Should.NotThrowAsync(async () =>
|
|
await workspace.SendInputAsync(sessionId, "x"u8.ToArray(), TestContext.Current.CancellationToken));
|
|
}
|
|
|
|
/// <param name="connections">
|
|
/// How connections are made. The renderer-gate tests never reach it — they stop at the gate — but they
|
|
/// take a fake anyway, because reaching a real host from here would make this a network test.
|
|
/// </param>
|
|
/// <param name="rendererTimeout">The gate's bound, or null for the shipped default.</param>
|
|
private static TerminalWorkspace CreateWorkspace(
|
|
ISshConnectionFactory connections,
|
|
TimeSpan? rendererTimeout = null) =>
|
|
new(
|
|
StubAssets(),
|
|
connections,
|
|
TimeProvider.System,
|
|
rendererTimeout is { } timeout
|
|
? new TerminalWorkspaceOptions { RendererTimeout = timeout }
|
|
: null);
|
|
|
|
private static InMemoryTerminalAssetProvider StubAssets() =>
|
|
new(new Dictionary<string, TerminalAsset>(StringComparer.Ordinal)
|
|
{
|
|
// The placeholders, not a token and URL already filled in — the reattach tests below have to
|
|
// connect a real renderer, and doing that by reading them back out of the served page is what
|
|
// proves the workspace serves a page a real renderer could actually attach with, rather than
|
|
// one that merely looks servable.
|
|
[TerminalDataPlane.PagePath] = new(
|
|
"text/html; charset=utf-8",
|
|
Encoding.UTF8.GetBytes(
|
|
$"<html><body data-token=\"{TerminalDataPlane.TokenPlaceholder}\" "
|
|
+ $"data-socket=\"{TerminalDataPlane.SocketUrlPlaceholder}\"></body></html>")),
|
|
});
|
|
|
|
private static SshConnectionRequest Request() =>
|
|
new("host.invalid", 22, "dodo", new SshPasswordCredential("irrelevant"));
|
|
|
|
/// <remarks>
|
|
/// <para>
|
|
/// Attaches the way the real page does: by fetching the served page, reading the token and socket URL
|
|
/// back out of it, and presenting them on the upgrade — rather than reaching into the workspace for a
|
|
/// token it does not expose. A shortcut here would prove only that a socket can be opened, not that the
|
|
/// workspace serves a page a renderer could actually attach with.
|
|
/// </para>
|
|
/// <para>
|
|
/// And it waits for the attach rather than only for the handshake, for the reason
|
|
/// <c>TerminalDataPlaneTests.ConnectAsync</c> sets out at length: the 101 is written before the socket
|
|
/// is attachable, and a frame sent in between is dropped. A caller that opens a session on the socket
|
|
/// this returns and then reads its opening frame is exactly the shape that loses that race.
|
|
/// </para>
|
|
/// <para>
|
|
/// <c>WaitForRendererAsync</c> answers only for the first renderer ever to attach, so a second call
|
|
/// returns immediately without proving anything about the second socket. That is enough here and is
|
|
/// not luck: the only frames a second socket is given are the replay, and the replay is *caused* by the
|
|
/// attach — <see cref="TerminalWorkspace.RendererReattached"/> and the frames before it cannot be sent
|
|
/// early. The day a test sends something else down a reattached socket, this needs the data plane's own
|
|
/// <c>SocketAttached</c>, which the workspace does not forward today.
|
|
/// </para>
|
|
/// </remarks>
|
|
private static async Task<ClientWebSocket> ConnectRendererAsync(TerminalWorkspace workspace)
|
|
{
|
|
using var http = new HttpClient();
|
|
var page = await http.GetStringAsync(workspace.PageUrl, TestContext.Current.CancellationToken);
|
|
|
|
var token = ExtractAttribute(page, "data-token");
|
|
var socketUrl = ExtractAttribute(page, "data-socket");
|
|
|
|
var client = new ClientWebSocket();
|
|
client.Options.AddSubProtocol(TerminalDataPlane.SubProtocol);
|
|
client.Options.AddSubProtocol($"token.{token}");
|
|
client.Options.SetRequestHeader(
|
|
"Origin",
|
|
string.Create(CultureInfo.InvariantCulture, $"http://127.0.0.1:{workspace.PageUrl.Port}"));
|
|
|
|
try
|
|
{
|
|
await client.ConnectAsync(new Uri(socketUrl), TestContext.Current.CancellationToken);
|
|
|
|
await workspace.WaitForRendererAsync(TestContext.Current.CancellationToken);
|
|
}
|
|
catch
|
|
{
|
|
client.Dispose();
|
|
throw;
|
|
}
|
|
|
|
return client;
|
|
}
|
|
|
|
private static string ExtractAttribute(string html, string name)
|
|
{
|
|
var marker = $"{name}=\"";
|
|
var start = html.IndexOf(marker, StringComparison.Ordinal) + marker.Length;
|
|
var end = html.IndexOf('"', start);
|
|
|
|
return html[start..end];
|
|
}
|
|
|
|
private static async Task<(byte Opcode, uint SessionId, byte[] Payload)> ReceiveFrameAsync(
|
|
ClientWebSocket socket)
|
|
{
|
|
var buffer = new byte[64 * 1024];
|
|
|
|
var result = await socket.ReceiveAsync(buffer.AsMemory(), TestContext.Current.CancellationToken);
|
|
|
|
TerminalFrame.TryRead(buffer.AsSpan(0, result.Count), out var opcode, out var sessionId, out var payload)
|
|
.ShouldBeTrue();
|
|
|
|
return (opcode, sessionId, payload.ToArray());
|
|
}
|
|
|
|
/// <remarks>
|
|
/// Polled rather than awaited on a task, because the point is what an observer of the property
|
|
/// sees: the pump ends on a thread of its own, and the count has to catch up without anyone
|
|
/// telling it to.
|
|
/// </remarks>
|
|
private static async Task WaitUntilAsync(Func<bool> condition)
|
|
{
|
|
var deadline = TimeProvider.System.GetUtcNow() + PollTimeout;
|
|
|
|
while (TimeProvider.System.GetUtcNow() < deadline)
|
|
{
|
|
if (condition())
|
|
{
|
|
return;
|
|
}
|
|
|
|
await Task.Delay(20, TestContext.Current.CancellationToken);
|
|
}
|
|
|
|
throw new TimeoutException($"The condition was still false after {PollTimeout}.");
|
|
}
|
|
}
|