Connections: drop the manual box's view-model state now that both heads ask through the prompt

Conversation 0 Commits 1 Files Changed 7

+142 -313

1 Commits

Author	SHA1	Message	Date
jaap-jan	fa85ad1eff	Connections: drop the manual box's view-model state now that both heads ask through the prompt ci / build and test (pull_request) Successful in 2m32s Details ci / desktop nightly (pull_request) Skipped Details ci / api image (pull_request) Successful in 7s Details ci / deploy ssh.dodotech.cloud (pull_request) Skipped Details ci / android head (pull_request) Successful in 3m41s Details The phone's Connections screen no longer draws the user@host + password box, and the desktop never did, so nothing bound VaultViewModel.ManualTarget, ManualPassword, ManualStatus or ConnectManuallyCommand any more, nor MainWindowViewModel.ConnectToRecentCommand, whose address branch wrote into that box. They are gone, and so is VaultViewModel.AskAboutHost, whose one caller was ConnectToRecent. TryParseManualTarget, ManualEndpoint and ConnectToEndpointAsync stay: the prompt, the desktop's Ctrl+K palette and the phone's hosts search all use them. The reasoning the removed members carried moved onto ConnectToEndpointAsync and ChoosePromptRecentAsync. The tests whose subject is still live now go through the prompt instead of the box: a typed address dialled exactly as typed, port 22 by default, the refusal sentences, the host-key retry replaying the attempt that raised it, the host-key card staying over the surface it was typed on, the session facts for a typed password, and no forwards for a typed address. The recent-row cases now drive ChoosePromptRecentCommand. Two cases existing prompt tests already covered were deleted. Manual check 11.8 now describes recent rows landing on the prompt.	2026-10-16 14:21:10 +02:00

Author

SHA1

Message

Date

jaap-jan

fa85ad1eff

Connections: drop the manual box's view-model state now that both heads ask through the prompt

ci / build and test (pull_request) Successful in 2m32s

Details

ci / desktop nightly (pull_request) Skipped

Details

ci / api image (pull_request) Successful in 7s

Details

ci / deploy ssh.dodotech.cloud (pull_request) Skipped

Details

ci / android head (pull_request) Successful in 3m41s

Details

The phone's Connections screen no longer draws the user@host + password box, and the desktop never
did, so nothing bound VaultViewModel.ManualTarget, ManualPassword, ManualStatus or
ConnectManuallyCommand any more, nor MainWindowViewModel.ConnectToRecentCommand, whose address branch
wrote into that box. They are gone, and so is VaultViewModel.AskAboutHost, whose one caller was
ConnectToRecent. TryParseManualTarget, ManualEndpoint and ConnectToEndpointAsync stay: the prompt, the
desktop's Ctrl+K palette and the phone's hosts search all use them. The reasoning the removed members
carried moved onto ConnectToEndpointAsync and ChoosePromptRecentAsync.

The tests whose subject is still live now go through the prompt instead of the box: a typed address
dialled exactly as typed, port 22 by default, the refusal sentences, the host-key retry replaying the
attempt that raised it, the host-key card staying over the surface it was typed on, the session facts
for a typed password, and no forwards for a typed address. The recent-row cases now drive
ChoosePromptRecentCommand. Two cases existing prompt tests already covered were deleted. Manual check
11.8 now describes recent rows landing on the prompt.

2026-10-16 14:21:10 +02:00

Connections: drop the manual box's view-model state now that both heads ask through the prompt #24