Files
DodoSSH/tests/DodoSSH.Api.Tests/TeamEnumAlignmentTests.cs
jaap-jan b20f7cae04
ci / build and test (pull_request) Successful in 6m27s
ci / desktop nightly (pull_request) Skipped
ci / android head (pull_request) Successful in 15m47s
ci / api image (pull_request) Failing after 28s
Let a host marked for the relay actually be reached through it
The relay checkbox said it was not wired up, and the plan said the server
half was built and shipped. It was not: there was ADR 0004, the contract
records, RelayOptions and a CHECK constraint, and RelayOptions said in its
own remarks that there was no endpoint and no dialler. So both halves are
built here, as step 3 of docs/reaching-a-host-you-cannot-dial.md.

Server, in Features/Relay:

- POST /api/v1/relay/tickets makes every decision: the host, Connect on
  its vault, the relay switched on, and the stored name resolved once and
  judged by RelayAddressPolicy. Loopback, link-local, 0.0.0.0/8,
  multicast and the metadata endpoints are refused with no configuration
  escape, with IPv4-mapped and NAT64 spellings unwrapped first; then the
  operator's denials, allow-list and private-network switch. What passes
  goes into a Data Protection ticket, and nothing resolves the name again.
  Every target refusal is the same 403, so the endpoint cannot be used to
  map the operator's DNS; the real reason is logged.
- GET /api/v1/relay/connect takes the ticket as a second subprotocol,
  checks its expiry against TimeProvider and spends it with a unique
  insert into relay_ticket_use before accepting the upgrade. After the
  upgrade a refusal is a close code: 4502 for a host the server could not
  reach, 4429 for a limit, 4408 idle, 4409 lifetime, 1001 after a drain.
- relay_session is the audit row, written from short-lived scopes.

Client:

- RelayBridge is a loopback SOCKS5 listener that accepts once and pipes
  to the relay socket. It rides on the new SshLoopbackProxy.Lifetime, so
  the connection disposes it on every way a session ends and a failed
  connect disposes it before throwing.
- ServerRelay, exposed as IVaultServer.Relay from /api/v1/meta, asks for
  the ticket, opens the socket, starts the bridge and turns every refusal
  into a sentence.
- VaultViewModel and TransfersViewModel reach a relayed host through it,
  never fall back to dialling it directly, and replace SSH.NET's transport
  error with the relay's own reason when it gave one.

Neither side ever cancels a WebSocket operation. Cancelling one aborts
the socket, and an aborted socket sends no close frame, which is the only
way the client learns the server could not reach the host.
AnIdleSession_IsClosedWithTheIdleCode asserts that the code arrives.

Three departures from ADR 0004, recorded in it: awaited copy loops rather
than Pipelines (same backpressure, two 32 KiB buffers), no ?ticket=
fallback, and no device id in the ticket.

Tests: API 245, shell 582 (5 skipped), layout 170, SSH 110 including a
real login through the bridge, API client 30, contracts 25. Not run: the
Android build (its change is copy only) and the Alpine layout oracle.
2026-09-28 14:37:20 +02:00

93 lines
4.0 KiB
C#

using DodoSSH.Contracts;
using DodoSSH.Domain;
using DodoSSH.Domain.Authorization;
namespace DodoSSH.Api.Tests;
/// <summary>
/// The team enums on the wire and the ones in the domain have to agree, and nothing but this makes them.
/// </summary>
/// <remarks>
/// <para>
/// The same hazard <c>EntityTypeAlignmentTests</c> exists for, one feature along and with a worse failure.
/// <c>TeamService</c> maps <see cref="TeamMemberRole"/> to <see cref="TeamRole"/> member by member, so a
/// renumbering on one side does not fail to compile — it silently changes what a role means. Someone
/// added as a viewer would come back as an admin, or the reverse, on the next deployment.
/// </para>
/// <para>
/// Mapped by <em>name</em> in the service and asserted by <em>value</em> here, which is the pairing that
/// catches the mistake: the service would go on compiling after a renumbering, and this would not go on
/// passing.
/// </para>
/// </remarks>
public sealed class TeamEnumAlignmentTests
{
[Fact]
public void EveryWireRole_HasADomainRoleWithTheSameValue()
{
((int)TeamMemberRole.Unspecified).ShouldBe((int)TeamRole.Unspecified);
((int)TeamMemberRole.Viewer).ShouldBe((int)TeamRole.Viewer);
((int)TeamMemberRole.Member).ShouldBe((int)TeamRole.Member);
((int)TeamMemberRole.Admin).ShouldBe((int)TeamRole.Admin);
((int)TeamMemberRole.Owner).ShouldBe((int)TeamRole.Owner);
}
[Fact]
public void TheTwoRoleEnums_HaveTheSameNumberOfMembers() =>
Enum.GetValues<TeamMemberRole>().Length.ShouldBe(Enum.GetValues<TeamRole>().Length);
[Fact]
public void EveryWireMembershipStatus_HasADomainStatusWithTheSameValue()
{
((int)TeamMemberStatus.Unspecified).ShouldBe((int)MembershipStatus.Unspecified);
((int)TeamMemberStatus.Invited).ShouldBe((int)MembershipStatus.Invited);
((int)TeamMemberStatus.Active).ShouldBe((int)MembershipStatus.Active);
((int)TeamMemberStatus.Revoked).ShouldBe((int)MembershipStatus.Revoked);
}
[Fact]
public void EveryWireGrantState_HasADomainStateWithTheSameValue()
{
((int)VaultGrantState.Unspecified).ShouldBe((int)GrantState.Unspecified);
((int)VaultGrantState.Active).ShouldBe((int)GrantState.Active);
((int)VaultGrantState.AwaitingRewrap).ShouldBe((int)GrantState.AwaitingRewrap);
((int)VaultGrantState.Revoked).ShouldBe((int)GrantState.Revoked);
}
/// <remarks>
/// <para>
/// <c>VaultSummary.Permissions</c> is an opaque int on the wire, on purpose — the flags live in
/// <c>DodoSSH.Domain</c> and no client project references that assembly. So the client repeats the one
/// bit it needs as a literal in <c>StoredVault.CanWrite</c>, and this pins the value it copied.
/// </para>
/// <para>
/// Asserted here rather than against <c>StoredVault</c> itself, which would mean a server test project
/// taking a reference on a client assembly to check a constant. The consequence of drift is worth the
/// literal either way: a Save button offered to somebody who is only a viewer of a team vault, ending
/// in a 403 they can do nothing about — or no Save button for somebody who may write.
/// </para>
/// </remarks>
[Fact]
public void TheWriteFlag_IsTheBitTheClientCopied()
{
((int)PermissionFlags.Read).ShouldBe(1 << 0);
((int)PermissionFlags.Write).ShouldBe(1 << 1);
}
/// <remarks>
/// Not a team enum, and here because this is where the wire-against-domain pairs live. The relay
/// writes its audit row's reason by value, so a renumbering would file every idle timeout as
/// something else.
/// </remarks>
[Fact]
public void EveryWireRelayCloseReason_HasADomainReasonWithTheSameValue()
{
Enum.GetValues<RelaySessionCloseReason>().Length.ShouldBe(Enum.GetValues<RelayCloseReason>().Length);
foreach (var reason in Enum.GetValues<RelaySessionCloseReason>())
{
((int)Enum.Parse<RelayCloseReason>(reason.ToString())).ShouldBe((int)reason);
}
}
}