Public Access
jaap-jan
d07b336868
The WebView sat inside the Hosts grid, so navigating to Files or the keychain hid every open terminal and the strip that named them. A connection you had opened was invisible from four of the five screens. The window now has two surfaces rather than one: a nav rail that says which page you are on, and a terminal strip that is always there and switches the whole content area to a shell. Screen keeps meaning "which page" and never becomes a sixth kind of page, which is why this is two properties instead of one enum with a terminal member in it. Every screen lives inside one wrapper panel that collapses when a terminal is showing. That is not tidiness — the WebView hosts a Win32 child window that composites above everything Avalonia draws, so a screen left visible over its rectangle is a screen sliced in half, and this window has shipped that defect once already. One decision point, IsTerminalShowing, and a nested panel rather than five compound bindings nobody would remember to extend. The focus choreography is the part no test in this repo can see. Every reveal path now focuses in the same turn the WebView appeared, so all three of them post at DispatcherPriority.Loaded and let the native control re-push its bounds first. Going the other way had a real bug: the screen-changed branch called a bare Focus() where it had to release the keyboard from the native child, so switching from a terminal to Files silently ate the first keystrokes. Rare before this commit and the primary gesture after it. The tab strip grew a cross inside each tab, a plus that opens the quick-connect palette, and middle-click close. Nested buttons are correct here: Avalonia handles a left press on the cross and deliberately does not handle other buttons, which is exactly what lets middle-click bubble up from the cross as well as the tab. The test is PointerUpdateKind rather than IsMiddleButtonPressed, because the latter reports button state and is also true for a left press made while the middle button happens to be held. The handler is on the tab and not the strip, so the background closes nothing by construction. Plus opens the palette rather than a flyout, since a menu dropping into the WebView's rectangle may or may not composite above a child HWND and this repo does not make rendering claims it has not photographed. Everything a user reads now says keychain. The wire, the database and the cryptographic spec still say vault, deliberately: renaming those is a migration and a protocol change for a word. That split is written down rather than left to be rediscovered as an inconsistency. Four things that were squeezed into the keychain's category rail, or into nothing at all, now have screens. Pinned host keys get one, with fingerprints never truncated and a filter that matches them, because comparing what you have against what the operator published is the whole workflow; the approved date is read out of the item's UUIDv7 rather than added as a column, and says so, since it means first approval and not last use. Keys can be generated in the client, which needed the openssh-key-v1 container written by hand — there is no BCL or NSec helper, and the PKCS#8 route is unverified in the SSH library this uses. The armour carries no passphrase: encrypting it needs bcrypt_pbkdf, which is Blowfish with a swizzle, in a project whose crypto is otherwise entirely libsodium, for a protection the key's own remarks argue is redundant inside a vault. Generation fills the existing editor and stops, so SAVE stays the one thing that writes. ~/.ssh/config can be imported behind a preview that is ticked per row and writes nothing until the button; IdentityFile records the path and imports the key material only on an explicit opt-in, because reading somebody's private key into a vault is precisely the act this product exists to make deliberate. Match blocks and ProxyJump are reported rather than obeyed — one cannot be evaluated statically and the other has nothing behind it to route with, and a preview that implied otherwise would be worse than one that admits it. Files can be dragged in all four directions that are honestly available. Remote to Explorer does not ship and is not pretended to: the shell wants the bytes during the drop, which needs a virtual file and a native COM data object, outside what Avalonia offers. Note for the next person that Avalonia 12 replaced the drag model outright — DataObject and DataFormats are no-op stubs and IDataObject is not in the reference assembly, so every tutorial written for 11 does not compile here. Hosts can be grouped, flat and never nested. A parent id merged as a scalar lets two offline clients each re-parent A under B and B under A, producing a cycle inside an encrypted payload that no server can police and every reader would have to detect for ever. Membership lives in that payload rather than in the one plaintext concession ADR 0001 allows, whose test is that the relay cannot function without it — nothing on the server reads a group, so what plaintext would hand over is a clustering of the estate for nothing. The plaintext column reserved for it is dropped, provably always null, and the server now refuses a client that sends one; it was never populated, was copied on apply, and was not cleared on delete, so a group id would have outlived the host it described. Snippets insert through xterm rather than through the pump, because xterm is the only thing that knows whether the remote has bracketed paste on, and that is what makes a shell treat embedded newlines as text instead of as execute. The host process moves opaque bytes and never parses output, so it would have to guess, and guessing wrong runs every line. Running is off by default and the copy says the text goes into whatever is there — the terminal has no notion of being at a prompt, and may be in vi or at a password prompt with echo off, so the Enter the user presses themselves is the entire safety property. Connections and keychain changes are recorded as synced encrypted items, which is what makes them auditable by a team later and costs the server knowledge of connection rate and timing from row counts alone. ADR 0001 already concedes it cannot hide that class of metadata; the trade is now written into it rather than left implicit. A connection entry is written once, at close, which is what makes a synced log tractable: nothing to merge, one outbox row, no chance of colliding with itself. Live sessions come from memory, not from the log. The write is void by contract and posts to a bounded channel, because putting an encrypt-and-write on the teardown path of every session is how closing the application comes to take four seconds. A ticket opened before a lock still closes afterwards, since a shell outlives the vault. The activity log hooks the one generic repository every kind writes through, so it cannot miss a caller — which is also why the log kinds themselves declare they are not audited, or the first entry would write an entry about writing an entry. It records the names of the fields that changed and never their values; a log with an old password in it would be a plaintext credential store with no vault around it. Retention is 90 days or 5,000 entries, whichever bites first, pruned on the sync loop rather than on a second timer. That log traffic then broke the status line, which is worth recording because the fix is a shape and not a patch: background sync counted its own log rows as pushed items, so the quiet rule stopped being quiet and every action's message was overwritten a second later by a sync report. The report now separates log rows from user items and the rule reads the latter. S3 buckets appear as a remote in the file browser, behind the same interface an SFTP session implements, so the queue and both panes did not have to learn what they are talking to. Uploads go through a pipe, because the queue wants to write and the SDK wants to read; memory is then bounded by the part size instead of buffering a file to disk twice. Finally, the Windows device key store moved out of the session project, which was the one thing keeping it from being portable — everything else in it is platform-neutral, and a Windows CNG dependency in the middle of the vault code meant a second head could not reference it without dragging Windows along. The seam that made the move free was already there. docs/android-port.md is the audit behind that: what ports, what does not, in order of cost, the four decisions taken, and an inventory of every screen and state the interface has to carry, written so a design can be made from it directly. dotnet build, dotnet test and dotnet format --verify-no-changes are all clean: 1240 tests at zero warnings, including the end-to-end suite against real containers. The manual checks that headless Avalonia cannot make — the drag from Explorer, a generated key against a real host, twelve tabs at the minimum window width — are listed in docs/manual-checks.md and are still outstanding.
275 lines
28 KiB
Markdown
275 lines
28 KiB
Markdown
# What the design asked for and this build has not got
|
||
|
||
The Avalonia client's interface was rebuilt from a Claude Design project — a five-screen spec covering
|
||
the chrome, hosts and terminals, file transfer, the vault, teams, and preferences.
|
||
|
||
Most of it landed. This file is the rest: every element of that design with nothing behind it, which
|
||
project each piece would have to land in, and **what the shipped interface does instead**. That last
|
||
column is the important one. This codebase states its limits rather than implying them — the README does
|
||
it for revocation, for relay session recording and for what locking does not do — so nothing here was
|
||
rendered with invented data to make a screenshot look finished. Where a feature does not exist, the
|
||
interface either omits it or says so.
|
||
|
||
Read alongside [the milestone plan](../README.md#milestones). Most of what follows is not a defect; it is
|
||
M2 and M3 arriving in a design before it arrives in the code.
|
||
|
||
## The shape of the problem
|
||
|
||
Three facts explain nearly every row below.
|
||
|
||
**An SSH connection here opens exactly one channel.** `ISshConnection` offers `OpenShellAsync` and nothing
|
||
else (`src/DodoSSH.Client.Ssh/SshConnection.cs`). No port forwarding, no ProxyJump. That one fact removes
|
||
the `FORWARDS` chip, the status bar's port list, and every `via bastion-eu` in the design.
|
||
|
||
It used to remove the file-transfer screen too. M2 did not lift the restriction — it worked around it:
|
||
file transfer is a *separate connection* rather than a second channel, because SSH.NET's `SftpClient` owns
|
||
its own transport. See [File transfer](#file-transfer-the-designs-sftp-screen), which is the one place in
|
||
this document where what shipped differs from what the row predicted.
|
||
|
||
**Teams are schema and nothing else.** The `team` and `team_membership` tables exist from the first
|
||
migration, with entities in `DodoSSH.Domain/Teams.cs` and a `TeamRole` enum — and no endpoint reads or
|
||
writes any of it. `VaultAccessService.ResolveAsync` returns `Denied` for every vault that is not the
|
||
caller's own personal one. That removes the Teams screen entirely, and with it every role chip, scope and
|
||
"shared with" affordance the vault screen was drawn with.
|
||
|
||
**The client has no preferences store.** It writes exactly two files — `cache.db` and `device.key` — and the
|
||
cache has six tables, none of them settings. Nothing on the design's TERMINAL preferences panel can be
|
||
saved, and there is no frame on the terminal data plane that would carry a change to the renderer anyway.
|
||
|
||
**Three things the design did not ask for and this build now has.** A key can be generated in the client
|
||
rather than pasted in (`SshKeyGenerator`, and the `openssh-key-v1` container is written by hand — see
|
||
`OpenSshKeyWriter` for why there was no alternative and why it is written unencrypted). Hosts can be
|
||
imported from `~/.ssh/config` (`DodoSSH.Client.Import`; it reads no key material, and `ProxyJump` is
|
||
recorded as intent because the SSH layer still has no jump hosts). And the file-transfer screen takes drag
|
||
and drop in four directions — remote to Explorer is the one that does not ship, because it needs a virtual
|
||
file the platform layer cannot supply; see `docs/manual-checks.md`.
|
||
|
||
**The rail has six destinations, not five.** The design gives host keys no slot at all. They were a fourth
|
||
category on the keychain screen for a while and are now a screen of their own, `KnownHostsScreen`, because
|
||
the other categories are things somebody creates and edits and a pin is a decision recorded at the moment
|
||
of connecting — and because comparing an untruncated fingerprint against a published one needs a column
|
||
layout the shared table could not give it.
|
||
|
||
**The product surface says "keychain" and everything under it says "vault", deliberately.** The nav rail,
|
||
the unlock and enrollment copy, and every sentence a user reads now call the encrypted store a keychain.
|
||
The wire does not: the route is `/api/v1/vaults/{vaultId}`, the tables are `vault` and `vault_key_grant`,
|
||
the CLR types are `VaultViewModel` and `VaultSession`, and `docs/crypto.md` — which is normative — says
|
||
"vault key". Renaming those would break every deployed client, need a table-rename migration, and put
|
||
`CryptoSpec.AadResourceType.Vault = 3` inside the blast radius of a find-and-replace, where changing it
|
||
would make every item in every vault permanently unreadable. So the split is the answer rather than a
|
||
stage on the way to one: read "vault" in this repository as the name of the cryptographic object, and
|
||
"keychain" as what the product calls it.
|
||
|
||
One thing cuts the other way and is worth knowing before planning any of this: **the wire protocol already
|
||
reserves the slots**. `SyncEntityType` (`src/DodoSSH.Contracts/SyncEntityType.cs`) has `HostGroup = 4`,
|
||
`Tag = 5`, `HostTag = 6`, `HostCredential = 7`, `Snippet = 8` and `PortForward = 9` — reserved, unused, and
|
||
already covered by the AAD resource-type table. Groups, tags and snippets are new item types on an existing
|
||
protocol rather than a protocol change.
|
||
|
||
Two of those slots are now taken. `HostGroup` and `Snippet` shipped as full item kinds — a table, an EF
|
||
configuration, a server kind that refuses every plaintext field, a codec, a merge, a cipher and a repository
|
||
— and neither needed a contract change, which is what the reservation bought. `Tag`, `HostTag`,
|
||
`HostCredential` and `PortForward` are still reserved and still unused.
|
||
|
||
**A third was added for something the design never mentioned**: `ObjectStore = 13`, an S3-compatible bucket
|
||
and the keys that reach it. It is a keychain item like any other — the endpoint and the secret access key are
|
||
both inside the payload, and the server refuses every plaintext field including the endpoint, because for
|
||
everybody self-hosting that is an address on their own network.
|
||
|
||
What made it cheap is that the transfer queue never needed anything SSH-specific: `IRemoteFileStore` was
|
||
lifted out of `ISftpSession` with only the host key left behind, and a bucket is the same contract with a
|
||
different implementation. Three things a bucket genuinely cannot do are refused with a reason rather than
|
||
approximated — there are no directories (only keys with slashes in them, and a marker object for an empty
|
||
one), no resumable upload (an object cannot be written from the middle), and no atomic rename (a copy and a
|
||
delete). Downloads *do* resume, because a ranged GET is part of the protocol.
|
||
|
||
**Two members were added rather than claimed**: `ConnectionLogEntry = 11` and `ActivityLogEntry = 12`, the
|
||
first additions to `SyncEntityType` since it was frozen. Logs are synced items rather than local files
|
||
because they are audit records — an administrator has to be able to read a shared vault's history once teams
|
||
land, and a log kept only on the machine that produced it can be neither read nor trusted by anybody else.
|
||
ADR 0001 records what that costs in metadata; it is not free and it is not hidden.
|
||
|
||
Three properties are worth knowing before touching them. An entry is **written once, at close** and never
|
||
updated, which is what lets a synced log avoid a merge entirely. Neither kind is **audited**, which is the
|
||
guard that stops the activity log producing an entry for every entry it writes. And both are **excluded from
|
||
the pending-change count and from what a background sync announces** — those numbers answer "how much of my
|
||
work is not yet safe", and a log entry is not somebody's work.
|
||
|
||
**One plaintext field was taken away rather than used.** `SyncPlaintextFields.GroupId` has existed since the
|
||
contract was frozen and `host.group_id` since the first migration; no client ever wrote either. Group
|
||
membership is inside the encrypted payload instead, the column is dropped, and the server now refuses the
|
||
field with a reason — because what it would have handed the operator is a clustering of every user's estate,
|
||
and ADR 0004's test for a plaintext concession is that the server *cannot function* without it. The wire
|
||
field cannot be removed and stays as a permanently refused member; `SyncEndpointTests` holds the refusal.
|
||
|
||
---
|
||
|
||
## Chrome — titlebar, nav rail, status bar
|
||
|
||
| Design element | Layer | What it would take | What ships instead |
|
||
| --- | --- | --- | --- |
|
||
| Org chip `dodotech / platform` | contracts + server | An organisation name a client can read. `VaultSummary.TeamId` exists and is always null. | The vault's own name, and the account this machine is enrolled as. |
|
||
| `SYNCED` dot, always green | client-app | Nothing — the design's claim is simply unconditional. | Green **only** when a connection is held, the last sync pass actually reached the server, and the outbox is empty; otherwise `UNREACHABLE`, the count of changes still waiting, or `OFFLINE`. Holding an `IVaultServer` proves a sign-in once succeeded and nothing more, so a laptop whose lid has been shut all afternoon still has one — reachability comes from the outcome of the last pass. A permanently green light is the same as no light. |
|
||
| `VAULT SYNCED 11:02` | client-session | `StoredSyncState.LastPulledAt`/`LastPushedAt` are persisted, but `VaultSession` exposes the store as `internal`. A property away. | Omitted. The one honest sync fact — the outbox depth — is in the titlebar and the status bar. |
|
||
| `⌘K` command palette running commands | client-domain | A snippet or saved-command item type (`SyncEntityType.Snippet = 8` is reserved). | Ctrl+K opens a real host search that connects on Enter. The box says "search hosts", not "search hosts · run command". |
|
||
| Status bar `· via bastion-eu` | client-ssh | Jump-host execution. See below. | Omitted. |
|
||
| Status bar port forwards | client-ssh | Port forwarding. See below. | Omitted. |
|
||
| Status bar `sftp · 2 transfers` | client-app | Nothing now — file transfer is built. What is missing is the count reaching the status bar, which is a screen away from where the queue lives. | Omitted from the status bar. The queue itself is on the FILES screen, with a row per transfer. |
|
||
| Status bar `locks in 09:41` | client-app | An idle auto-lock. See preferences below. | Omitted. |
|
||
| IBM Plex Mono / IBM Plex Sans | ui | Shipping the font files as `AvaloniaResource` and registering them. The design loads them from Google Fonts, which a desktop app cannot. | Inter (already embedded) for prose, and the system monospace stack the terminal already names. Named once in `App.axaml` as `MonoFont`, so the substitution is reversible in one place. |
|
||
| `⌘K`, `⌥↵` | ui | Nothing; the design is Mac-flavoured. | `CTRL K`. Development is Windows-only today (`docs/platform-flags.md`). |
|
||
|
||
**Also worth knowing:** custom chrome went in as `SystemDecorations="BorderOnly"`, not by extending the
|
||
client area. `ExtendClientAreaChromeHints` was removed in Avalonia 12, so extending leaves the system
|
||
caption buttons and window title drawn on top of the application's own — two sets of window controls, and
|
||
"DodoSSH" printed twice. Measured, not assumed.
|
||
|
||
---
|
||
|
||
## Hosts + terminal
|
||
|
||
| Design element | Layer | What it would take | What ships instead |
|
||
| --- | --- | --- | --- |
|
||
| Tag chips (`nginx`, `eu`, `pg16`) | client-domain | A tag item type and a host-tag join. Both reserved on the wire (`Tag = 5`, `HostTag = 6`), neither implemented, plus a payload schema bump on `HostSecret`. | Omitted. The filter box searches name, address and notes instead. |
|
||
| Groups `PRODUCTION` / `STAGING` / `PERSONAL` | client-domain | A host-group item type (`HostGroup = 4`, reserved) or a group field on `HostSecret`. | **Shipped**, as both: `VaultHostGroup` is a synced item kind and `HostSecret.GroupId` names one. Flat, not nested. A keychain with no groups renders exactly as it did before — one flat list, no headings. |
|
||
| Group badge `TEAM·PLATFORM` | server | Teams. | Omitted. |
|
||
| Per-host status dot, three colours | client-ssh | The amber state would mean "reachable but not connected", and nothing here ever probes a host. | Two states, both real: green when a terminal is open on that host, grey when not. |
|
||
| `· ⤷ bastion-eu` in the host subtitle | client-ssh | **Jump hosts are data-only.** `HostSecret.JumpHostIds` is a `JumpChain` that is stored, encrypted, synced and three-way merged — and nothing reads it at connect time. `SshConnectionRequest` carries one host. | Omitted. The stored chain is preserved untouched by every edit. |
|
||
| `SPLIT ⌘D` and side-by-side panes | client-ssh + ui | The renderer stacks panes and shows one (`terminal.css`: `.pane { position:absolute; inset:0; display:none }`). Tiling needs a real pane geometry and a splitter. | Omitted. Tabs ship instead, over the same one-WebView multiplexing. |
|
||
| `⇄ FORWARDS · 2` | client-ssh | Port forwarding. `SyncEntityType.PortForward = 9` is reserved; nothing in the SSH layer forwards anything. | Omitted. |
|
||
| `SNIPPETS` panel, `↵` to run | client-domain | A snippet item type (`Snippet = 8`, reserved). | **Shipped**, as a screen rather than a panel. `↵` is per snippet and off by default: inserting types the command at the prompt and stops, because nothing here can tell whether the terminal is at a prompt at all. |
|
||
| Broadcast to all panes (`⌥↵`) | client-ssh | Input is routed strictly by session id in `TerminalDataPlane.Dispatch`; there is no fan-out. Needs splits first. | Omitted. |
|
||
| Pane header `24ms` | client-ssh | Round-trip measurement. SSH.NET offers no RTT API. | Omitted. |
|
||
| Pane header `aes256-gcm` | client-ssh | **The closest miss on this list.** `SshNetConnection` holds the `SshClient`, so `ConnectionInfo.CurrentServerEncryption` is right there — it just is not on `ISshConnection` or surfaced by `TerminalWorkspace`. | Omitted; the tab strip shows the account and endpoint actually dialled. |
|
||
| Pane header showing the running command and `following` | client-ssh | The host moves opaque bytes and never parses terminal output. Would need shell integration (OSC 133) on the remote. | Omitted. |
|
||
| A `local · zsh` tab | client-ssh | Every session here is an SSH channel. Needs ConPTY and a second session kind. | Omitted. |
|
||
| Tab strip `+` button | ui | Not missing so much as redundant: the real operation is *select a host, press Connect*, which the sidebar already is. | Omitted. Connect opens a tab; Ctrl+K opens one by name. |
|
||
| Terminal font size (`--termfs`, 11–16px) | client-storage | See preferences. | Fixed at the renderer's 13px. |
|
||
|
||
---
|
||
|
||
## File transfer (the design's SFTP screen)
|
||
|
||
**Built in M2.** The screen ships: two directory panes, a breadcrumb trail on each, and a queue that moves
|
||
one file at a time with progress, throughput and resume. What follows is what it does *not* do, and one
|
||
thing this document got wrong before it was built.
|
||
|
||
**The correction.** The row below used to say an SFTP subsystem channel on `ISshConnection` was what it
|
||
would take. SSH.NET does not offer that: `SftpClient` derives from `BaseClient` and owns its own transport,
|
||
and there is no supported way to hand it a session an `SshClient` already has. So the transfers screen
|
||
**opens a second authenticated connection** to the host rather than a second channel on the terminal's. That
|
||
is visible to a user — the host records a second login, and a host whose password is typed each time asks
|
||
for it again on this screen — so it is named for what it is: `ISftpSessionFactory.OpenSftpAsync` is a
|
||
connect, and it goes through the same host key gate, the same pin and the same two refusals a shell does.
|
||
|
||
| Design element | Layer | What ships |
|
||
| --- | --- | --- |
|
||
| SFTP itself | client-ssh | `ISftpSession` over SSH.NET's `SftpClient`: listing, stat, offset-based read and write, mkdir, delete and rename. Delete is deliberately **not** recursive. |
|
||
| Remote listing with `NAME/SIZE/MODIFIED/PERMS` | client-ssh | All four. `PosixMode` renders `drwxr-xr-x` from the bits SFTP hands over; setuid, setgid and sticky are not shown, because SSH.NET does not surface them and `rwx` where `rws` is true would be worse than nothing. |
|
||
| Local listing | client-transfer | `LocalDirectory`, which is where this client's `System.IO` now lives. `PERMS` is blank on the local side rather than filled with a plausible-looking POSIX mode that is not a fact about a file on Windows. |
|
||
| Transfer queue, progress, throughput | client-transfer | `FileTransferQueue`. One transfer at a time, so the rate on a row is the rate of the link rather than a share of it. Throughput is measured over a half-second window, not averaged since the start. |
|
||
| `resume supported` | client-transfer | **Within a run of the application.** Every transfer writes to a `.dodossh-part` file beside its destination and is renamed into place at the end, so an interrupted one can never be mistaken for a finished one, and `RESUME` carries on from the part file's own length. A part file found at startup is *not* resumed: nothing records what wrote it, and resuming on the strength of a name matching is how a corrupt artefact gets delivered with nothing reporting a failure. Making it survive a restart needs the preferences store this client has not got — see below. |
|
||
|
||
| Design element | Layer | What it would take | What ships instead |
|
||
| --- | --- | --- | --- |
|
||
| Per-host last directory | client-storage | Somewhere to persist two panes' navigation state. There is still no settings table. | The remote pane opens on the account's home directory, which the server canonicalises during the handshake; the local pane opens on the user profile. |
|
||
| `sftp over bastion-eu` | client-ssh | Jump hosts, as above. `HostSecret.JumpHostIds` is still stored, synced, merged and read by nothing. | Omitted. |
|
||
| Overwriting a file that is already there | ui | A prompt, which means a modal this window has no idiom for. | Refused, with the name that is in the way. The remote pane has DELETE and MKDIR so the refusal is not a dead end. |
|
||
| Dragging between the panes | ui | Drag-and-drop between two `ListBox`es, plus a drop target that is a directory rather than a row. | Two arrow buttons between the panes, pointing at the pane the file is going to. |
|
||
| Transferring a directory | client-transfer | Recursive enumeration on both sides, and a policy for what a partial directory means. | One file at a time. A directory cannot be selected as a transfer source. |
|
||
|
||
**Not to be reached for:** `CreditWindow` is a 256 KiB flow-control window for terminal output, not a
|
||
transfer primitive. The queue does its own 64 KiB copy loop and shares nothing with the terminal data plane.
|
||
|
||
---
|
||
|
||
## Vault
|
||
|
||
The screen ships and is real: four categories over the vault's four item types, one table, a detail pane,
|
||
and both editors. What follows is what the design drew around them.
|
||
|
||
| Design element | Layer | What it would take | What ships instead |
|
||
| --- | --- | --- | --- |
|
||
| `ACCESS` column and `your access → CONNECT-ONLY` | server | Per-item ACLs. `EncryptedPayload.DataKeyId` is documented as the seam for per-item grants **in M5**. `VaultSummary` does carry an opaque `int Permissions`, but nothing gives the bits a meaning on the wire — `PermissionFlags` itself lives in `DodoSSH.Domain` — and those are per *vault*, never per item. There is no `ConnectOnly` role in `TeamRole` at all. | Omitted. The column shows sync state instead — whether a change is still sitting in this machine's outbox — which the design had no column for. |
|
||
| `SHARED WITH · 6` avatars | server | The whole sharing stack: grants, a member directory, and re-wrapping a vault key for another account. | Omitted. |
|
||
| "Private key never leaves the vault. Sessions sign through the team agent (dodod)" | client-ssh | **Both sentences are false here, and the second cannot be made true by this architecture.** There is no agent of any kind, and the connect path decrypts the private key and hands the bytes to SSH.NET. | Omitted. The key editor already says what is true: the key and its passphrase are encrypted here and never reach the server in a readable form. |
|
||
| Scope rail: `PERSONAL` / `TEAM · PLATFORM` / `TEAM · DATA` | server | Team vaults. `VaultAccessService.ListAsync` filters to personal vaults owned by the caller. | The real vault list, which today has one entry, with a line saying why. |
|
||
| `SCOPE` column | server | As above — and note scope here is a property of a *vault*, never of an item. | Omitted. |
|
||
| `LAST` column (`11:02`, `1d ago`) | contracts | No last-used timestamp at any layer. `VaultItem<TSecret>` is `(id, secret, version, three sync flags)`. | Omitted. |
|
||
| `FINGERPRINT` for SSH keys | client-domain | `SshKeySecret` has no fingerprint field, and computing one means parsing key formats the type deliberately stores verbatim. | The `DETAIL` column carries what *is* known — whether a passphrase and a public half are stored. Pins show their real fingerprint, in full and untruncated. |
|
||
| `•••• rotated jul 14` for passwords | client-domain | `CredentialSecret` has no rotation date or password age. | The account the password is for. |
|
||
| `IDENTITIES` category | contracts | A new item type, not even reserved in `SyncEntityType`. | Omitted. |
|
||
| `CERTIFICATES` category, `expires 2026-09-01` | contracts | Same ladder, plus certificate parsing. | Omitted. |
|
||
| `18 items · 12 shared` | server | The sharing stack. | `N items · N not synced`, counted over the rows on screen. |
|
||
| `added by anna@dodotech.dev` | contracts | The server records `CreatedByUserId`, but `SyncChange` carries no actor field and no other user's name is fetchable. | Omitted, and the detail pane says in one line that items record no author, no timestamps and no sharing. |
|
||
| `created 2026-03-14` | client-sync | Recoverable in principle — entity ids are UUIDv7 and carry a timestamp — but nothing surfaces it. | Omitted. |
|
||
| `TEST CONNECT` | ui | Connecting is host-scoped, not credential-scoped: there is nothing to test a credential *against* without a host. | Omitted. |
|
||
| `REVOKE` | server | Revoking someone else's access needs grants to revoke. Deleting an item is a different act and is already there. **ADR 0001** also constrains how any future revoke may be presented: revocation is not retroactive. | Delete, named for what it does. |
|
||
| `SSH KEY · ED25519` | client-domain | No algorithm field, and deriving it means parsing the armour. | The type without the algorithm. |
|
||
| One `+ ADD CREDENTIAL` button | ui | — | Two buttons, one per kind that can be added. "Credential" is a specific item type in this codebase (a username and a password), so using it as an umbrella word would collide with the vocabulary. |
|
||
| — | — | — | **`HOST KEYS` is the reverse case:** a fully-backed, shipped category the design had no slot for. It is in the rail. |
|
||
|
||
---
|
||
|
||
## Teams
|
||
|
||
Nothing on this screen exists. It is in the nav rail and reaches a screen that says so.
|
||
|
||
| Design element | Layer | What it would take |
|
||
| --- | --- | --- |
|
||
| The team itself | server | Team endpoints. The server has eight routes and none is about people. |
|
||
| Shared vaults | server | Vault creation, grants, and membership evaluation. Exactly one vault exists per user, created as a side effect of enrollment. |
|
||
| Roles (`OWNER`/`ADMIN`/`MEMBER`/`CONNECT-ONLY`/`VIEWER`) | contracts + server | `TeamRole` exists in `DodoSSH.Domain`, is read by no code path, has no wire representation, and has no `ConnectOnly` member. |
|
||
| Members table | server | A member DTO and a directory endpoint. |
|
||
| `2FA ENFORCED` and the per-member 2FA column | server | No two-factor concept exists anywhere — the only hit in the whole worktree is an aside in `docs/crypto.md`. |
|
||
| `LAST ACTIVE` | server | `UserAccount.LastSeenAtUtc` exists and is written at just-in-time provisioning and at enrollment, and never on an ordinary authenticated request — so the column cannot answer "last active". |
|
||
| Avatars | server | `MeResponse` has no picture field, and no other user's display name is fetchable. |
|
||
| Pending invites, resend, revoke | server | An invitation entity, a token with a lifetime, and an outbound mail path. `MembershipStatus.Invited` and `TeamMembership.InvitedByUserId` are the only hints, and nothing writes them. |
|
||
| `SSO · OIDC · okta.dodotech.dev` | server | Per-team SSO. Authentication is one global JWT scheme bound to one authority. |
|
||
|
||
> **A trap for whoever builds this.** `GET /api/v1/meta` advertises `features: ["teams"]`
|
||
> *unconditionally* (`MetaEndpoints.cs`). Do not gate a Teams screen on that string — it is true of every
|
||
> deployment today and means nothing.
|
||
|
||
---
|
||
|
||
## Preferences
|
||
|
||
The screen ships with what is real — this machine's device key, locking, syncing, and signing out — and
|
||
lists the rest as absent rather than omitting it silently.
|
||
|
||
> **Signing out is not on the design and is here anyway.** The design has no way to leave a machine, and
|
||
> without one there is no way to hand a laptop on, to enrol a second account, or to get past a forgotten
|
||
> passphrase — which is unrecoverable by construction, so the unlock screen would otherwise be a dead end.
|
||
> It empties the local cache and withdraws the device key from the account; it cannot end the session at the
|
||
> identity provider, and says so.
|
||
|
||
| Design element | Layer | What it would take |
|
||
| --- | --- | --- |
|
||
| Any preference, saved | client-storage | A seventh table in the client cache, or a preference item type in the vault. Which one matters: the vault syncs, so a preference stored there follows you between machines, and a terminal font size probably should not. |
|
||
| Terminal font, size, cursor style, cursor blink, scrollback | client-terminal | The store, **and** a frame to carry it. `TerminalServerOpcode` has four values (`Output`, `SessionOpened`, `SessionClosed`, `SessionActivated`) and none carries an option. |
|
||
| Font family picker offering IBM Plex Mono | ui | Shipping the font, as above. |
|
||
| Audible bell | client-terminal + ui | xterm.js 6 removed `bellStyle` and `bellSound`; what remains is an `onBell` event, so the page would have to make the sound itself. |
|
||
| `GENERAL` section | ui | There is no general setting to put in it. The theme is fixed by decision, and window size is not persisted. |
|
||
| `KEYS & AGENT` section | client-ssh | **There is no agent, at all** — no own agent, no forwarding, no Pageant or OpenSSH-agent interop. |
|
||
| `SYNC & VAULT` section | client-domain | Nothing here is adjustable. The auto-sync interval is a `private static readonly` with a remark arguing for its value. |
|
||
| `SECURITY & SSO` section | server | The SSO half needs team endpoints; there is no policy for the screen to show. |
|
||
| `SHORTCUTS` section | ui | There is no keybinding infrastructure and no rebinding surface. |
|
||
| Auto-lock after idle | client-session | An activity source, a decision about what counts as idle, and — the hard part — a policy for a shell mid-job. `LockAsync`'s own remark already argues that an unattended timeout which killed a running job would be worse than the exposure it removed. |
|
||
| Require biometric to sign | crypto | Three separate falsehoods in one row. There is no signing service — the private key is decrypted and handed to SSH.NET whole, so there is no per-signature moment to interrupt; there are no connect-only keys; and per-use consent would need the key to live in the TPM, which is a different key hierarchy from the one in `docs/crypto.md`. |
|
||
| Pill toggle switches | ui | Purely presentational — `App.axaml` has no `ToggleSwitch` selector, so Fluent's default would appear un-themed beside the hairline chrome. |
|
||
|
||
---
|
||
|
||
## Two things the import changed on purpose
|
||
|
||
**Hosts left the vault column.** They have their own sidebar beside the terminal, and the vault screen
|
||
holds keys, passwords and pinned host keys. This follows the design, and it is also the better split: the
|
||
host list is what you look at while you work, and the rest is what you go and manage. `VaultSection` lost
|
||
its `Hosts` member and gained `All`.
|
||
|
||
**Tabs moved to the shell, not the vault.** Locking disposes the vault and deliberately leaves shells
|
||
running, so a tab list rebuilt per unlock would lose track of sessions that are still connected — the very
|
||
sessions the unlock screen already counts. `TerminalWorkspace` gained `SessionActivated` on the wire,
|
||
`IsSessionLive`, and a `SessionEnded` event so a tab can stop claiming to be connected.
|