DodoTech-Public/DodoSSH
Public Access
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 2 Wiki Activity

Fix the CI formatting gate, which was already failing

Browse Source 
dotnet format --verify-no-changes exits 2 on main: the async-suffix naming
rule fires on every async test method. I reported this gate as clean when
finishing the sync engine and it was not.

Test names are documentation. Push_WithAStaleVersion_ReportsConflict says
what is asserted; adding Async says the same plus an implementation detail
nobody reading a failure report needs. The suffix convention exists so
callers can spot awaitables, and a test method has no callers -- so the
rule is switched off under tests/ rather than the names being changed.
This commit is contained in:
jaap-jan
2026-07-28 16:05:52 +02:00
parent 98d29bff37
commit e6673f0bf2
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.editorconfig
+6
View File
@@ -133,6 +133,12 @@ dotnet_diagnostic.CA1849.severity = warning # sync call in async method
dotnet_diagnostic.CA1812.severity = none dotnet_diagnostic.CA1812.severity = none
dotnet_diagnostic.CA1034.severity = none dotnet_diagnostic.CA1034.severity = none
# A test name is documentation: Push_WithAStaleVersion_ReportsConflict says what is being
# asserted, and Push_WithAStaleVersion_ReportsConflictAsync says the same thing plus an
# implementation detail nobody reading a failure report cares about. The async suffix
# convention exists so callers can spot awaitables; a test method has no callers.
dotnet_diagnostic.IDE1006.severity = none
[src/DodoSSH.Infrastructure/Migrations/*.cs] [src/DodoSSH.Infrastructure/Migrations/*.cs]
# EF Core generates these; do not lint or format them. # EF Core generates these; do not lint or format them.
generated_code = true generated_code = true